frysk git repository

frysk git repository

[Tim Moore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
Although the CVS repository has not yet been turned off, I would like people to start
using the git repository to check in their changes. Remember that the command to clone
the repository is "git-clone ssh://sourceware.org/git/frysk.git".

Also, commit messages make most sense in the git world, with the various tools that print
out logs, if you begin your message with a one-line summary, and a blank line. After that
you can include the ChangeLog entries we have now.

Tim

- --
Red Hat France SARL, 171 Avenue Georges Clemenceau
92024 Nanterre Cedex, France.
Siret n° 421 199 464 00056
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHH3w5eDhWHdXrDRURAhgZAKCOlUFoI3jcWnP5UNiUd4bEqfQx/wCgw+jV
0pVXswRg+9f+eE7kGmOCYYM=
=aqNn
-----END PGP SIGNATURE-----

Re: frysk git repository

[Elena Zannoni]

Speaking of which, I noticed that there are a bunch of cvs files in the 
git repo,
including .cvsignore, CVSROOT, and so on. Are those there for a reason?

elena




Tim Moore wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
> Although the CVS repository has not yet been turned off, I would like people to start
> using the git repository to check in their changes. Remember that the command to clone
> the repository is "git-clone ssh://sourceware.org/git/frysk.git".
>
> Also, commit messages make most sense in the git world, with the various tools that print
> out logs, if you begin your message with a one-line summary, and a blank line. After that
> you can include the ChangeLog entries we have now.
>
> Tim
>
> - --
> Red Hat France SARL, 171 Avenue Georges Clemenceau
> 92024 Nanterre Cedex, France.
> Siret n° 421 199 464 00056
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iD8DBQFHH3w5eDhWHdXrDRURAhgZAKCOlUFoI3jcWnP5UNiUd4bEqfQx/wCgw+jV
> 0pVXswRg+9f+eE7kGmOCYYM=
> =aqNn
> -----END PGP SIGNATURE-----
>
>   

Re: frysk git repository

[Mark Wielaard]

Hi Tim,

On Wed, 2007-10-24 at 19:09 +0200, Tim Moore wrote:
> Although the CVS repository has not yet been turned off, I would like
> people to start
> using the git repository to check in their changes. Remember that the
> command to clone
> the repository is "git-clone ssh://sourceware.org/git/frysk.git".

I seem to be unable to do this with my sourceware.org account:

$ git-clone ssh://mark@sourceware.org/git/frysk.git
Initialized empty Git repository in /home/mark/src/git/frysk/.git/
Permission denied (publickey,gssapi-with-mic).
fatal: The remote end hung up unexpectedly
fetch-pack from 'ssh://mark@sourceware.org/git/frysk.git' failed.

It does however have a read-only checkout through the git protocol which
does work for me: git-clone git://sourceware.org/git/frysk.git

Cheers,

Mark

Re: frysk git repository

[Mark Wielaard]

On Wed, 2007-10-24 at 21:50 +0200, Mark Wielaard wrote:
> On Wed, 2007-10-24 at 19:09 +0200, Tim Moore wrote:
> > Although the CVS repository has not yet been turned off, I would like
> > people to start
> > using the git repository to check in their changes. Remember that the
> > command to clone
> > the repository is "git-clone ssh://sourceware.org/git/frysk.git".
> 
> I seem to be unable to do this with my sourceware.org account:
> 
> $ git-clone ssh://mark@sourceware.org/git/frysk.git
> Initialized empty Git repository in /home/mark/src/git/frysk/.git/
> Permission denied (publickey,gssapi-with-mic).
> fatal: The remote end hung up unexpectedly
> fetch-pack from 'ssh://mark@sourceware.org/git/frysk.git' failed.

OK, I figured it out. sources.redhat.com == sourceware.org and it works
with sources.redhat.com because I have the following in my .ssh/config
file:

Host sources.redhat.com
        Protocol 1

So just add the following:

Host sourceware.org
        Protocol 1

And everything works as expected over ssh.

Cheers,

Mark

Re: frysk git repository

[Tim Moore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Wielaard wrote:
> On Wed, 2007-10-24 at 21:50 +0200, Mark Wielaard wrote:
>> On Wed, 2007-10-24 at 19:09 +0200, Tim Moore wrote:
>>> Although the CVS repository has not yet been turned off, I would like
>>> people to start
>>> using the git repository to check in their changes. Remember that the
>>> command to clone
>>> the repository is "git-clone ssh://sourceware.org/git/frysk.git".
>> I seem to be unable to do this with my sourceware.org account:
>>
>> $ git-clone ssh://mark@sourceware.org/git/frysk.git
>> Initialized empty Git repository in /home/mark/src/git/frysk/.git/
>> Permission denied (publickey,gssapi-with-mic).
>> fatal: The remote end hung up unexpectedly
>> fetch-pack from 'ssh://mark@sourceware.org/git/frysk.git' failed.
> 
> OK, I figured it out. sources.redhat.com == sourceware.org and it works
> with sources.redhat.com because I have the following in my .ssh/config
> file:
> 
> Host sources.redhat.com
>         Protocol 1
> 
> So just add the following:
> 
> Host sourceware.org
>         Protocol 1
> 
> And everything works as expected over ssh.
Well, whatever works for you :)

If you encounter weird problems checking out frysk that seem to be permissions
related, email fche@redhat.com. Everyone in the frysk group should have read / write
access to the repo.

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHICAGeDhWHdXrDRURAkdWAJ98sw19iwYnDvuqbUwD8GaOXgb10gCfdSXL
x8JGRHukKlnJcnsAzyOqXHo=
=MBVd
-----END PGP SIGNATURE-----

Re: frysk git repository

[Tim Moore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Elena Zannoni wrote:
> Speaking of which, I noticed that there are a bunch of cvs files in the
> git repo,
> including .cvsignore, CVSROOT, and so on. Are those there for a reason?
> 
> elena
> 
They are an artifact of how I did the import. I'll remove them in the master branch.

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHICBYeDhWHdXrDRURAqtzAJ9vgIDZ5Cmo/4yAnBRLwAANHgtsGgCeJ9p/
We9vMfs57aefpcDcXFEPCdE=
=r1qZ
-----END PGP SIGNATURE-----

Re: frysk git repository

[Andrew Cagney]

Tim Moore wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
> Although the CVS repository has not yet been turned off,

Tim,

I've done this - it is at least blocking my commits.  I've also turned 
off the version.in updates to cvs.

thanks for the work.

Andrew

>  I would like people to start
> using the git repository to check in their changes. Remember that the command to clone
> the repository is "git-clone ssh://sourceware.org/git/frysk.git".
>
> Also, commit messages make most sense in the git world, with the various tools that print
> out logs, if you begin your message with a one-line summary, and a blank line. After that
> you can include the ChangeLog entries we have now.
>
> Tim
>
> - --
> Red Hat France SARL, 171 Avenue Georges Clemenceau
> 92024 Nanterre Cedex, France.
> Siret n° 421 199 464 00056
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iD8DBQFHH3w5eDhWHdXrDRURAhgZAKCOlUFoI3jcWnP5UNiUd4bEqfQx/wCgw+jV
> 0pVXswRg+9f+eE7kGmOCYYM=
> =aqNn
> -----END PGP SIGNATURE-----
>   

Re: frysk git repository (workflow)

[Sami Wagiaalla]

If I am working on several tasks what is the recommended work flow.

Do I create clones for each task I am working on or branches within the 
same clone.

Also how do I publish a branch on sourceware; it seems like the branches 
I create
with git branch foo are local branches. And in that case is it 
recommended that I
publish all my scratch branches on sourceware instead of having local 
clones/branches ?

Sami Wagiaalla

Re: frysk git repository

[Mark Wielaard]

Hi Tim,

On Wed, 2007-10-24 at 19:09 +0200, Tim Moore wrote:
> Also, commit messages make most sense in the git world, with the various tools that print
> out logs, if you begin your message with a one-line summary, and a blank line. After that
> you can include the ChangeLog entries we have now.

Is there a way to include the actual diffs of the patches that are
pushed into the repo to the commit list to make reviewing changes
easier?

Thanks,

Mark

Re: frysk git repository

[Tim Moore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Wielaard wrote:
> Hi Tim,
> 
> On Wed, 2007-10-24 at 19:09 +0200, Tim Moore wrote:
>> Also, commit messages make most sense in the git world, with the various tools that print
>> out logs, if you begin your message with a one-line summary, and a blank line. After that
>> you can include the ChangeLog entries we have now.
> 
> Is there a way to include the actual diffs of the patches that are
> pushed into the repo to the commit list to make reviewing changes
> easier?

I can tweak the script, but I think that falls into the category of "too much information"
since you can review the changes locally using either the git command line tools or
gitk.

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHIha5eDhWHdXrDRURAgUFAJ9QXRBtpOYIrgDfjD2uJn86OjdT2ACdF3k2
lZgnMyItckan7938zVdFbCA=
=eHgY
-----END PGP SIGNATURE-----

Re: frysk git repository

[Tim Moore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Wielaard wrote:
> Hi Tim,
> 
> On Wed, 2007-10-24 at 19:09 +0200, Tim Moore wrote:
>> Also, commit messages make most sense in the git world, with the various tools that print
>> out logs, if you begin your message with a one-line summary, and a blank line. After that
>> you can include the ChangeLog entries we have now.
> 
> Is there a way to include the actual diffs of the patches that are
> pushed into the repo to the commit list to make reviewing changes
> easier?

I can tweak the script, but I think that falls into the category of "too much information"
since you can review the changes locally using either the git command line tools or
gitk.

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHIha5eDhWHdXrDRURAgUFAJ9QXRBtpOYIrgDfjD2uJn86OjdT2ACdF3k2
lZgnMyItckan7938zVdFbCA=
=eHgY
-----END PGP SIGNATURE-----

Re: frysk git repository

[Mark Wielaard]

Hi Tim,

On Fri, 2007-10-26 at 18:32 +0200, Tim Moore wrote:
> > Is there a way to include the actual diffs of the patches that are
> > pushed into the repo to the commit list to make reviewing changes
> > easier?
> 
> I can tweak the script, but I think that falls into the category of "too much information"
> since you can review the changes locally using either the git command line tools or
> gitk.

There is never too much information! Including it in the email would be
way easier for people to review and comment on them when the patches
actually happen. Could you add some easy way in the commit mail to see
the actual patches? Then people could compare and see what is easiest to
work with for them.

Also, would it be possible to tweak the subject to start with the
oneline commit message?

Thanks,

Mark

Re: frysk git repository

[Sami Wagiaalla]

> There is never too much information!
Its not too much information but it might be too big in size.
If that is not an issue then I would like to see the patches
in the email as well. Having them inlined in the email it self
and not as attachments would be best.

Re: frysk git repository (workflow)

[Tim Moore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sami Wagiaalla wrote:
> If I am working on several tasks what is the recommended work flow.
> 
> Do I create clones for each task I am working on or branches within the
> same clone.
> 
Usually you create branches within one repo and switch between them using git-checkout.
If you need to look at your work in the non-checked out branches you can use git-diff or
git-cat-file. There are some tricks to "check out" a source tree without an associated
repository, but if you really want to have more than one branch checked out, you can clone
your local repository...

It's extremely fast to switch between branches in git. Unfortunately it's not so fast
to rebuild frysk once you've switched :/ though git does take care to only modify files
that are different on the branches.

> Also how do I publish a branch on sourceware; it seems like the branches
> I create
> with git branch foo are local branches. And in that case is it
git push origin sami:refs/heads/sami

> recommended that I
> publish all my scratch branches on sourceware instead of having local
> clones/branches ?
No, you should publish branches that contain work that you want others to check out but
which won't be checked into the master branch imminently.

Tim

- --
Red Hat France SARL, 171 Avenue Georges Clemenceau
92024 Nanterre Cedex, France.
Siret n° 421 199 464 00056
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHI3wxeDhWHdXrDRURAtyiAKCgeP9e8gdLEbsywlFFBH8x6bfCIgCdFuXn
JjezvITKDAMGAPq39OnJKA8=
=3iOn
-----END PGP SIGNATURE-----

Re: frysk git repository

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

Hi,

On Fri, 2007-10-26 at 14:38 -0400, Sami Wagiaalla wrote:
> > There is never too much information!
> Its not too much information but it might be too big in size.
> If that is not an issue then I would like to see the patches
> in the email as well. Having them inlined in the email it self
> and not as attachments would be best.

Yes. For Mercurial I would use something like the following:

        [hooks]
        incoming.notify = python:hgext.notify.hook
        
        [notify]
        sources = serve push pull bundle
        maxdiff = 500
        
        [usersubs]
        fedora-hg-list@klomp.org = /hg/fedora
        
        [smtp]
        host = localhost

Which makes sure emails are send (by the notify extension), but diffs
are capped at 500 lines max (and then you get a link to the hg webrepo
to retrieve the full diff of the changeset). Hopefully there is
something similar for git.

Cheers,

Mark

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: frysk git repository

[Andrew Cagney]

The problem I found with the CVS messages was that the changes were 
scattered across a number of urls - each requiring a separate click.  
With git, it should be possible to just post a single URL containing the 
change?

Andrew


Mark Wielaard wrote:
> Hi,
>
> On Fri, 2007-10-26 at 14:38 -0400, Sami Wagiaalla wrote:
>   
>>> There is never too much information!
>>>       
>> Its not too much information but it might be too big in size.
>> If that is not an issue then I would like to see the patches
>> in the email as well. Having them inlined in the email it self
>> and not as attachments would be best.
>>     
>
> Yes. For Mercurial I would use something like the following:
>
>         [hooks]
>         incoming.notify = python:hgext.notify.hook
>         
>         [notify]
>         sources = serve push pull bundle
>         maxdiff = 500
>         
>         [usersubs]
>         fedora-hg-list@klomp.org = /hg/fedora
>         
>         [smtp]
>         host = localhost
>
> Which makes sure emails are send (by the notify extension), but diffs
> are capped at 500 lines max (and then you get a link to the hg webrepo
> to retrieve the full diff of the changeset). Hopefully there is
> something similar for git.
>
> Cheers,
>
> Mark
>