public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "law at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/106602] riscv: suboptimal codegen for zero_extendsidi2_shifted w/o bitmanip Date: Wed, 16 Nov 2022 18:47:56 +0000 [thread overview] Message-ID: <bug-106602-4-7UCqg2UlRZ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106602-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106602 --- Comment #25 from Jeffrey A. Law <law at gcc dot gnu.org> --- To outline what we were thinking. Yes, it's possible that 4->3 combinations aren't supported. I'd have to sit down with the combine sources to be sure. So the alternate approach we came up with was to mimick ZBS's ability to load up single bit constants with a define_insn_and_split, obviously splitting it into a constant load + shift unconditionally if it's still around post-combine. That's going to lead into a bigger question about constant loads. Right now we tend to break them down during expansion. The advantage of that is the components become CSE candidates. The downside is it will tend to inhibit instruction combination as we've seen in this case. I don't have a good answer on the best approach.
next prev parent reply other threads:[~2022-11-16 18:47 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-12 20:34 [Bug target/106602] New: riscv: suboptimal codegen for shift left, right, left vineetg at rivosinc dot com 2022-08-12 20:39 ` [Bug target/106602] " pinskia at gcc dot gnu.org 2022-08-12 20:40 ` vineetg at rivosinc dot com 2022-11-01 0:12 ` [Bug target/106602] riscv: suboptimal codegen for zero_extendsidi2_shifted w/o bitmanip vineetg at rivosinc dot com 2022-11-01 0:18 ` pinskia at gcc dot gnu.org 2022-11-01 0:29 ` vineetg at rivosinc dot com 2022-11-01 0:32 ` vineetg at rivosinc dot com 2022-11-01 19:56 ` law at gcc dot gnu.org 2022-11-01 19:58 ` law at gcc dot gnu.org 2022-11-01 20:15 ` palmer at gcc dot gnu.org 2022-11-01 20:31 ` vineetg at rivosinc dot com 2022-11-01 23:39 ` vineetg at rivosinc dot com 2022-11-02 0:38 ` vineetg at rivosinc dot com 2022-11-02 0:46 ` law at gcc dot gnu.org 2022-11-02 1:03 ` law at gcc dot gnu.org 2022-11-02 1:24 ` vineetg at rivosinc dot com 2022-11-02 1:31 ` law at gcc dot gnu.org 2022-11-02 1:35 ` pinskia at gcc dot gnu.org 2022-11-02 1:35 ` pinskia at gcc dot gnu.org 2022-11-02 15:11 ` law at gcc dot gnu.org 2022-11-02 17:02 ` vineetg at rivosinc dot com 2022-11-02 17:05 ` vineetg at rivosinc dot com 2022-11-02 17:16 ` law at gcc dot gnu.org 2022-11-03 4:15 ` vineetg at rivosinc dot com 2022-11-03 20:41 ` vineetg at rivosinc dot com 2022-11-03 21:21 ` vineetg at rivosinc dot com 2022-11-16 17:55 ` law at gcc dot gnu.org 2022-11-16 18:47 ` law at gcc dot gnu.org [this message] 2022-12-27 23:31 ` cvs-commit at gcc dot gnu.org 2022-12-27 23:33 ` law at gcc dot gnu.org 2023-04-17 18:14 ` cvs-commit at gcc dot gnu.org 2023-04-19 2:41 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106602-4-7UCqg2UlRZ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).