public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109008] [13 Regression] Wrong code in scipy package since r13-3926-gd4c2f1d376da6f Date: Thu, 09 Mar 2023 12:56:22 +0000 [thread overview] Message-ID: <bug-109008-4-7fyFWEq8ZK@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109008-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109008 --- Comment #45 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Created attachment 54623 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54623&action=edit gcc13-pr109008-3.patch Further incremental patch to do the .5ulp widening rather than 1ulp if not -frounding-math and not for IBM double double. So far I've tested the + and - 300000 tests, still no errors (so conservatively correct) and: 1 0 50 1 1 11 1 11 1 1 1 13 1 1 16 1 1 25 1 1 28 1 1 3 1 1 36 1 1 4 1 1 40 1 19 1 1 39 1 1 50 0 2 1 17 2 1 2 2 1 32 2 1 7 2 2 1 2 5 1 3 3 1 3 4 1 38 50 1 56 1 50 71 1 0 78 0 1 160 50 50 13173 0 0 130096 -1 -1 154232 1 1 so significantly better than the 1ulp version, over 50% of cases are 1ulp away in each direction, over 43% of other cases have really empty range, over 4% exact and rest is noise. Let me finish * and / testing. For the forward op, we'd need to do something like in the #c30 patch, which was ugly. And regarding !MODE_HAS_INFINITIES, the min/max values really act there like infinities, so I think we should just detect that case and use infinities in the widened range even when the mode doesn't have them. But, I'm afraid I don't know how to test that...
next prev parent reply other threads:[~2023-03-09 12:56 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-03 12:08 [Bug tree-optimization/109008] New: [13 Regression ]Maybe wrong " marxin at gcc dot gnu.org 2023-03-03 12:11 ` [Bug tree-optimization/109008] [13 Regression] Maybe " rguenth at gcc dot gnu.org 2023-03-03 12:14 ` rguenth at gcc dot gnu.org 2023-03-03 12:18 ` [Bug tree-optimization/109008] [13 Regression] Wrong " rguenth at gcc dot gnu.org 2023-03-03 12:24 ` rguenth at gcc dot gnu.org 2023-03-03 12:27 ` rguenth at gcc dot gnu.org 2023-03-03 12:31 ` jakub at gcc dot gnu.org 2023-03-03 12:54 ` jakub at gcc dot gnu.org 2023-03-03 13:03 ` rguenth at gcc dot gnu.org 2023-03-03 13:10 ` rguenth at gcc dot gnu.org 2023-03-03 13:14 ` rguenth at gcc dot gnu.org 2023-03-03 13:34 ` jakub at gcc dot gnu.org 2023-03-03 13:50 ` rguenth at gcc dot gnu.org 2023-03-03 14:28 ` jakub at gcc dot gnu.org 2023-03-07 12:06 ` rguenth at gcc dot gnu.org 2023-03-07 12:12 ` jakub at gcc dot gnu.org 2023-03-07 12:20 ` jakub at gcc dot gnu.org 2023-03-07 12:23 ` rguenth at gcc dot gnu.org 2023-03-07 12:25 ` rguenth at gcc dot gnu.org 2023-03-07 13:16 ` jakub at gcc dot gnu.org 2023-03-07 13:18 ` rguenth at gcc dot gnu.org 2023-03-07 13:29 ` rguenth at gcc dot gnu.org 2023-03-07 13:58 ` rguenth at gcc dot gnu.org 2023-03-07 14:10 ` rguenth at gcc dot gnu.org 2023-03-07 18:52 ` jakub at gcc dot gnu.org 2023-03-07 19:39 ` jakub at gcc dot gnu.org 2023-03-07 20:49 ` jakub at gcc dot gnu.org 2023-03-08 9:26 ` aldyh at gcc dot gnu.org 2023-03-08 9:29 ` aldyh at gcc dot gnu.org 2023-03-08 9:36 ` jakub at gcc dot gnu.org 2023-03-08 10:09 ` aldyh at gcc dot gnu.org 2023-03-08 11:29 ` jakub at gcc dot gnu.org 2023-03-08 11:30 ` jakub at gcc dot gnu.org 2023-03-08 14:51 ` jakub at gcc dot gnu.org 2023-03-08 14:52 ` jakub at gcc dot gnu.org 2023-03-08 15:07 ` jakub at gcc dot gnu.org 2023-03-08 15:54 ` jakub at gcc dot gnu.org 2023-03-08 16:37 ` jakub at gcc dot gnu.org 2023-03-08 18:56 ` jakub at gcc dot gnu.org 2023-03-08 20:02 ` jakub at gcc dot gnu.org 2023-03-09 8:52 ` cvs-commit at gcc dot gnu.org 2023-03-09 10:24 ` rguenth at gcc dot gnu.org 2023-03-09 11:06 ` jakub at gcc dot gnu.org 2023-03-09 11:12 ` marxin at gcc dot gnu.org 2023-03-09 11:50 ` jakub at gcc dot gnu.org 2023-03-09 12:34 ` rguenth at gcc dot gnu.org 2023-03-09 12:56 ` jakub at gcc dot gnu.org [this message] 2023-03-09 13:03 ` jakub at gcc dot gnu.org 2023-03-09 13:25 ` jakub at gcc dot gnu.org 2023-03-10 9:08 ` cvs-commit at gcc dot gnu.org 2023-03-10 11:41 ` cvs-commit at gcc dot gnu.org 2023-03-22 9:07 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109008-4-7fyFWEq8ZK@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).