public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109008] [13 Regression] Wrong code in scipy package since r13-3926-gd4c2f1d376da6f
Date: Tue, 07 Mar 2023 13:16:29 +0000	[thread overview]
Message-ID: <bug-109008-4-W2097e0xvJ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109008-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109008

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #16)
> (In reply to Jakub Jelinek from comment #14)
> > Created attachment 54599 [details]
> > gcc13-pr109008-wip.patch
> > 
> > I have now this WIP but it doesn't work correctly yet, need to debug it now,
> > just finished writing it and making it compile.
> > Note, after the binary search it is still unfinished, I'd like to then
> > adjust it one bit at a time to narrow it further.  But before working on
> > that it needs to work correctly.
> 
> Looks nicer and more precise (even though the iterating function is ugly
> and you also suffer from the lack of copying of alternate range state,
> but using .union () is a way out here I guess ;)).

I thought the union_ handles it.  I didn't want to simply override the lower or
upper bound on r, because frange::set has various canonicalizations and the
like.

> Can we ignore -frounding-math here?

I believe it isn't ignored, -frounding-math ought to be taken into account in
frange_arithmetic.  The intent was that the testing function/lambda would e.g.
for the
addition when extending lower bound perform rounding etc. towards +inf and when
extending upper bound towards -inf.
But as I said, the patch currently doesn't work correctly, the test on the
nextafter
value at the start of the new function fails even when I'd think it should
pass.

  parent reply	other threads:[~2023-03-07 13:16 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 12:08 [Bug tree-optimization/109008] New: [13 Regression ]Maybe wrong " marxin at gcc dot gnu.org
2023-03-03 12:11 ` [Bug tree-optimization/109008] [13 Regression] Maybe " rguenth at gcc dot gnu.org
2023-03-03 12:14 ` rguenth at gcc dot gnu.org
2023-03-03 12:18 ` [Bug tree-optimization/109008] [13 Regression] Wrong " rguenth at gcc dot gnu.org
2023-03-03 12:24 ` rguenth at gcc dot gnu.org
2023-03-03 12:27 ` rguenth at gcc dot gnu.org
2023-03-03 12:31 ` jakub at gcc dot gnu.org
2023-03-03 12:54 ` jakub at gcc dot gnu.org
2023-03-03 13:03 ` rguenth at gcc dot gnu.org
2023-03-03 13:10 ` rguenth at gcc dot gnu.org
2023-03-03 13:14 ` rguenth at gcc dot gnu.org
2023-03-03 13:34 ` jakub at gcc dot gnu.org
2023-03-03 13:50 ` rguenth at gcc dot gnu.org
2023-03-03 14:28 ` jakub at gcc dot gnu.org
2023-03-07 12:06 ` rguenth at gcc dot gnu.org
2023-03-07 12:12 ` jakub at gcc dot gnu.org
2023-03-07 12:20 ` jakub at gcc dot gnu.org
2023-03-07 12:23 ` rguenth at gcc dot gnu.org
2023-03-07 12:25 ` rguenth at gcc dot gnu.org
2023-03-07 13:16 ` jakub at gcc dot gnu.org [this message]
2023-03-07 13:18 ` rguenth at gcc dot gnu.org
2023-03-07 13:29 ` rguenth at gcc dot gnu.org
2023-03-07 13:58 ` rguenth at gcc dot gnu.org
2023-03-07 14:10 ` rguenth at gcc dot gnu.org
2023-03-07 18:52 ` jakub at gcc dot gnu.org
2023-03-07 19:39 ` jakub at gcc dot gnu.org
2023-03-07 20:49 ` jakub at gcc dot gnu.org
2023-03-08  9:26 ` aldyh at gcc dot gnu.org
2023-03-08  9:29 ` aldyh at gcc dot gnu.org
2023-03-08  9:36 ` jakub at gcc dot gnu.org
2023-03-08 10:09 ` aldyh at gcc dot gnu.org
2023-03-08 11:29 ` jakub at gcc dot gnu.org
2023-03-08 11:30 ` jakub at gcc dot gnu.org
2023-03-08 14:51 ` jakub at gcc dot gnu.org
2023-03-08 14:52 ` jakub at gcc dot gnu.org
2023-03-08 15:07 ` jakub at gcc dot gnu.org
2023-03-08 15:54 ` jakub at gcc dot gnu.org
2023-03-08 16:37 ` jakub at gcc dot gnu.org
2023-03-08 18:56 ` jakub at gcc dot gnu.org
2023-03-08 20:02 ` jakub at gcc dot gnu.org
2023-03-09  8:52 ` cvs-commit at gcc dot gnu.org
2023-03-09 10:24 ` rguenth at gcc dot gnu.org
2023-03-09 11:06 ` jakub at gcc dot gnu.org
2023-03-09 11:12 ` marxin at gcc dot gnu.org
2023-03-09 11:50 ` jakub at gcc dot gnu.org
2023-03-09 12:34 ` rguenth at gcc dot gnu.org
2023-03-09 12:56 ` jakub at gcc dot gnu.org
2023-03-09 13:03 ` jakub at gcc dot gnu.org
2023-03-09 13:25 ` jakub at gcc dot gnu.org
2023-03-10  9:08 ` cvs-commit at gcc dot gnu.org
2023-03-10 11:41 ` cvs-commit at gcc dot gnu.org
2023-03-22  9:07 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109008-4-W2097e0xvJ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).