public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109008] [13 Regression] Wrong code in scipy package since r13-3926-gd4c2f1d376da6f Date: Thu, 09 Mar 2023 13:25:10 +0000 [thread overview] Message-ID: <bug-109008-4-SzXz4c7vri@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109008-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109008 --- Comment #47 from Jakub Jelinek <jakub at gcc dot gnu.org> --- For the !MODE_HAS_INFINITIES, perhaps --- gcc/range-op-float.cc.jj 2023-03-09 13:12:05.248873234 +0100 +++ gcc/range-op-float.cc 2023-03-09 14:21:51.959802517 +0100 @@ -2216,6 +2216,7 @@ float_widen_lhs_range (tree type, const return ret; REAL_VALUE_TYPE lb = lhs.lower_bound (); REAL_VALUE_TYPE ub = lhs.upper_bound (); + bool lb_inf = false, ub_inf = false; if (real_isfinite (&lb)) { frange_nextafter (TYPE_MODE (type), lb, dconstninf); @@ -2238,6 +2239,14 @@ float_widen_lhs_range (tree type, const real_arithmetic (&tem, PLUS_EXPR, &lhs.lower_bound (), &lb); real_arithmetic (&lb, RDIV_EXPR, &tem, &dconst2); } + if (!MODE_HAS_INFINITIES (TYPE_MODE (type)) + && frange_val_is_min (lhs.lower_bound (), type)) + { + /* If type doesn't have infinities, then the minimum acts + as kind of infinity. Turn it into a true infinity. */ + real_inf (&lb, true); + lb_inf = true; + } } if (real_isfinite (&ub)) { @@ -2256,6 +2265,14 @@ float_widen_lhs_range (tree type, const real_arithmetic (&tem, PLUS_EXPR, &lhs.upper_bound (), &ub); real_arithmetic (&ub, RDIV_EXPR, &tem, &dconst2); } + if (!MODE_HAS_INFINITIES (TYPE_MODE (type)) + && frange_val_is_max (lhs.upper_bound (), type)) + { + /* If type doesn't have infinities, then the maximum acts + as kind of infinity. Turn it into a true infinity. */ + real_inf (&ub, false); + ub_inf = true; + } } /* Temporarily disable -ffinite-math-only, so that frange::set doesn't reduce the range back to real_min_representable (type) as lower bound @@ -2266,6 +2283,15 @@ float_widen_lhs_range (tree type, const ret.clear_nan (); ret.union_ (lhs); flag_finite_math_only = save_flag_finite_math_only; + if (lb_inf || ub_inf) + { + if (ret.kind () == VR_VARYING) + ret.m_kind = VR_RANGE; + if (lb_inf) + ret.m_min = lb; + if (ub_inf) + ret.m_max = ub; + } return ret; } except that the members are private and so the above will not compile. We'd need some kind of set_unsafe or whatever that would allow to override those even when it is not canonical. But given that I'm not sure if even the forward operations result in correct ranges around these non-infinity "infinities", doing something with it is perhaps premature.
next prev parent reply other threads:[~2023-03-09 13:25 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-03 12:08 [Bug tree-optimization/109008] New: [13 Regression ]Maybe wrong " marxin at gcc dot gnu.org 2023-03-03 12:11 ` [Bug tree-optimization/109008] [13 Regression] Maybe " rguenth at gcc dot gnu.org 2023-03-03 12:14 ` rguenth at gcc dot gnu.org 2023-03-03 12:18 ` [Bug tree-optimization/109008] [13 Regression] Wrong " rguenth at gcc dot gnu.org 2023-03-03 12:24 ` rguenth at gcc dot gnu.org 2023-03-03 12:27 ` rguenth at gcc dot gnu.org 2023-03-03 12:31 ` jakub at gcc dot gnu.org 2023-03-03 12:54 ` jakub at gcc dot gnu.org 2023-03-03 13:03 ` rguenth at gcc dot gnu.org 2023-03-03 13:10 ` rguenth at gcc dot gnu.org 2023-03-03 13:14 ` rguenth at gcc dot gnu.org 2023-03-03 13:34 ` jakub at gcc dot gnu.org 2023-03-03 13:50 ` rguenth at gcc dot gnu.org 2023-03-03 14:28 ` jakub at gcc dot gnu.org 2023-03-07 12:06 ` rguenth at gcc dot gnu.org 2023-03-07 12:12 ` jakub at gcc dot gnu.org 2023-03-07 12:20 ` jakub at gcc dot gnu.org 2023-03-07 12:23 ` rguenth at gcc dot gnu.org 2023-03-07 12:25 ` rguenth at gcc dot gnu.org 2023-03-07 13:16 ` jakub at gcc dot gnu.org 2023-03-07 13:18 ` rguenth at gcc dot gnu.org 2023-03-07 13:29 ` rguenth at gcc dot gnu.org 2023-03-07 13:58 ` rguenth at gcc dot gnu.org 2023-03-07 14:10 ` rguenth at gcc dot gnu.org 2023-03-07 18:52 ` jakub at gcc dot gnu.org 2023-03-07 19:39 ` jakub at gcc dot gnu.org 2023-03-07 20:49 ` jakub at gcc dot gnu.org 2023-03-08 9:26 ` aldyh at gcc dot gnu.org 2023-03-08 9:29 ` aldyh at gcc dot gnu.org 2023-03-08 9:36 ` jakub at gcc dot gnu.org 2023-03-08 10:09 ` aldyh at gcc dot gnu.org 2023-03-08 11:29 ` jakub at gcc dot gnu.org 2023-03-08 11:30 ` jakub at gcc dot gnu.org 2023-03-08 14:51 ` jakub at gcc dot gnu.org 2023-03-08 14:52 ` jakub at gcc dot gnu.org 2023-03-08 15:07 ` jakub at gcc dot gnu.org 2023-03-08 15:54 ` jakub at gcc dot gnu.org 2023-03-08 16:37 ` jakub at gcc dot gnu.org 2023-03-08 18:56 ` jakub at gcc dot gnu.org 2023-03-08 20:02 ` jakub at gcc dot gnu.org 2023-03-09 8:52 ` cvs-commit at gcc dot gnu.org 2023-03-09 10:24 ` rguenth at gcc dot gnu.org 2023-03-09 11:06 ` jakub at gcc dot gnu.org 2023-03-09 11:12 ` marxin at gcc dot gnu.org 2023-03-09 11:50 ` jakub at gcc dot gnu.org 2023-03-09 12:34 ` rguenth at gcc dot gnu.org 2023-03-09 12:56 ` jakub at gcc dot gnu.org 2023-03-09 13:03 ` jakub at gcc dot gnu.org 2023-03-09 13:25 ` jakub at gcc dot gnu.org [this message] 2023-03-10 9:08 ` cvs-commit at gcc dot gnu.org 2023-03-10 11:41 ` cvs-commit at gcc dot gnu.org 2023-03-22 9:07 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109008-4-SzXz4c7vri@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).