public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109008] [13 Regression] Wrong code in scipy package since r13-3926-gd4c2f1d376da6f Date: Wed, 08 Mar 2023 15:07:27 +0000 [thread overview] Message-ID: <bug-109008-4-xy7DWN1GJk@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109008-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109008 --- Comment #34 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Testing I've performed so far (though on 10000 iterations rather than 300000, that is ongoing), once with the https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109008#c33 patch alone, once with that patch and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109008#c32. First step, generate a random testcase: pr109008-gen.c: #include <stdint.h> #include <stdlib.h> #include <stdio.h> #include <string.h> static long rand_n; static int rand_c; static uint32_t get_rand32 (void) { uint32_t ret = 0; if (rand_c == 0) { ret = random () & 0x7fffffff; rand_c = 31; } else ret = rand_n & (((uint32_t) 1 << rand_c) - 1); ret <<= (32 - rand_c); rand_n = random (); ret |= rand_n & (((uint32_t) 1 << (32 - rand_c)) - 1); rand_n >>= (32 - rand_c); rand_c = 31 - (32 - rand_c); return ret; } static uint64_t get_rand64 (void) { return (((uint64_t) get_rand32 ()) << 32) | get_rand32 (); } static float get_randf (void) { uint32_t i = get_rand32 (); float f; memcpy (&f, &i, sizeof (f)); return f; } int main () { printf ("#define nanf __builtin_nanf (\"\")\n"); printf ("#define inf __builtin_inff ()\n"); for (int n = 0; n < 300000; ++n) { float n1 = get_randf (); float n2 = get_randf (); uint32_t x = get_rand32 (); if ((x & 7) == 0) n2 = n1; x >>= 3; printf ("float f%d (float eps) { float f = ", n); switch (x % 3) { case 0: printf ("%af + eps", n1); break; case 1: printf ("%af - eps", n1); break; case 2: printf ("eps - %af", n1); break; } printf ("; if (f == %af) return eps; return __builtin_nanf (\"42\"); }\n", n2); } return 0; } pr109008-main.c: #include <math.h> #include "pr109008.c" struct S { float (*fn) (float); float lb, ub; }; struct S arr[] = { #include "pr109008.h" }; int main () { float plus_inf = __builtin_inf (); float minus_inf = -plus_inf; for (int i = 0; i < sizeof (arr) / sizeof (arr[0]); ++i) { float lb = nextafterf (arr[i].lb, minus_inf); float ub = nextafterf (arr[i].ub, plus_inf); if (!__builtin_isnan (arr[i].fn (lb)) || !__builtin_isnan (arr[i].fn (ub))) __builtin_printf ("%p err\n", arr[i].fn); } } gcc -g -O2 -o pr109008-gen{,.c}; ./pr109008-gen > pr109008.c Next, with cc1 built with just #c33 patch: rm -f /tmp/ranges; ./cc1 -quiet -O2 pr109008.c; sort -u /tmp/ranges > pr109008.h gcc -g -o pr109008-main{,.c}; ./pr109008-main For 10000 iterations this showed 872 errors. Next, with cc1 built with both #c32 and #c33 patches: rm -f /tmp/ranges; ./cc1 -quiet -O2 pr109008.c; sort -u /tmp/ranges > pr109008.h gcc -g -o pr109008-main{,.c}; ./pr109008-main This didn't print any errors, so at least for foperator_plus and foperator_minus seems to be from this limited testing conservatively correct. Want to finish now this testing also for 300000 iterations and then perhaps try the #c30 patch with variant of #c33 to check also that implementation. And finally compare the #c32+#c33 vs. #c30+#c33variant ranges. Another thing which would be nice to think about is whether float_widen_lhs_range needs to extend even real_{min,max}_representable () bounds towards -+inf, or whether that case can't happen (and check that separately for + or - and * or /), because e.g. for mult/div whether lhs is finite is quite important.
next prev parent reply other threads:[~2023-03-08 15:07 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-03 12:08 [Bug tree-optimization/109008] New: [13 Regression ]Maybe wrong " marxin at gcc dot gnu.org 2023-03-03 12:11 ` [Bug tree-optimization/109008] [13 Regression] Maybe " rguenth at gcc dot gnu.org 2023-03-03 12:14 ` rguenth at gcc dot gnu.org 2023-03-03 12:18 ` [Bug tree-optimization/109008] [13 Regression] Wrong " rguenth at gcc dot gnu.org 2023-03-03 12:24 ` rguenth at gcc dot gnu.org 2023-03-03 12:27 ` rguenth at gcc dot gnu.org 2023-03-03 12:31 ` jakub at gcc dot gnu.org 2023-03-03 12:54 ` jakub at gcc dot gnu.org 2023-03-03 13:03 ` rguenth at gcc dot gnu.org 2023-03-03 13:10 ` rguenth at gcc dot gnu.org 2023-03-03 13:14 ` rguenth at gcc dot gnu.org 2023-03-03 13:34 ` jakub at gcc dot gnu.org 2023-03-03 13:50 ` rguenth at gcc dot gnu.org 2023-03-03 14:28 ` jakub at gcc dot gnu.org 2023-03-07 12:06 ` rguenth at gcc dot gnu.org 2023-03-07 12:12 ` jakub at gcc dot gnu.org 2023-03-07 12:20 ` jakub at gcc dot gnu.org 2023-03-07 12:23 ` rguenth at gcc dot gnu.org 2023-03-07 12:25 ` rguenth at gcc dot gnu.org 2023-03-07 13:16 ` jakub at gcc dot gnu.org 2023-03-07 13:18 ` rguenth at gcc dot gnu.org 2023-03-07 13:29 ` rguenth at gcc dot gnu.org 2023-03-07 13:58 ` rguenth at gcc dot gnu.org 2023-03-07 14:10 ` rguenth at gcc dot gnu.org 2023-03-07 18:52 ` jakub at gcc dot gnu.org 2023-03-07 19:39 ` jakub at gcc dot gnu.org 2023-03-07 20:49 ` jakub at gcc dot gnu.org 2023-03-08 9:26 ` aldyh at gcc dot gnu.org 2023-03-08 9:29 ` aldyh at gcc dot gnu.org 2023-03-08 9:36 ` jakub at gcc dot gnu.org 2023-03-08 10:09 ` aldyh at gcc dot gnu.org 2023-03-08 11:29 ` jakub at gcc dot gnu.org 2023-03-08 11:30 ` jakub at gcc dot gnu.org 2023-03-08 14:51 ` jakub at gcc dot gnu.org 2023-03-08 14:52 ` jakub at gcc dot gnu.org 2023-03-08 15:07 ` jakub at gcc dot gnu.org [this message] 2023-03-08 15:54 ` jakub at gcc dot gnu.org 2023-03-08 16:37 ` jakub at gcc dot gnu.org 2023-03-08 18:56 ` jakub at gcc dot gnu.org 2023-03-08 20:02 ` jakub at gcc dot gnu.org 2023-03-09 8:52 ` cvs-commit at gcc dot gnu.org 2023-03-09 10:24 ` rguenth at gcc dot gnu.org 2023-03-09 11:06 ` jakub at gcc dot gnu.org 2023-03-09 11:12 ` marxin at gcc dot gnu.org 2023-03-09 11:50 ` jakub at gcc dot gnu.org 2023-03-09 12:34 ` rguenth at gcc dot gnu.org 2023-03-09 12:56 ` jakub at gcc dot gnu.org 2023-03-09 13:03 ` jakub at gcc dot gnu.org 2023-03-09 13:25 ` jakub at gcc dot gnu.org 2023-03-10 9:08 ` cvs-commit at gcc dot gnu.org 2023-03-10 11:41 ` cvs-commit at gcc dot gnu.org 2023-03-22 9:07 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109008-4-xy7DWN1GJk@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).