public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aldyh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109008] [13 Regression] Wrong code in scipy package since r13-3926-gd4c2f1d376da6f
Date: Wed, 08 Mar 2023 09:26:55 +0000	[thread overview]
Message-ID: <bug-109008-4-Krxah8tcVW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109008-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109008

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amacleod at redhat dot com

--- Comment #26 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #16)
> (In reply to Jakub Jelinek from comment #14)
> > Created attachment 54599 [details]
> > gcc13-pr109008-wip.patch
> > 
> > I have now this WIP but it doesn't work correctly yet, need to debug it now,
> > just finished writing it and making it compile.
> > Note, after the binary search it is still unfinished, I'd like to then
> > adjust it one bit at a time to narrow it further.  But before working on
> > that it needs to work correctly.
> 
> Looks nicer and more precise (even though the iterating function is ugly
> and you also suffer from the lack of copying of alternate range state,
> but using .union () is a way out here I guess ;)).

While working on LTO streaming of ranges, I also noticed that we don't have a
way of accessing the individual NAN sign bits or a way of copying NAN state. 
Why don't we get this right instead of hacking around it?

Would it help if we provided the following?

nan_state_t irange::get_nan_state ();

irange::set (tree type, const REAL_VALUE_TYPE &, const REAL_VALUE_TYPE &, const
nan_state_t &, value_range_kind = VR_RANGE);

We could implement nan_state_t to include the m_pos_nan and m_neg_nan for
minimal disruption now, and later use it for extending the NAN information
(signalling, etc).

  parent reply	other threads:[~2023-03-08  9:27 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 12:08 [Bug tree-optimization/109008] New: [13 Regression ]Maybe wrong " marxin at gcc dot gnu.org
2023-03-03 12:11 ` [Bug tree-optimization/109008] [13 Regression] Maybe " rguenth at gcc dot gnu.org
2023-03-03 12:14 ` rguenth at gcc dot gnu.org
2023-03-03 12:18 ` [Bug tree-optimization/109008] [13 Regression] Wrong " rguenth at gcc dot gnu.org
2023-03-03 12:24 ` rguenth at gcc dot gnu.org
2023-03-03 12:27 ` rguenth at gcc dot gnu.org
2023-03-03 12:31 ` jakub at gcc dot gnu.org
2023-03-03 12:54 ` jakub at gcc dot gnu.org
2023-03-03 13:03 ` rguenth at gcc dot gnu.org
2023-03-03 13:10 ` rguenth at gcc dot gnu.org
2023-03-03 13:14 ` rguenth at gcc dot gnu.org
2023-03-03 13:34 ` jakub at gcc dot gnu.org
2023-03-03 13:50 ` rguenth at gcc dot gnu.org
2023-03-03 14:28 ` jakub at gcc dot gnu.org
2023-03-07 12:06 ` rguenth at gcc dot gnu.org
2023-03-07 12:12 ` jakub at gcc dot gnu.org
2023-03-07 12:20 ` jakub at gcc dot gnu.org
2023-03-07 12:23 ` rguenth at gcc dot gnu.org
2023-03-07 12:25 ` rguenth at gcc dot gnu.org
2023-03-07 13:16 ` jakub at gcc dot gnu.org
2023-03-07 13:18 ` rguenth at gcc dot gnu.org
2023-03-07 13:29 ` rguenth at gcc dot gnu.org
2023-03-07 13:58 ` rguenth at gcc dot gnu.org
2023-03-07 14:10 ` rguenth at gcc dot gnu.org
2023-03-07 18:52 ` jakub at gcc dot gnu.org
2023-03-07 19:39 ` jakub at gcc dot gnu.org
2023-03-07 20:49 ` jakub at gcc dot gnu.org
2023-03-08  9:26 ` aldyh at gcc dot gnu.org [this message]
2023-03-08  9:29 ` aldyh at gcc dot gnu.org
2023-03-08  9:36 ` jakub at gcc dot gnu.org
2023-03-08 10:09 ` aldyh at gcc dot gnu.org
2023-03-08 11:29 ` jakub at gcc dot gnu.org
2023-03-08 11:30 ` jakub at gcc dot gnu.org
2023-03-08 14:51 ` jakub at gcc dot gnu.org
2023-03-08 14:52 ` jakub at gcc dot gnu.org
2023-03-08 15:07 ` jakub at gcc dot gnu.org
2023-03-08 15:54 ` jakub at gcc dot gnu.org
2023-03-08 16:37 ` jakub at gcc dot gnu.org
2023-03-08 18:56 ` jakub at gcc dot gnu.org
2023-03-08 20:02 ` jakub at gcc dot gnu.org
2023-03-09  8:52 ` cvs-commit at gcc dot gnu.org
2023-03-09 10:24 ` rguenth at gcc dot gnu.org
2023-03-09 11:06 ` jakub at gcc dot gnu.org
2023-03-09 11:12 ` marxin at gcc dot gnu.org
2023-03-09 11:50 ` jakub at gcc dot gnu.org
2023-03-09 12:34 ` rguenth at gcc dot gnu.org
2023-03-09 12:56 ` jakub at gcc dot gnu.org
2023-03-09 13:03 ` jakub at gcc dot gnu.org
2023-03-09 13:25 ` jakub at gcc dot gnu.org
2023-03-10  9:08 ` cvs-commit at gcc dot gnu.org
2023-03-10 11:41 ` cvs-commit at gcc dot gnu.org
2023-03-22  9:07 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109008-4-Krxah8tcVW@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).