public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/110334] [13/14 Regresssion] unused functions not eliminated before LTO streaming
Date: Wed, 28 Jun 2023 10:00:59 +0000 [thread overview]
Message-ID: <bug-110334-4-5V3LXkWxhF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110334-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110334
--- Comment #14 from Jan Hubicka <hubicka at ucw dot cz> ---
>
> why disallow caller->indirect_calls?
See testcase in comment #9
>
> > + return false;
> > + for (cgraph_edge *e2 = callee->callees; e2; e2 = e2->next_callee)
>
> I don't think this flys - it looks quadratic. Can we compute this
> in the inline summary once instead?
I guess I can place a cache there. I think this check will become more
global over time so it more fits IMO here.
>
> As for indirect calls, can we maybe mark initial direct GIMPLE call
> stmts as "always-inline" and only look at that marking, thus an
> indirect call will never become "always-inline"? Iff cgraph edges
> prevail during all early inlining we could mark call edges for
> this purpose?
I also think we need call site specific info.
Tagging gimple call statements and copying the info to gimple edges will
probably be needed here. We want to keep the info from early inlining
to late inlining since we output errors late.
We already have plenty of GF_CALL_ flags, so adding one should be easy?
Honza
next prev parent reply other threads:[~2023-06-28 10:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 7:05 [Bug ipa/110334] New: " rguenth at gcc dot gnu.org
2023-06-21 7:06 ` [Bug ipa/110334] " rguenth at gcc dot gnu.org
2023-06-21 7:08 ` rguenth at gcc dot gnu.org
2023-06-21 7:12 ` rguenth at gcc dot gnu.org
2023-06-22 11:15 ` rguenth at gcc dot gnu.org
2023-06-22 11:45 ` rguenth at gcc dot gnu.org
2023-06-22 12:02 ` rguenth at gcc dot gnu.org
2023-06-23 10:47 ` hubicka at gcc dot gnu.org
2023-06-23 11:21 ` rguenth at gcc dot gnu.org
2023-06-23 12:59 ` hubicka at ucw dot cz
2023-06-23 13:07 ` Jan Hubicka
2023-06-23 13:07 ` hubicka at ucw dot cz
2023-06-26 6:39 ` rguenther at suse dot de
2023-06-26 17:50 ` hubicka at ucw dot cz
2023-06-27 6:41 ` rguenther at suse dot de
2023-06-28 10:00 ` Jan Hubicka
2023-06-28 4:42 ` cvs-commit at gcc dot gnu.org
2023-06-28 10:00 ` hubicka at ucw dot cz [this message]
2023-06-28 10:20 ` rguenther at suse dot de
2023-06-28 10:45 ` hubicka at ucw dot cz
2023-06-28 21:06 ` cvs-commit at gcc dot gnu.org
2023-07-03 7:05 ` jakub at gcc dot gnu.org
2023-07-10 7:40 ` rguenth at gcc dot gnu.org
2023-07-10 8:24 ` rguenth at gcc dot gnu.org
2023-07-10 8:24 ` rguenth at gcc dot gnu.org
2023-07-11 14:45 ` hubicka at ucw dot cz
2023-07-11 14:46 ` hubicka at ucw dot cz
2023-07-12 7:05 ` rguenther at suse dot de
2023-07-27 9:26 ` rguenth at gcc dot gnu.org
2023-11-25 10:00 ` egallager at gcc dot gnu.org
2023-11-27 7:28 ` rguenth at gcc dot gnu.org
2024-05-21 9:16 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-110334-4-5V3LXkWxhF@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).