public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/110334] [13/14 Regresssion] unused functions not eliminated before LTO streaming
Date: Wed, 28 Jun 2023 21:06:25 +0000	[thread overview]
Message-ID: <bug-110334-4-gxNwQAnqRY@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110334-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110334

--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:d88fd2e1d0720e6f892da9ff48e9a301a7ad0ad4

commit r14-2172-gd88fd2e1d0720e6f892da9ff48e9a301a7ad0ad4
Author: Jan Hubicka <jh@suse.cz>
Date:   Wed Jun 28 23:05:28 2023 +0200

    Enable early inlining into always_inline functions

    Early inliner currently skips always_inline functions and moreover we
ignore
    calls from always_inline in ipa_reverse_postorder.  This leads to disabling
    most of propagation done using early optimization that is quite bad when
    early inline functions are not leaf functions, which is now quite common
    in libstdc++.

    This patch instead of fully disabling the inline checks calls in callee.
    I am quite conservative about what can be inlined as this patch is bit
    touchy anyway.  To avoid problems with always_inline being optimized
    after early inline I extended inline_always_inline_functions to lazilly
    compute fnsummary when needed.

    gcc/ChangeLog:

            PR middle-end/110334
            * ipa-fnsummary.h (ipa_fn_summary): Add
            safe_to_inline_to_always_inline.
            * ipa-inline.cc (can_early_inline_edge_p): ICE
            if SSA is not built; do cycle checking for
            always_inline functions.
            (inline_always_inline_functions): Be recrusive;
            watch for cycles; do not updat overall summary.
            (early_inliner): Do not give up on always_inlines.
            * ipa-utils.cc (ipa_reverse_postorder): Do not skip
            always inlines.

    gcc/testsuite/ChangeLog:

            PR middle-end/110334
            * g++.dg/opt/pr66119.C: Disable early inlining.
            * gcc.c-torture/compile/pr110334.c: New test.
            * gcc.dg/tree-ssa/pr110334.c: New test.

  parent reply	other threads:[~2023-06-28 21:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  7:05 [Bug ipa/110334] New: " rguenth at gcc dot gnu.org
2023-06-21  7:06 ` [Bug ipa/110334] " rguenth at gcc dot gnu.org
2023-06-21  7:08 ` rguenth at gcc dot gnu.org
2023-06-21  7:12 ` rguenth at gcc dot gnu.org
2023-06-22 11:15 ` rguenth at gcc dot gnu.org
2023-06-22 11:45 ` rguenth at gcc dot gnu.org
2023-06-22 12:02 ` rguenth at gcc dot gnu.org
2023-06-23 10:47 ` hubicka at gcc dot gnu.org
2023-06-23 11:21 ` rguenth at gcc dot gnu.org
2023-06-23 12:59 ` hubicka at ucw dot cz
2023-06-23 13:07   ` Jan Hubicka
2023-06-23 13:07 ` hubicka at ucw dot cz
2023-06-26  6:39 ` rguenther at suse dot de
2023-06-26 17:50 ` hubicka at ucw dot cz
2023-06-27  6:41 ` rguenther at suse dot de
2023-06-28 10:00   ` Jan Hubicka
2023-06-28  4:42 ` cvs-commit at gcc dot gnu.org
2023-06-28 10:00 ` hubicka at ucw dot cz
2023-06-28 10:20 ` rguenther at suse dot de
2023-06-28 10:45 ` hubicka at ucw dot cz
2023-06-28 21:06 ` cvs-commit at gcc dot gnu.org [this message]
2023-07-03  7:05 ` jakub at gcc dot gnu.org
2023-07-10  7:40 ` rguenth at gcc dot gnu.org
2023-07-10  8:24 ` rguenth at gcc dot gnu.org
2023-07-10  8:24 ` rguenth at gcc dot gnu.org
2023-07-11 14:45 ` hubicka at ucw dot cz
2023-07-11 14:46 ` hubicka at ucw dot cz
2023-07-12  7:05 ` rguenther at suse dot de
2023-07-27  9:26 ` rguenth at gcc dot gnu.org
2023-11-25 10:00 ` egallager at gcc dot gnu.org
2023-11-27  7:28 ` rguenth at gcc dot gnu.org
2024-05-21  9:16 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110334-4-gxNwQAnqRY@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).