public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/110334] [13/14 Regresssion] unused functions not eliminated before LTO streaming Date: Thu, 22 Jun 2023 11:45:04 +0000 [thread overview] Message-ID: <bug-110334-4-OCxkxiuc5D@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110334-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110334 --- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> --- So we run into /* Never inline regular functions into always-inline functions during incremental inlining. This sucks as functions calling always inline functions will get less optimized, but at the same time inlining of functions calling always inline function into an always inline function might introduce cycles of edges to be always inlined in the callgraph. We might want to be smarter and just avoid this type of inlining. */ || (DECL_DISREGARD_INLINE_LIMITS (node->decl) && lookup_attribute ("always_inline", DECL_ATTRIBUTES (node->decl)))) which I think is sensible but the issue is that for some reason the skvx::Vec<4, unsigned int>::Vec (_1, s_6(D)) calls are not always_inline. (gdb) p node->callees $3 = <cgraph_edge* 0x7ffff301c068 (<cgraph_node * 0x7ffff2f43000 "__ct_base "/8008> -> <cgraph_node * 0x7ffff3338dd0 "__ct_comp "/8006>)> (gdb) p node->callees->next_callee $4 = <cgraph_edge* 0x7ffff301c000 (<cgraph_node * 0x7ffff2f43000 "__ct_base "/8008> -> <cgraph_node * 0x7ffff3338dd0 "__ct_comp "/8006>)> __attribute__((always_inline)) void skvx::VecStorage<8, unsigned int>::VecStorage (struct VecStorage * const this, unsigned int s) { struct Vec * _1; struct Vec * _2; <bb 2> : *this_4(D) ={v} {CLOBBER}; _1 = &this_4(D)->lo; skvx::Vec<4, unsigned int>::Vec (_1, s_6(D)); _2 = &this_4(D)->hi; skvx::Vec<4, unsigned int>::Vec (_2, s_6(D)); return; the location info points to __attribute__((always_inline)) Vec(typename ConvertNative<N, T>::type native) : Vec(bit_pun<Vec>(native)) {} I'm not sure what fails to work here.
next prev parent reply other threads:[~2023-06-22 11:45 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-21 7:05 [Bug ipa/110334] New: " rguenth at gcc dot gnu.org 2023-06-21 7:06 ` [Bug ipa/110334] " rguenth at gcc dot gnu.org 2023-06-21 7:08 ` rguenth at gcc dot gnu.org 2023-06-21 7:12 ` rguenth at gcc dot gnu.org 2023-06-22 11:15 ` rguenth at gcc dot gnu.org 2023-06-22 11:45 ` rguenth at gcc dot gnu.org [this message] 2023-06-22 12:02 ` rguenth at gcc dot gnu.org 2023-06-23 10:47 ` hubicka at gcc dot gnu.org 2023-06-23 11:21 ` rguenth at gcc dot gnu.org 2023-06-23 12:59 ` hubicka at ucw dot cz 2023-06-23 13:07 ` Jan Hubicka 2023-06-23 13:07 ` hubicka at ucw dot cz 2023-06-26 6:39 ` rguenther at suse dot de 2023-06-26 17:50 ` hubicka at ucw dot cz 2023-06-27 6:41 ` rguenther at suse dot de 2023-06-28 10:00 ` Jan Hubicka 2023-06-28 4:42 ` cvs-commit at gcc dot gnu.org 2023-06-28 10:00 ` hubicka at ucw dot cz 2023-06-28 10:20 ` rguenther at suse dot de 2023-06-28 10:45 ` hubicka at ucw dot cz 2023-06-28 21:06 ` cvs-commit at gcc dot gnu.org 2023-07-03 7:05 ` jakub at gcc dot gnu.org 2023-07-10 7:40 ` rguenth at gcc dot gnu.org 2023-07-10 8:24 ` rguenth at gcc dot gnu.org 2023-07-10 8:24 ` rguenth at gcc dot gnu.org 2023-07-11 14:45 ` hubicka at ucw dot cz 2023-07-11 14:46 ` hubicka at ucw dot cz 2023-07-12 7:05 ` rguenther at suse dot de 2023-07-27 9:26 ` rguenth at gcc dot gnu.org 2023-11-25 10:00 ` egallager at gcc dot gnu.org 2023-11-27 7:28 ` rguenth at gcc dot gnu.org 2024-05-21 9:16 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110334-4-OCxkxiuc5D@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).