[Bug pch/113970] New: [14 Regression] pch/system-{1,2}.C fails on darwin

[Bug pch/113970] New: [14 Regression] pch/system-{1,2}.C fails on darwin

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

            Bug ID: 113970
           Summary: [14 Regression] pch/system-{1,2}.C fails on darwin
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: needs-bisection, wrong-code
          Severity: normal
          Priority: P3
         Component: pch
          Assignee: unassigned at gcc dot gnu.org
          Reporter: iains at gcc dot gnu.org
  Target Milestone: ---
            Target: *-darwin*

somewhere between r14-8885 and r14-9043

FAIL: g++.dg/pch/system-1.C  -g assembly comparison
FAIL: g++.dg/pch/system-1.C  -O2 -g assembly comparison
FAIL: g++.dg/pch/system-2.C  -g assembly comparison
FAIL: g++.dg/pch/system-2.C  -O2 -g assembly comparison

lots of lines like:
line #354
<       .long   0x11ac1
>       .long   0x11ac2
line #691
<       .uleb128 0x22
>       .uleb128 0x21
line #703
<       .uleb128 0x22
>       .uleb128 0x21
line #805
<       .uleb128 0x22
>       .uleb128 0x21

presumably something has changed size or alignment.

[Bug pch/113970] [14 Regression] pch/system-{1,2}.C fails on darwin

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-02-17
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

[Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|pch                         |c++
                 CC|                            |nshead at gcc dot gnu.org
            Summary|[14 Regression]             |[14 Regression]
                   |pch/system-{1,2}.C fails on |pch/system-{1,2}.C fails on
                   |darwin                      |darwin after
                   |                            |r14-8987-gdd9d14f7d53
           Keywords|needs-bisection             |
   Target Milestone|---                         |14.0

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
Bisected to r14-8987-gdd9d14f7d53; reverting that commit on current trunk
(r14-9043) also clears the issue.

[Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
If I read this correctly, it is the debug info that is different rather than
the code itself being different?

[Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

--- Comment #3 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 57500
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57500&action=edit
with PCH

[Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 57501
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57501&action=edit
without PCH

As Andrew says, the differences are in the debug info (it might even only be in
the order of the debug info - hard to tell from a quick comparison).

[Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:615b62aada6cc42759e5c43e196dab6c524925d6

commit r14-9201-g615b62aada6cc42759e5c43e196dab6c524925d6
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Wed Feb 28 11:20:53 2024 +1100

    c++: Revert deferring emission of inline variables [PR114013]

    This is a (partial) reversion of r14-8987-gdd9d14f7d53 to return to
    eagerly emitting inline variables to the middle-end when they are
    declared. 'import_export_decl' will still continue to accept them, as
    allowing this is a pure extension and doesn't seem to cause issues with
    modules, but otherwise deferring the emission of inline variables
    appears to cause issues on some targets and prevents some code using
    inline variable templates from correctly linking.

    There might be a more targetted way to support this, but due to the
    complexity of handling linkage and emission I'd prefer to wait till
    GCC 15 to explore our options.

            PR c++/113970
            PR c++/114013

    gcc/cp/ChangeLog:

            * decl.cc (make_rtl_for_nonlocal_decl): Don't defer inline
            variables.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1z/inline-var10.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>

[Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Should we close this as fixed then?

[Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Marek Polacek from comment #6)
> Should we close this as fixed then?

Yes, it is fixed as per my recent testing.