From: Jeff Law <jeffreyalaw@gmail.com>
To: juzhe.zhong@rivai.ai, jakub <jakub@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"kito.cheng" <kito.cheng@gmail.com>, palmer <palmer@dabbelt.com>,
"richard.sandiford" <richard.sandiford@arm.com>,
rguenther <rguenther@suse.de>
Subject: Re: [PATCH] machine_mode type size: Extend enum size from 8-bit to 16-bit
Date: Mon, 10 Apr 2023 14:39:23 -0600 [thread overview]
Message-ID: <303ff180-6b1d-a655-2678-4e857ce7d15e@gmail.com> (raw)
In-Reply-To: <6B0515CD206AB305+20230410233334379633207@rivai.ai>
On 4/10/23 09:33, juzhe.zhong@rivai.ai wrote:
> I saw many redundant scalar modes:
>
> E_CDImode, /* machmode.def:267 */
> #define HAVE_CDImode
> #ifdef USE_ENUM_MODES
> #define CDImode E_CDImode
> #else
> #define CDImode (complex_mode ((complex_mode::from_int) E_CDImode))
> #endif
> E_CTImode, /* machmode.def:267 */
> #define HAVE_CTImode
> #ifdef USE_ENUM_MODES
> #define CTImode E_CTImode
> #else
> #define CTImode (complex_mode ((complex_mode::from_int) E_CTImode))
> #endif
> E_HCmode, /* machmode.def:269 */
> #define HAVE_HCmode
> #ifdef USE_ENUM_MODES
> #define HCmode E_HCmode
> #else
> #define HCmode (complex_mode ((complex_mode::from_int) E_HCmode))
> #endif
> E_SCmode, /* machmode.def:269 */
> #define HAVE_SCmode
> #ifdef USE_ENUM_MODES
> #define SCmode E_SCmode
> #else
> #define SCmode (complex_mode ((complex_mode::from_int) E_SCmode))
> #endif
> E_DCmode, /* machmode.def:269 */
> #define HAVE_DCmode
> #ifdef USE_ENUM_MODES
> #define DCmode E_DCmode
> #else
> #define DCmode (complex_mode ((complex_mode::from_int) E_DCmode))
> #endif
> E_TCmode, /* machmode.def:269 */
> #define HAVE_TCmode
> #ifdef USE_ENUM_MODES
> #define TCmode E_TCmode
> #else
> #define TCmode (complex_mode ((complex_mode::from_int) E_TCmode))
> #endif
> ...
>
> These scalar modes are redundant I think, can we forbid them?
> There are 40+ scalar modes that are not used.
Those are fairly standard complex modes. Those are unlikely to go away.
Some of those might be redundant with 2 element vector modes, but I'd
hesitate to do something like using CDI to represent a 2XDI vector.
next prev parent reply other threads:[~2023-04-10 20:39 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 14:48 juzhe.zhong
2023-04-10 14:54 ` Jeff Law
2023-04-10 15:02 ` juzhe.zhong
2023-04-10 15:14 ` juzhe.zhong
2023-04-11 9:16 ` Jakub Jelinek
2023-04-11 9:46 ` juzhe.zhong
2023-04-11 10:11 ` Jakub Jelinek
2023-04-11 10:25 ` juzhe.zhong
2023-04-11 10:52 ` Jakub Jelinek
2023-04-11 9:46 ` Richard Sandiford
2023-04-11 9:59 ` Jakub Jelinek
2023-04-11 10:11 ` juzhe.zhong
2023-04-11 10:05 ` Richard Earnshaw
2023-04-11 10:15 ` Richard Sandiford
2023-04-11 10:59 ` Richard Biener
2023-04-11 11:11 ` Richard Sandiford
2023-04-11 11:19 ` juzhe.zhong
2023-04-11 13:50 ` Kito Cheng
2023-04-12 7:53 ` Richard Biener
2023-04-12 9:06 ` Kito Cheng
2023-04-12 9:21 ` Richard Biener
2023-04-12 9:31 ` Kito Cheng
2023-04-12 23:22 ` 钟居哲
2023-04-13 13:06 ` Richard Sandiford
2023-04-13 14:02 ` Richard Biener
2023-04-15 2:58 ` Hans-Peter Nilsson
2023-04-17 6:38 ` Richard Biener
2023-04-20 5:37 ` Hans-Peter Nilsson
2023-05-05 1:43 ` Li, Pan2
2023-05-05 6:25 ` Richard Biener
2023-05-06 1:10 ` Li, Pan2
2023-05-06 1:53 ` Kito Cheng
2023-05-06 1:59 ` juzhe.zhong
2023-05-06 2:12 ` Li, Pan2
2023-05-06 2:18 ` Kito Cheng
2023-05-06 2:20 ` Li, Pan2
2023-05-06 2:48 ` Li, Pan2
2023-05-07 1:55 ` Li, Pan2
2023-05-07 15:23 ` Jeff Law
2023-05-08 1:07 ` Li, Pan2
2023-05-08 6:29 ` Richard Biener
2023-05-08 6:41 ` Li, Pan2
2023-05-08 6:59 ` Li, Pan2
2023-05-08 7:37 ` Richard Biener
2023-05-08 8:05 ` Li, Pan2
2023-05-09 6:13 ` Li, Pan2
2023-05-09 7:04 ` Richard Biener
2023-05-09 10:16 ` Richard Sandiford
2023-05-09 10:26 ` Richard Biener
2023-05-09 11:50 ` Li, Pan2
2023-05-10 5:09 ` Li, Pan2
2023-05-10 7:22 ` Li, Pan2
2023-05-08 1:35 ` Li, Pan2
2023-04-10 15:18 ` Jakub Jelinek
2023-04-10 15:22 ` juzhe.zhong
2023-04-10 20:42 ` Jeff Law
2023-04-10 23:03 ` juzhe.zhong
2023-04-11 1:36 ` juzhe.zhong
[not found] ` <20230410232205400970205@rivai.ai>
2023-04-10 15:33 ` juzhe.zhong
2023-04-10 20:39 ` Jeff Law [this message]
2023-04-10 20:36 ` Jeff Law
2023-04-10 22:53 ` juzhe.zhong
2023-04-10 15:10 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=303ff180-6b1d-a655-2678-4e857ce7d15e@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).