* [PATCH 0/6] Turn some C warnings into errors by default
@ 2023-11-13 13:09 Florian Weimer
2023-11-13 13:09 ` [PATCH 1/6] c-family: Introduce pedpermerror Florian Weimer
` (6 more replies)
0 siblings, 7 replies; 29+ messages in thread
From: Florian Weimer @ 2023-11-13 13:09 UTC (permalink / raw)
To: gcc-patches
This patch series converts the following warnings into errors by
default:
-Wint-conversion
-Wimplicit-function-declaration
-Wimplicit-int
-Wreturn-mismatch
-Wincompatible-pointer-types
As explained in the first commit, I decided not to use permerror_opt
because it does not exhibit the existing behavior for -pedantic-errors.
The impact on existing sources of the last commit is not really known to
me at this point. I plan to start a Fedora build later this week with
an instrumented compiler, to see how much of a compatible impact it will
be. The first conversion pass through Fedora only covered
-Wimplicit-function-declaration, -Wimplicit-int. I started looking at
-Wint-conversion, and it did not seem to be too bad, so I think
including it should be fine. I'm more worried about
-Wincompatible-pointer-types.
I have not yet added a new overview test for -fpermissive. Such a test
should trigger all the dozen or so places where I introduced
pedpermerror, and see what happens under multiple dialects, each with
-fpermissive and without, and maybe also with and withoyt for
-pedantic-errors in -std=gnu89 and default modes. I plan to do this
once I get some initial feedback on the direction of these series
because this test would likely be obsolete fairly quickly if changes to
the diagnostics are required. I did copy some existing tests to test
both the error and warning (-fpermissive) diagnostics, and adjusted
others to expect errors, so there is already quite a bit coverage
without that overview test.
Right now, this series breaks the build on aarch64-linux-gnu due to an
incompatible pointer assignment in libgcc:
[PATCH] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder
<https://inbox.sourceware.org/gcc-patches/874jht5tsq.fsf@oldenburg.str.redhat.com/>
Other targets had the same issue previously, but I've already fixed most
of them (I hope). There could of course be similar issues lurking in
target-specific code, or even in system headers.
With the recent testsuite fixes, the testsuite should be fairly clean
despite these changes. I verified that on i686-linux-gnu,
powerpc64-linux-gnu, and x86_64-linux-gnu. There is one
aarch64-linux-gnu testsuite change I'd like the AArch64 maintainers to
review:
[PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c
<https://inbox.sourceware.org/gcc-patches/87r0kx6eez.fsf@oldenburg.str.redhat.com/>
Recently, I also found a problem in the gm2 testsuite:
[PATCH] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test
<https://inbox.sourceware.org/gcc-patches/874jhp3nwf.fsf@oldenburg.str.redhat.com/>
Thanks,
Florian
Florian Weimer (6):
c-family: Introduce pedpermerror
c: Turn int-conversion warnings into permerrors
c: Turn -Wimplicit-function-declaration into a pedpermerror
c: Turn -Wimplicit-int into a pedpermerror
c: Turn -Wreturn-mismatch into a pedpermerror
c: Turn -Wincompatible-pointer-types into a pedpermerror
gcc/c-family/c-common.h | 4 +
gcc/c-family/c-warn.cc | 34 ++++
gcc/c/c-decl.cc | 40 ++--
gcc/c/c-typeck.cc | 164 +++++++++------
gcc/diagnostic-core.h | 3 +
gcc/diagnostic.cc | 7 +
gcc/doc/invoke.texi | 33 +++-
gcc/testsuite/c-c++-common/pr77624-1.c | 4 +-
.../c-c++-common/spellcheck-reserved.c | 4 +-
gcc/testsuite/gcc.dg/20030906-1.c | 2 +-
gcc/testsuite/gcc.dg/20030906-1a.c | 21 ++
gcc/testsuite/gcc.dg/20030906-2.c | 2 +-
gcc/testsuite/gcc.dg/20030906-2a.c | 21 ++
.../Wimplicit-function-declaration-c99-2.c | 7 +
.../Wimplicit-function-declaration-c99.c | 2 +-
gcc/testsuite/gcc.dg/Wimplicit-int-1.c | 2 +-
gcc/testsuite/gcc.dg/Wimplicit-int-1a.c | 11 ++
gcc/testsuite/gcc.dg/Wimplicit-int-4.c | 2 +-
gcc/testsuite/gcc.dg/Wimplicit-int-4a.c | 11 ++
.../gcc.dg/Wincompatible-pointer-types-2.c | 2 +-
.../gcc.dg/Wincompatible-pointer-types-4.c | 2 +-
.../gcc.dg/Wincompatible-pointer-types-5.c | 10 +
.../gcc.dg/Wincompatible-pointer-types-6.c | 10 +
gcc/testsuite/gcc.dg/Wint-conversion-2.c | 2 +-
gcc/testsuite/gcc.dg/Wint-conversion-3.c | 2 +-
gcc/testsuite/gcc.dg/Wint-conversion-4.c | 14 ++
gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c | 2 +-
gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c | 40 ++++
gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c | 2 +-
gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c | 41 ++++
gcc/testsuite/gcc.dg/anon-struct-11.c | 5 +-
gcc/testsuite/gcc.dg/anon-struct-11a.c | 111 +++++++++++
gcc/testsuite/gcc.dg/anon-struct-13.c | 2 +-
gcc/testsuite/gcc.dg/anon-struct-13a.c | 76 +++++++
gcc/testsuite/gcc.dg/assign-warn-1.c | 2 +-
gcc/testsuite/gcc.dg/assign-warn-4.c | 21 ++
.../gcc.dg/builtin-arith-overflow-4.c | 2 +-
.../gcc.dg/builtin-arith-overflow-4a.c | 43 ++++
gcc/testsuite/gcc.dg/c23-qual-4.c | 6 +-
gcc/testsuite/gcc.dg/dfp/composite-type-2.c | 58 ++++++
gcc/testsuite/gcc.dg/dfp/composite-type.c | 2 +-
gcc/testsuite/gcc.dg/diag-aka-1.c | 2 +-
gcc/testsuite/gcc.dg/diag-aka-1a.c | 29 +++
.../gcc.dg/diagnostic-range-bad-return-2.c | 52 +++++
.../gcc.dg/diagnostic-range-bad-return.c | 2 +-
gcc/testsuite/gcc.dg/diagnostic-types-1.c | 2 +-
gcc/testsuite/gcc.dg/diagnostic-types-2.c | 24 +++
gcc/testsuite/gcc.dg/enum-compat-1.c | 2 +-
gcc/testsuite/gcc.dg/enum-compat-2.c | 32 +++
gcc/testsuite/gcc.dg/func-ptr-conv-1.c | 2 +-
gcc/testsuite/gcc.dg/func-ptr-conv-2.c | 56 ++++++
gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c | 2 +-
gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c | 17 ++
gcc/testsuite/gcc.dg/gomp/pr35738-2.c | 18 ++
gcc/testsuite/gcc.dg/gomp/pr35738.c | 2 +-
gcc/testsuite/gcc.dg/init-bad-7.c | 2 +-
gcc/testsuite/gcc.dg/init-bad-7a.c | 12 ++
gcc/testsuite/gcc.dg/init-excess-3.c | 4 +-
gcc/testsuite/gcc.dg/missing-header-fixit-1.c | 2 +-
.../gcc.dg/missing-header-fixit-1a.c | 37 ++++
gcc/testsuite/gcc.dg/missing-header-fixit-2.c | 2 +-
.../gcc.dg/missing-header-fixit-2a.c | 31 +++
gcc/testsuite/gcc.dg/missing-header-fixit-4.c | 2 +-
.../gcc.dg/missing-header-fixit-4a.c | 27 +++
gcc/testsuite/gcc.dg/missing-header-fixit-5.c | 2 +-
.../gcc.dg/missing-header-fixit-5a.c | 42 ++++
.../gcc.dg/noncompile/incomplete-3.c | 2 +-
gcc/testsuite/gcc.dg/noncompile/pr79758-2.c | 6 +
gcc/testsuite/gcc.dg/noncompile/pr79758.c | 1 +
gcc/testsuite/gcc.dg/overflow-warn-1.c | 4 +-
gcc/testsuite/gcc.dg/overflow-warn-3.c | 4 +-
gcc/testsuite/gcc.dg/param-type-mismatch-2.c | 187 ++++++++++++++++++
gcc/testsuite/gcc.dg/param-type-mismatch.c | 2 +-
gcc/testsuite/gcc.dg/pointer-array-atomic-2.c | 60 ++++++
gcc/testsuite/gcc.dg/pointer-array-atomic.c | 2 +-
gcc/testsuite/gcc.dg/pointer-array-quals-1.c | 6 +-
gcc/testsuite/gcc.dg/pr105635-2.c | 11 ++
gcc/testsuite/gcc.dg/pr105635.c | 2 +-
gcc/testsuite/gcc.dg/pr23075-2.c | 14 ++
gcc/testsuite/gcc.dg/pr23075.c | 2 +-
gcc/testsuite/gcc.dg/pr29521-a.c | 15 ++
gcc/testsuite/gcc.dg/pr29521.c | 2 +-
gcc/testsuite/gcc.dg/pr61162-2.c | 2 +-
gcc/testsuite/gcc.dg/pr61162-3.c | 13 ++
gcc/testsuite/gcc.dg/pr61852.c | 4 +-
gcc/testsuite/gcc.dg/pr67730-a.c | 11 ++
gcc/testsuite/gcc.dg/pr67730.c | 2 +-
gcc/testsuite/gcc.dg/spec-barrier-3.c | 2 +-
gcc/testsuite/gcc.dg/spec-barrier-3a.c | 13 ++
.../gcc.dg/spellcheck-identifiers-1a.c | 136 +++++++++++++
.../gcc.dg/spellcheck-identifiers-2.c | 2 +-
.../gcc.dg/spellcheck-identifiers-2a.c | 33 ++++
.../gcc.dg/spellcheck-identifiers-3.c | 2 +-
.../gcc.dg/spellcheck-identifiers-3a.c | 45 +++++
.../gcc.dg/spellcheck-identifiers-4.c | 2 +-
.../gcc.dg/spellcheck-identifiers-4a.c | 10 +
gcc/testsuite/gcc.dg/spellcheck-identifiers.c | 2 +-
gcc/testsuite/gcc.dg/transparent-union-1.c | 2 +-
gcc/testsuite/gcc.dg/transparent-union-1a.c | 85 ++++++++
.../gcc.target/aarch64/acle/memtag_2.c | 4 +-
.../gcc.target/aarch64/acle/memtag_2a.c | 71 +++++++
.../sve/acle/general-c/ld1sh_gather_1.c | 2 +-
.../aarch64/sve/acle/general-c/load_2.c | 4 +-
.../aarch64/sve/acle/general-c/load_3.c | 2 +-
.../acle/general-c/load_ext_gather_index_1.c | 2 +-
.../load_ext_gather_index_restricted_1.c | 2 +-
.../acle/general-c/load_ext_gather_offset_1.c | 4 +-
.../acle/general-c/load_ext_gather_offset_2.c | 4 +-
.../acle/general-c/load_ext_gather_offset_3.c | 4 +-
.../acle/general-c/load_ext_gather_offset_4.c | 4 +-
.../acle/general-c/load_ext_gather_offset_5.c | 4 +-
.../load_ext_gather_offset_restricted_1.c | 4 +-
.../load_ext_gather_offset_restricted_2.c | 4 +-
.../load_ext_gather_offset_restricted_3.c | 4 +-
.../load_ext_gather_offset_restricted_4.c | 4 +-
.../aarch64/sve/acle/general-c/sizeless-1.c | 8 +-
.../aarch64/sve/acle/general-c/sizeless-2.c | 8 +-
.../aarch64/sve/acle/general-c/store_1.c | 8 +-
.../aarch64/sve/acle/general-c/store_2.c | 10 +-
.../acle/general-c/store_scatter_index_1.c | 8 +-
.../store_scatter_index_restricted_1.c | 8 +-
.../acle/general-c/store_scatter_offset_2.c | 8 +-
.../store_scatter_offset_restricted_1.c | 8 +-
.../aarch64/sve/acle/general/attributes_7.c | 28 +--
.../i386/sse2-bfloat16-scalar-typecheck.c | 4 +-
.../i386/vect-bfloat16-typecheck_1.c | 4 +-
.../i386/vect-bfloat16-typecheck_2.c | 4 +-
.../gcc.target/powerpc/conditional-return.c | 2 +-
128 files changed, 1920 insertions(+), 231 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/20030906-1a.c
create mode 100644 gcc/testsuite/gcc.dg/20030906-2a.c
create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c
create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-1a.c
create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-4a.c
create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c
create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-6.c
create mode 100644 gcc/testsuite/gcc.dg/Wint-conversion-4.c
create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c
create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c
create mode 100644 gcc/testsuite/gcc.dg/anon-struct-11a.c
create mode 100644 gcc/testsuite/gcc.dg/anon-struct-13a.c
create mode 100644 gcc/testsuite/gcc.dg/assign-warn-4.c
create mode 100644 gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c
create mode 100644 gcc/testsuite/gcc.dg/dfp/composite-type-2.c
create mode 100644 gcc/testsuite/gcc.dg/diag-aka-1a.c
create mode 100644 gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c
create mode 100644 gcc/testsuite/gcc.dg/diagnostic-types-2.c
create mode 100644 gcc/testsuite/gcc.dg/enum-compat-2.c
create mode 100644 gcc/testsuite/gcc.dg/func-ptr-conv-2.c
create mode 100644 gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c
create mode 100644 gcc/testsuite/gcc.dg/gomp/pr35738-2.c
create mode 100644 gcc/testsuite/gcc.dg/init-bad-7a.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-1a.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-2a.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-4a.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-5a.c
create mode 100644 gcc/testsuite/gcc.dg/noncompile/pr79758-2.c
create mode 100644 gcc/testsuite/gcc.dg/param-type-mismatch-2.c
create mode 100644 gcc/testsuite/gcc.dg/pointer-array-atomic-2.c
create mode 100644 gcc/testsuite/gcc.dg/pr105635-2.c
create mode 100644 gcc/testsuite/gcc.dg/pr23075-2.c
create mode 100644 gcc/testsuite/gcc.dg/pr29521-a.c
create mode 100644 gcc/testsuite/gcc.dg/pr61162-3.c
create mode 100644 gcc/testsuite/gcc.dg/pr67730-a.c
create mode 100644 gcc/testsuite/gcc.dg/spec-barrier-3a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c
create mode 100644 gcc/testsuite/gcc.dg/transparent-union-1a.c
create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
base-commit: b51bfee1beed03872ea0289cb47dd2336d9f528c
prerequisite-patch-id: f46d6a56470ab459865ba2e45372d60e131b9ee2
prerequisite-patch-id: 7e0b407ec2bbd5e3b9c7ed1342b08d3677a65283
prerequisite-patch-id: 02e95117add6ada9d5cdb489399fb2e562db76e2
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 1/6] c-family: Introduce pedpermerror
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
@ 2023-11-13 13:09 ` Florian Weimer
2023-11-13 19:22 ` Jeff Law
2023-11-14 7:39 ` Florian Weimer
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
` (5 subsequent siblings)
6 siblings, 2 replies; 29+ messages in thread
From: Florian Weimer @ 2023-11-13 13:09 UTC (permalink / raw)
To: gcc-patches
It turns out that permerror_opt is not directly usable for
-fpermissive in the C front end. The front end uses pedwarn
extensively, and pedwarns are not overridable by -Wno-* options,
yet permerrors are. Add new pedpermerror helpers that turn into
pedwarns if -pedantic-errors is active.
Due to the dependency on flag_pedantic_errors, the new helpers
are specific to the C-family front ends. For implementing the
rich location variant, export emit_diagnostic_valist from
gcc/diagnostic.cc in parallel to its location_t variant.
gcc/
* diagnostic-core.h (emit_diagnostic_valist): Declare function.
* diagnostic.cc (emit_diagnostic_valist): Define it.
gcc/c-family/
* c-common.h (pedpermerror): Declare functions.
* c-warn.cc (pedpermerror): Define them.
---
gcc/c-family/c-common.h | 4 ++++
gcc/c-family/c-warn.cc | 34 ++++++++++++++++++++++++++++++++++
gcc/diagnostic-core.h | 3 +++
gcc/diagnostic.cc | 7 +++++++
4 files changed, 48 insertions(+)
diff --git a/gcc/c-family/c-common.h b/gcc/c-family/c-common.h
index b57e83d7c5d..789e0bf2459 100644
--- a/gcc/c-family/c-common.h
+++ b/gcc/c-family/c-common.h
@@ -1486,6 +1486,10 @@ extern void warn_for_address_or_pointer_of_packed_member (tree, tree);
extern void warn_parm_array_mismatch (location_t, tree, tree);
extern void maybe_warn_sizeof_array_div (location_t, tree, tree, tree, tree);
extern void do_warn_array_compare (location_t, tree_code, tree, tree);
+extern bool pedpermerror (location_t, int, const char *,
+ ...) ATTRIBUTE_GCC_DIAG(3,4);
+extern bool pedpermerror (rich_location *, int, const char *,
+ ...) ATTRIBUTE_GCC_DIAG(3,4);
/* Places where an lvalue, or modifiable lvalue, may be required.
Used to select diagnostic messages in lvalue_error and
diff --git a/gcc/c-family/c-warn.cc b/gcc/c-family/c-warn.cc
index b1bd8ba9f42..475a3e4b42e 100644
--- a/gcc/c-family/c-warn.cc
+++ b/gcc/c-family/c-warn.cc
@@ -3932,3 +3932,37 @@ check_for_xor_used_as_pow (location_t lhs_loc, tree lhs_val,
lhs_uhwi, lhs_uhwi);
}
}
+
+/* If !flag_pedantic_errors, equivalent to permerror_opt, otherwise to
+ pedwarn. */
+
+bool
+pedpermerror (location_t location, int opt, const char *gmsgid, ...)
+{
+ auto_diagnostic_group d;
+ va_list ap;
+ va_start (ap, gmsgid);
+ rich_location richloc (line_table, location);
+ bool ret = emit_diagnostic_valist (flag_pedantic_errors
+ ? DK_PEDWARN : DK_PERMERROR,
+ location, opt, gmsgid, &ap);
+ va_end (ap);
+ return ret;
+}
+
+/* Same as "pedpermerror" above, but at RICHLOC. */
+
+bool
+pedpermerror (rich_location *richloc, int opt, const char *gmsgid, ...)
+{
+ gcc_assert (richloc);
+
+ auto_diagnostic_group d;
+ va_list ap;
+ va_start (ap, gmsgid);
+ bool ret = emit_diagnostic_valist (flag_pedantic_errors
+ ? DK_PEDWARN : DK_PERMERROR,
+ richloc, opt, gmsgid, &ap);
+ va_end (ap);
+ return ret;
+}
diff --git a/gcc/diagnostic-core.h b/gcc/diagnostic-core.h
index 04eba3d140e..eac775fb573 100644
--- a/gcc/diagnostic-core.h
+++ b/gcc/diagnostic-core.h
@@ -121,6 +121,9 @@ extern bool emit_diagnostic (diagnostic_t, location_t, int,
const char *, ...) ATTRIBUTE_GCC_DIAG(4,5);
extern bool emit_diagnostic (diagnostic_t, rich_location *, int,
const char *, ...) ATTRIBUTE_GCC_DIAG(4,5);
+extern bool emit_diagnostic_valist (diagnostic_t, rich_location *, int,
+ const char *,
+ va_list *) ATTRIBUTE_GCC_DIAG (4,0);
extern bool emit_diagnostic_valist (diagnostic_t, location_t, int, const char *,
va_list *) ATTRIBUTE_GCC_DIAG (4,0);
extern bool seen_error (void);
diff --git a/gcc/diagnostic.cc b/gcc/diagnostic.cc
index addd6606eaa..6e73343dbdb 100644
--- a/gcc/diagnostic.cc
+++ b/gcc/diagnostic.cc
@@ -1829,6 +1829,13 @@ emit_diagnostic_valist (diagnostic_t kind, location_t location, int opt,
return diagnostic_impl (&richloc, NULL, opt, gmsgid, ap, kind);
}
+bool
+emit_diagnostic_valist (diagnostic_t kind, rich_location *richloc, int opt,
+ const char *gmsgid, va_list *ap)
+{
+ return diagnostic_impl (richloc, NULL, opt, gmsgid, ap, kind);
+}
+
/* An informative note at LOCATION. Use this for additional details on an error
message. */
void
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
2023-11-13 13:09 ` [PATCH 1/6] c-family: Introduce pedpermerror Florian Weimer
@ 2023-11-13 13:10 ` Florian Weimer
2023-11-13 19:24 ` Jeff Law
` (2 more replies)
2023-11-13 13:10 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror Florian Weimer
` (4 subsequent siblings)
6 siblings, 3 replies; 29+ messages in thread
From: Florian Weimer @ 2023-11-13 13:10 UTC (permalink / raw)
To: gcc-patches
gcc/
* doc/invoke.texi (Warning Options): Document changes.
gcc/c/
* c-typeck.cc (build_conditional_expr): Use pedpermerror for
pointer/integer type mismatches, based on -Wint-conversion.
(pedwarn_pedpermerror_init, permerror_init): New function.
(pedwarn_init): Call pedwarn_pedpermerror_init.
(convert_for_assignment): Use pedpermerror and
pedpermerror_init for -Wint-conversion warnings.
gcc/testsuite/
* c-c++-common/pr77624-1.c (foo, bar): Expect
error instead of warning.
* gcc.dg/Wint-conversion-2.c: Compile with -fpermissive due
to expected int-conversion warning.
* gcc.dg/Wint-conversion-3.c: Likewise.
* gcc.dg/Wint-conversion-4.c: New test. Based on
gcc.dg/Wint-conversion-3.c. Expect int-conversion errors.
* gcc.dg/assign-warn-1.c: Compile with -fpermissive.
* gcc.dg/assign-warn-4.c: New file. Extracted from
assign-warn1.c. Expect int-cnversion errors.
* gcc.dg/diagnostic-types-1.c: compile with -fpermissive.
* gcc.dg/diagnostic-types-2.c: New file. Extracted from
gcc.dg/diagnostic-types-1.c. Expect some errors instead of
warnings.
* gcc.dg/gomp/pr35738.c: Compile with -fpermissive due to
expected int-conversion error.
* gcc.dg/gomp/pr35738-2.c: New test. Based on
gcc.dg/gomp/pr35738.c. Expect int-converison errors.
* gcc.dg/init-excess-3.c: Expect int-converison errors.
* gcc.dg/overflow-warn-1.c: Likewise.
* gcc.dg/overflow-warn-3.c: Likewise.
* gcc.dg/param-type-mismatch.c: Compile with -fpermissive.
* gcc.dg/param-type-mismatch-2.c: New test. Copied from
gcc.dg/param-type-mismatch.c. Expect errors.
* gcc.dg/pr61162-2.c: Compile with -fpermissive.
* gcc.dg/pr61162-3.c: New test. Extracted from
gcc.dg/pr61162-2.c. Expect int-conversion errors.
* gcc.dg/spec-barrier-3.c: Use -fpermissive due to expected
int-conversion error.
* gcc.dg/spec-barrier-3a.c: New test. Based on
gcc.dg/spec-barrier-3.c. Expect int-conversion errors.
* gcc.target/aarch64/acle/memtag_2.c: Use -fpermissive due to expected
int-conversion error.
* gcc.target/aarch64/acle/memtag_2a.c: New test. Copied from
gcc.target/aarch64/acle/memtag_2.c. Expect error.
* gcc.target/aarch64/sve/acle/general-c/load_3.c (f1): Expect
error.
* gcc.target/aarch64/sve/acle/general-c/store_2.c (f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
(f1): Likewise.
---
gcc/c/c-typeck.cc | 98 +++++----
gcc/doc/invoke.texi | 6 +
gcc/testsuite/c-c++-common/pr77624-1.c | 4 +-
gcc/testsuite/gcc.dg/Wint-conversion-2.c | 2 +-
gcc/testsuite/gcc.dg/Wint-conversion-3.c | 2 +-
gcc/testsuite/gcc.dg/Wint-conversion-4.c | 14 ++
gcc/testsuite/gcc.dg/assign-warn-1.c | 2 +-
gcc/testsuite/gcc.dg/assign-warn-4.c | 21 ++
gcc/testsuite/gcc.dg/diagnostic-types-1.c | 2 +-
gcc/testsuite/gcc.dg/diagnostic-types-2.c | 24 +++
gcc/testsuite/gcc.dg/gomp/pr35738-2.c | 18 ++
gcc/testsuite/gcc.dg/gomp/pr35738.c | 2 +-
gcc/testsuite/gcc.dg/init-excess-3.c | 4 +-
gcc/testsuite/gcc.dg/overflow-warn-1.c | 4 +-
gcc/testsuite/gcc.dg/overflow-warn-3.c | 4 +-
gcc/testsuite/gcc.dg/param-type-mismatch-2.c | 187 ++++++++++++++++++
gcc/testsuite/gcc.dg/param-type-mismatch.c | 2 +-
gcc/testsuite/gcc.dg/pr61162-2.c | 2 +-
gcc/testsuite/gcc.dg/pr61162-3.c | 13 ++
gcc/testsuite/gcc.dg/spec-barrier-3.c | 2 +-
gcc/testsuite/gcc.dg/spec-barrier-3a.c | 13 ++
.../gcc.target/aarch64/acle/memtag_2.c | 4 +-
.../gcc.target/aarch64/acle/memtag_2a.c | 71 +++++++
.../aarch64/sve/acle/general-c/load_3.c | 2 +-
.../aarch64/sve/acle/general-c/store_2.c | 2 +-
.../acle/general-c/store_scatter_index_1.c | 2 +-
.../store_scatter_index_restricted_1.c | 2 +-
.../acle/general-c/store_scatter_offset_2.c | 2 +-
.../store_scatter_offset_restricted_1.c | 2 +-
29 files changed, 452 insertions(+), 61 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/Wint-conversion-4.c
create mode 100644 gcc/testsuite/gcc.dg/assign-warn-4.c
create mode 100644 gcc/testsuite/gcc.dg/diagnostic-types-2.c
create mode 100644 gcc/testsuite/gcc.dg/gomp/pr35738-2.c
create mode 100644 gcc/testsuite/gcc.dg/param-type-mismatch-2.c
create mode 100644 gcc/testsuite/gcc.dg/pr61162-3.c
create mode 100644 gcc/testsuite/gcc.dg/spec-barrier-3a.c
create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc
index 366ca88c633..9d7bdbb4523 100644
--- a/gcc/c/c-typeck.cc
+++ b/gcc/c/c-typeck.cc
@@ -5436,8 +5436,9 @@ build_conditional_expr (location_t colon_loc, tree ifexp, bool ifexp_bcp,
&& (code2 == INTEGER_TYPE || code2 == BITINT_TYPE))
{
if (!null_pointer_constant_p (orig_op2))
- pedwarn (colon_loc, OPT_Wint_conversion,
- "pointer/integer type mismatch in conditional expression");
+ pedpermerror (colon_loc, OPT_Wint_conversion,
+ "pointer/integer type mismatch "
+ "in conditional expression");
else
{
op2 = null_pointer_node;
@@ -5448,8 +5449,9 @@ build_conditional_expr (location_t colon_loc, tree ifexp, bool ifexp_bcp,
&& (code1 == INTEGER_TYPE || code1 == BITINT_TYPE))
{
if (!null_pointer_constant_p (orig_op1))
- pedwarn (colon_loc, OPT_Wint_conversion,
- "pointer/integer type mismatch in conditional expression");
+ pedpermerror (colon_loc, OPT_Wint_conversion,
+ "pointer/integer type mismatch "
+ "in conditional expression");
else
{
op1 = null_pointer_node;
@@ -6545,28 +6547,49 @@ error_init (location_t loc, const char *gmsgid, ...)
inform (loc, "(near initialization for %qs)", ofwhat);
}
-/* Issue a pedantic warning for a bad initializer component. OPT is
- the option OPT_* (from options.h) controlling this warning or 0 if
- it is unconditionally given. GMSGID identifies the message. The
- component name is taken from the spelling stack. */
+/* Used to implement pedwarn_init and permerror_init. */
static void ATTRIBUTE_GCC_DIAG (3,0)
-pedwarn_init (location_t loc, int opt, const char *gmsgid, ...)
+pedwarn_pedpermerror_init (location_t loc, int opt, const char *gmsgid,
+ va_list *ap, diagnostic_t kind)
{
/* Use the location where a macro was expanded rather than where
it was defined to make sure macros defined in system headers
but used incorrectly elsewhere are diagnosed. */
location_t exploc = expansion_point_location_if_in_system_header (loc);
auto_diagnostic_group d;
- va_list ap;
- va_start (ap, gmsgid);
- bool warned = emit_diagnostic_valist (DK_PEDWARN, exploc, opt, gmsgid, &ap);
- va_end (ap);
+ bool warned = emit_diagnostic_valist (kind, exploc, opt, gmsgid, ap);
char *ofwhat = print_spelling ((char *) alloca (spelling_length () + 1));
if (*ofwhat && warned)
inform (exploc, "(near initialization for %qs)", ofwhat);
}
+/* Issue a pedantic warning for a bad initializer component. OPT is
+ the option OPT_* (from options.h) controlling this warning or 0 if
+ it is unconditionally given. GMSGID identifies the message. The
+ component name is taken from the spelling stack. */
+
+static void ATTRIBUTE_GCC_DIAG (3,0)
+pedwarn_init (location_t loc, int opt, const char *gmsgid, ...)
+{
+ va_list ap;
+ va_start (ap, gmsgid);
+ pedwarn_pedpermerror_init (loc, opt, gmsgid, &ap, DK_PEDWARN);
+ va_end (ap);
+}
+
+/* Like pedwarn_init, but issue a permerror. */
+
+static void ATTRIBUTE_GCC_DIAG (3,0)
+pedpermerror_init (location_t loc, int opt, const char *gmsgid, ...)
+{
+ va_list ap;
+ va_start (ap, gmsgid);
+ pedwarn_pedpermerror_init (loc, opt, gmsgid, &ap,
+ flag_pedantic_errors ? DK_PEDWARN : DK_PERMERROR);
+ va_end (ap);
+}
+
/* Issue a warning for a bad initializer component.
OPT is the OPT_W* value corresponding to the warning option that
@@ -7616,27 +7639,28 @@ convert_for_assignment (location_t location, location_t expr_loc, tree type,
auto_diagnostic_group d;
range_label_for_type_mismatch rhs_label (rhstype, type);
gcc_rich_location richloc (expr_loc, &rhs_label);
- if (pedwarn (&richloc, OPT_Wint_conversion,
- "passing argument %d of %qE makes pointer from "
- "integer without a cast", parmnum, rname))
+ if (pedpermerror (&richloc, OPT_Wint_conversion,
+ "passing argument %d of %qE makes pointer "
+ "from integer without a cast", parmnum, rname))
inform_for_arg (fundecl, expr_loc, parmnum, type, rhstype);
}
break;
case ic_assign:
- pedwarn (location, OPT_Wint_conversion,
- "assignment to %qT from %qT makes pointer from integer "
- "without a cast", type, rhstype);
+ pedpermerror (location, OPT_Wint_conversion,
+ "assignment to %qT from %qT makes pointer from "
+ "integer without a cast", type, rhstype);
break;
case ic_init:
case ic_init_const:
- pedwarn_init (location, OPT_Wint_conversion,
- "initialization of %qT from %qT makes pointer from "
- "integer without a cast", type, rhstype);
+ pedpermerror_init (location, OPT_Wint_conversion,
+ "initialization of %qT from %qT makes pointer "
+ "from integer without a cast", type, rhstype);
break;
case ic_return:
- pedwarn (location, OPT_Wint_conversion, "returning %qT from a "
- "function with return type %qT makes pointer from "
- "integer without a cast", rhstype, type);
+ pedpermerror_init (location, OPT_Wint_conversion,
+ "returning %qT from a function with return type "
+ "%qT makes pointer from integer without a cast",
+ rhstype, type);
break;
default:
gcc_unreachable ();
@@ -7654,27 +7678,27 @@ convert_for_assignment (location_t location, location_t expr_loc, tree type,
auto_diagnostic_group d;
range_label_for_type_mismatch rhs_label (rhstype, type);
gcc_rich_location richloc (expr_loc, &rhs_label);
- if (pedwarn (&richloc, OPT_Wint_conversion,
- "passing argument %d of %qE makes integer from "
- "pointer without a cast", parmnum, rname))
+ if (pedpermerror (&richloc, OPT_Wint_conversion,
+ "passing argument %d of %qE makes integer from "
+ "pointer without a cast", parmnum, rname))
inform_for_arg (fundecl, expr_loc, parmnum, type, rhstype);
}
break;
case ic_assign:
- pedwarn (location, OPT_Wint_conversion,
- "assignment to %qT from %qT makes integer from pointer "
- "without a cast", type, rhstype);
+ pedpermerror (location, OPT_Wint_conversion,
+ "assignment to %qT from %qT makes integer from "
+ "pointer without a cast", type, rhstype);
break;
case ic_init:
case ic_init_const:
- pedwarn_init (location, OPT_Wint_conversion,
- "initialization of %qT from %qT makes integer from "
- "pointer without a cast", type, rhstype);
+ pedpermerror_init (location, OPT_Wint_conversion,
+ "initialization of %qT from %qT makes integer "
+ "from pointer without a cast", type, rhstype);
break;
case ic_return:
- pedwarn (location, OPT_Wint_conversion, "returning %qT from a "
- "function with return type %qT makes integer from "
- "pointer without a cast", rhstype, type);
+ pedpermerror (location, OPT_Wint_conversion, "returning %qT from a "
+ "function with return type %qT makes integer from "
+ "pointer without a cast", rhstype, type);
break;
default:
gcc_unreachable ();
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index f1a5722675f..b9fafe0fd34 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -6179,6 +6179,7 @@ only by this flag, but it also downgrades some C and C++ diagnostics
that have their own flag:
@gccoptlist{
+-Wint-conversion @r{(C)}
-Wnarrowing @r{(C++)}
}
@@ -8545,6 +8546,11 @@ conversions. This warning is about implicit conversions; for explicit
conversions the warnings @option{-Wno-int-to-pointer-cast} and
@option{-Wno-pointer-to-int-cast} may be used.
+By default, in C99 and later dialects of C, GCC treats this issue as an
+error. The error can be downgraded to a warning using
+@option{-fpermissive} (along with certain other errors), or for this
+error alone, with @option{-Wno-error=int-conversion}.
+
This warning is upgraded to an error by @option{-pedantic-errors}.
@opindex Wzero-length-bounds
diff --git a/gcc/testsuite/c-c++-common/pr77624-1.c b/gcc/testsuite/c-c++-common/pr77624-1.c
index 3567e9b866f..e25469ee2c1 100644
--- a/gcc/testsuite/c-c++-common/pr77624-1.c
+++ b/gcc/testsuite/c-c++-common/pr77624-1.c
@@ -4,11 +4,11 @@
int
foo (int a)
{
- return __atomic_is_lock_free (2, a); /* { dg-warning "pointer from integer" "" { target c } } */
+ return __atomic_is_lock_free (2, a); /* { dg-error "pointer from integer" "" { target c } } */
} /* { dg-error "invalid conversion" "" { target c++ } .-1 } */
int
bar (int a)
{
- return __atomic_always_lock_free (2, a); /* { dg-warning "pointer from integer" "" { target c } } */
+ return __atomic_always_lock_free (2, a); /* { dg-error "pointer from integer" "" { target c } } */
} /* { dg-error "invalid conversion" "" { target c++ } .-1 } */
diff --git a/gcc/testsuite/gcc.dg/Wint-conversion-2.c b/gcc/testsuite/gcc.dg/Wint-conversion-2.c
index bf590a7bcd7..101e792e5b6 100644
--- a/gcc/testsuite/gcc.dg/Wint-conversion-2.c
+++ b/gcc/testsuite/gcc.dg/Wint-conversion-2.c
@@ -1,7 +1,7 @@
/* PR middle-end/86202 - ICE in get_range_info calling an invalid memcpy()
declaration */
/* { dg-do compile } */
-/* { dg-options "-Wint-conversion" } */
+/* { dg-options "-fpermissive -Wint-conversion" } */
void *memcpy (void *, void *, __SIZE_TYPE__ *); /* { dg-warning "conflicting types for built-in function .memcpy." } */
void *a, *b;
diff --git a/gcc/testsuite/gcc.dg/Wint-conversion-3.c b/gcc/testsuite/gcc.dg/Wint-conversion-3.c
index 4e514769c01..4614c015db4 100644
--- a/gcc/testsuite/gcc.dg/Wint-conversion-3.c
+++ b/gcc/testsuite/gcc.dg/Wint-conversion-3.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
const char *
f1 (int flag)
diff --git a/gcc/testsuite/gcc.dg/Wint-conversion-4.c b/gcc/testsuite/gcc.dg/Wint-conversion-4.c
new file mode 100644
index 00000000000..6ded61aed9c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wint-conversion-4.c
@@ -0,0 +1,14 @@
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+const char *
+f1 (int flag)
+{
+ return flag ? "" : 1; /* { dg-error "pointer/integer type mismatch in conditional expression \\\[-Wint-conversion\\\]" } */
+}
+
+const char *
+f2 (int flag)
+{
+ return flag ? 1 : ""; /* { dg-error "pointer/integer type mismatch in conditional expression \\\[-Wint-conversion\\\]" } */
+}
diff --git a/gcc/testsuite/gcc.dg/assign-warn-1.c b/gcc/testsuite/gcc.dg/assign-warn-1.c
index 365025724c4..c483276a913 100644
--- a/gcc/testsuite/gcc.dg/assign-warn-1.c
+++ b/gcc/testsuite/gcc.dg/assign-warn-1.c
@@ -1,7 +1,7 @@
/* Test diagnostics for bad implicit type conversions. */
/* Origin: Joseph Myers <jsm@polyomino.org.uk> */
/* { dg-do compile } */
-/* { dg-options "-pedantic -ftrack-macro-expansion=0" } */
+/* { dg-options "-pedantic -fpermissive -ftrack-macro-expansion=0" } */
#define TESTARG(ID, TL, TR) void ID##F(TL); void ID##F2(TR x) { ID##F(x); } extern int dummy
#define TESTARP(ID, TL, TR) struct { void (*x)(TL); } ID##Fp; void ID##F2(TR x) { ID##Fp.x(x); } extern int dummy
diff --git a/gcc/testsuite/gcc.dg/assign-warn-4.c b/gcc/testsuite/gcc.dg/assign-warn-4.c
new file mode 100644
index 00000000000..da834f7d29d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/assign-warn-4.c
@@ -0,0 +1,21 @@
+/* Test diagnostics for bad implicit type conversions. Error variant. */
+/* { dg-do compile } */
+/* { dg-options "-ftrack-macro-expansion=0" } */
+
+#define TESTARG(ID, TL, TR) void ID##F(TL); void ID##F2(TR x) { ID##F(x); } extern int dummy
+#define TESTARP(ID, TL, TR) struct { void (*x)(TL); } ID##Fp; void ID##F2(TR x) { ID##Fp.x(x); } extern int dummy
+#define TESTASS(ID, TL, TR) void ID##F(TR x) { TL y; y = x; } extern int dummy
+#define TESTINI(ID, TL, TR) void ID##F(TR x) { TL y = x; } extern int dummy
+#define TESTRET(ID, TL, TR) TR ID##V; TL ID##F(void) { return ID##V; } extern int dummy
+
+TESTARG(ciia, char *, int); /* { dg-error "passing argument 1 of 'ciiaF' makes pointer from integer without a cast" } */
+TESTARP(ciib, char *, int); /* { dg-error "passing argument 1 of 'ciibFp.x' makes pointer from integer without a cast" } */
+TESTASS(ciic, char *, int); /* { dg-error "assignment to 'char \\*' from 'int' makes pointer from integer without a cast" } */
+TESTINI(ciid, char *, int); /* { dg-error "initialization of 'char \\*' from 'int' makes pointer from integer without a cast" } */
+TESTRET(ciie, char *, int); /* { dg-error "returning 'int' from a function with return type 'char \\*' makes pointer from integer without a cast" } */
+
+TESTARG(iica, int, char *); /* { dg-error "passing argument 1 of 'iicaF' makes integer from pointer without a cast" } */
+TESTARP(iicb, int, char *); /* { dg-error "passing argument 1 of 'iicbFp.x' makes integer from pointer without a cast" } */
+TESTASS(iicc, int, char *); /* { dg-error "assignment to 'int' from 'char \\*' makes integer from pointer without a cast" } */
+TESTINI(iicd, int, char *); /* { dg-error "initialization of 'int' from 'char \\*' makes integer from pointer without a cast" } */
+TESTRET(iice, int, char *); /* { dg-error "returning 'char \\*' from a function with return type 'int' makes integer from pointer without a cast" } */
diff --git a/gcc/testsuite/gcc.dg/diagnostic-types-1.c b/gcc/testsuite/gcc.dg/diagnostic-types-1.c
index fc4b104df05..94b67c6ae8d 100644
--- a/gcc/testsuite/gcc.dg/diagnostic-types-1.c
+++ b/gcc/testsuite/gcc.dg/diagnostic-types-1.c
@@ -1,6 +1,6 @@
/* PR c/81233 */
/* { dg-do compile } */
-/* { dg-options "-Wc++-compat -Wpedantic" } */
+/* { dg-options "-fpermissive -Wc++-compat -Wpedantic" } */
/* Test we're printing the types, like the good compiler we are. */
enum E1 { A } e;
diff --git a/gcc/testsuite/gcc.dg/diagnostic-types-2.c b/gcc/testsuite/gcc.dg/diagnostic-types-2.c
new file mode 100644
index 00000000000..e6d284d2c5f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/diagnostic-types-2.c
@@ -0,0 +1,24 @@
+/* { dg-do compile } */
+/* { dg-options "-Wpedantic" } */
+/* Test we're printing the types, like the good compiler we are. */
+
+extern void foo2 (int *); /* { dg-message "expected 'int \\*' but argument is of type 'int'" } */
+extern void foo3 (int); /* { dg-message "expected 'int' but argument is of type 'int \\*'" } */
+
+int *
+fn1 (int *p)
+{
+ p = 1; /* { dg-error "assignment to 'int \\*' from 'int' makes pointer from integer without a cast" } */
+ int *q = 1; /* { dg-error "initialization of 'int \\*' from 'int' makes pointer from integer without a cast" } */
+ foo2 (1); /* { dg-error "passing argument 1 of 'foo2' makes pointer from integer without a cast" } */
+ return 1; /* { dg-error "returning 'int' from a function with return type 'int \\*' makes pointer from integer without a cast" } */
+}
+
+int
+fn2 (int i, int *p)
+{
+ i = p; /* { dg-error "assignment to 'int' from 'int \\*' makes integer from pointer without a cast" } */
+ int j = p; /* { dg-error "initialization of 'int' from 'int \\*' makes integer from pointer without a cast" } */
+ foo3 (p); /* { dg-error "passing argument 1 of 'foo3' makes integer from pointer without a cast" } */
+ return p; /* { dg-error "returning 'int \\*' from a function with return type 'int' makes integer from pointer without a cast" } */
+}
diff --git a/gcc/testsuite/gcc.dg/gomp/pr35738-2.c b/gcc/testsuite/gcc.dg/gomp/pr35738-2.c
new file mode 100644
index 00000000000..846afe7e778
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/gomp/pr35738-2.c
@@ -0,0 +1,18 @@
+/* PR c/35738 */
+/* { dg-do compile } */
+/* { dg-options "-fopenmp" } */
+
+void foo (void);
+
+void
+bar (void *p)
+{
+ int i = 0;
+ char q[10];
+#pragma omp atomic
+ i += q; /* { dg-error "makes integer from pointer without a cast" } */
+#pragma omp atomic
+ i += foo; /* { dg-error "makes integer from pointer without a cast" } */
+#pragma omp atomic
+ i += p; /* { dg-error "makes integer from pointer without a cast" } */
+}
diff --git a/gcc/testsuite/gcc.dg/gomp/pr35738.c b/gcc/testsuite/gcc.dg/gomp/pr35738.c
index 0b3866eae3b..954cfa43ece 100644
--- a/gcc/testsuite/gcc.dg/gomp/pr35738.c
+++ b/gcc/testsuite/gcc.dg/gomp/pr35738.c
@@ -1,6 +1,6 @@
/* PR c/35738 */
/* { dg-do compile } */
-/* { dg-options "-fopenmp" } */
+/* { dg-options "-fpermissive -fopenmp" } */
void foo (void);
diff --git a/gcc/testsuite/gcc.dg/init-excess-3.c b/gcc/testsuite/gcc.dg/init-excess-3.c
index c03a98487b4..6ea7858a1c9 100644
--- a/gcc/testsuite/gcc.dg/init-excess-3.c
+++ b/gcc/testsuite/gcc.dg/init-excess-3.c
@@ -7,9 +7,9 @@
char s0[] = {"abc",1}; /* { dg-error "'char..' initializer|near init" } */
char s1[] = {"abc","a"}; /* { dg-error "'char..' initializer|near init" } */
char s2[] = {1,"abc"}; /* { dg-error "'char..' initializer|near init|computable at load time" } */
-/* { dg-warning "integer from pointer without a cast" "" { target *-*-* } .-1 } */
+/* { dg-error "integer from pointer without a cast" "" { target *-*-* } .-1 } */
char s3[5] = {"abc",1}; /* { dg-error "'char.5.' initializer|near init" } */
char s4[5] = {"abc","a"}; /* { dg-error "'char.5.' initializer|near init" } */
char s5[5] = {1,"abc"}; /* { dg-error "'char.5.' initializer|near init|computable at load time" } */
-/* { dg-warning "integer from pointer without a cast" "" { target *-*-* } .-1 } */
+/* { dg-error "integer from pointer without a cast" "" { target *-*-* } .-1 } */
diff --git a/gcc/testsuite/gcc.dg/overflow-warn-1.c b/gcc/testsuite/gcc.dg/overflow-warn-1.c
index a9d9fbae148..90eb43b35e2 100644
--- a/gcc/testsuite/gcc.dg/overflow-warn-1.c
+++ b/gcc/testsuite/gcc.dg/overflow-warn-1.c
@@ -47,10 +47,10 @@ static int sc = INT_MAX + 1; /* { dg-warning "25:integer overflow in expression"
constants. The third has the overflow in an unevaluated
subexpression, so is a null pointer constant. */
void *p = 0 * (INT_MAX + 1); /* { dg-warning "integer overflow in expression" } */
-/* { dg-warning "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-1 } */
+/* { dg-error "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-1 } */
void *q = 0 * (1 / 0); /* { dg-warning "division by zero" } */
/* { dg-error "initializer element is not constant" "constant" { target *-*-* } .-1 } */
-/* { dg-warning "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-2 } */
+/* { dg-error "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-2 } */
void *r = (1 ? 0 : INT_MAX+1);
void
diff --git a/gcc/testsuite/gcc.dg/overflow-warn-3.c b/gcc/testsuite/gcc.dg/overflow-warn-3.c
index f64047795c7..a2ead836964 100644
--- a/gcc/testsuite/gcc.dg/overflow-warn-3.c
+++ b/gcc/testsuite/gcc.dg/overflow-warn-3.c
@@ -53,10 +53,10 @@ static int sc = INT_MAX + 1; /* { dg-warning "integer overflow in expression" }
subexpression, so is a null pointer constant. */
void *p = 0 * (INT_MAX + 1); /* { dg-warning "integer overflow in expression" } */
/* { dg-warning "overflow in constant expression" "constant" { target *-*-* } .-1 } */
-/* { dg-warning "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-2 } */
+/* { dg-error "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-2 } */
void *q = 0 * (1 / 0); /* { dg-warning "division by zero" } */
/* { dg-error "initializer element is not constant" "constant" { target *-*-* } .-1 } */
-/* { dg-warning "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-2 } */
+/* { dg-error "initialization of 'void \\*' from 'int' makes pointer from integer without a cast" "null" { target *-*-* } .-2 } */
void *r = (1 ? 0 : INT_MAX+1);
void
diff --git a/gcc/testsuite/gcc.dg/param-type-mismatch-2.c b/gcc/testsuite/gcc.dg/param-type-mismatch-2.c
new file mode 100644
index 00000000000..91d998437d1
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/param-type-mismatch-2.c
@@ -0,0 +1,187 @@
+/* { dg-options "-fdiagnostics-show-caret -Wpointer-sign" } */
+
+/* A collection of calls where argument 2 is of the wrong type.
+ Like param-type-mismatch.c, but expecting errors. */
+
+/* decl, with argname. */
+
+extern int callee_1 (int one, const char *two, float three); /* { dg-line callee_1 } */
+
+int test_1 (int first, int second, float third)
+{
+ return callee_1 (first, second, third); /* { dg-error "passing argument 2 of 'callee_1' makes pointer from integer without a cast" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_1 (first, second, third);
+ ^~~~~~
+ |
+ int
+ { dg-end-multiline-output "" } */
+ /* { dg-message "expected 'const char \\*' but argument is of type 'int'" "" { target *-*-* } callee_1 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_1 (int one, const char *two, float three);
+ ~~~~~~~~~~~~^~~
+ { dg-end-multiline-output "" } */
+}
+
+/* decl, without argname. */
+
+extern int callee_2 (int, const char *, float); /* { dg-line callee_2 } */
+
+int test_2 (int first, int second, float third)
+{
+ return callee_2 (first, second, third); /* { dg-error "passing argument 2 of 'callee_2' makes pointer from integer without a cast" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_2 (first, second, third);
+ ^~~~~~
+ |
+ int
+ { dg-end-multiline-output "" } */
+ /* { dg-message "expected 'const char \\*' but argument is of type 'int'" "" { target *-*-* } callee_2 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_2 (int, const char *, float);
+ ^~~~~~~~~~~~
+ { dg-end-multiline-output "" } */
+}
+
+/* defn, with argname. */
+
+static int callee_3 (int one, const char *two, float three) /* { dg-line callee_3 } */
+{
+ return callee_2 (one, two, three);
+}
+
+int test_3 (int first, int second, float third)
+{
+ return callee_3 (first, second, third); // { dg-error "passing argument 2 of 'callee_3' makes pointer from integer without a cast" }
+ /* { dg-begin-multiline-output "" }
+ return callee_3 (first, second, third);
+ ^~~~~~
+ |
+ int
+ { dg-end-multiline-output "" } */
+ /* { dg-message "expected 'const char \\*' but argument is of type 'int'" "" { target *-*-* } callee_3 } */
+ /* { dg-begin-multiline-output "" }
+ static int callee_3 (int one, const char *two, float three)
+ ~~~~~~~~~~~~^~~
+ { dg-end-multiline-output "" } */
+}
+
+/* Trivial decl, with argname. */
+
+extern int callee_4 (int one, float two, float three); /* { dg-line callee_4 } */
+
+int test_4 (int first, const char *second, float third)
+{
+ return callee_4 (first, second, third); /* { dg-error "incompatible type for argument 2 of 'callee_4'" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_4 (first, second, third);
+ ^~~~~~
+ |
+ const char *
+ { dg-end-multiline-output "" } */
+ /* { dg-message "expected 'float' but argument is of type 'const char \\*'" "" { target *-*-* } callee_4 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_4 (int one, float two, float three);
+ ~~~~~~^~~
+ { dg-end-multiline-output "" } */
+}
+
+/* Trivial decl, without argname. */
+
+extern int callee_5 (int, float, float); /* { dg-line callee_5 } */
+
+int test_5 (int first, const char *second, float third)
+{
+ return callee_5 (first, second, third); /* { dg-error "incompatible type for argument 2 of 'callee_5'" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_5 (first, second, third);
+ ^~~~~~
+ |
+ const char *
+ { dg-end-multiline-output "" } */
+ /* { dg-message "expected 'float' but argument is of type 'const char \\*'" "" { target *-*-* } callee_5 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_5 (int, float, float);
+ ^~~~~
+ { dg-end-multiline-output "" } */
+}
+
+/* Callback with name. */
+
+extern int callee_6 (int one, int (*two)(int, int), float three); /* { dg-line callee_6 } */
+
+int test_6 (int first, int second, float third)
+{
+ return callee_6 (first, second, third); /* { dg-error "passing argument 2 of 'callee_6' makes pointer from integer without a cast" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_6 (first, second, third);
+ ^~~~~~
+ |
+ int
+ { dg-end-multiline-output "" } */
+ /* { dg-message " expected 'int \\(\\*\\)\\(int, int\\)' but argument is of type 'int'" "" { target *-*-* } callee_6 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_6 (int one, int (*two)(int, int), float three);
+ ~~~~~~^~~~~~~~~~~~~~
+ { dg-end-multiline-output "" } */
+}
+
+/* Callback without name. */
+
+extern int callee_7 (int one, int (*)(int, int), float three); /* { dg-line callee_7 } */
+
+int test_7 (int first, int second, float third)
+{
+ return callee_7 (first, second, third); /* { dg-error "passing argument 2 of 'callee_7' makes pointer from integer without a cast" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_7 (first, second, third);
+ ^~~~~~
+ |
+ int
+ { dg-end-multiline-output "" } */
+ /* { dg-message " expected 'int \\(\\*\\)\\(int, int\\)' but argument is of type 'int'" "" { target *-*-* } callee_7 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_7 (int one, int (*)(int, int), float three);
+ ^~~~~~~~~~~~~~~~~
+ { dg-end-multiline-output "" } */
+}
+
+/* -Wincompatible-pointer-types for a parameter. */
+
+extern int callee_8 (int one, float *two, float (three)); /* { dg-line callee_8 } */
+
+int test_8 (int first, int *second, float third)
+{
+ return callee_8 (first, second, third); /* { dg-warning "passing argument 2 of 'callee_8' from incompatible pointer type" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_8 (first, second, third);
+ ^~~~~~
+ |
+ int *
+ { dg-end-multiline-output "" } */
+ /* { dg-message "expected 'float \\*' but argument is of type 'int \\*'" "" { target *-*-* } callee_8 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_8 (int one, float *two, float (three));
+ ~~~~~~~^~~
+ { dg-end-multiline-output "" } */
+}
+
+/* -Wpointer-sign for a parameter. */
+
+extern int callee_9 (int one, int *two, float (three)); /* { dg-line callee_9 } */
+
+int test_9 (int first, unsigned int *second, float third)
+{
+ return callee_9 (first, second, third); /* { dg-warning "pointer targets in passing argument 2 of 'callee_9' differ in signedness" } */
+ /* { dg-begin-multiline-output "" }
+ return callee_9 (first, second, third);
+ ^~~~~~
+ |
+ unsigned int *
+ { dg-end-multiline-output "" } */
+ /* { dg-message "expected 'int \\*' but argument is of type 'unsigned int \\*'" "" { target *-*-* } callee_9 } */
+ /* { dg-begin-multiline-output "" }
+ extern int callee_9 (int one, int *two, float (three));
+ ~~~~~^~~
+ { dg-end-multiline-output "" } */
+}
diff --git a/gcc/testsuite/gcc.dg/param-type-mismatch.c b/gcc/testsuite/gcc.dg/param-type-mismatch.c
index 9e654a9e9c6..f6d68749cd8 100644
--- a/gcc/testsuite/gcc.dg/param-type-mismatch.c
+++ b/gcc/testsuite/gcc.dg/param-type-mismatch.c
@@ -1,4 +1,4 @@
-/* { dg-options "-fdiagnostics-show-caret -Wpointer-sign" } */
+/* { dg-options "-fpermissive -fdiagnostics-show-caret -Wpointer-sign" } */
/* A collection of calls where argument 2 is of the wrong type. */
diff --git a/gcc/testsuite/gcc.dg/pr61162-2.c b/gcc/testsuite/gcc.dg/pr61162-2.c
index 4aa8493d1a3..a7d0b45a310 100644
--- a/gcc/testsuite/gcc.dg/pr61162-2.c
+++ b/gcc/testsuite/gcc.dg/pr61162-2.c
@@ -1,6 +1,6 @@
/* PR c/61162 */
/* { dg-do compile } */
-/* { dg-options "-Wc++-compat -Wpointer-sign -Wpedantic" } */
+/* { dg-options "-fpermissive -Wc++-compat -Wpointer-sign -Wpedantic" } */
enum e { A };
struct s { int a; };
diff --git a/gcc/testsuite/gcc.dg/pr61162-3.c b/gcc/testsuite/gcc.dg/pr61162-3.c
new file mode 100644
index 00000000000..c48625797d8
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr61162-3.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+
+int
+fn4 (int *a)
+{
+ return a; /* { dg-error "10:returning 'int \\*' from a function with return type 'int' makes integer from pointer without a cast" } */
+}
+
+int *
+fn5 (int a)
+{
+ return a; /* { dg-error "10:returning 'int' from a function with return type 'int \\*' makes pointer from integer without a cast" } */
+}
diff --git a/gcc/testsuite/gcc.dg/spec-barrier-3.c b/gcc/testsuite/gcc.dg/spec-barrier-3.c
index 3ed4d39061a..0940a2105c6 100644
--- a/gcc/testsuite/gcc.dg/spec-barrier-3.c
+++ b/gcc/testsuite/gcc.dg/spec-barrier-3.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-Wpedantic" } */
+/* { dg-options "-fpermissive -Wpedantic" } */
/* __builtin_speculation_safe_value returns a value with the same type
as its first argument. There should be a warning if that isn't
diff --git a/gcc/testsuite/gcc.dg/spec-barrier-3a.c b/gcc/testsuite/gcc.dg/spec-barrier-3a.c
new file mode 100644
index 00000000000..ee98ad0ca50
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/spec-barrier-3a.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-Wpedantic" } */
+
+/* __builtin_speculation_safe_value returns a value with the same type
+ as its first argument. There should be an error if that isn't
+ type-compatible with the use. */
+int *
+f (int x)
+{
+ return __builtin_speculation_safe_value (x); /* { dg-error "returning 'int' from a function with return type 'int \\*' makes pointer from integer without a cast" } */
+}
+
+/* { dg-prune-output "this target does not define a speculation barrier;" } */
diff --git a/gcc/testsuite/gcc.target/aarch64/acle/memtag_2.c b/gcc/testsuite/gcc.target/aarch64/acle/memtag_2.c
index fcab05b7abe..806e0750fd1 100644
--- a/gcc/testsuite/gcc.target/aarch64/acle/memtag_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/acle/memtag_2.c
@@ -2,7 +2,7 @@
/* { dg-do compile } */
/* { dg-require-effective-target lp64 } */
-/* { dg-options "-O3 -march=armv8.5-a+memtag" } */
+/* { dg-options "-fpermissive -O3 -march=armv8.5-a+memtag" } */
#include "arm_acle.h"
@@ -67,4 +67,4 @@ test_memtag_error_argument (void)
__arm_mte_ptrdiff(no_decl2, 0); /* { dg-error {} } */
__arm_mte_ptrdiff(0); /* { dg-error {} } */
__arm_mte_ptrdiff(); /* { dg-error {} } */
-}
\ No newline at end of file
+}
diff --git a/gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c b/gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
new file mode 100644
index 00000000000..16db40df663
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
@@ -0,0 +1,71 @@
+/* Test the MEMTAG intrinsic qualifier warnings and argument errors. */
+
+/* { dg-do compile } */
+/* { dg-require-effective-target lp64 } */
+/* { dg-options "-O3 -march=armv8.5-a+memtag" } */
+
+#include "arm_acle.h"
+
+void
+test_memtag_warning_return_qualifier (void)
+{
+ const char *c;
+ volatile char *v;
+ char *n;
+ int *i;
+ int64_t d;
+
+ v = __arm_mte_get_tag(c); /* { dg-warning {assignment} } */
+ n = __arm_mte_get_tag(c); /* { dg-warning {assignment} } */
+ i = __arm_mte_get_tag(c); /* { dg-warning {assignment} } */
+ c = __arm_mte_get_tag(v); /* { dg-warning {assignment} } */
+ n = __arm_mte_get_tag(v); /* { dg-warning {assignment} } */
+
+ i = __arm_mte_create_random_tag (c, 0); /* { dg-warning {assignment} } */
+ i = __arm_mte_increment_tag (c, 0); /* { dg-warning {assignment} } */
+
+ c = __arm_mte_get_tag(n); /* No warning. */
+ d = __arm_mte_ptrdiff(c, i); /* No warning. */
+}
+
+void
+test_memtag_warning_argument (void)
+{
+ const char *c;
+ __arm_mte_exclude_tag(0, 0); /* No warning. */
+ __arm_mte_create_random_tag (0, 0); /* No warning. */
+ __arm_mte_set_tag(0); /* No warning. */
+ __arm_mte_get_tag(0); /* No warning. */
+ __arm_mte_increment_tag (0, 15); /* No warning. */
+ __arm_mte_ptrdiff(c, 0); /* No warning. */
+ __arm_mte_ptrdiff(0, c); /* No warning. */
+}
+
+void
+test_memtag_error_argument (void)
+{
+ /* Produce errors properly for invalid arguments. */
+ __arm_mte_exclude_tag(no_decl, 0); /* { dg-error {} } */
+ __arm_mte_exclude_tag(); /* { dg-error {} } */
+ __arm_mte_ptrdiff(no_decl2, 0); /* { dg-error {} } */
+ __arm_mte_ptrdiff(0); /* { dg-error {} } */
+ __arm_mte_ptrdiff(); /* { dg-error {} } */
+
+ const char *c;
+ uint64_t i;
+ __arm_mte_exclude_tag(i, 0); /* { dg-error {argument} } */
+ __arm_mte_create_random_tag (i, 0); /* { dg-error {argument} } */
+ __arm_mte_set_tag(i); /* { dg-error {argument} } */
+ __arm_mte_get_tag(i); /* { dg-error {argument} } */
+ __arm_mte_increment_tag (i, 15); /* { dg-error {argument} } */
+ __arm_mte_ptrdiff(c, i); /* { dg-error {argument} } */
+ __arm_mte_ptrdiff(i, c); /* { dg-error {argument} } */
+
+ __arm_mte_exclude_tag(1, 0); /* { dg-error {argument} } */
+ __arm_mte_create_random_tag (1, 0); /* { dg-error {argument} } */
+ __arm_mte_set_tag(1); /* { dg-error {argument} } */
+ __arm_mte_get_tag(1); /* { dg-error {argument} } */
+ __arm_mte_increment_tag (1, 15); /* { dg-error {argument} } */
+ __arm_mte_ptrdiff(c, 1); /* { dg-error {argument} } */
+ __arm_mte_ptrdiff(1, c); /* { dg-error {argument} } */
+}
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_3.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_3.c
index 770203f64c8..34166395ecc 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_3.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_3.c
@@ -13,6 +13,6 @@ f1 (svbool_t pg, signed char *s8_ptr, svint8_t s8)
svld1_vnum (pg, s8_ptr, 0, 0); /* { dg-error {too many arguments to function 'svld1_vnum'} } */
svld1_vnum (0, s8_ptr, 0); /* { dg-error {passing 'int' to argument 1 of 'svld1_vnum', which expects 'svbool_t'} } */
svld1_vnum (pg, 0, 0); /* { dg-error {passing 'int' to argument 2 of 'svld1_vnum', which expects a pointer type} } */
- svld1_vnum (pg, s8_ptr, s8_ptr); /* { dg-warning "passing argument 3 of 'svld1_vnum_s8' makes integer from pointer without a cast" } */
+ svld1_vnum (pg, s8_ptr, s8_ptr); /* { dg-error "passing argument 3 of 'svld1_vnum_s8' makes integer from pointer without a cast" } */
svld1_vnum (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svld1_vnum', which expects 'int64_t'} } */
}
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c
index c718b3ee04e..669f8844bc1 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c
@@ -14,7 +14,7 @@ f1 (svbool_t pg, signed char *s8_ptr, void *void_ptr, struct s *s_ptr,
svst1_vnum (0, s8_ptr, 0, s8); /* { dg-error {passing 'int' to argument 1 of 'svst1_vnum', which expects 'svbool_t'} } */
svst1_vnum (pg, s8_ptr, pg, s8); /* { dg-error {passing 'svbool_t' to argument 3 of 'svst1_vnum', which expects 'int64_t'} } */
svst1_vnum (pg, s8_ptr, s8, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svst1_vnum', which expects 'int64_t'} } */
- svst1_vnum (pg, s8_ptr, void_ptr, s8); /* { dg-warning "passing argument 3 of 'svst1_vnum_s8' makes integer from pointer without a cast" } */
+ svst1_vnum (pg, s8_ptr, void_ptr, s8); /* { dg-error "passing argument 3 of 'svst1_vnum_s8' makes integer from pointer without a cast" } */
svst1_vnum (pg, void_ptr, 0, 0); /* { dg-error {passing 'int' to argument 4 of 'svst1_vnum', which expects an SVE vector type} } */
svst1_vnum (pg, void_ptr, 0, pg); /* { dg-error {'svst1_vnum' has no form that takes 'svbool_t' arguments} } */
svst1_vnum (pg, 0, 0, s8);
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
index 89528237522..29f4510c49b 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
@@ -26,7 +26,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svst1_scatter_index (pg, cf32_ptr, s32, f32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32index_f32' from incompatible pointer type" } */
svst1_scatter_index (pg, s, s32, s32); /* { dg-error {passing 'struct s' to argument 2 of 'svst1_scatter_index', which expects a vector or pointer base address} } */
- svst1_scatter_index (pg, u32, void_ptr, s32); /* { dg-warning "passing argument 3 of 'svst1_scatter_u32base_index_s32' makes integer from pointer without a cast" } */
+ svst1_scatter_index (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svst1_scatter_u32base_index_s32' makes integer from pointer without a cast" } */
svst1_scatter_index (pg, u32, pg, s32); /* { dg-error {passing 'svbool_t' to argument 3 of 'svst1_scatter_index', which expects 'int64_t'} } */
svst1_scatter_index (pg, u32, s32, s32); /* { dg-error {passing 'svint32_t' to argument 3 of 'svst1_scatter_index', which expects 'int64_t'} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
index 5e31362c412..ab718b5eeee 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
@@ -28,7 +28,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svstnt1_scatter_index (pg, cf64_ptr, s64, f64); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_s64index_f64' from incompatible pointer type" } */
svstnt1_scatter_index (pg, s, s64, s64); /* { dg-error {passing 'struct s' to argument 2 of 'svstnt1_scatter_index', which expects a vector or pointer base address} } */
- svstnt1_scatter_index (pg, u32, void_ptr, s32); /* { dg-warning "passing argument 3 of 'svstnt1_scatter_u32base_index_s32' makes integer from pointer without a cast" } */
+ svstnt1_scatter_index (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svstnt1_scatter_u32base_index_s32' makes integer from pointer without a cast" } */
svstnt1_scatter_index (pg, u32, pg, s32); /* { dg-error {passing 'svbool_t' to argument 3 of 'svstnt1_scatter_index', which expects 'int64_t'} } */
svstnt1_scatter_index (pg, u32, s32, s32); /* { dg-error {passing 'svint32_t' to argument 3 of 'svstnt1_scatter_index', which expects 'int64_t'} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
index 4854818cae6..311b1744c91 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
@@ -26,7 +26,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svst1_scatter_offset (pg, cf32_ptr, s32, f32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32offset_f32' from incompatible pointer type" } */
svst1_scatter_offset (pg, s, s32, s32); /* { dg-error {passing 'struct s' to argument 2 of 'svst1_scatter_offset', which expects a vector or pointer base address} } */
- svst1_scatter_offset (pg, u32, void_ptr, s32); /* { dg-warning "passing argument 3 of 'svst1_scatter_u32base_offset_s32' makes integer from pointer without a cast" } */
+ svst1_scatter_offset (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svst1_scatter_u32base_offset_s32' makes integer from pointer without a cast" } */
svst1_scatter_offset (pg, u32, pg, s32); /* { dg-error {passing 'svbool_t' to argument 3 of 'svst1_scatter_offset', which expects 'int64_t'} } */
svst1_scatter_offset (pg, u32, s32, s32); /* { dg-error {passing 'svint32_t' to argument 3 of 'svst1_scatter_offset', which expects 'int64_t'} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
index 100624b7b03..5b251127a47 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
@@ -28,7 +28,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svstnt1_scatter_offset (pg, cf32_ptr, u32, f32); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_u32offset_f32' from incompatible pointer type" } */
svstnt1_scatter_offset (pg, s, u32, s32); /* { dg-error {passing 'struct s' to argument 2 of 'svstnt1_scatter_offset', which expects a vector or pointer base address} } */
- svstnt1_scatter_offset (pg, u32, void_ptr, s32); /* { dg-warning "passing argument 3 of 'svstnt1_scatter_u32base_offset_s32' makes integer from pointer without a cast" } */
+ svstnt1_scatter_offset (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svstnt1_scatter_u32base_offset_s32' makes integer from pointer without a cast" } */
svstnt1_scatter_offset (pg, u32, pg, s32); /* { dg-error {passing 'svbool_t' to argument 3 of 'svstnt1_scatter_offset', which expects 'int64_t'} } */
svstnt1_scatter_offset (pg, u32, s32, s32); /* { dg-error {passing 'svint32_t' to argument 3 of 'svstnt1_scatter_offset', which expects 'int64_t'} } */
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
2023-11-13 13:09 ` [PATCH 1/6] c-family: Introduce pedpermerror Florian Weimer
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
@ 2023-11-13 13:10 ` Florian Weimer
2023-11-13 19:25 ` Jeff Law
2023-11-13 19:42 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092] Sam James
2023-11-13 13:11 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror Florian Weimer
` (3 subsequent siblings)
6 siblings, 2 replies; 29+ messages in thread
From: Florian Weimer @ 2023-11-13 13:10 UTC (permalink / raw)
To: gcc-patches
In the future, it may make sense to avoid cascading errors from
the implicit declaration, especially its assumed int return type.
This change here only changes the kind of the diagnostic, not
its wording or consequences.
gcc/c/
* doc/invoke.texi (Warning Options): Document changes.
gcc/c/
* c-decl.cc (implicit_decl_pedpermerror): Rename from
implicit_decl_warning. Call pedpermerror instead of
pedwarn and warning_at.
(implicitly_declare): Adjust callers.
gcc/testsuite/
* c-c++-common/spellcheck-reserved.c (test, test_2): Expect
error instead of warning.
(f): Expect error instead of warning.
* gcc.dg/Wimplicit-function-declaration-c99.c: Compile with
-fpermissive due to expected warning.
* gcc.dg/Wimplicit-function-declaration-c99-2.c: New test.
Copied from gcc.dg/Wimplicit-function-declaration-c99.c.
Expect error.
* gcc.dg/missing-header-fixit-1.c: Compile with -fpermissive
due to expect error.
* gcc.dg/missing-header-fixit-1a.c: New test. Copied from
gcc.dg/missing-header-fixit-1.c, but expect error.
* gcc.dg/missing-header-fixit-2.c: Compile with -fpermissive
due to expect error.
* gcc.dg/missing-header-fixit-2a.c: New test. Copied from
gcc.dg/missing-header-fixit-2.c, but expect error.
* gcc.dg/missing-header-fixit-4.c: Compile with -fpermissive
due to expect error.
* gcc.dg/missing-header-fixit-4a.c: New test. Copied from
gcc.dg/missing-header-fixit-4.c, but expect error.
* gcc.dg/missing-header-fixit-5.c: Compile with -fpermissive
due to expect error.
* gcc.dg/missing-header-fixit-5a.c: New test. Copied from
gcc.dg/missing-header-fixit-5.c, but expect error.
* gcc.dg/pr61852.c: Expect implicit-function-declaration
error instead of warning.
* gcc.dg/spellcheck-identifiers-2.c: Compile with
-fpermissive due to expected warnings.
* gcc.dg/spellcheck-identifiers-2a.c: New test. Copied
from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
* gcc.dg/spellcheck-identifiers-3.c: Compile with
-fpermissive due to expected warnings.
* gcc.dg/spellcheck-identifiers-3a.c: New test. Copied
from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
* gcc.dg/spellcheck-identifiers-4.c: Compile with
-fpermissive due to expected warnings.
* gcc.dg/spellcheck-identifiers-4a.c: New test. Copied
from gcc.dg/spellcheck-identifiers-2a.c. Expect error.
* gcc.dg/spellcheck-identifiers.c: Compile with
-fpermissive due to expected warnings.
* gcc.dg/spellcheck-identifiers-1a.c: New test. Copied
from gcc.dg/spellcheck-identifiers.c. Expect errors.
* gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c (f1):
Expect error.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c:
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c:
(f1): Likewise.
---
gcc/c/c-decl.cc | 20 +--
gcc/doc/invoke.texi | 8 +-
.../c-c++-common/spellcheck-reserved.c | 4 +-
.../Wimplicit-function-declaration-c99-2.c | 7 +
.../Wimplicit-function-declaration-c99.c | 2 +-
| 2 +-
| 37 +++++
| 2 +-
| 31 ++++
| 2 +-
| 27 ++++
| 2 +-
| 42 ++++++
gcc/testsuite/gcc.dg/pr61852.c | 4 +-
.../gcc.dg/spellcheck-identifiers-1a.c | 136 ++++++++++++++++++
.../gcc.dg/spellcheck-identifiers-2.c | 2 +-
.../gcc.dg/spellcheck-identifiers-2a.c | 33 +++++
.../gcc.dg/spellcheck-identifiers-3.c | 2 +-
.../gcc.dg/spellcheck-identifiers-3a.c | 45 ++++++
.../gcc.dg/spellcheck-identifiers-4.c | 2 +-
.../gcc.dg/spellcheck-identifiers-4a.c | 10 ++
gcc/testsuite/gcc.dg/spellcheck-identifiers.c | 2 +-
.../sve/acle/general-c/ld1sh_gather_1.c | 2 +-
.../acle/general-c/load_ext_gather_index_1.c | 2 +-
.../load_ext_gather_index_restricted_1.c | 2 +-
.../acle/general-c/load_ext_gather_offset_1.c | 2 +-
.../acle/general-c/load_ext_gather_offset_2.c | 2 +-
.../acle/general-c/load_ext_gather_offset_3.c | 2 +-
.../acle/general-c/load_ext_gather_offset_4.c | 2 +-
.../acle/general-c/load_ext_gather_offset_5.c | 2 +-
.../load_ext_gather_offset_restricted_1.c | 2 +-
.../load_ext_gather_offset_restricted_2.c | 2 +-
.../load_ext_gather_offset_restricted_3.c | 2 +-
.../load_ext_gather_offset_restricted_4.c | 2 +-
34 files changed, 409 insertions(+), 37 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-1a.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-2a.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-4a.c
create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-5a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c
create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c
diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc
index 64d3a941cb9..e8387bfa984 100644
--- a/gcc/c/c-decl.cc
+++ b/gcc/c/c-decl.cc
@@ -3493,12 +3493,12 @@ pushdecl (tree x)
}
\f
-/* Issue a warning about implicit function declaration. ID is the function
+/* Issue a pedpermerror about implicit function declaration. ID is the function
identifier, OLDDECL is a declaration of the function in a different scope,
or NULL_TREE. */
static void
-implicit_decl_warning (location_t loc, tree id, tree olddecl)
+implicit_decl_pedpermerror (location_t loc, tree id, tree olddecl)
{
if (!warn_implicit_function_declaration)
return;
@@ -3515,14 +3515,14 @@ implicit_decl_warning (location_t loc, tree id, tree olddecl)
{
gcc_rich_location richloc (loc);
richloc.add_fixit_replace (suggestion);
- warned = pedwarn (&richloc, OPT_Wimplicit_function_declaration,
- "implicit declaration of function %qE;"
- " did you mean %qs?",
- id, suggestion);
+ warned = pedpermerror (&richloc, OPT_Wimplicit_function_declaration,
+ "implicit declaration of function %qE;"
+ " did you mean %qs?",
+ id, suggestion);
}
else
- warned = pedwarn (loc, OPT_Wimplicit_function_declaration,
- "implicit declaration of function %qE", id);
+ warned = pedpermerror (loc, OPT_Wimplicit_function_declaration,
+ "implicit declaration of function %qE", id);
}
else if (const char *suggestion = hint.suggestion ())
{
@@ -3812,7 +3812,7 @@ implicitly_declare (location_t loc, tree functionid)
then recycle the old declaration but with the new type. */
if (!C_DECL_IMPLICIT (decl))
{
- implicit_decl_warning (loc, functionid, decl);
+ implicit_decl_pedpermerror (loc, functionid, decl);
C_DECL_IMPLICIT (decl) = 1;
}
if (fndecl_built_in_p (decl))
@@ -3865,7 +3865,7 @@ implicitly_declare (location_t loc, tree functionid)
DECL_EXTERNAL (decl) = 1;
TREE_PUBLIC (decl) = 1;
C_DECL_IMPLICIT (decl) = 1;
- implicit_decl_warning (loc, functionid, 0);
+ implicit_decl_pedpermerror (loc, functionid, 0);
asmspec_tree = maybe_apply_renaming_pragma (decl, /*asmname=*/NULL);
if (asmspec_tree)
set_user_assembler_name (decl, TREE_STRING_POINTER (asmspec_tree));
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index b9fafe0fd34..1a15af29f01 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -6179,6 +6179,7 @@ only by this flag, but it also downgrades some C and C++ diagnostics
that have their own flag:
@gccoptlist{
+-Wimplicit-function-declaration @r{(C)}
-Wint-conversion @r{(C)}
-Wnarrowing @r{(C++)}
}
@@ -6859,8 +6860,11 @@ This warning is upgraded to an error by @option{-pedantic-errors}.
@opindex Wno-implicit-function-declaration
@item -Wno-implicit-function-declaration @r{(C and Objective-C only)}
This option controls warnings when a function is used before being declared.
-This warning is enabled by default in C99 and later dialects of C,
-and also by @option{-Wall}.
+This warning is enabled by default, as an error, in C99 and later
+dialects of C, and also by @option{-Wall}. The error can be downgraded
+to a warning using @option{-fpermissive} (along with certain other
+errors), or for this error alone, with
+@option{-Wno-error=implicit-function-declaration}.
This warning is upgraded to an error by @option{-pedantic-errors}.
diff --git a/gcc/testsuite/c-c++-common/spellcheck-reserved.c b/gcc/testsuite/c-c++-common/spellcheck-reserved.c
index 56e59dcc00a..0be35c56f52 100644
--- a/gcc/testsuite/c-c++-common/spellcheck-reserved.c
+++ b/gcc/testsuite/c-c++-common/spellcheck-reserved.c
@@ -29,7 +29,7 @@ SOME_MACRO foo; /* { dg-bogus "__SOME_MACRO" } */
void test (const char *buf, char ch)
{
__builtin_strtchr (buf, ch); /* { dg-line misspelled_reserved } */
- /* { dg-warning "did you mean '__builtin_strchr'" "" { target c } misspelled_reserved } */
+ /* { dg-error "did you mean '__builtin_strchr'" "" { target c } misspelled_reserved } */
/* { dg-error "'__builtin_strtchr' was not declared in this scope; did you mean '__builtin_strrchr'\\?" "" { target c++ } misspelled_reserved } */
}
@@ -38,7 +38,7 @@ void test (const char *buf, char ch)
void test_2 (const char *buf, char ch)
{
_builtin_strchr (buf, ch); /* { dg-line misspelled_one_underscore } */
- /* { dg-warning "did you mean '__builtin_strchr'" "" { target c } misspelled_one_underscore } */
+ /* { dg-error "did you mean '__builtin_strchr'" "" { target c } misspelled_one_underscore } */
/* { dg-error "'_builtin_strchr' was not declared in this scope; did you mean '__builtin_strchr'\\?" "" { target c++ } misspelled_one_underscore } */
}
diff --git a/gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c b/gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c
new file mode 100644
index 00000000000..d65abc9670c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c
@@ -0,0 +1,7 @@
+/* { dg-do compile } */
+/* { dg-options "-std=c99" } */
+
+void f(void)
+{
+ puts("Hello"); /* { dg-error "implicit declaration of function" } */
+}
diff --git a/gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99.c b/gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99.c
index 254f7e70e65..abea8a5f356 100644
--- a/gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99.c
+++ b/gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-std=c99" } */
+/* { dg-options "-fpermissive -std=c99" } */
void f(void)
{
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-1.c b/gcc/testsuite/gcc.dg/missing-header-fixit-1.c
index 2b28357e1db..eb33d9b1f23 100644
--- a/gcc/testsuite/gcc.dg/missing-header-fixit-1.c
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-1.c
@@ -5,7 +5,7 @@
/* This is padding (to avoid the generated patch containing DejaGnu
directives). */
-/* { dg-options "-fdiagnostics-generate-patch" } */
+/* { dg-options "-fpermissive -fdiagnostics-generate-patch" } */
void test (int i, int j)
{
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-1a.c b/gcc/testsuite/gcc.dg/missing-header-fixit-1a.c
new file mode 100644
index 00000000000..e47236b955d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-1a.c
@@ -0,0 +1,37 @@
+/* Example of a fix-it hint that adds a #include directive,
+ adding them to the top of the file, given that there is no
+ pre-existing #include. */
+
+/* This is padding (to avoid the generated patch containing DejaGnu
+ directives). */
+
+/* { dg-options "-fdiagnostics-generate-patch" } */
+
+void test (int i, int j)
+{
+ printf ("%i of %i\n", i, j); /* { dg-error "implicit declaration" } */
+ /* { dg-message "include '<stdio.h>' or provide a declaration of 'printf'" "" { target *-*-* } .-1 } */
+ /* { dg-warning "incompatible implicit declaration of built-in function 'printf'" "" { target *-*-* } .-2 } */
+}
+
+/* Verify the output from -fdiagnostics-generate-patch.
+ We expect the patch to begin with a header, containing this
+ source filename, via an absolute path.
+ Given the path, we can only capture it via regexps. */
+/* { dg-regexp "\\-\\-\\- .*" } */
+/* { dg-regexp "\\+\\+\\+ .*" } */
+/* Use #if 0/#endif rather than comments, to allow the text to contain
+ a comment. */
+#if 0
+{ dg-begin-multiline-output "" }
+@@ -1,3 +1,4 @@
++#include <stdio.h>
+ /* Example of a fix-it hint that adds a #include directive,
+ adding them to the top of the file, given that there is no
+ pre-existing #include. */
+{ dg-end-multiline-output "" }
+#endif
+
+/* FIXME: should we attempt to skip leading comments when determining the
+ insertion location?
+ Similarly, should we attempt to be within single-inclusion guards, etc? */
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-2.c b/gcc/testsuite/gcc.dg/missing-header-fixit-2.c
index 5d5f87488f5..38d36a66c46 100644
--- a/gcc/testsuite/gcc.dg/missing-header-fixit-2.c
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-2.c
@@ -9,7 +9,7 @@
/* { dg-warning "implicit declaration of function 'printf'" "" { target *-*-* } 6 } */
/* { dg-warning "incompatible implicit declaration of built-in function 'printf'" "" { target *-*-* } 6 } */
-/* { dg-options "-fdiagnostics-generate-patch" } */
+/* { dg-options "-fpermissive -fdiagnostics-generate-patch" } */
/* Verify the output from -fdiagnostics-generate-patch.
We expect the patch to begin with a header, containing the
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-2a.c b/gcc/testsuite/gcc.dg/missing-header-fixit-2a.c
new file mode 100644
index 00000000000..4ae617bddbd
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-2a.c
@@ -0,0 +1,31 @@
+/* Verify that when we suggest adding #include directives that they
+ are added to the affected file. */
+
+/* The following header file is missing a "#include <stdio.h>". */
+
+#include "missing-header-fixit-2.h"
+
+/* These directives actually apply to the header. */
+/* { dg-error "implicit declaration of function 'printf'" "" { target *-*-* } 6 } */
+/* { dg-warning "incompatible implicit declaration of built-in function 'printf'" "" { target *-*-* } 6 } */
+
+/* { dg-options "-fdiagnostics-generate-patch" } */
+
+/* Verify the output from -fdiagnostics-generate-patch.
+ We expect the patch to begin with a header, containing the
+ filename of the header, via an absolute path.
+ Given the path, we can only capture it via regexps. */
+/* { dg-regexp "\\-\\-\\- .*" } */
+/* { dg-regexp "\\+\\+\\+ .*" } */
+/* Use #if 0/#endif rather than comments, to allow the text to contain
+ a comment.
+ We expect the *header* to have been patched, adding the missing include. */
+#if 0
+{ dg-begin-multiline-output "" }
+@@ -1,3 +1,4 @@
++#include <stdio.h>
+ /* This is missing-header-fixit-2.h, for use by
+ missing-header-fixit-2.c */
+
+{ dg-end-multiline-output "" }
+#endif
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-4.c b/gcc/testsuite/gcc.dg/missing-header-fixit-4.c
index b6680563dc1..8e4e48d2e43 100644
--- a/gcc/testsuite/gcc.dg/missing-header-fixit-4.c
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-4.c
@@ -3,7 +3,7 @@
#include "empty.h"
int the_next_line;
-/* { dg-options "-fdiagnostics-show-caret -fdiagnostics-show-line-numbers" } */
+/* { dg-options "-fpermissive -fdiagnostics-show-caret -fdiagnostics-show-line-numbers" } */
void test (int i, int j)
{
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-4a.c b/gcc/testsuite/gcc.dg/missing-header-fixit-4a.c
new file mode 100644
index 00000000000..b93061f287b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-4a.c
@@ -0,0 +1,27 @@
+/* Example of a fix-it hint that adds a #include directive,
+ adding them after a pre-existing #include directive. */
+#include "empty.h"
+int the_next_line;
+
+/* { dg-options "-fdiagnostics-show-caret -fdiagnostics-show-line-numbers" } */
+
+void test (int i, int j)
+{
+ printf ("%i of %i\n", i, j); /* { dg-line printf } */
+ /* { dg-error "implicit declaration of function" "" { target *-*-* } printf } */
+ /* { dg-begin-multiline-output "" }
+ 10 | printf ("%i of %i\n", i, j);
+ | ^~~~~~
+ { dg-end-multiline-output "" } */
+ /* { dg-warning "incompatible implicit declaration" "" { target *-*-* } printf } */
+ /* { dg-begin-multiline-output "" }
+ 10 | printf ("%i of %i\n", i, j);
+ | ^~~~~~
+ { dg-end-multiline-output "" } */
+ /* { dg-message "include '<stdio.h>' or provide a declaration of 'printf'" "" { target *-*-* } 4 } */
+ /* { dg-begin-multiline-output "" }
+ 3 | #include "empty.h"
+ +++ |+#include <stdio.h>
+ 4 | int the_next_line;
+ { dg-end-multiline-output "" } */
+}
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-5.c b/gcc/testsuite/gcc.dg/missing-header-fixit-5.c
index bf44feb24a9..c34a47dc286 100644
--- a/gcc/testsuite/gcc.dg/missing-header-fixit-5.c
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-5.c
@@ -3,7 +3,7 @@
Rely on -Wimplicit-function-declaration for fixit hints, not on
-Wbuiltin-declaration-mismatch (which misses abs, isdigit, putchar). */
-/* { dg-options "-fdiagnostics-show-caret -fdiagnostics-show-line-numbers -Wimplicit-function-declaration -Wno-builtin-declaration-mismatch" } */
+/* { dg-options "-fpermissive -fdiagnostics-show-caret -fdiagnostics-show-line-numbers -Wimplicit-function-declaration -Wno-builtin-declaration-mismatch" } */
int
foo (char *m, int i)
--git a/gcc/testsuite/gcc.dg/missing-header-fixit-5a.c b/gcc/testsuite/gcc.dg/missing-header-fixit-5a.c
new file mode 100644
index 00000000000..420cbf7be40
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/missing-header-fixit-5a.c
@@ -0,0 +1,42 @@
+
+/* Forget to include any standard headers, all for built-in functions.
+ Rely on -Wimplicit-function-declaration for fixit hints, not on
+ -Wbuiltin-declaration-mismatch (which misses abs, isdigit, putchar). */
+
+/* { dg-options "-fdiagnostics-show-caret -fdiagnostics-show-line-numbers -Wimplicit-function-declaration -Wno-builtin-declaration-mismatch" } */
+
+int
+foo (char *m, int i)
+{
+ if (isdigit (m[0])) /* { dg-error "implicit declaration of function" } */
+ /* { dg-begin-multiline-output "" }
+ 11 | if (isdigit (m[0]))
+ | ^~~~~~~
+ { dg-end-multiline-output "" } */
+ /* { dg-begin-multiline-output "" }
+ +++ |+#include <ctype.h>
+ 1 |
+ { dg-end-multiline-output "" } */
+ {
+ return abs (i); /* { dg-error "implicit declaration of function" } */
+ /* { dg-begin-multiline-output "" }
+ 21 | return abs (i);
+ | ^~~
+ { dg-end-multiline-output "" } */
+ /* { dg-begin-multiline-output "" }
+ +++ |+#include <stdlib.h>
+ 1 |
+ { dg-end-multiline-output "" } */
+ }
+ else
+ putchar (m[0]); /* { dg-error "implicit declaration of function" } */
+ /* { dg-begin-multiline-output "" }
+ 32 | putchar (m[0]);
+ | ^~~~~~~
+ { dg-end-multiline-output "" } */
+ /* { dg-begin-multiline-output "" }
+ +++ |+#include <stdio.h>
+ 1 |
+ { dg-end-multiline-output "" } */
+ return i;
+}
diff --git a/gcc/testsuite/gcc.dg/pr61852.c b/gcc/testsuite/gcc.dg/pr61852.c
index f488aca7ac2..e669d3c4d39 100644
--- a/gcc/testsuite/gcc.dg/pr61852.c
+++ b/gcc/testsuite/gcc.dg/pr61852.c
@@ -1,10 +1,10 @@
/* PR c/61852 */
/* { dg-do compile } */
-/* { dg-options "-Wimplicit-function-declaration" } */
+/* { dg-options "" } */
int
f (int a)
{
- int b = a + a + a + ff (a); /* { dg-warning "23:implicit declaration of function" } */
+ int b = a + a + a + ff (a); /* { dg-error "23:implicit declaration of function" } */
return b;
}
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c
new file mode 100644
index 00000000000..f50c52b656c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c
@@ -0,0 +1,136 @@
+/* { dg-do compile } */
+/* { dg-options "-fdiagnostics-show-caret" } */
+
+typedef struct GtkWidget { int dummy; } GtkWidget;
+
+extern void gtk_widget_show_all (GtkWidget *w);
+
+void
+test_1 (GtkWidget *w)
+{
+ gtk_widget_showall (w); /* { dg-error "3: implicit declaration of function .gtk_widget_showall.; did you mean .gtk_widget_show_all.?" } */
+ /* { dg-begin-multiline-output "" }
+ gtk_widget_showall (w);
+ ^~~~~~~~~~~~~~~~~~
+ gtk_widget_show_all
+ { dg-end-multiline-output "" } */
+
+ /* Ensure we don't try to suggest "gtk_widget_showall" for subsequent
+ corrections. */
+ gtk_widget_showall_ (w); /* { dg-error "3: implicit declaration of function .gtk_widget_showall_.; did you mean .gtk_widget_show_all.?" } */
+ /* { dg-begin-multiline-output "" }
+ gtk_widget_showall_ (w);
+ ^~~~~~~~~~~~~~~~~~~
+ gtk_widget_show_all
+ { dg-end-multiline-output "" } */
+
+ GtkWidgetShowAll (w); /* { dg-error "3: implicit declaration of function .GtkWidgetShowAll.; did you mean .gtk_widget_show_all.?" } */
+ /* { dg-begin-multiline-output "" }
+ GtkWidgetShowAll (w);
+ ^~~~~~~~~~~~~~~~
+ gtk_widget_show_all
+ { dg-end-multiline-output "" } */
+}
+
+int
+test_2 (int param)
+{
+ return parma * parma; /* { dg-error "10: .parma. undeclared .first use in this function.; did you mean .param." } */
+ /* { dg-begin-multiline-output "" }
+ return parma * parma;
+ ^~~~~
+ param
+ { dg-end-multiline-output "" } */
+}
+
+#define MACRO(X) ((X))
+
+int
+test_3 (int i)
+{
+ return MACRAME (i); /* { dg-error "10: implicit declaration of function .MACRAME.; did you mean .MACRO.?" } */
+ /* { dg-begin-multiline-output "" }
+ return MACRAME (i);
+ ^~~~~~~
+ MACRO
+ { dg-end-multiline-output "" } */
+}
+
+#define IDENTIFIER_POINTER(X) ((X))
+
+int
+test_4 (int node)
+{
+ return IDENTIFIER_PTR (node); /* { dg-error "10: implicit declaration of function .IDENTIFIER_PTR.; did you mean .IDENTIFIER_POINTER.?" } */
+ /* { dg-begin-multiline-output "" }
+ return IDENTIFIER_PTR (node);
+ ^~~~~~~~~~~~~~
+ IDENTIFIER_POINTER
+ { dg-end-multiline-output "" } */
+}
+
+
+int
+test_5 (void)
+{
+ return __LINE_; /* { dg-error "10: .__LINE_. undeclared .first use in this function.; did you mean .__LINE__." } */
+ /* { dg-begin-multiline-output "" }
+ return __LINE_;
+ ^~~~~~~
+ __LINE__
+ { dg-end-multiline-output "" } */
+}
+
+#define MAX_ITEMS 100
+int array[MAX_ITEM]; /* { dg-error "11: .MAX_ITEM. undeclared here .not in a function.; did you mean .MAX_ITEMS." } */
+ /* { dg-begin-multiline-output "" }
+ int array[MAX_ITEM];
+ ^~~~~~~~
+ MAX_ITEMS
+ { dg-end-multiline-output "" } */
+
+
+enum foo {
+ FOO_FIRST,
+ FOO_SECOND
+};
+
+int
+test_6 (enum foo f)
+{
+ switch (f)
+ {
+ case FOO_FURST: /* { dg-error "10: .FOO_FURST. undeclared .first use in this function.; did you mean .FOO_FIRST." } */
+ break;
+ /* { dg-begin-multiline-output "" }
+ case FOO_FURST:
+ ^~~~~~~~~
+ FOO_FIRST
+ { dg-end-multiline-output "" } */
+
+ case FOO_SECCOND: /* { dg-error "10: .FOO_SECCOND. undeclared .first use in this function.; did you mean .FOO_SECOND." } */
+ break;
+ /* { dg-begin-multiline-output "" }
+ case FOO_SECCOND:
+ ^~~~~~~~~~~
+ FOO_SECOND
+ { dg-end-multiline-output "" } */
+
+ default:
+ break;
+ }
+}
+
+int snprintf (char *, __SIZE_TYPE__, const char *, ...);
+
+void
+test_7 (int i, int j)
+{
+ int buffer[100];
+ snprint (buffer, 100, "%i of %i", i, j); /* { dg-error "3: implicit declaration of function .snprint.; did you mean .snprintf.." } */
+ /* { dg-begin-multiline-output "" }
+ snprint (buffer, 100, "%i of %i", i, j);
+ ^~~~~~~
+ snprintf
+ { dg-end-multiline-output "" } */
+}
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers-2.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers-2.c
index ad6e9d3191d..b49709dc528 100644
--- a/gcc/testsuite/gcc.dg/spellcheck-identifiers-2.c
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers-2.c
@@ -1,7 +1,7 @@
/* PR c/71858 */
/* Make sure anticipated builtins are not considered before they are declared. */
/* { dg-do compile } */
-/* { dg-options "-Wimplicit-function-declaration -fdiagnostics-show-caret" } */
+/* { dg-options "-fpermissive -Wimplicit-function-declaration -fdiagnostics-show-caret" } */
int sscafn (const char *, const char *, ...);
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c
new file mode 100644
index 00000000000..1a3e68c703c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c
@@ -0,0 +1,33 @@
+/* PR c/71858 */
+/* Make sure anticipated builtins are not considered before they are declared. */
+/* { dg-do compile } */
+/* { dg-options "-fdiagnostics-show-caret" } */
+
+int sscafn (const char *, const char *, ...);
+
+int
+test_1 (const char *p)
+{
+ int i;
+ return ssacnf (p, "%d", &i); /* { dg-error "10: implicit declaration of function .ssacnf.; did you mean .sscafn.?" } */
+ /* { dg-begin-multiline-output "" }
+ return ssacnf (p, "%d", &i);
+ ^~~~~~
+ sscafn
+ { dg-end-multiline-output "" } */
+}
+
+int scafn (const char *, ...);
+int scanf (const char *, ...);
+
+int
+test_2 (void)
+{
+ int i;
+ return sacnf ("%d", &i); /* { dg-error "10: implicit declaration of function .sacnf.; did you mean .scanf.?" } */
+ /* { dg-begin-multiline-output "" }
+ return sacnf ("%d", &i);
+ ^~~~~
+ scanf
+ { dg-end-multiline-output "" } */
+}
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers-3.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers-3.c
index 94f4078d0e8..0b5982fa705 100644
--- a/gcc/testsuite/gcc.dg/spellcheck-identifiers-3.c
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers-3.c
@@ -1,7 +1,7 @@
/* PR c/71858 */
/* Only consider function names, function pointers and macros for implicit function declarations. */
/* { dg-do compile } */
-/* { dg-options "-Wimplicit-function-declaration -fdiagnostics-show-caret" } */
+/* { dg-options "-fpermissive -Wimplicit-function-declaration -fdiagnostics-show-caret" } */
void fn1abcd (void);
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c
new file mode 100644
index 00000000000..0c0a19e547b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c
@@ -0,0 +1,45 @@
+/* PR c/71858 */
+/* Only consider function names, function pointers and macros for implicit function declarations. */
+/* { dg-do compile } */
+/* { dg-options "-fdiagnostics-show-caret" } */
+
+void fn1abcd (void);
+
+void
+test_1 (int fn1bacd)
+{
+ fn1badc (); /* { dg-error "3: implicit declaration of function .fn1badc.; did you mean .fn1abcd.?" } */
+ /* { dg-begin-multiline-output "" }
+ fn1badc ();
+ ^~~~~~~
+ fn1abcd
+ { dg-end-multiline-output "" } */
+}
+
+void fn2efgh (void);
+void (*fn2efhg) (void);
+
+void
+test_2 (void)
+{
+ fn2fehg (); /* { dg-error "3: implicit declaration of function .fn2fehg.; did you mean .fn2efhg.?" } */
+ /* { dg-begin-multiline-output "" }
+ fn2fehg ();
+ ^~~~~~~
+ fn2efhg
+ { dg-end-multiline-output "" } */
+}
+
+void fn3ijkl (void);
+typedef int fn3ijlk;
+
+void
+test_3 (void)
+{
+ fn3jilk (); /* { dg-error "3: implicit declaration of function .fn3jilk.; did you mean .fn3ijkl.?" } */
+ /* { dg-begin-multiline-output "" }
+ fn3jilk ();
+ ^~~~~~~
+ fn3ijkl
+ { dg-end-multiline-output "" } */
+}
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers-4.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers-4.c
index f9b7d8d0cab..f24d863a15c 100644
--- a/gcc/testsuite/gcc.dg/spellcheck-identifiers-4.c
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers-4.c
@@ -1,4 +1,4 @@
-/* { dg-options "-Wimplicit-function-declaration" } */
+/* { dg-options "-fpermissive -Wimplicit-function-declaration" } */
extern double sqrt (double);
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c
new file mode 100644
index 00000000000..33a6b4220f4
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c
@@ -0,0 +1,10 @@
+/* { dg-options "" } */
+
+extern double sqrt (double);
+
+void test (float pf, float inff)
+{
+ assert (pf == inff); /* { dg-bogus "sqrt" } */
+ /* { dg-error "implicit declaration of function 'assert'" "" { target *-*-* } .-1 } */
+ /* { dg-message "header '<assert.h>'" "" { target *-*-* } .-2 } */
+}
diff --git a/gcc/testsuite/gcc.dg/spellcheck-identifiers.c b/gcc/testsuite/gcc.dg/spellcheck-identifiers.c
index 063e3f9eda1..cd632c6a064 100644
--- a/gcc/testsuite/gcc.dg/spellcheck-identifiers.c
+++ b/gcc/testsuite/gcc.dg/spellcheck-identifiers.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-Wimplicit-function-declaration -fdiagnostics-show-caret" } */
+/* { dg-options "-fpermissive -fdiagnostics-show-caret" } */
typedef struct GtkWidget { int dummy; } GtkWidget;
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c
index 91f37f6a53d..c9f49b6e73d 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c
@@ -11,7 +11,7 @@ f1 (svbool_t pg, short *s16_ptr, unsigned short *u16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svld1sh_gather_index (pg, s16_ptr, s32); /* { dg-warning {implicit declaration of function 'svld1sh_gather_index'; did you mean 'svld1_gather_index'} } */
+ svld1sh_gather_index (pg, s16_ptr, s32); /* { dg-error {implicit declaration of function 'svld1sh_gather_index'; did you mean 'svld1_gather_index'} } */
svld1sh_gather_index_u32 (pg, s16_ptr); /* { dg-error {too few arguments to function 'svld1sh_gather_index_u32'} } */
svld1sh_gather_index_u32 (pg, s16_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1sh_gather_index_u32'} } */
svld1sh_gather_index_u32 (pg, u16_ptr, s32); /* { dg-warning {pointer targets in passing argument 2 of 'svld1sh_gather_s32index_u32' differ in signedness} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c
index 91f37f6a53d..c9f49b6e73d 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c
@@ -11,7 +11,7 @@ f1 (svbool_t pg, short *s16_ptr, unsigned short *u16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svld1sh_gather_index (pg, s16_ptr, s32); /* { dg-warning {implicit declaration of function 'svld1sh_gather_index'; did you mean 'svld1_gather_index'} } */
+ svld1sh_gather_index (pg, s16_ptr, s32); /* { dg-error {implicit declaration of function 'svld1sh_gather_index'; did you mean 'svld1_gather_index'} } */
svld1sh_gather_index_u32 (pg, s16_ptr); /* { dg-error {too few arguments to function 'svld1sh_gather_index_u32'} } */
svld1sh_gather_index_u32 (pg, s16_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1sh_gather_index_u32'} } */
svld1sh_gather_index_u32 (pg, u16_ptr, s32); /* { dg-warning {pointer targets in passing argument 2 of 'svld1sh_gather_s32index_u32' differ in signedness} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c
index c47e5411c20..a2dcf9a041b 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c
@@ -13,7 +13,7 @@ f1 (svbool_t pg, short *s16_ptr, unsigned short *u16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svldnt1sh_gather_index (pg, s16_ptr, s64); /* { dg-warning {implicit declaration of function 'svldnt1sh_gather_index'; did you mean 'svldnt1_gather_index'} } */
+ svldnt1sh_gather_index (pg, s16_ptr, s64); /* { dg-error {implicit declaration of function 'svldnt1sh_gather_index'; did you mean 'svldnt1_gather_index'} } */
svldnt1sh_gather_index_u64 (pg, s16_ptr); /* { dg-error {too few arguments to function 'svldnt1sh_gather_index_u64'} } */
svldnt1sh_gather_index_u64 (pg, s16_ptr, s64, 0); /* { dg-error {too many arguments to function 'svldnt1sh_gather_index_u64'} } */
svldnt1sh_gather_index_u64 (pg, u16_ptr, s64); /* { dg-warning {pointer targets in passing argument 2 of 'svldnt1sh_gather_s64index_u64' differ in signedness} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
index dae4d0ce120..cd849f89941 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
@@ -11,7 +11,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svld1sb_gather_offset (pg, s8_ptr, s32); /* { dg-warning {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
+ svld1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_s32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_s32'} } */
svld1sb_gather_offset_s32 (pg, s8_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_s32'} } */
svld1sb_gather_offset_s32 (pg, s16_ptr, s32); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s32offset_s32' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
index 1bc66977cdf..850eecf99f6 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
@@ -11,7 +11,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svld1sb_gather_offset (pg, s8_ptr, s32); /* { dg-warning {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
+ svld1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_u32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_u32'} } */
svld1sb_gather_offset_u32 (pg, s8_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_u32'} } */
svld1sb_gather_offset_u32 (pg, s16_ptr, s32); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s32offset_u32' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
index 6522889dbe7..93a728593f9 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
@@ -11,7 +11,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svld1sb_gather_offset (pg, s8_ptr, s64); /* { dg-warning {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
+ svld1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_s64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_s64'} } */
svld1sb_gather_offset_s64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_s64'} } */
svld1sb_gather_offset_s64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s64offset_s64' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
index 02562198909..d54dc8eafab 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
@@ -11,7 +11,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svld1sb_gather_offset (pg, s8_ptr, s64); /* { dg-warning {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
+ svld1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_u64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_u64'} } */
svld1sb_gather_offset_u64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_u64'} } */
svld1sb_gather_offset_u64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s64offset_u64' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
index 8d57aa020ea..3b521d5c141 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
@@ -11,7 +11,7 @@ f1 (svbool_t pg, unsigned char *s8_ptr, unsigned short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svld1ub_gather_offset (pg, s8_ptr, s32); /* { dg-warning {implicit declaration of function 'svld1ub_gather_offset'; did you mean 'svld1_gather_offset'} } */
+ svld1ub_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svld1ub_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1ub_gather_offset_s32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1ub_gather_offset_s32'} } */
svld1ub_gather_offset_s32 (pg, s8_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1ub_gather_offset_s32'} } */
svld1ub_gather_offset_s32 (pg, s16_ptr, s32); /* { dg-warning {passing argument 2 of 'svld1ub_gather_s32offset_s32' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
index 353fec2d39d..96d8ad55074 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
@@ -13,7 +13,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svldnt1sb_gather_offset (pg, s8_ptr, s32); /* { dg-warning {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
+ svldnt1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_s32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_s32'} } */
svldnt1sb_gather_offset_s32 (pg, s8_ptr, u32, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_s32'} } */
svldnt1sb_gather_offset_s32 (pg, s16_ptr, u32); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_u32offset_s32' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
index e22b3dd8fea..25ce7268a1e 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
@@ -13,7 +13,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svldnt1sb_gather_offset (pg, s8_ptr, s32); /* { dg-warning {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
+ svldnt1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_u32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_u32'} } */
svldnt1sb_gather_offset_u32 (pg, s8_ptr, u32, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_u32'} } */
svldnt1sb_gather_offset_u32 (pg, s16_ptr, u32); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_u32offset_u32' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
index 73b5715c368..04465f251b1 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
@@ -13,7 +13,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svldnt1sb_gather_offset (pg, s8_ptr, s64); /* { dg-warning {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
+ svldnt1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_s64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_s64'} } */
svldnt1sb_gather_offset_s64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_s64'} } */
svldnt1sb_gather_offset_s64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_s64offset_s64' from incompatible pointer type} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
index e2ceb18bc42..479be66996d 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
@@ -13,7 +13,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svint32_t s32, svuint32_t u32, svfloat32_t f32,
svint64_t s64, svuint64_t u64, svfloat64_t f64, struct s s)
{
- svldnt1sb_gather_offset (pg, s8_ptr, s64); /* { dg-warning {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
+ svldnt1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_u64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_u64'} } */
svldnt1sb_gather_offset_u64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_u64'} } */
svldnt1sb_gather_offset_u64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_s64offset_u64' from incompatible pointer type} } */
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
` (2 preceding siblings ...)
2023-11-13 13:10 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror Florian Weimer
@ 2023-11-13 13:11 ` Florian Weimer
2023-11-13 19:26 ` Jeff Law
2023-11-13 19:45 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror [PR91093] Sam James
2023-11-13 13:11 ` [PATCH 5/6] c: Turn -Wreturn-mismatch into a pedpermerror Florian Weimer
` (2 subsequent siblings)
6 siblings, 2 replies; 29+ messages in thread
From: Florian Weimer @ 2023-11-13 13:11 UTC (permalink / raw)
To: gcc-patches
There is a missed opportunity here to issue spelling diagnostics
in prototype declarations (e.g., for “extern int foo (int32t);”).
gcc/
* doc/invoke.texi (Warning Options): Document changes.
gcc/c/
* c-decl.cc (warn_defaults_to): Call emit_diagnostic_valist
instead of reimplementing it. Issue a pedpermerror for C99
and later.
(store_parm_decls_oldstyle): Call pedpermerror for
OPT_Wimplicit_int.
gcc/testsuite/
* gcc.dg/Wimplicit-int-1.c: Compile with -fpermissive due to
expected warning.
* gcc.dg/Wimplicit-int-4.c: Likewise.
* gcc.dg/Wimplicit-int-1a.c: New test. Copied from
gcc.dg/Wimplicit-int-1.c, but expect errors.
* gcc.dg/Wimplicit-int-4a.c: New test. Copied from
gcc.dg/Wimplicit-int-4.c, but expect errors.
* gcc.dg/gnu23-attr-syntax-2.c: Compile with -fpermissive
due to expected implicit-int error.
* gcc.dg/gnu23-attr-syntax-3.c: New test. Copied from
gcc.dg/gnu23-attr-syntax-2.c, but expect an error.
* gcc.dg/pr105635.c: Build with -fpermissive due to implicit
int.
* gcc.dg/pr105635-2.c: New test. Copied from
gcc.dg/pr105635.c. Expect implicit int error.
* gcc.dg/noncompile/pr79758.c: Build with -fpermissive due to
implicit int.
* gcc.dg/noncompile/pr79758-2.c: New test. Copied from
gcc.dg/noncompile/pr79758.c. Expect implicit int error.
---
gcc/c/c-decl.cc | 20 +++++++++++---------
gcc/doc/invoke.texi | 7 +++++--
gcc/testsuite/gcc.dg/Wimplicit-int-1.c | 2 +-
gcc/testsuite/gcc.dg/Wimplicit-int-1a.c | 11 +++++++++++
gcc/testsuite/gcc.dg/Wimplicit-int-4.c | 2 +-
gcc/testsuite/gcc.dg/Wimplicit-int-4a.c | 11 +++++++++++
gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c | 2 +-
gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c | 17 +++++++++++++++++
gcc/testsuite/gcc.dg/noncompile/pr79758-2.c | 6 ++++++
gcc/testsuite/gcc.dg/noncompile/pr79758.c | 1 +
gcc/testsuite/gcc.dg/pr105635-2.c | 11 +++++++++++
gcc/testsuite/gcc.dg/pr105635.c | 2 +-
12 files changed, 77 insertions(+), 15 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-1a.c
create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-4a.c
create mode 100644 gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c
create mode 100644 gcc/testsuite/gcc.dg/noncompile/pr79758-2.c
create mode 100644 gcc/testsuite/gcc.dg/pr105635-2.c
diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc
index e8387bfa984..f787d213cfe 100644
--- a/gcc/c/c-decl.cc
+++ b/gcc/c/c-decl.cc
@@ -6577,16 +6577,18 @@ warn_defaults_to (location_t location, int opt, const char *gmsgid, ...)
{
diagnostic_info diagnostic;
va_list ap;
- rich_location richloc (line_table, location);
+ diagnostic_t kind;
va_start (ap, gmsgid);
- diagnostic_set_info (&diagnostic, gmsgid, &ap, &richloc,
- flag_isoc99 ? DK_PEDWARN : DK_WARNING);
- diagnostic.option_index = opt;
- diagnostic_report_diagnostic (global_dc, &diagnostic);
+ if (flag_isoc99 && !flag_pedantic_errors && opt)
+ kind = DK_PERMERROR;
+ else if (flag_isoc99)
+ kind = DK_PEDWARN;
+ else
+ kind = DK_WARNING;
+ emit_diagnostic_valist (kind, location, opt, gmsgid, &ap);
va_end (ap);
}
-
/* Returns the smallest location != UNKNOWN_LOCATION in LOCATIONS,
considering only those c_declspec_words found in LIST, which
must be terminated by cdw_number_of_elements. */
@@ -10635,9 +10637,9 @@ store_parm_decls_oldstyle (tree fndecl, const struct c_arg_info *arg_info)
warn_if_shadowing (decl);
if (flag_isoc99)
- pedwarn (DECL_SOURCE_LOCATION (decl),
- OPT_Wimplicit_int, "type of %qD defaults to %<int%>",
- decl);
+ pedpermerror (DECL_SOURCE_LOCATION (decl),
+ OPT_Wimplicit_int, "type of %qD defaults to %<int%>",
+ decl);
else
warning_at (DECL_SOURCE_LOCATION (decl),
OPT_Wmissing_parameter_type,
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 1a15af29f01..3a1b9b00f24 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -6180,6 +6180,7 @@ that have their own flag:
@gccoptlist{
-Wimplicit-function-declaration @r{(C)}
+-Wimplicit-int @r{(C)}
-Wint-conversion @r{(C)}
-Wnarrowing @r{(C++)}
}
@@ -6851,8 +6852,10 @@ This warning is enabled by @option{-Wall} in C++.
@opindex Wno-implicit-int
@item -Wno-implicit-int @r{(C and Objective-C only)}
This option controls warnings when a declaration does not specify a type.
-This warning is enabled by default in C99 and later dialects of C,
-and also by @option{-Wall}.
+This warning is enabled by default, as an error, in C99 and later
+dialects of C, and also by @option{-Wall}. The error can be downgraded
+to a warning using @option{-fpermissive} (along with certain other
+errors), or for this error alone, with @option{-Wno-error=implicit-int}.
This warning is upgraded to an error by @option{-pedantic-errors}.
diff --git a/gcc/testsuite/gcc.dg/Wimplicit-int-1.c b/gcc/testsuite/gcc.dg/Wimplicit-int-1.c
index 4a96e8f505d..fc7726c517e 100644
--- a/gcc/testsuite/gcc.dg/Wimplicit-int-1.c
+++ b/gcc/testsuite/gcc.dg/Wimplicit-int-1.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
static l; /* { dg-warning "type defaults to" } */
diff --git a/gcc/testsuite/gcc.dg/Wimplicit-int-1a.c b/gcc/testsuite/gcc.dg/Wimplicit-int-1a.c
new file mode 100644
index 00000000000..ef1835e2d3a
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wimplicit-int-1a.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+static l; /* { dg-error "type defaults to" } */
+
+foo (a) /* { dg-error "return type defaults to" } */
+/* { dg-error "type of .a. defaults to .int." "type" { target *-*-* } .-1 } */
+{
+ auto p; /* { dg-error "type defaults to" } */
+ typedef bar; /* { dg-error "type defaults to" } */
+}
diff --git a/gcc/testsuite/gcc.dg/Wimplicit-int-4.c b/gcc/testsuite/gcc.dg/Wimplicit-int-4.c
index c9c6e8e5e95..99c61a76ecf 100644
--- a/gcc/testsuite/gcc.dg/Wimplicit-int-4.c
+++ b/gcc/testsuite/gcc.dg/Wimplicit-int-4.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-Wno-implicit -Wimplicit-int" } */
+/* { dg-options "-fpermissive -Wno-implicit -Wimplicit-int" } */
static l; /* { dg-warning "type defaults to" } */
diff --git a/gcc/testsuite/gcc.dg/Wimplicit-int-4a.c b/gcc/testsuite/gcc.dg/Wimplicit-int-4a.c
new file mode 100644
index 00000000000..920a088f02b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wimplicit-int-4a.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options "-Wno-implicit -Wimplicit-int" } */
+
+static l; /* { dg-error "type defaults to" } */
+
+foo (a) /* { dg-error "return type defaults to" } */
+/* { dg-error "type of .a. defaults to .int." "type" { target *-*-* } .-1 } */
+{
+ auto p; /* { dg-error "type defaults to" } */
+ typedef bar; /* { dg-error "type defaults to" } */
+}
diff --git a/gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c b/gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c
index ba60f7a095a..8943534f2b2 100644
--- a/gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c
+++ b/gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c
@@ -1,7 +1,7 @@
/* Test C23 attribute syntax. Invalid uses of attributes with GNU C
features. */
/* { dg-do compile } */
-/* { dg-options "-std=gnu23 -w" } */
+/* { dg-options "-fpermissive -std=gnu23 -w" } */
/* Attributes cannot be used as prefix attributes on old-style
parameter declarations or on function declarators with identifier
diff --git a/gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c b/gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c
new file mode 100644
index 00000000000..d73d6a3cfa8
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c
@@ -0,0 +1,17 @@
+/* Test C23 attribute syntax. Invalid uses of attributes with GNU C
+ features. Non-permissive variant. */
+/* { dg-do compile } */
+/* { dg-options "-std=gnu23 -w" } */
+
+/* Attributes cannot be used as prefix attributes on old-style
+ parameter declarations or on function declarators with identifier
+ lists (removed from C23). */
+
+void (*f(a, b) [[]])() int a, b; { } /* { dg-error "expected" } */
+
+void f(x, y) int x; [[]] int y; { } /* { dg-error "expected" } */
+/* { dg-error "type of 'y' defaults to 'int'" "" { target *-*-* } .-1 } */
+
+/* Nonempty attributes cannot be used as postfix attributes with
+ __auto_type. */
+__auto_type [[gnu::no_such_attr]] x = 1; /* { dg-error "'__auto_type' followed by" } */
diff --git a/gcc/testsuite/gcc.dg/noncompile/pr79758-2.c b/gcc/testsuite/gcc.dg/noncompile/pr79758-2.c
new file mode 100644
index 00000000000..e6a27f952ef
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noncompile/pr79758-2.c
@@ -0,0 +1,6 @@
+/* PR c/79758 */
+/* { dg-do compile } */
+
+void fn1 (int[a]) { }; /* { dg-error "undeclared here" } */
+void fn1 (b) { }; /* { dg-error "redefinition" } */
+/* { dg-error "defaults to 'int'" "" { target *-*-* } .-1 } */
diff --git a/gcc/testsuite/gcc.dg/noncompile/pr79758.c b/gcc/testsuite/gcc.dg/noncompile/pr79758.c
index a31216068f0..e42a44380fa 100644
--- a/gcc/testsuite/gcc.dg/noncompile/pr79758.c
+++ b/gcc/testsuite/gcc.dg/noncompile/pr79758.c
@@ -1,5 +1,6 @@
/* PR c/79758 */
/* { dg-do compile } */
+/* { dg-additional-options "-fpermissive" } */
void fn1 (int[a]) { }; /* { dg-error "undeclared here" } */
void fn1 (b) { }; /* { dg-error "redefinition" } */
diff --git a/gcc/testsuite/gcc.dg/pr105635-2.c b/gcc/testsuite/gcc.dg/pr105635-2.c
new file mode 100644
index 00000000000..807eef0b7cd
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr105635-2.c
@@ -0,0 +1,11 @@
+/* PR c/105635 */
+/* { dg-do compile } */
+/* { dg-options "-Wall" } */
+
+void foo (int, int[*]); /* { dg-message "previous declaration of 'foo' with type" } */
+
+foo (int x, int y) /* { dg-error "return type defaults to 'int'" } */
+{ /* { dg-warning "conflicting types for 'foo'" "" { target *-*-* } .-1 } */
+ /* { dg-message "declared here" "" { target *-*-* } .-2 } */
+ return (x >= 0) != (y < 0); /* { dg-warning "'return' with a value, in function returning void" } */
+}
diff --git a/gcc/testsuite/gcc.dg/pr105635.c b/gcc/testsuite/gcc.dg/pr105635.c
index aa02f593bfa..b98ea1b3c3b 100644
--- a/gcc/testsuite/gcc.dg/pr105635.c
+++ b/gcc/testsuite/gcc.dg/pr105635.c
@@ -1,6 +1,6 @@
/* PR c/105635 */
/* { dg-do compile } */
-/* { dg-options "-Wall" } */
+/* { dg-options "-fpermissive -Wall" } */
void foo (int, int[*]); /* { dg-message "previous declaration of 'foo' with type" } */
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 5/6] c: Turn -Wreturn-mismatch into a pedpermerror
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
` (3 preceding siblings ...)
2023-11-13 13:11 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror Florian Weimer
@ 2023-11-13 13:11 ` Florian Weimer
2023-11-13 19:28 ` Jeff Law
2023-11-13 13:11 ` [PATCH 6/6] c: Turn -Wincompatible-pointer-types " Florian Weimer
2023-11-13 19:44 ` [PATCH 0/6] Turn some C warnings into errors by default Sam James
6 siblings, 1 reply; 29+ messages in thread
From: Florian Weimer @ 2023-11-13 13:11 UTC (permalink / raw)
To: gcc-patches
gcc/
* doc/invoke.texi (Warning Options): Document changes.
gcc/c/
* c-typeck.cc (c_finish_return): Issue a permerror
for mismatching pointers to builtins. For mismatching
other pointers, issue a pedpermerror.
gcc/testsuite/
* gcc.dg/20030906-1.c: Compile with -fpermissive due to
expected -Wreturn-mismatch error.
* gcc.dg/20030906-1a.c: New test. Copied from
gcc.dg/20030906-1.c. Expect the error.
* gcc.dg/20030906-2.c: Compile with -fpermissive due to
expected -Wreturn-mismatch error.
* gcc.dg/20030906-2a.c: New test. Copied from
gcc.dg/20030906-2.c. Expect the error.
* gcc.dg/Wreturn-mismatch-1.c: Compile with -fpermissive due to
expected -Wreturn-mismatch error.
* gcc.dg/Wreturn-mismatch-1a.c: New test. Copied from
gcc.dg/Wreturn-mismatch-1.c. Expect the error.
* gcc.dg/Wreturn-mismatch-2.c: Compile with -fpermissive due to
expected -Wreturn-mismatch error.
* gcc.dg/Wreturn-mismatch-2a.c: New test. Copied from
gcc.dg/Wreturn-mismatch-2.c. Expect the error.
* gcc.dg/diagnostic-range-bad-return.c: Compile with
-fpermissive due to expected -Wreturn-mismatch error.
* gcc.dg/diagnostic-range-bad-return-2.c: New test.
Copied from gcc.dg/diagnostic-range-bad-return.c. Expect the
error.
* gcc.dg/pr105635-2.c: Expect -Wreturn-mismatch error.
* gcc.dg/pr23075.c: Build with -fpermissive due to
expected -Wreturn-mismatch error.
* gcc.dg/pr23075-2.c: New test. Copied from gcc.dg/pr23075.c.
Expect the error.
* gcc.dg/pr29521.c: Compile with -fpermissive due to expected
-Wreturn-mismatch error.
* gcc.dg/pr29521-a.c: New test. Copied from gcc.dg/pr29521.c.
Expect error.
* gcc.dg/pr67730.c: Compile with -fpermissive due to expected
-Wreturn-mismatch error.
* gcc.dg/pr67730-a.c: New test. Copied from
gcc.dg/pr67730-a.c. Expect error.
* gcc.target/powerpc/conditional-return.c: Compile with
-fpermissive due to expected -Wreturn-mismatch error.
---
gcc/c/c-typeck.cc | 6 ++-
gcc/doc/invoke.texi | 6 ++-
gcc/testsuite/gcc.dg/20030906-1.c | 2 +-
gcc/testsuite/gcc.dg/20030906-1a.c | 21 ++++++++
gcc/testsuite/gcc.dg/20030906-2.c | 2 +-
gcc/testsuite/gcc.dg/20030906-2a.c | 21 ++++++++
gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c | 2 +-
gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c | 40 ++++++++++++++
gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c | 2 +-
gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c | 41 +++++++++++++++
.../gcc.dg/diagnostic-range-bad-return-2.c | 52 +++++++++++++++++++
.../gcc.dg/diagnostic-range-bad-return.c | 2 +-
gcc/testsuite/gcc.dg/pr105635-2.c | 2 +-
gcc/testsuite/gcc.dg/pr23075-2.c | 14 +++++
gcc/testsuite/gcc.dg/pr23075.c | 2 +-
gcc/testsuite/gcc.dg/pr29521-a.c | 15 ++++++
gcc/testsuite/gcc.dg/pr29521.c | 2 +-
gcc/testsuite/gcc.dg/pr67730-a.c | 11 ++++
gcc/testsuite/gcc.dg/pr67730.c | 2 +-
.../gcc.target/powerpc/conditional-return.c | 2 +-
20 files changed, 234 insertions(+), 13 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/20030906-1a.c
create mode 100644 gcc/testsuite/gcc.dg/20030906-2a.c
create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c
create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c
create mode 100644 gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c
create mode 100644 gcc/testsuite/gcc.dg/pr23075-2.c
create mode 100644 gcc/testsuite/gcc.dg/pr29521-a.c
create mode 100644 gcc/testsuite/gcc.dg/pr67730-a.c
diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc
index 9d7bdbb4523..be376758b82 100644
--- a/gcc/c/c-typeck.cc
+++ b/gcc/c/c-typeck.cc
@@ -11192,7 +11192,9 @@ c_finish_return (location_t loc, tree retval, tree origtype)
&& valtype != NULL_TREE && TREE_CODE (valtype) != VOID_TYPE)
{
no_warning = true;
- if (emit_diagnostic (flag_isoc99 ? DK_PEDWARN : DK_WARNING,
+ if (emit_diagnostic (flag_isoc99 && !flag_pedantic_errors
+ ? DK_PERMERROR
+ : flag_isoc99 ? DK_PEDWARN : DK_WARNING,
loc, OPT_Wreturn_mismatch,
"%<return%> with no value,"
" in function returning non-void"))
@@ -11205,7 +11207,7 @@ c_finish_return (location_t loc, tree retval, tree origtype)
current_function_returns_null = 1;
bool warned_here;
if (TREE_CODE (TREE_TYPE (retval)) != VOID_TYPE)
- warned_here = pedwarn
+ warned_here = pedpermerror
(xloc, OPT_Wreturn_mismatch,
"%<return%> with a value, in function returning void");
else
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 3a1b9b00f24..6635a136cd9 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -6183,6 +6183,7 @@ that have their own flag:
-Wimplicit-int @r{(C)}
-Wint-conversion @r{(C)}
-Wnarrowing @r{(C++)}
+-Wreturn-mismatch @r{(C)}
}
The @option{-fpermissive} option is the default for historic C language
@@ -7373,7 +7374,10 @@ Attempting to use the return value of a non-@code{void} function other
than @code{main} that flows off the end by reaching the closing curly
brace that terminates the function is undefined.
-This warning is specific to C and enabled by default.
+This warning is specific to C and enabled by default. In C99 and later
+language dialects, it is treated as an error. It an be downgraded
+to a warning using @option{-fpermissive} (along with other warnings),
+or for just this warning, with @option{-Wno-error=return-mismatch}.
@opindex Wreturn-type
@opindex Wno-return-type
diff --git a/gcc/testsuite/gcc.dg/20030906-1.c b/gcc/testsuite/gcc.dg/20030906-1.c
index c416f55ee75..6ba5b3d770a 100644
--- a/gcc/testsuite/gcc.dg/20030906-1.c
+++ b/gcc/testsuite/gcc.dg/20030906-1.c
@@ -2,7 +2,7 @@
Copyright (C) 2003 Free Software Foundation Inc. */
/* { dg-do compile } */
-/* { dg-options "-O -finline-functions -Wreturn-type" } */
+/* { dg-options "-fpermissive -O -finline-functions -Wreturn-type" } */
extern int i;
extern int foo (void);
diff --git a/gcc/testsuite/gcc.dg/20030906-1a.c b/gcc/testsuite/gcc.dg/20030906-1a.c
new file mode 100644
index 00000000000..46ca1771a4d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/20030906-1a.c
@@ -0,0 +1,21 @@
+/* Bug 9862 -- Spurious warnings with -finline-functions.
+ Copyright (C) 2003 Free Software Foundation Inc. */
+
+/* { dg-do compile } */
+/* { dg-options "-O -finline-functions -Wreturn-type" } */
+
+extern int i;
+extern int foo (void);
+extern int bar (void);
+
+int foo (void)
+{
+ if( i ) return 0;
+ else return 1;
+}
+
+int bar (void)
+{
+ if( i ) return; /* { dg-error "'return' with no value, in function returning non-void" } */
+ else return 1;
+}
diff --git a/gcc/testsuite/gcc.dg/20030906-2.c b/gcc/testsuite/gcc.dg/20030906-2.c
index 1191133e6a0..a85d91f46f3 100644
--- a/gcc/testsuite/gcc.dg/20030906-2.c
+++ b/gcc/testsuite/gcc.dg/20030906-2.c
@@ -2,7 +2,7 @@
Copyright (C) 2003 Free Software Foundation Inc. */
/* { dg-do compile } */
-/* { dg-options "-O -finline-functions -Wreturn-type" } */
+/* { dg-options "-fpermissive -O -finline-functions -Wreturn-type" } */
extern int i;
extern int foo (void);
diff --git a/gcc/testsuite/gcc.dg/20030906-2a.c b/gcc/testsuite/gcc.dg/20030906-2a.c
new file mode 100644
index 00000000000..a6ffbacb46d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/20030906-2a.c
@@ -0,0 +1,21 @@
+/* Bug 9862 -- Spurious warnings with -finline-functions.
+ Copyright (C) 2003 Free Software Foundation Inc. */
+
+/* { dg-do compile } */
+/* { dg-options "-O -finline-functions -Wreturn-type" } */
+
+extern int i;
+extern int foo (void);
+extern int bar (void);
+
+int foo (void)
+{
+ if( i ) return; /* { dg-error "'return' with no value, in function returning non-void" } */
+ else return 1;
+}
+
+int bar (void)
+{
+ if( i ) return 0;
+ else return 1;
+}
diff --git a/gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c b/gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c
index 3bad847ecf7..aef6782cbeb 100644
--- a/gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c
+++ b/gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
void f1 (void);
diff --git a/gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c b/gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c
new file mode 100644
index 00000000000..70c7c9ddb86
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c
@@ -0,0 +1,40 @@
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+void f1 (void);
+
+int
+f2 (void)
+{
+ f1 ();
+}
+
+static inline int
+f3 (void)
+{
+ f1 ();
+}
+
+void
+f4 (void)
+{
+ return 1; /* { dg-error "'return' with a value\[^\n\r\]*-Wreturn-mismatch" } */
+}
+
+void
+f5 (void)
+{
+ return f1 (); /* { dg-bogus "ISO C" } */
+}
+
+int
+f6 (void)
+{
+ return; /* { dg-error "'return' with no value\[^\n\r\]*-Wreturn-mismatch" } */
+}
+
+int
+f7 (void)
+{
+ return f1 (); /* { dg-error "void value not ignored as it ought to be" } */
+}
diff --git a/gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c b/gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c
index 49eb5a5a95c..08811024b7e 100644
--- a/gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c
+++ b/gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-Wall" } */
+/* { dg-options "-fpermissive -Wall" } */
void f1 (void);
diff --git a/gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c b/gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c
new file mode 100644
index 00000000000..836651ed925
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c
@@ -0,0 +1,41 @@
+/* { dg-do compile } */
+/* { dg-options "-Wall" } */
+
+void f1 (void);
+
+int
+f2 (void)
+{
+ f1 ();
+} /* { dg-warning "control reaches end of non-void\[^\n\r\]*-Wreturn-type" } */
+
+static inline int
+f3 (void)
+{
+ f1 ();
+} /* { dg-warning "no return statement in function\[^\n\r\]*-Wreturn-type" } */
+
+void
+f4 (void)
+{
+ return 1; /* { dg-error "with a value,\[^\n\r\]*-Wreturn-mismatch" } */
+}
+
+void
+f5 (void)
+{
+ return f1 ();
+}
+
+int
+f6 (void)
+{
+ return; /* { dg-error "with no value,\[^\n\r\]*Wreturn-mismatch" } */
+}
+
+int
+f7 (void)
+{
+ return f1 (); /* { dg-error "void value not ignored as it ought to be" } */
+} /* { dg-warning "control reaches end of non-void\[^\n\r\]*-Wreturn-type" } */
+
diff --git a/gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c b/gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c
new file mode 100644
index 00000000000..2fe8d341dba
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c
@@ -0,0 +1,52 @@
+/* { dg-options "-fdiagnostics-show-caret -Wreturn-local-addr" } */
+
+int *address_of_local (void)
+{
+ int some_local;
+ return &some_local; /* { dg-warning "function returns address of local variable" } */
+/* { dg-begin-multiline-output "" }
+ return &some_local;
+ ^~~~~~~~~~~
+ { dg-end-multiline-output "" } */
+}
+
+void surplus_return_when_void_1 (void)
+{
+ return 500; /* { dg-error "'return' with a value, in function returning void" } */
+/* { dg-begin-multiline-output "" }
+ return 500;
+ ^~~
+ { dg-end-multiline-output "" } */
+/* { dg-begin-multiline-output "" }
+ void surplus_return_when_void_1 (void)
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~
+ { dg-end-multiline-output "" } */
+}
+
+void surplus_return_when_void_2 (int i, int j)
+{
+ return i * j; /* { dg-error "'return' with a value, in function returning void" } */
+/* { dg-begin-multiline-output "" }
+ return i * j;
+ ~~^~~
+ { dg-end-multiline-output "" } */
+/* { dg-begin-multiline-output "" }
+ void surplus_return_when_void_2 (int i, int j)
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~
+ { dg-end-multiline-output "" } */
+}
+
+int missing_return_value (void)
+{
+ return; /* { dg-error "'return' with no value, in function returning non-void" } */
+/* { dg-begin-multiline-output "" }
+ return;
+ ^~~~~~
+ { dg-end-multiline-output "" } */
+/* { dg-begin-multiline-output "" }
+ int missing_return_value (void)
+ ^~~~~~~~~~~~~~~~~~~~
+ { dg-end-multiline-output "" } */
+/* TODO: ideally we'd underline the return type i.e. "int", but that
+ location isn't captured. */
+}
diff --git a/gcc/testsuite/gcc.dg/diagnostic-range-bad-return.c b/gcc/testsuite/gcc.dg/diagnostic-range-bad-return.c
index 063fdf1f636..b74481b870c 100644
--- a/gcc/testsuite/gcc.dg/diagnostic-range-bad-return.c
+++ b/gcc/testsuite/gcc.dg/diagnostic-range-bad-return.c
@@ -1,4 +1,4 @@
-/* { dg-options "-fdiagnostics-show-caret -Wreturn-local-addr" } */
+/* { dg-options "-fpermissive -fdiagnostics-show-caret -Wreturn-local-addr" } */
int *address_of_local (void)
{
diff --git a/gcc/testsuite/gcc.dg/pr105635-2.c b/gcc/testsuite/gcc.dg/pr105635-2.c
index 807eef0b7cd..019dbc7e557 100644
--- a/gcc/testsuite/gcc.dg/pr105635-2.c
+++ b/gcc/testsuite/gcc.dg/pr105635-2.c
@@ -7,5 +7,5 @@ void foo (int, int[*]); /* { dg-message "previous declaration of 'foo' with type
foo (int x, int y) /* { dg-error "return type defaults to 'int'" } */
{ /* { dg-warning "conflicting types for 'foo'" "" { target *-*-* } .-1 } */
/* { dg-message "declared here" "" { target *-*-* } .-2 } */
- return (x >= 0) != (y < 0); /* { dg-warning "'return' with a value, in function returning void" } */
+ return (x >= 0) != (y < 0); /* { dg-error "'return' with a value, in function returning void" } */
}
diff --git a/gcc/testsuite/gcc.dg/pr23075-2.c b/gcc/testsuite/gcc.dg/pr23075-2.c
new file mode 100644
index 00000000000..0702ddf1a66
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr23075-2.c
@@ -0,0 +1,14 @@
+/* PR c/23075 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -Wreturn-type" } */
+
+int
+foo (void)
+{
+ return; /* { dg-error "with no value" } */
+} /* { dg-bogus "control reaches end" } */
+
+int
+bar (void)
+{
+} /* { dg-warning "control reaches end" } */
diff --git a/gcc/testsuite/gcc.dg/pr23075.c b/gcc/testsuite/gcc.dg/pr23075.c
index 2d85fb0650f..28baf41006a 100644
--- a/gcc/testsuite/gcc.dg/pr23075.c
+++ b/gcc/testsuite/gcc.dg/pr23075.c
@@ -1,6 +1,6 @@
/* PR c/23075 */
/* { dg-do compile } */
-/* { dg-options "-O2 -Wreturn-type" } */
+/* { dg-options "-O2 -fpermissive -Wreturn-type" } */
int
foo (void)
diff --git a/gcc/testsuite/gcc.dg/pr29521-a.c b/gcc/testsuite/gcc.dg/pr29521-a.c
new file mode 100644
index 00000000000..2c6a48b7e30
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr29521-a.c
@@ -0,0 +1,15 @@
+/* PR 29521 : warning for return with expression in function returning void */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+void func (void) { }
+
+void func2 (void)
+{
+ return func ();
+}
+
+void func3 (void)
+{
+ return 1; /* { dg-error "'return' with a value" } */
+}
diff --git a/gcc/testsuite/gcc.dg/pr29521.c b/gcc/testsuite/gcc.dg/pr29521.c
index b6fb535fab7..cd431514ed2 100644
--- a/gcc/testsuite/gcc.dg/pr29521.c
+++ b/gcc/testsuite/gcc.dg/pr29521.c
@@ -1,6 +1,6 @@
/* PR 29521 : warning for return with expression in function returning void */
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
void func (void) { }
diff --git a/gcc/testsuite/gcc.dg/pr67730-a.c b/gcc/testsuite/gcc.dg/pr67730-a.c
new file mode 100644
index 00000000000..08737cc9811
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr67730-a.c
@@ -0,0 +1,11 @@
+/* PR c/67730 */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+#include <stddef.h>
+
+void
+fn1 (void)
+{
+ return NULL; /* { dg-error "10:.return. with a value" } */
+}
diff --git a/gcc/testsuite/gcc.dg/pr67730.c b/gcc/testsuite/gcc.dg/pr67730.c
index 54d73a62cf8..cc51858c531 100644
--- a/gcc/testsuite/gcc.dg/pr67730.c
+++ b/gcc/testsuite/gcc.dg/pr67730.c
@@ -1,6 +1,6 @@
/* PR c/67730 */
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
#include <stddef.h>
diff --git a/gcc/testsuite/gcc.target/powerpc/conditional-return.c b/gcc/testsuite/gcc.target/powerpc/conditional-return.c
index 6b3ef5f52ca..c6491216752 100644
--- a/gcc/testsuite/gcc.target/powerpc/conditional-return.c
+++ b/gcc/testsuite/gcc.target/powerpc/conditional-return.c
@@ -1,7 +1,7 @@
/* Check that a conditional return is used. */
/* { dg-do compile } */
-/* { dg-options "-O2 -w" } */
+/* { dg-options "-O2 -fpermissive -w" } */
/* { dg-final { scan-assembler {\mbeqlr\M} } } */
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 6/6] c: Turn -Wincompatible-pointer-types into a pedpermerror
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
` (4 preceding siblings ...)
2023-11-13 13:11 ` [PATCH 5/6] c: Turn -Wreturn-mismatch into a pedpermerror Florian Weimer
@ 2023-11-13 13:11 ` Florian Weimer
2023-11-13 19:30 ` Jeff Law
2023-11-13 19:44 ` [PATCH 0/6] Turn some C warnings into errors by default Sam James
6 siblings, 1 reply; 29+ messages in thread
From: Florian Weimer @ 2023-11-13 13:11 UTC (permalink / raw)
To: gcc-patches
gcc/
* doc/invoke.texi (Warning Options): Document changes.
gcc/c/
* c-typeck.cc (build_conditional_expr): Use pedpermerror-
equivalent for pointer type mismatches in conditional
expression.
(convert_for_assignment): Use pedpermerror and
pedpermerror_init for OPT_Wincompatible_pointer_types
warnings.
gcc/testsuite/
* gcc.dg/Wincompatible-pointer-types-2.c: Compile with
-fpermissive due to expected errors.
* gcc.dg/Wincompatible-pointer-types-4.c: Likewise.
* gcc.dg/Wincompatible-pointer-types-5.c: New test. Copied
from gcc.dg/Wincompatible-pointer-types-2.c. Expect errors.
* gcc.dg/Wincompatible-pointer-types-6.c: New test. Copied
from gcc.dg/Wincompatible-pointer-types-4.c. Expect errors.
* gcc.dg/anon-struct-11.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/anon-struct-11a.c: New test. Copied from
gcc.dg/anon-struct-11.c. Expect errors.
* gcc.dg/anon-struct-13.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/anon-struct-13a.c: New test. Copied from
gcc.dg/anon-struct-13.c. Expect errors.
* gcc.dg/builtin-arith-overflow-4.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/builtin-arith-overflow-4a.c: New test. Copied from
gcc.dg/builtin-arith-overflow-4.c. Expect errors.
* gcc.dg/c23-qual-4.c: Expect -Wincompatible-pointer-types errors.
* gcc.dg/dfp/composite-type.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/dfp/composite-type-2.c: New test. Copied from
gcc.dg/dfp/composite-type.c. Expect errors.
* gcc.dg/diag-aka-1.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/diag-aka-1a.c: New test. Copied from gcc.dg/diag-aka-1a.c.
Expect errors.
* gcc.dg/enum-compat-1.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/enum-compat-2.c: New test. Copied from
gcc.dg/enum-compat-1.c. Expect errors.
* gcc.dg/func-ptr-conv-1.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/func-ptr-conv-2.c: New test. Copied from
gcc.dg/func-ptr-conv-1.c. Expect errors.
* gcc.dg/init-bad-7.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/init-bad-7a.c: New test. Copied from gcc.dg/init-bad-7.c.
Expect errors.
* gcc.dg/noncompile/incomplete-3.c (foo): Expect
-Wincompatible-pointer-types error.
* gcc.dg/param-type-mismatch-2.c (test8): Likewise.
* gcc.dg/pointer-array-atomic.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/pointer-array-atomic-2.c: New test. Copied from
gcc.dg/pointer-array-atomic.c. Expect errors.
* gcc.dg/pointer-array-quals-1.c (test): Expect
-Wincompatible-pointer-types errors.
* gcc.dg/transparent-union-1.c: Compile with -fpermissive
due to expected errors.
* gcc.dg/transparent-union-1a.c: New test. Copied from
gcc.dg/transparent-union-1.c. Expect errors.
* gcc.target/aarch64/acle/memtag_2a.c
(test_memtag_warning_return_qualifier): Expect additional
errors.
* gcc.target/aarch64/sve/acle/general-c/load_2.c (f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/sizeless-1.c (f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/sizeless-2.c (f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_1.c (f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_2.c (f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
(f1): Likewise.
* gcc.target/aarch64/sve/acle/general/attributes_7.c
(f1): Likewise.
* gcc.target/i386/sse2-bfloat16-scalar-typecheck.c (footest):
Expect -Wincompatible-pointer-types errors.
* gcc.target/i386/vect-bfloat16-typecheck_1.c (footest): Likewise.
* gcc.target/i386/vect-bfloat16-typecheck_2.c (footest): Likewise.
---
gcc/c/c-typeck.cc | 60 ++++++----
gcc/doc/invoke.texi | 6 +
.../gcc.dg/Wincompatible-pointer-types-2.c | 2 +-
.../gcc.dg/Wincompatible-pointer-types-4.c | 2 +-
.../gcc.dg/Wincompatible-pointer-types-5.c | 10 ++
.../gcc.dg/Wincompatible-pointer-types-6.c | 10 ++
gcc/testsuite/gcc.dg/anon-struct-11.c | 5 +-
gcc/testsuite/gcc.dg/anon-struct-11a.c | 111 ++++++++++++++++++
gcc/testsuite/gcc.dg/anon-struct-13.c | 2 +-
gcc/testsuite/gcc.dg/anon-struct-13a.c | 76 ++++++++++++
.../gcc.dg/builtin-arith-overflow-4.c | 2 +-
.../gcc.dg/builtin-arith-overflow-4a.c | 43 +++++++
gcc/testsuite/gcc.dg/c23-qual-4.c | 6 +-
gcc/testsuite/gcc.dg/dfp/composite-type-2.c | 58 +++++++++
gcc/testsuite/gcc.dg/dfp/composite-type.c | 2 +-
gcc/testsuite/gcc.dg/diag-aka-1.c | 2 +-
gcc/testsuite/gcc.dg/diag-aka-1a.c | 29 +++++
gcc/testsuite/gcc.dg/enum-compat-1.c | 2 +-
gcc/testsuite/gcc.dg/enum-compat-2.c | 32 +++++
gcc/testsuite/gcc.dg/func-ptr-conv-1.c | 2 +-
gcc/testsuite/gcc.dg/func-ptr-conv-2.c | 56 +++++++++
gcc/testsuite/gcc.dg/init-bad-7.c | 2 +-
gcc/testsuite/gcc.dg/init-bad-7a.c | 12 ++
.../gcc.dg/noncompile/incomplete-3.c | 2 +-
gcc/testsuite/gcc.dg/param-type-mismatch-2.c | 2 +-
gcc/testsuite/gcc.dg/pointer-array-atomic-2.c | 60 ++++++++++
gcc/testsuite/gcc.dg/pointer-array-atomic.c | 2 +-
gcc/testsuite/gcc.dg/pointer-array-quals-1.c | 6 +-
gcc/testsuite/gcc.dg/transparent-union-1.c | 2 +-
gcc/testsuite/gcc.dg/transparent-union-1a.c | 85 ++++++++++++++
.../gcc.target/aarch64/acle/memtag_2a.c | 6 +-
.../aarch64/sve/acle/general-c/load_2.c | 4 +-
.../acle/general-c/load_ext_gather_offset_1.c | 2 +-
.../acle/general-c/load_ext_gather_offset_2.c | 2 +-
.../acle/general-c/load_ext_gather_offset_3.c | 2 +-
.../acle/general-c/load_ext_gather_offset_4.c | 2 +-
.../acle/general-c/load_ext_gather_offset_5.c | 2 +-
.../load_ext_gather_offset_restricted_1.c | 2 +-
.../load_ext_gather_offset_restricted_2.c | 2 +-
.../load_ext_gather_offset_restricted_3.c | 2 +-
.../load_ext_gather_offset_restricted_4.c | 2 +-
.../aarch64/sve/acle/general-c/sizeless-1.c | 8 +-
.../aarch64/sve/acle/general-c/sizeless-2.c | 8 +-
.../aarch64/sve/acle/general-c/store_1.c | 8 +-
.../aarch64/sve/acle/general-c/store_2.c | 8 +-
.../acle/general-c/store_scatter_index_1.c | 6 +-
.../store_scatter_index_restricted_1.c | 6 +-
.../acle/general-c/store_scatter_offset_2.c | 6 +-
.../store_scatter_offset_restricted_1.c | 6 +-
.../aarch64/sve/acle/general/attributes_7.c | 28 ++---
.../i386/sse2-bfloat16-scalar-typecheck.c | 4 +-
.../i386/vect-bfloat16-typecheck_1.c | 4 +-
.../i386/vect-bfloat16-typecheck_2.c | 4 +-
53 files changed, 705 insertions(+), 110 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c
create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-6.c
create mode 100644 gcc/testsuite/gcc.dg/anon-struct-11a.c
create mode 100644 gcc/testsuite/gcc.dg/anon-struct-13a.c
create mode 100644 gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c
create mode 100644 gcc/testsuite/gcc.dg/dfp/composite-type-2.c
create mode 100644 gcc/testsuite/gcc.dg/diag-aka-1a.c
create mode 100644 gcc/testsuite/gcc.dg/enum-compat-2.c
create mode 100644 gcc/testsuite/gcc.dg/func-ptr-conv-2.c
create mode 100644 gcc/testsuite/gcc.dg/init-bad-7a.c
create mode 100644 gcc/testsuite/gcc.dg/pointer-array-atomic-2.c
create mode 100644 gcc/testsuite/gcc.dg/transparent-union-1a.c
diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc
index be376758b82..f25770827ff 100644
--- a/gcc/c/c-typeck.cc
+++ b/gcc/c/c-typeck.cc
@@ -5420,7 +5420,13 @@ build_conditional_expr (location_t colon_loc, tree ifexp, bool ifexp_bcp,
else
{
int qual = ENCODE_QUAL_ADDR_SPACE (as_common);
- if (emit_diagnostic (bltin1 && bltin2 ? DK_WARNING : DK_PEDWARN,
+ /* Historically, builtin/builtin pointer conflicts have not
+ been covered by -pedantic-errors. It is still possible
+ to turn of the permissive error in -pedantic-errors mode
+ using -Wno-error=incompatible_pointer_types. */
+ if (emit_diagnostic (bltin1 && bltin2 ? DK_PERMERROR
+ : flag_pedantic_errors ? DK_PEDWARN
+ : DK_PERMERROR,
colon_loc, OPT_Wincompatible_pointer_types,
"pointer type mismatch "
"in conditional expression"))
@@ -7560,46 +7566,48 @@ convert_for_assignment (location_t location, location_t expr_loc, tree type,
auto_diagnostic_group d;
range_label_for_type_mismatch rhs_label (rhstype, type);
gcc_rich_location richloc (expr_loc, &rhs_label);
- if (pedwarn (&richloc, OPT_Wincompatible_pointer_types,
- "passing argument %d of %qE from incompatible "
- "pointer type", parmnum, rname))
+ if (pedpermerror (&richloc, OPT_Wincompatible_pointer_types,
+ "passing argument %d of %qE from "
+ "incompatible pointer type",
+ parmnum, rname))
inform_for_arg (fundecl, expr_loc, parmnum, type, rhstype);
}
break;
case ic_assign:
if (bltin)
- pedwarn (location, OPT_Wincompatible_pointer_types,
- "assignment to %qT from pointer to "
- "%qD with incompatible type %qT",
- type, bltin, rhstype);
+ pedpermerror (location, OPT_Wincompatible_pointer_types,
+ "assignment to %qT from pointer to "
+ "%qD with incompatible type %qT",
+ type, bltin, rhstype);
else
- pedwarn (location, OPT_Wincompatible_pointer_types,
- "assignment to %qT from incompatible pointer type %qT",
- type, rhstype);
+ pedpermerror (location, OPT_Wincompatible_pointer_types,
+ "assignment to %qT from incompatible pointer "
+ "type %qT",
+ type, rhstype);
break;
case ic_init:
case ic_init_const:
if (bltin)
- pedwarn_init (location, OPT_Wincompatible_pointer_types,
- "initialization of %qT from pointer to "
- "%qD with incompatible type %qT",
- type, bltin, rhstype);
+ pedpermerror_init (location, OPT_Wincompatible_pointer_types,
+ "initialization of %qT from pointer to "
+ "%qD with incompatible type %qT",
+ type, bltin, rhstype);
else
- pedwarn_init (location, OPT_Wincompatible_pointer_types,
- "initialization of %qT from incompatible "
- "pointer type %qT",
- type, rhstype);
+ pedpermerror_init (location, OPT_Wincompatible_pointer_types,
+ "initialization of %qT from incompatible "
+ "pointer type %qT",
+ type, rhstype);
break;
case ic_return:
if (bltin)
- pedwarn (location, OPT_Wincompatible_pointer_types,
- "returning pointer to %qD of type %qT from "
- "a function with incompatible type %qT",
- bltin, rhstype, type);
+ pedpermerror (location, OPT_Wincompatible_pointer_types,
+ "returning pointer to %qD of type %qT from "
+ "a function with incompatible type %qT",
+ bltin, rhstype, type);
else
- pedwarn (location, OPT_Wincompatible_pointer_types,
- "returning %qT from a function with incompatible "
- "return type %qT", rhstype, type);
+ pedpermerror (location, OPT_Wincompatible_pointer_types,
+ "returning %qT from a function with incompatible "
+ "return type %qT", rhstype, type);
break;
default:
gcc_unreachable ();
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 6635a136cd9..49fab5799d0 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -6181,6 +6181,7 @@ that have their own flag:
@gccoptlist{
-Wimplicit-function-declaration @r{(C)}
-Wimplicit-int @r{(C)}
+-Wincompatible-pointer-types @r{(C)}
-Wint-conversion @r{(C)}
-Wnarrowing @r{(C++)}
-Wreturn-mismatch @r{(C)}
@@ -8547,6 +8548,11 @@ types. This warning is for cases not covered by @option{-Wno-pointer-sign},
which warns for pointer argument passing or assignment with different
signedness.
+By default, in C99 and later dialects of C, GCC treats this issue as an
+error. The error can be downgraded to a warning using
+@option{-fpermissive} (along with certain other errors), or for this
+error alone, with @option{-Wno-error=incompatible-pointer-types}.
+
This warning is upgraded to an error by @option{-pedantic-errors}.
@opindex Wno-int-conversion
diff --git a/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-2.c b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-2.c
index 19276bbcfba..bbf983c1536 100644
--- a/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-2.c
+++ b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-2.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
void *
f1 (int flag, int *a, long *b)
diff --git a/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-4.c b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-4.c
index c62a7e02bb9..55a9f67b2b1 100644
--- a/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-4.c
+++ b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-4.c
@@ -4,7 +4,7 @@
void *
f1 (int flag)
{
- return flag ? __builtin_memcpy : __builtin_memcmp; /* { dg-warning "pointer type mismatch in conditional expression \\\[-Wincompatible-pointer-types\\\]" } */
+ return flag ? __builtin_memcpy : __builtin_memcmp; /* { dg-error "pointer type mismatch in conditional expression \\\[-Wincompatible-pointer-types\\\]" } */
/* { dg-note "first expression has type 'void \\* \\(\\*\\)\\(void \\*," "" { target *-*-* } .-1 } */
/* { dg-note "second expression has type 'int \\(\\*\\)\\(const void \\*," "" { target *-*-* } .-2 } */
}
diff --git a/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c
new file mode 100644
index 00000000000..dcbfa4767de
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+void *
+f1 (int flag, int *a, long *b)
+{
+ return flag ? a : b; /* { dg-error "pointer type mismatch in conditional expression \\\[-Wincompatible-pointer-types\\\]" } */
+ /* { dg-note "first expression has type 'int \\*'" "" { target *-*-* } .-1 } */
+ /* { dg-note "second expression has type 'long int \\*'" "" { target *-*-* } .-2 } */
+}
diff --git a/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-6.c b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-6.c
new file mode 100644
index 00000000000..15b37e447ff
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wincompatible-pointer-types-6.c
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+/* { dg-options "-std=c90 -pedantic-errors -Wno-error=incompatible-pointer-types" } */
+
+void *
+f1 (int flag)
+{
+ return flag ? __builtin_memcpy : __builtin_memcmp; /* { dg-warning "pointer type mismatch in conditional expression \\\[-Wincompatible-pointer-types\\\]" } */
+ /* { dg-note "first expression has type 'void \\* \\(\\*\\)\\(void \\*," "" { target *-*-* } .-1 } */
+ /* { dg-note "second expression has type 'int \\(\\*\\)\\(const void \\*," "" { target *-*-* } .-2 } */
+}
diff --git a/gcc/testsuite/gcc.dg/anon-struct-11.c b/gcc/testsuite/gcc.dg/anon-struct-11.c
index c2f85fc24e4..622fb7cacc6 100644
--- a/gcc/testsuite/gcc.dg/anon-struct-11.c
+++ b/gcc/testsuite/gcc.dg/anon-struct-11.c
@@ -1,8 +1,7 @@
/* { dg-do compile } */
-/* No special options--in particular, turn off the default
- -pedantic-errors option. */
-/* { dg-options "" } */
+/* Also turn off the default -pedantic-errors option. */
+/* { dg-options "-fpermissive" } */
/* When not using -fplan9-extensions, we don't support automatic
conversion of pointer types, and we don't support referring to a
diff --git a/gcc/testsuite/gcc.dg/anon-struct-11a.c b/gcc/testsuite/gcc.dg/anon-struct-11a.c
new file mode 100644
index 00000000000..9ee3bb63ebf
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/anon-struct-11a.c
@@ -0,0 +1,111 @@
+/* { dg-do compile } */
+
+/* No special options--in particular, turn off the default
+ -pedantic-errors option. */
+/* { dg-options "" } */
+
+/* When not using -fplan9-extensions, we don't support automatic
+ conversion of pointer types, and we don't support referring to a
+ typedef name directly. */
+
+extern void exit (int);
+extern void abort (void);
+
+struct A { char a; };
+
+struct B {
+ char b;
+ struct A; /* { dg-warning "does not declare anything" } */
+ char c;
+};
+
+void
+f1 (struct A *p) /* { dg-message "expected" } */
+{
+ p->a = 1;
+}
+
+void
+test1 (void)
+{
+ struct B b;
+ struct A *p;
+
+ b.b = 2;
+ b.c = 3;
+ f1 (&b); /* { dg-error "incompatible pointer type" } */
+ if (b.a != 1) /* { dg-error "no member" } */
+ abort ();
+ if (b.b != 2 || b.c != 3)
+ abort ();
+ p = &b; /* { dg-error "incompatible pointer type" } */
+ if (p->a != 1)
+ abort ();
+}
+
+typedef struct { char d; } D;
+
+struct E {
+ char b;
+ struct F { char f; }; /* { dg-warning "does not declare anything" } */
+ char c;
+ union {
+ D; /* { dg-warning "does not declare anything" } */
+ };
+ char e;
+};
+
+void
+f2 (struct F *p) /* { dg-message "expected" } */
+{
+ p->f = 6;
+}
+
+void
+f3 (D *p) /* { dg-message "expected" } */
+{
+ p->d = 4;
+}
+
+void
+f4 (D d)
+{
+}
+
+void
+test2 (void)
+{
+ struct E e;
+ struct F *pf;
+ D *pd;
+ D d;
+
+ e.b = 2;
+ e.c = 3;
+ e.e = 5;
+ f2 (&e); /* { dg-error "incompatible pointer type" } */
+ f3 (&e); /* { dg-error "incompatible pointer type" } */
+ if (e.d != 4) /* { dg-error "no member" } */
+ abort ();
+ if (e.f != 6) /* { dg-error "no member" } */
+ abort ();
+ if (e.b != 2 || e.c != 3 || e.e != 5)
+ abort ();
+ pf = &e; /* { dg-error "incompatible pointer type" } */
+ if (pf->f != 6)
+ abort ();
+ pd = &e; /* { dg-error "incompatible pointer type" } */
+ if (pd->d != 4)
+ abort ();
+ d = e.D; /* { dg-error "no member" } */
+ f3 (&e.D); /* { dg-error "no member" } */
+ f4 (e.D); /* { dg-error "no member" } */
+}
+
+int
+main ()
+{
+ test1 ();
+ test2 ();
+ exit (0);
+}
diff --git a/gcc/testsuite/gcc.dg/anon-struct-13.c b/gcc/testsuite/gcc.dg/anon-struct-13.c
index 6a508141bac..de478b9684b 100644
--- a/gcc/testsuite/gcc.dg/anon-struct-13.c
+++ b/gcc/testsuite/gcc.dg/anon-struct-13.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-fplan9-extensions" } */
+/* { dg-options "-fpermissive -fplan9-extensions" } */
/* Test for ambiguity when using the Plan 9 extensions. */
diff --git a/gcc/testsuite/gcc.dg/anon-struct-13a.c b/gcc/testsuite/gcc.dg/anon-struct-13a.c
new file mode 100644
index 00000000000..9e6c5d96595
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/anon-struct-13a.c
@@ -0,0 +1,76 @@
+/* { dg-do compile } */
+/* { dg-options "-fplan9-extensions" } */
+
+/* Test for ambiguity when using the Plan 9 extensions. */
+
+struct A {
+ char a; /* { dg-error "duplicate member" } */
+};
+
+struct B
+{
+ struct A;
+ struct A;
+};
+
+char
+f1 (struct B *p)
+{
+ return p->a; /* { dg-error "no member" } */
+}
+
+void
+f2 (struct A *p) /* { dg-message "expected" } */
+{
+}
+
+void
+f3 (struct B *p)
+{
+ f2 (p); /* { dg-error "incompatible pointer type" } */
+}
+
+struct C
+{
+ char c; /* { dg-error "duplicate member" } */
+};
+
+struct D
+{
+ struct C;
+};
+
+struct E
+{
+ struct C;
+ struct D;
+};
+
+char
+f4 (struct E *p)
+{
+ return p->c; /* { dg-error "no member" } */
+}
+
+void
+f6 (struct C *p) /* { dg-message "expected" } */
+{
+}
+
+void
+f7 (struct E *p)
+{
+ f6 (p); /* { dg-error "incompatible pointer type" } */
+}
+
+struct A
+f8 (struct B *p)
+{
+ return p->A; /* { dg-error "no member" } */
+}
+
+struct C
+f9 (struct E *p)
+{
+ return p->C; /* { dg-error "no member" } */
+}
diff --git a/gcc/testsuite/gcc.dg/builtin-arith-overflow-4.c b/gcc/testsuite/gcc.dg/builtin-arith-overflow-4.c
index ab7d82a8d83..4c2c89ff616 100644
--- a/gcc/testsuite/gcc.dg/builtin-arith-overflow-4.c
+++ b/gcc/testsuite/gcc.dg/builtin-arith-overflow-4.c
@@ -1,6 +1,6 @@
/* PR c/90628 */
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
_Atomic int a = 1, b = 2, c = 3;
_Atomic long d = 4, e = 5, f = 6;
diff --git a/gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c b/gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c
new file mode 100644
index 00000000000..c021cabdc24
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c
@@ -0,0 +1,43 @@
+/* PR c/90628 */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+_Atomic int a = 1, b = 2, c = 3;
+_Atomic long d = 4, e = 5, f = 6;
+_Atomic long long g = 7, h = 8, i = 9;
+
+void
+f1 ()
+{
+ __builtin_add_overflow (a, b, &c); /* { dg-error "argument 3 in call to function '__builtin_add_overflow' has pointer to '_Atomic' type" } */
+}
+
+void
+f2 ()
+{
+ __builtin_sub_overflow (d, e, &f); /* { dg-error "argument 3 in call to function '__builtin_sub_overflow' has pointer to '_Atomic' type" } */
+}
+
+void
+f3 ()
+{
+ __builtin_mul_overflow (g, h, &i); /* { dg-error "argument 3 in call to function '__builtin_mul_overflow' has pointer to '_Atomic' type" } */
+}
+
+void
+f4 ()
+{
+ __builtin_sadd_overflow (a, b, &c); /* { dg-error "passing argument 3 of '__builtin_sadd_overflow' from incompatible pointer type" } */
+}
+
+void
+f5 ()
+{
+ __builtin_ssubl_overflow (d, e, &f); /* { dg-error "passing argument 3 of '__builtin_ssubl_overflow' from incompatible pointer type" } */
+}
+
+void
+f6 ()
+{
+ __builtin_smulll_overflow (g, h, &i); /* { dg-error "passing argument 3 of '__builtin_smulll_overflow' from incompatible pointer type" } */
+}
diff --git a/gcc/testsuite/gcc.dg/c23-qual-4.c b/gcc/testsuite/gcc.dg/c23-qual-4.c
index 8a7a9f2be35..a8538de74e8 100644
--- a/gcc/testsuite/gcc.dg/c23-qual-4.c
+++ b/gcc/testsuite/gcc.dg/c23-qual-4.c
@@ -83,9 +83,9 @@ void test(void)
(void)(1 ? x0 : z0);
(void)(1 ? x1 : z1);
(void)(1 ? x2 : z2);
- (void)(1 ? x0 : x1); /* { dg-warning "pointer type mismatch in conditional expression" } */
- (void)(1 ? x1 : x2); /* { dg-warning "pointer type mismatch in conditional expression" } */
- (void)(1 ? x2 : x0); /* { dg-warning "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x0 : x1); /* { dg-error "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x1 : x2); /* { dg-error "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x2 : x0); /* { dg-error "pointer type mismatch in conditional expression" } */
v0p = (1 ? z0 : v0p); /* { dg-warning "assignment discards 'const' qualifier from pointer target type" } */
v1p = (1 ? z1 : v1p); /* { dg-warning "assignment discards 'const' qualifier from pointer target type" } */
v2p = (1 ? z2 : v2p); /* { dg-warning "assignment discards 'const' qualifier from pointer target type" } */
diff --git a/gcc/testsuite/gcc.dg/dfp/composite-type-2.c b/gcc/testsuite/gcc.dg/dfp/composite-type-2.c
new file mode 100644
index 00000000000..5c6d95cc200
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/dfp/composite-type-2.c
@@ -0,0 +1,58 @@
+/* { dg-do compile } */
+/* { dg-options "-O -Wall -ftrack-macro-expansion=0" } */
+
+/* C99 6.2.7: Compatible type and composite type. */
+
+#define DECIMAL_COMPOSITE_DECL(TYPE) \
+ _Decimal##TYPE g1_##TYPE(); \
+ _Decimal##TYPE g2_##TYPE(); \
+ _Decimal##TYPE (*h1_##TYPE)[2]; \
+ _Decimal##TYPE (*h2_##TYPE)[3]; \
+ _Decimal##TYPE (*h3_##TYPE)[4]; \
+ _Decimal##TYPE f1_##TYPE(_Decimal##TYPE(*)()); \
+ _Decimal##TYPE f1_##TYPE(_Decimal##TYPE(*)(_Decimal##TYPE*)); \
+ _Decimal##TYPE f1_##TYPE (_Decimal##TYPE(*g)(_Decimal##TYPE*)) \
+ { \
+ _Decimal##TYPE d##TYPE; \
+ d##TYPE = ((_Decimal##TYPE (*) (_Decimal##TYPE*)) g)(&d##TYPE); \
+ d##TYPE = ((_Decimal##TYPE (*) ()) g); \
+ return d##TYPE; \
+ } \
+ _Decimal##TYPE f2_##TYPE(_Decimal##TYPE(*)[]); \
+ _Decimal##TYPE f2_##TYPE(_Decimal##TYPE(*)[3]);
+
+#define DECIMAL_COMPOSITE_TEST(TYPE) \
+do \
+{ \
+ _Decimal##TYPE d##TYPE; \
+ d##TYPE = f1_##TYPE(g1_##TYPE); \
+ d##TYPE = f1_##TYPE(g2_##TYPE); \
+ d##TYPE = f2_##TYPE(h1_##TYPE); \
+ d##TYPE = f2_##TYPE(h2_##TYPE); \
+ d##TYPE = f2_##TYPE(h3_##TYPE); \
+ (void) d##TYPE; \
+} while(0)
+
+DECIMAL_COMPOSITE_DECL(32); /* { dg-error "incompatible types when assigning to type '\[^\n\]*' from type '\[^\n\]*'" } */
+/* { dg-message "note: expected '\[^'\n\]*' but argument is of type '\[^'\n\]*'" "note: expected" { target *-*-* } .-1 } */
+
+
+DECIMAL_COMPOSITE_DECL(64); /* { dg-error "incompatible types when assigning to type '\[^\n\]*' from type '\[^\n\]*'" } */
+/* { dg-message "note: expected '\[^'\n\]*' but argument is of type '\[^'\n\]*'" "note: expected" { target *-*-* } .-1 } */
+
+
+DECIMAL_COMPOSITE_DECL(128); /* { dg-error "incompatible types when assigning to type '\[^\n\]*' from type '\[^\n\]*'" } */
+/* { dg-message "note: expected '\[^'\n\]*' but argument is of type '\[^'\n\]*'" "note: expected" { target *-*-* } .-1 } */
+
+
+int main()
+{
+ DECIMAL_COMPOSITE_TEST(32); /* { dg-error "incompatible pointer type" } */
+ DECIMAL_COMPOSITE_TEST(64); /* { dg-error "incompatible pointer type" } */
+ DECIMAL_COMPOSITE_TEST(128); /* { dg-error "incompatible pointer type" } */
+
+ return 0;
+}
+
+/* The invalid function redeclarations might also trigger:
+ { dg-prune-output "-Warray-parameter" } */
diff --git a/gcc/testsuite/gcc.dg/dfp/composite-type.c b/gcc/testsuite/gcc.dg/dfp/composite-type.c
index ce7d5c1a0a0..2eb601400b5 100644
--- a/gcc/testsuite/gcc.dg/dfp/composite-type.c
+++ b/gcc/testsuite/gcc.dg/dfp/composite-type.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-O -Wall -ftrack-macro-expansion=0" } */
+/* { dg-options "-fpermissive -O -Wall -ftrack-macro-expansion=0" } */
/* C99 6.2.7: Compatible type and composite type. */
diff --git a/gcc/testsuite/gcc.dg/diag-aka-1.c b/gcc/testsuite/gcc.dg/diag-aka-1.c
index 3383c1c263b..485a8a5f85d 100644
--- a/gcc/testsuite/gcc.dg/diag-aka-1.c
+++ b/gcc/testsuite/gcc.dg/diag-aka-1.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-Wc++-compat" } */
+/* { dg-options "-fpermissive -Wc++-compat" } */
typedef struct A { int i; } B;
typedef struct T { int i; } *T; /* { dg-warning "using 'T' as both a typedef and a tag is invalid" } */
diff --git a/gcc/testsuite/gcc.dg/diag-aka-1a.c b/gcc/testsuite/gcc.dg/diag-aka-1a.c
new file mode 100644
index 00000000000..d161b785e7d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/diag-aka-1a.c
@@ -0,0 +1,29 @@
+/* { dg-do compile } */
+/* { dg-options "-Wc++-compat" } */
+
+typedef struct A { int i; } B;
+typedef struct T { int i; } *T; /* { dg-warning "using 'T' as both a typedef and a tag is invalid" } */
+typedef const float TFA;
+typedef TFA TFB;
+typedef TFB TFC;
+typedef int IA[];
+typedef IA *IAP;
+extern IAP arr[];
+
+void fn1 (B *); /* { dg-message "expected 'B \\*' {aka 'struct A \\*'} but argument is of type 'struct B \\*'" } */
+void fn2 (TFC *);
+
+void
+bar (B *b, int *i)
+{
+ fn1 ((struct B *) b); /* { dg-error "passing argument" } */
+ fn2 (i); /* { dg-error "passing argument" } */
+ sizeof (arr); /* { dg-error "invalid application of .sizeof. to incomplete type .int \\(\\*\\\[\\\]\\)\\\[\\\]." } */
+}
+
+int
+foo (void *a)
+{
+ T t = a; /* { dg-warning "request for implicit conversion from 'void \\*' to 'T' {aka 'struct T \\*'} not" } */
+ return t->i;
+}
diff --git a/gcc/testsuite/gcc.dg/enum-compat-1.c b/gcc/testsuite/gcc.dg/enum-compat-1.c
index 5fb150cee79..b7352f6ddc3 100644
--- a/gcc/testsuite/gcc.dg/enum-compat-1.c
+++ b/gcc/testsuite/gcc.dg/enum-compat-1.c
@@ -3,7 +3,7 @@
/* Origin: Joseph Myers <jsm@polyomino.org.uk>, based on
PR c/6024 from Richard Earnshaw <rearnsha@arm.com> */
/* { dg-do compile } */
-/* { dg-options "" } */
+/* { dg-options "-fpermissive" } */
/* Original test from PR c/6024. */
enum e1 {a, b};
diff --git a/gcc/testsuite/gcc.dg/enum-compat-2.c b/gcc/testsuite/gcc.dg/enum-compat-2.c
new file mode 100644
index 00000000000..69509012480
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/enum-compat-2.c
@@ -0,0 +1,32 @@
+/* Test that enumerated types are only considered compatible when they
+ are the same type. PR c/6024. */
+/* Origin: Joseph Myers <jsm@polyomino.org.uk>, based on
+ PR c/6024 from Richard Earnshaw <rearnsha@arm.com> */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+/* Original test from PR c/6024. */
+enum e1 {a, b};
+enum e2 {c, d};
+
+void f(enum e1); /* { dg-error "prototype" "error at decl" } */
+
+void f(x)
+ enum e2 x; /* { dg-error "doesn't match prototype" } */
+{
+ return;
+}
+
+/* Other compatibility tests. */
+enum e3 { A };
+enum e4 { B };
+
+enum e3 v3;
+enum e4 *p = &v3; /* { dg-error "incompatible" "incompatible pointer" } */
+enum e3 *q = &v3;
+
+void g(enum e3); /* { dg-message "note: previous declaration" "error at first decl" } */
+void g(enum e4); /* { dg-error "conflicting types" "error at second decl" } */
+
+void h(enum e3);
+void h(enum e3);
diff --git a/gcc/testsuite/gcc.dg/func-ptr-conv-1.c b/gcc/testsuite/gcc.dg/func-ptr-conv-1.c
index 5c8a101343e..7c2876cc998 100644
--- a/gcc/testsuite/gcc.dg/func-ptr-conv-1.c
+++ b/gcc/testsuite/gcc.dg/func-ptr-conv-1.c
@@ -5,7 +5,7 @@
are not permitted. PR c/11234. */
/* Origin: Joseph Myers <jsm@polyomino.org.uk> */
/* { dg-do compile } */
-/* { dg-options "-pedantic" } */
+/* { dg-options "-fpermissive -pedantic" } */
void f(void);
diff --git a/gcc/testsuite/gcc.dg/func-ptr-conv-2.c b/gcc/testsuite/gcc.dg/func-ptr-conv-2.c
new file mode 100644
index 00000000000..a9884a6c919
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/func-ptr-conv-2.c
@@ -0,0 +1,56 @@
+/* Conversions between function and object pointers are not permitted
+ in any version of ISO C, even with casts, except for the special
+ case of converting a null pointer constant to function pointer
+ type. Likewise, comparisons between function and object pointers
+ are not permitted. PR c/11234. */
+/* Origin: Joseph Myers <jsm@polyomino.org.uk> */
+/* { dg-do compile } */
+/* { dg-options "-pedantic" } */
+
+void f(void);
+
+void *v1 = f; /* { dg-warning "12:pointer" "bad conversion" } */
+void *v2 = &f; /* { dg-warning "12:pointer" "bad conversion" } */
+void *v3 = (void *)f; /* { dg-warning "12:pointer" "bad conversion" } */
+void *v4 = (void *)&f; /* { dg-warning "12:pointer" "bad conversion" } */
+void *v5;
+char *c1 = f; /* { dg-error "12:pointer" "bad conversion" } */
+char *c2 = &f; /* { dg-error "12:pointer" "bad conversion" } */
+char *c3 = (char *)f; /* { dg-warning "12:pointer" "bad conversion" } */
+char *c4 = (char *)&f; /* { dg-warning "12:pointer" "bad conversion" } */
+char *c5;
+void (*fp)(void);
+int a;
+
+void
+g(void)
+{
+ v5 = f; /* { dg-warning "6:pointer" "bad conversion" } */
+ v5 = &f; /* { dg-warning "6:pointer" "bad conversion" } */
+ v5 = (void *)f; /* { dg-warning "8:pointer" "bad conversion" } */
+ v5 = (void *)&f; /* { dg-warning "8:pointer" "bad conversion" } */
+ c5 = f; /* { dg-error "6:pointer" "bad conversion" } */
+ c5 = &f; /* { dg-error "6:pointer" "bad conversion" } */
+ c5 = (char *)f; /* { dg-warning "8:pointer" "bad conversion" } */
+ c5 = (char *)&f; /* { dg-warning "8:pointer" "bad conversion" } */
+ fp = v5; /* { dg-warning "6:pointer" "bad conversion" } */
+ fp = c5; /* { dg-error "6:pointer" "bad conversion" } */
+ fp = (void (*)(void))v5; /* { dg-warning "8:pointer" "bad conversion" } */
+ fp = (void (*)(void))c5; /* { dg-warning "8:pointer" "bad conversion" } */
+ (a ? f : v3); /* { dg-warning "10:pointer" "bad conversion" } */
+ (a ? v2 : fp); /* { dg-warning "11:pointer" "bad conversion" } */
+ /* The following are OK. */
+ fp = 0;
+ fp = (void *)0;
+ fp = 0L;
+ fp = (void (*)(void))0;
+ fp = (void (*)(void))(void *)0;
+ (a ? f : 0);
+ (a ? f : (void *)0);
+ (a ? (void *)0 : fp);
+ (a ? 0 : fp);
+}
+
+/* The following are OK. */
+void (*fp2)(void) = 0;
+void (*fp3)(void) = (void *)0;
diff --git a/gcc/testsuite/gcc.dg/init-bad-7.c b/gcc/testsuite/gcc.dg/init-bad-7.c
index de5e570978c..caa8c783d65 100644
--- a/gcc/testsuite/gcc.dg/init-bad-7.c
+++ b/gcc/testsuite/gcc.dg/init-bad-7.c
@@ -1,6 +1,6 @@
/* PR c/37724 */
/* { dg-do compile } */
-/* { dg-options "-std=gnu99 -pedantic" } */
+/* { dg-options "-fpermissive -std=gnu99 -pedantic" } */
struct f
{
diff --git a/gcc/testsuite/gcc.dg/init-bad-7a.c b/gcc/testsuite/gcc.dg/init-bad-7a.c
new file mode 100644
index 00000000000..9ead2901c4c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/init-bad-7a.c
@@ -0,0 +1,12 @@
+/* PR c/37724 */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+struct f
+{
+ int *a;
+};
+
+char b[10];
+struct f g = {b}; /* { dg-error "initialization of 'int \\*' from incompatible pointer type" } */
+/* { dg-note "near initialization for" "" { target *-*-* } .-1 } */
diff --git a/gcc/testsuite/gcc.dg/noncompile/incomplete-3.c b/gcc/testsuite/gcc.dg/noncompile/incomplete-3.c
index 0618b4d8170..b783052d145 100644
--- a/gcc/testsuite/gcc.dg/noncompile/incomplete-3.c
+++ b/gcc/testsuite/gcc.dg/noncompile/incomplete-3.c
@@ -4,6 +4,6 @@ typedef struct { int a; } b_t;
int foo (void)
{
b_t d;
- struct b_t *c = &d; /* { dg-warning "incompatible pointer type" } */
+ struct b_t *c = &d; /* { dg-error "incompatible pointer type" } */
c->a; /* { dg-error "invalid use of undefined type" } */
}
diff --git a/gcc/testsuite/gcc.dg/param-type-mismatch-2.c b/gcc/testsuite/gcc.dg/param-type-mismatch-2.c
index 91d998437d1..83bc360fbc9 100644
--- a/gcc/testsuite/gcc.dg/param-type-mismatch-2.c
+++ b/gcc/testsuite/gcc.dg/param-type-mismatch-2.c
@@ -152,7 +152,7 @@ extern int callee_8 (int one, float *two, float (three)); /* { dg-line callee_8
int test_8 (int first, int *second, float third)
{
- return callee_8 (first, second, third); /* { dg-warning "passing argument 2 of 'callee_8' from incompatible pointer type" } */
+ return callee_8 (first, second, third); /* { dg-error "passing argument 2 of 'callee_8' from incompatible pointer type" } */
/* { dg-begin-multiline-output "" }
return callee_8 (first, second, third);
^~~~~~
diff --git a/gcc/testsuite/gcc.dg/pointer-array-atomic-2.c b/gcc/testsuite/gcc.dg/pointer-array-atomic-2.c
new file mode 100644
index 00000000000..de63ff141a3
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pointer-array-atomic-2.c
@@ -0,0 +1,60 @@
+/* { dg-do compile } */
+/* { dg-options "-std=c11" } */
+/* Origin: Martin Uecker <uecker@eecs.berkeley.edu> */
+void tvoid(void* x);
+void transpose0(double* out, _Atomic double* in) { }
+void transpose1(double out[2][2], _Atomic double in[2][2]) { }
+void transpose2(double out[2][2][2], _Atomic double in[2][2][2]) { }
+// return
+int (*x2(_Atomic int x[3][3]))[3] { return x; } /* { dg-error "returning '_Atomic int \\(\\*\\)\\\[3\\\]' from a function with incompatible return type" } */
+_Atomic int (*x3(int x[3][3]))[3] { return x; } /* { dg-error "returning 'int \\(\\*\\)\\\[3\\\]' from a function with incompatible return type" } */
+void test(void)
+{
+ double x0[2];
+ double y0[2];
+ _Atomic double z0[4];
+ double x1[2][2];
+ double y1[2][2];
+ double o1[2][3];
+ _Atomic double z1[2][2];
+ double x2[2][2][2];
+ double y2[2][2][2];
+ double o2[2][2][3];
+ _Atomic double z2[2][2][2];
+ tvoid(z0);
+ tvoid(z1);
+ tvoid(z2);
+ // passing as arguments
+ transpose0(y0, x0); /* { dg-error "passing argument 2 of 'transpose0' from incompatible pointer type" } */
+ transpose1(y1, o1); /* { dg-error "passing argument 2 of 'transpose1' from incompatible pointer type" } */
+ transpose1(y1, x1); /* { dg-error "passing argument 2 of 'transpose1' from incompatible pointer type" } */
+ transpose2(y2, o2); /* { dg-error "passing argument 2 of 'transpose2' from incompatible pointer type" } */
+ transpose2(y2, x2); /* { dg-error "passing argument 2 of 'transpose2' from incompatible pointer type" } */
+ // initialization
+ _Atomic double (*x0p) = x0; /* { dg-error "initialization of '_Atomic double \\*' from incompatible pointer type" } */
+ _Atomic double (*x1p)[2] = x1; /* { dg-error "initialization of '_Atomic double \\(\\*\\)\\\[2\\\]' from incompatible pointer type" } */
+ _Atomic double (*x2p)[2][2] = x2; /* { dg-error "initialization of '_Atomic double \\(\\*\\)\\\[2\\\]\\\[2\\\]' from incompatible pointer type" } */
+ // assignment
+ x0p = x0; /* { dg-error "assignment to '_Atomic double \\*' from incompatible pointer type" } */
+ x1p = x1; /* { dg-error "assignment to '_Atomic double \\(\\*\\)\\\[2\\\]' from incompatible pointer type" } */
+ x2p = x2; /* { dg-error "assignment to '_Atomic double \\(\\*\\)\\\[2\\\]\\\[2\\\]' from incompatible pointer type" } */
+ // subtraction
+ &(x0[1]) - &(z0[0]); /* { dg-error "invalid operands to binary" } */
+ &(x1[1]) - &(z1[0]); /* { dg-error "invalid operands to binary" } */
+ &(x2[1]) - &(z2[0]); /* { dg-error "invalid operands to binary" } */
+ // comparison
+ x0 == z0; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x1 == z1; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x2 == z2; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x0 > z0; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x1 > z1; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x2 > z2; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x0 < z0; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x1 < z1; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ x2 < z2; /* { dg-warning "comparison of distinct pointer types lacks a cast" } */
+ // conditional expressions
+ (void)(1 ? x0 : z0); /* { dg-error "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x1 : z1); /* { dg-error "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x2 : z2); /* { dg-error "pointer type mismatch in conditional expression" } */
+}
+
diff --git a/gcc/testsuite/gcc.dg/pointer-array-atomic.c b/gcc/testsuite/gcc.dg/pointer-array-atomic.c
index bb63797b237..87d177a71a4 100644
--- a/gcc/testsuite/gcc.dg/pointer-array-atomic.c
+++ b/gcc/testsuite/gcc.dg/pointer-array-atomic.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-std=c11" } */
+/* { dg-options "-fpermissive -std=c11" } */
/* Origin: Martin Uecker <uecker@eecs.berkeley.edu> */
void tvoid(void* x);
void transpose0(double* out, _Atomic double* in) { }
diff --git a/gcc/testsuite/gcc.dg/pointer-array-quals-1.c b/gcc/testsuite/gcc.dg/pointer-array-quals-1.c
index 498ab223162..be80912723a 100644
--- a/gcc/testsuite/gcc.dg/pointer-array-quals-1.c
+++ b/gcc/testsuite/gcc.dg/pointer-array-quals-1.c
@@ -84,9 +84,9 @@ void test(void)
(void)(1 ? x0 : z0);
(void)(1 ? x1 : z1);
(void)(1 ? x2 : z2);
- (void)(1 ? x0 : x1); /* { dg-warning "pointer type mismatch in conditional expression" } */
- (void)(1 ? x1 : x2); /* { dg-warning "pointer type mismatch in conditional expression" } */
- (void)(1 ? x2 : x0); /* { dg-warning "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x0 : x1); /* { dg-error "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x1 : x2); /* { dg-error "pointer type mismatch in conditional expression" } */
+ (void)(1 ? x2 : x0); /* { dg-error "pointer type mismatch in conditional expression" } */
v0p = (1 ? z0 : v0p); /* { dg-warning "assignment discards 'const' qualifier from pointer target type" } */
v1p = (1 ? z1 : v1p); /* { dg-warning "assignment discards 'const' qualifier from pointer target type" } */
v2p = (1 ? z2 : v2p); /* { dg-warning "assignment discards 'const' qualifier from pointer target type" } */
diff --git a/gcc/testsuite/gcc.dg/transparent-union-1.c b/gcc/testsuite/gcc.dg/transparent-union-1.c
index 3f0c260c906..518adfb6ce0 100644
--- a/gcc/testsuite/gcc.dg/transparent-union-1.c
+++ b/gcc/testsuite/gcc.dg/transparent-union-1.c
@@ -1,6 +1,6 @@
/* PR c/20043 */
/* { dg-do compile } */
-/* { dg-options "-std=gnu99" } */
+/* { dg-options "-fpermissive -std=gnu99" } */
extern void f0 (int *);
extern void f0 (int *__restrict);
diff --git a/gcc/testsuite/gcc.dg/transparent-union-1a.c b/gcc/testsuite/gcc.dg/transparent-union-1a.c
new file mode 100644
index 00000000000..9796ceab490
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/transparent-union-1a.c
@@ -0,0 +1,85 @@
+/* PR c/20043 */
+/* { dg-do compile } */
+/* { dg-options "-std=gnu99" } */
+
+extern void f0 (int *);
+extern void f0 (int *__restrict);
+
+extern void f1 (int *__restrict);
+extern void f1 (int *);
+
+typedef union { int *i; long *l; } U2
+ __attribute__((transparent_union));
+extern void f2 (U2);
+extern void f2 (int *);
+
+typedef union { int *__restrict i; long *__restrict l; } U3
+ __attribute__((transparent_union));
+extern void f3 (U3);
+extern void f3 (int *__restrict);
+
+extern void f4 (U3);
+extern void f4 (int *);
+
+extern void f5 (U2);
+extern void f5 (int *__restrict);
+
+typedef union { long *l; int *i; } U6
+ __attribute__((transparent_union));
+extern void f6 (U6);
+extern void f6 (int *);
+
+typedef union { long *__restrict l; int *__restrict i; } U7
+ __attribute__((transparent_union));
+extern void f7 (U7);
+extern void f7 (int *__restrict);
+
+extern void f8 (U7);
+extern void f8 (int *);
+
+extern void f9 (U6);
+extern void f9 (int *__restrict);
+
+extern void f10 (U2);
+extern void f11 (U3);
+extern void f12 (U6);
+extern void f13 (U7);
+
+int i;
+long l;
+
+int
+main (void)
+{
+ f0 (&i);
+ f0 (&l); /* { dg-error "passing argument 1 of 'f0' from incompatible pointer type" } */
+ f1 (&i);
+ f1 (&l); /* { dg-error "passing argument 1 of 'f1' from incompatible pointer type" } */
+ f2 (&i);
+ f2 (&l); /* { dg-error "passing argument 1 of 'f2' from incompatible pointer type" } */
+ f3 (&i);
+ f3 (&l); /* { dg-error "passing argument 1 of 'f3' from incompatible pointer type" } */
+ f4 (&i);
+ f4 (&l); /* { dg-error "passing argument 1 of 'f4' from incompatible pointer type" } */
+ f5 (&i);
+ f5 (&l); /* { dg-error "passing argument 1 of 'f5' from incompatible pointer type" } */
+ f6 (&i);
+ f6 (&l); /* { dg-error "passing argument 1 of 'f6' from incompatible pointer type" } */
+ f7 (&i);
+ f7 (&l); /* { dg-error "passing argument 1 of 'f7' from incompatible pointer type" } */
+ f8 (&i);
+ f8 (&l); /* { dg-error "passing argument 1 of 'f8' from incompatible pointer type" } */
+ f9 (&i);
+ f9 (&l); /* { dg-error "passing argument 1 of 'f9' from incompatible pointer type" } */
+ f10 (&i);
+ f10 (&l);
+ f11 (&i);
+ f11 (&l);
+ f12 (&i);
+ f12 (&l);
+ f13 (&i);
+ f13 (&l);
+ return 0;
+}
+
+/* { dg-message "note: expected '\[^\n'\]*' but argument is of type '\[^\n'\]*'" "note: expected" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c b/gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
index 16db40df663..9ae371d8867 100644
--- a/gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
+++ b/gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
@@ -17,12 +17,12 @@ test_memtag_warning_return_qualifier (void)
v = __arm_mte_get_tag(c); /* { dg-warning {assignment} } */
n = __arm_mte_get_tag(c); /* { dg-warning {assignment} } */
- i = __arm_mte_get_tag(c); /* { dg-warning {assignment} } */
+ i = __arm_mte_get_tag(c); /* { dg-error {assignment} } */
c = __arm_mte_get_tag(v); /* { dg-warning {assignment} } */
n = __arm_mte_get_tag(v); /* { dg-warning {assignment} } */
- i = __arm_mte_create_random_tag (c, 0); /* { dg-warning {assignment} } */
- i = __arm_mte_increment_tag (c, 0); /* { dg-warning {assignment} } */
+ i = __arm_mte_create_random_tag (c, 0); /* { dg-error {assignment} } */
+ i = __arm_mte_increment_tag (c, 0); /* { dg-error {assignment} } */
c = __arm_mte_get_tag(n); /* No warning. */
d = __arm_mte_ptrdiff(c, i); /* No warning. */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_2.c
index a8288762695..5f4cbeaea2e 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_2.c
@@ -15,8 +15,8 @@ f1 (svbool_t pg, signed char *s8_ptr, void *void_ptr, struct s *s_ptr,
svld1_s8 (pg, 0);
svld1_s32 (pg, (int32_t *) 0);
svld1_s8 (pg, void_ptr);
- svld1_s8 (pg, s_ptr); /* { dg-warning {passing argument 2 of 'svld1_s8' from incompatible pointer type} } */
+ svld1_s8 (pg, s_ptr); /* { dg-error {passing argument 2 of 'svld1_s8' from incompatible pointer type} } */
svld1_f32 (pg, f32_ptr);
- svld1_f32 (pg, cf32_ptr); /* { dg-warning {passing argument 2 of 'svld1_f32' from incompatible pointer type} } */
+ svld1_f32 (pg, cf32_ptr); /* { dg-error {passing argument 2 of 'svld1_f32' from incompatible pointer type} } */
return svld1_s8 (pg, s8_ptr); /* { dg-error {incompatible types when returning type 'svint8_t' but 'svuint8_t' was expected} } */
}
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
index cd849f89941..41bf2da0fab 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
@@ -14,7 +14,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svld1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_s32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_s32'} } */
svld1sb_gather_offset_s32 (pg, s8_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_s32'} } */
- svld1sb_gather_offset_s32 (pg, s16_ptr, s32); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s32offset_s32' from incompatible pointer type} } */
+ svld1sb_gather_offset_s32 (pg, s16_ptr, s32); /* { dg-error {passing argument 2 of 'svld1sb_gather_s32offset_s32' from incompatible pointer type} } */
svld1sb_gather_offset_s32 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svld1sb_gather_offset_s32', which expects a vector of 32-bit integers} } */
svld1sb_gather_offset_s32 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svld1sb_gather_offset_s32', which expects a vector of 32-bit integers} } */
svld1sb_gather_offset_s32 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svld1sb_gather_offset_s32', which expects a vector of 32-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
index 850eecf99f6..1261b49d487 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
@@ -14,7 +14,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svld1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_u32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_u32'} } */
svld1sb_gather_offset_u32 (pg, s8_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_u32'} } */
- svld1sb_gather_offset_u32 (pg, s16_ptr, s32); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s32offset_u32' from incompatible pointer type} } */
+ svld1sb_gather_offset_u32 (pg, s16_ptr, s32); /* { dg-error {passing argument 2 of 'svld1sb_gather_s32offset_u32' from incompatible pointer type} } */
svld1sb_gather_offset_u32 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svld1sb_gather_offset_u32', which expects a vector of 32-bit integers} } */
svld1sb_gather_offset_u32 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svld1sb_gather_offset_u32', which expects a vector of 32-bit integers} } */
svld1sb_gather_offset_u32 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svld1sb_gather_offset_u32', which expects a vector of 32-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
index 93a728593f9..518348d1146 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
@@ -14,7 +14,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svld1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_s64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_s64'} } */
svld1sb_gather_offset_s64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_s64'} } */
- svld1sb_gather_offset_s64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s64offset_s64' from incompatible pointer type} } */
+ svld1sb_gather_offset_s64 (pg, s16_ptr, s64); /* { dg-error {passing argument 2 of 'svld1sb_gather_s64offset_s64' from incompatible pointer type} } */
svld1sb_gather_offset_s64 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svld1sb_gather_offset_s64', which expects a vector of 64-bit integers} } */
svld1sb_gather_offset_s64 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svld1sb_gather_offset_s64', which expects a vector of 64-bit integers} } */
svld1sb_gather_offset_s64 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svld1sb_gather_offset_s64', which expects a vector of 64-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
index d54dc8eafab..6086911fd5d 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
@@ -14,7 +14,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svld1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svld1sb_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1sb_gather_offset_u64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1sb_gather_offset_u64'} } */
svld1sb_gather_offset_u64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svld1sb_gather_offset_u64'} } */
- svld1sb_gather_offset_u64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svld1sb_gather_s64offset_u64' from incompatible pointer type} } */
+ svld1sb_gather_offset_u64 (pg, s16_ptr, s64); /* { dg-error {passing argument 2 of 'svld1sb_gather_s64offset_u64' from incompatible pointer type} } */
svld1sb_gather_offset_u64 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svld1sb_gather_offset_u64', which expects a vector of 64-bit integers} } */
svld1sb_gather_offset_u64 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svld1sb_gather_offset_u64', which expects a vector of 64-bit integers} } */
svld1sb_gather_offset_u64 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svld1sb_gather_offset_u64', which expects a vector of 64-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
index 3b521d5c141..9e2cceec2e9 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
@@ -14,7 +14,7 @@ f1 (svbool_t pg, unsigned char *s8_ptr, unsigned short *s16_ptr,
svld1ub_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svld1ub_gather_offset'; did you mean 'svld1_gather_offset'} } */
svld1ub_gather_offset_s32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svld1ub_gather_offset_s32'} } */
svld1ub_gather_offset_s32 (pg, s8_ptr, s32, 0); /* { dg-error {too many arguments to function 'svld1ub_gather_offset_s32'} } */
- svld1ub_gather_offset_s32 (pg, s16_ptr, s32); /* { dg-warning {passing argument 2 of 'svld1ub_gather_s32offset_s32' from incompatible pointer type} } */
+ svld1ub_gather_offset_s32 (pg, s16_ptr, s32); /* { dg-error {passing argument 2 of 'svld1ub_gather_s32offset_s32' from incompatible pointer type} } */
svld1ub_gather_offset_s32 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svld1ub_gather_offset_s32', which expects a vector of 32-bit integers} } */
svld1ub_gather_offset_s32 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svld1ub_gather_offset_s32', which expects a vector of 32-bit integers} } */
svld1ub_gather_offset_s32 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svld1ub_gather_offset_s32', which expects a vector of 32-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
index 96d8ad55074..18e16630944 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
@@ -16,7 +16,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svldnt1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_s32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_s32'} } */
svldnt1sb_gather_offset_s32 (pg, s8_ptr, u32, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_s32'} } */
- svldnt1sb_gather_offset_s32 (pg, s16_ptr, u32); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_u32offset_s32' from incompatible pointer type} } */
+ svldnt1sb_gather_offset_s32 (pg, s16_ptr, u32); /* { dg-error {passing argument 2 of 'svldnt1sb_gather_u32offset_s32' from incompatible pointer type} } */
svldnt1sb_gather_offset_s32 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svldnt1sb_gather_offset_s32', which expects a vector of 32-bit integers} } */
svldnt1sb_gather_offset_s32 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svldnt1sb_gather_offset_s32', which expects a vector of 32-bit integers} } */
svldnt1sb_gather_offset_s32 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svldnt1sb_gather_offset_s32', which expects a vector of 32-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
index 25ce7268a1e..6bb9998bff5 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
@@ -16,7 +16,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svldnt1sb_gather_offset (pg, s8_ptr, s32); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_u32 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_u32'} } */
svldnt1sb_gather_offset_u32 (pg, s8_ptr, u32, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_u32'} } */
- svldnt1sb_gather_offset_u32 (pg, s16_ptr, u32); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_u32offset_u32' from incompatible pointer type} } */
+ svldnt1sb_gather_offset_u32 (pg, s16_ptr, u32); /* { dg-error {passing argument 2 of 'svldnt1sb_gather_u32offset_u32' from incompatible pointer type} } */
svldnt1sb_gather_offset_u32 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svldnt1sb_gather_offset_u32', which expects a vector of 32-bit integers} } */
svldnt1sb_gather_offset_u32 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svldnt1sb_gather_offset_u32', which expects a vector of 32-bit integers} } */
svldnt1sb_gather_offset_u32 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svldnt1sb_gather_offset_u32', which expects a vector of 32-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
index 04465f251b1..8dc160ce9c3 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
@@ -16,7 +16,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svldnt1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_s64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_s64'} } */
svldnt1sb_gather_offset_s64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_s64'} } */
- svldnt1sb_gather_offset_s64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_s64offset_s64' from incompatible pointer type} } */
+ svldnt1sb_gather_offset_s64 (pg, s16_ptr, s64); /* { dg-error {passing argument 2 of 'svldnt1sb_gather_s64offset_s64' from incompatible pointer type} } */
svldnt1sb_gather_offset_s64 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svldnt1sb_gather_offset_s64', which expects a vector of 64-bit integers} } */
svldnt1sb_gather_offset_s64 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svldnt1sb_gather_offset_s64', which expects a vector of 64-bit integers} } */
svldnt1sb_gather_offset_s64 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svldnt1sb_gather_offset_s64', which expects a vector of 64-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
index 479be66996d..9a418f28089 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
@@ -16,7 +16,7 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svldnt1sb_gather_offset (pg, s8_ptr, s64); /* { dg-error {implicit declaration of function 'svldnt1sb_gather_offset'; did you mean 'svldnt1_gather_offset'} } */
svldnt1sb_gather_offset_u64 (pg, s8_ptr); /* { dg-error {too few arguments to function 'svldnt1sb_gather_offset_u64'} } */
svldnt1sb_gather_offset_u64 (pg, s8_ptr, s64, 0); /* { dg-error {too many arguments to function 'svldnt1sb_gather_offset_u64'} } */
- svldnt1sb_gather_offset_u64 (pg, s16_ptr, s64); /* { dg-warning {passing argument 2 of 'svldnt1sb_gather_s64offset_u64' from incompatible pointer type} } */
+ svldnt1sb_gather_offset_u64 (pg, s16_ptr, s64); /* { dg-error {passing argument 2 of 'svldnt1sb_gather_s64offset_u64' from incompatible pointer type} } */
svldnt1sb_gather_offset_u64 (pg, s8_ptr, pg); /* { dg-error {passing 'svbool_t' to argument 3 of 'svldnt1sb_gather_offset_u64', which expects a vector of 64-bit integers} } */
svldnt1sb_gather_offset_u64 (pg, s8_ptr, s8); /* { dg-error {passing 'svint8_t' to argument 3 of 'svldnt1sb_gather_offset_u64', which expects a vector of 64-bit integers} } */
svldnt1sb_gather_offset_u64 (pg, s8_ptr, s16); /* { dg-error {passing 'svint16_t' to argument 3 of 'svldnt1sb_gather_offset_u64', which expects a vector of 64-bit integers} } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-1.c
index 01cfd14f873..b0389fa00a8 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-1.c
@@ -105,8 +105,8 @@ statements (int n)
/* Pointer assignment. */
- gnu_sc_ptr = sve_sc_ptr; /* { dg-warning {assignment to [^\n]* from incompatible pointer type} } */
- sve_sc_ptr = gnu_sc_ptr; /* { dg-warning {assignment to [^\n]* from incompatible pointer type} } */
+ gnu_sc_ptr = sve_sc_ptr; /* { dg-error {assignment to [^\n]* from incompatible pointer type} } */
+ sve_sc_ptr = gnu_sc_ptr; /* { dg-error {assignment to [^\n]* from incompatible pointer type} } */
/* Pointer arithmetic. */
@@ -153,8 +153,8 @@ statements (int n)
0 ? 0 : sve_sc1; /* { dg-error {type mismatch in conditional expression} } */
0 ?: sve_sc1; /* { dg-error {type mismatch in conditional expression} } */
0 ? sve_sc_ptr : sve_sc_ptr;
- 0 ? sve_sc_ptr : gnu_sc_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
- 0 ? gnu_sc_ptr : sve_sc_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
+ 0 ? sve_sc_ptr : gnu_sc_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
+ 0 ? gnu_sc_ptr : sve_sc_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
/* Generic associations. */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-2.c
index 613b9c47878..d16f40b5f2a 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/sizeless-2.c
@@ -105,8 +105,8 @@ statements (int n)
/* Pointer assignment. */
- gnu_sc_ptr = sve_sc_ptr; /* { dg-warning {incompatible pointer type} } */
- sve_sc_ptr = gnu_sc_ptr; /* { dg-warning {incompatible pointer type} } */
+ gnu_sc_ptr = sve_sc_ptr; /* { dg-error {incompatible pointer type} } */
+ sve_sc_ptr = gnu_sc_ptr; /* { dg-error {incompatible pointer type} } */
/* Pointer arithmetic. */
@@ -153,8 +153,8 @@ statements (int n)
0 ? 0 : sve_sc1; /* { dg-error {type mismatch in conditional expression} } */
0 ?: sve_sc1; /* { dg-error {type mismatch in conditional expression} } */
0 ? sve_sc_ptr : sve_sc_ptr;
- 0 ? sve_sc_ptr : gnu_sc_ptr; /* { dg-warning {pointer type mismatch} } */
- 0 ? gnu_sc_ptr : sve_sc_ptr; /* { dg-warning {pointer type mismatch} } */
+ 0 ? sve_sc_ptr : gnu_sc_ptr; /* { dg-error {pointer type mismatch} } */
+ 0 ? gnu_sc_ptr : sve_sc_ptr; /* { dg-error {pointer type mismatch} } */
/* Generic associations. */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_1.c
index 625f059af44..3669b3088a7 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_1.c
@@ -16,11 +16,11 @@ f1 (svbool_t pg, signed char *s8_ptr, void *void_ptr, struct s *s_ptr,
svst1 (pg, void_ptr, 0); /* { dg-error {passing 'int' to argument 3 of 'svst1', which expects an SVE vector type} } */
svst1 (pg, void_ptr, pg); /* { dg-error {'svst1' has no form that takes 'svbool_t' arguments} } */
svst1 (pg, 0, s8);
- svst1 (pg, (int32_t *) 0, s8); /* { dg-warning "passing argument 2 of 'svst1_s8' from incompatible pointer type" } */
+ svst1 (pg, (int32_t *) 0, s8); /* { dg-error "passing argument 2 of 'svst1_s8' from incompatible pointer type" } */
svst1 (pg, void_ptr, s8);
- svst1 (pg, s_ptr, s8); /* { dg-warning "passing argument 2 of 'svst1_s8' from incompatible pointer type" } */
- svst1 (pg, f32_ptr, s8); /* { dg-warning "passing argument 2 of 'svst1_s8' from incompatible pointer type" } */
+ svst1 (pg, s_ptr, s8); /* { dg-error "passing argument 2 of 'svst1_s8' from incompatible pointer type" } */
+ svst1 (pg, f32_ptr, s8); /* { dg-error "passing argument 2 of 'svst1_s8' from incompatible pointer type" } */
svst1 (pg, f32_ptr, f32);
- svst1 (pg, cf32_ptr, f32); /* { dg-warning "passing argument 2 of 'svst1_f32' from incompatible pointer type" } */
+ svst1 (pg, cf32_ptr, f32); /* { dg-error "passing argument 2 of 'svst1_f32' from incompatible pointer type" } */
svst1 (pg, s, s8); /* { dg-error {passing 'struct s' to argument 2 of 'svst1', which expects a scalar pointer} } */
}
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c
index 669f8844bc1..30a0a4c8586 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_2.c
@@ -18,10 +18,10 @@ f1 (svbool_t pg, signed char *s8_ptr, void *void_ptr, struct s *s_ptr,
svst1_vnum (pg, void_ptr, 0, 0); /* { dg-error {passing 'int' to argument 4 of 'svst1_vnum', which expects an SVE vector type} } */
svst1_vnum (pg, void_ptr, 0, pg); /* { dg-error {'svst1_vnum' has no form that takes 'svbool_t' arguments} } */
svst1_vnum (pg, 0, 0, s8);
- svst1_vnum (pg, (int32_t *) 0, 0, s8); /* { dg-warning "passing argument 2 of 'svst1_vnum_s8' from incompatible pointer type" } */
+ svst1_vnum (pg, (int32_t *) 0, 0, s8); /* { dg-error "passing argument 2 of 'svst1_vnum_s8' from incompatible pointer type" } */
svst1_vnum (pg, void_ptr, 0, s8);
- svst1_vnum (pg, s_ptr, 0, s8); /* { dg-warning "passing argument 2 of 'svst1_vnum_s8' from incompatible pointer type" } */
- svst1_vnum (pg, f32_ptr, 0, s8); /* { dg-warning "passing argument 2 of 'svst1_vnum_s8' from incompatible pointer type" } */
+ svst1_vnum (pg, s_ptr, 0, s8); /* { dg-error "passing argument 2 of 'svst1_vnum_s8' from incompatible pointer type" } */
+ svst1_vnum (pg, f32_ptr, 0, s8); /* { dg-error "passing argument 2 of 'svst1_vnum_s8' from incompatible pointer type" } */
svst1_vnum (pg, f32_ptr, 0, f32);
- svst1_vnum (pg, cf32_ptr, 0, f32); /* { dg-warning "passing argument 2 of 'svst1_vnum_f32' from incompatible pointer type" } */
+ svst1_vnum (pg, cf32_ptr, 0, f32); /* { dg-error "passing argument 2 of 'svst1_vnum_f32' from incompatible pointer type" } */
}
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
index 29f4510c49b..21bd93afb3f 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
@@ -20,10 +20,10 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svst1_scatter_index (pg, 0, s32, s32);
svst1_scatter_index (pg, (int32_t *) 0, s32, s32);
svst1_scatter_index (pg, void_ptr, s32, s32);
- svst1_scatter_index (pg, s_ptr, s32, s32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32index_s32' from incompatible pointer type" } */
- svst1_scatter_index (pg, f32_ptr, s32, s32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32index_s32' from incompatible pointer type" } */
+ svst1_scatter_index (pg, s_ptr, s32, s32); /* { dg-error "passing argument 2 of 'svst1_scatter_s32index_s32' from incompatible pointer type" } */
+ svst1_scatter_index (pg, f32_ptr, s32, s32); /* { dg-error "passing argument 2 of 'svst1_scatter_s32index_s32' from incompatible pointer type" } */
svst1_scatter_index (pg, f32_ptr, s32, f32);
- svst1_scatter_index (pg, cf32_ptr, s32, f32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32index_f32' from incompatible pointer type" } */
+ svst1_scatter_index (pg, cf32_ptr, s32, f32); /* { dg-error "passing argument 2 of 'svst1_scatter_s32index_f32' from incompatible pointer type" } */
svst1_scatter_index (pg, s, s32, s32); /* { dg-error {passing 'struct s' to argument 2 of 'svst1_scatter_index', which expects a vector or pointer base address} } */
svst1_scatter_index (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svst1_scatter_u32base_index_s32' makes integer from pointer without a cast" } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
index ab718b5eeee..ec99f8af23e 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
@@ -22,10 +22,10 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svstnt1_scatter_index (pg, 0, s64, s64);
svstnt1_scatter_index (pg, (int64_t *) 0, s64, s64);
svstnt1_scatter_index (pg, void_ptr, s64, s64);
- svstnt1_scatter_index (pg, s_ptr, s64, s64); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_s64index_s64' from incompatible pointer type" } */
- svstnt1_scatter_index (pg, f32_ptr, s64, s64); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_s64index_s64' from incompatible pointer type" } */
+ svstnt1_scatter_index (pg, s_ptr, s64, s64); /* { dg-error "passing argument 2 of 'svstnt1_scatter_s64index_s64' from incompatible pointer type" } */
+ svstnt1_scatter_index (pg, f32_ptr, s64, s64); /* { dg-error "passing argument 2 of 'svstnt1_scatter_s64index_s64' from incompatible pointer type" } */
svstnt1_scatter_index (pg, f64_ptr, s64, f64);
- svstnt1_scatter_index (pg, cf64_ptr, s64, f64); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_s64index_f64' from incompatible pointer type" } */
+ svstnt1_scatter_index (pg, cf64_ptr, s64, f64); /* { dg-error "passing argument 2 of 'svstnt1_scatter_s64index_f64' from incompatible pointer type" } */
svstnt1_scatter_index (pg, s, s64, s64); /* { dg-error {passing 'struct s' to argument 2 of 'svstnt1_scatter_index', which expects a vector or pointer base address} } */
svstnt1_scatter_index (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svstnt1_scatter_u32base_index_s32' makes integer from pointer without a cast" } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
index 311b1744c91..318f0dddfb1 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
@@ -20,10 +20,10 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svst1_scatter_offset (pg, 0, s32, s32);
svst1_scatter_offset (pg, (int32_t *) 0, s32, s32);
svst1_scatter_offset (pg, void_ptr, s32, s32);
- svst1_scatter_offset (pg, s_ptr, s32, s32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32offset_s32' from incompatible pointer type" } */
- svst1_scatter_offset (pg, f32_ptr, s32, s32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32offset_s32' from incompatible pointer type" } */
+ svst1_scatter_offset (pg, s_ptr, s32, s32); /* { dg-error "passing argument 2 of 'svst1_scatter_s32offset_s32' from incompatible pointer type" } */
+ svst1_scatter_offset (pg, f32_ptr, s32, s32); /* { dg-error "passing argument 2 of 'svst1_scatter_s32offset_s32' from incompatible pointer type" } */
svst1_scatter_offset (pg, f32_ptr, s32, f32);
- svst1_scatter_offset (pg, cf32_ptr, s32, f32); /* { dg-warning "passing argument 2 of 'svst1_scatter_s32offset_f32' from incompatible pointer type" } */
+ svst1_scatter_offset (pg, cf32_ptr, s32, f32); /* { dg-error "passing argument 2 of 'svst1_scatter_s32offset_f32' from incompatible pointer type" } */
svst1_scatter_offset (pg, s, s32, s32); /* { dg-error {passing 'struct s' to argument 2 of 'svst1_scatter_offset', which expects a vector or pointer base address} } */
svst1_scatter_offset (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svst1_scatter_u32base_offset_s32' makes integer from pointer without a cast" } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
index 5b251127a47..74bd7aefd70 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
@@ -22,10 +22,10 @@ f1 (svbool_t pg, signed char *s8_ptr, short *s16_ptr,
svstnt1_scatter_offset (pg, 0, u32, s32);
svstnt1_scatter_offset (pg, (int32_t *) 0, u32, s32);
svstnt1_scatter_offset (pg, void_ptr, u32, s32);
- svstnt1_scatter_offset (pg, s_ptr, u32, s32); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_u32offset_s32' from incompatible pointer type" } */
- svstnt1_scatter_offset (pg, f32_ptr, u32, s32); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_u32offset_s32' from incompatible pointer type" } */
+ svstnt1_scatter_offset (pg, s_ptr, u32, s32); /* { dg-error "passing argument 2 of 'svstnt1_scatter_u32offset_s32' from incompatible pointer type" } */
+ svstnt1_scatter_offset (pg, f32_ptr, u32, s32); /* { dg-error "passing argument 2 of 'svstnt1_scatter_u32offset_s32' from incompatible pointer type" } */
svstnt1_scatter_offset (pg, f32_ptr, u32, f32);
- svstnt1_scatter_offset (pg, cf32_ptr, u32, f32); /* { dg-warning "passing argument 2 of 'svstnt1_scatter_u32offset_f32' from incompatible pointer type" } */
+ svstnt1_scatter_offset (pg, cf32_ptr, u32, f32); /* { dg-error "passing argument 2 of 'svstnt1_scatter_u32offset_f32' from incompatible pointer type" } */
svstnt1_scatter_offset (pg, s, u32, s32); /* { dg-error {passing 'struct s' to argument 2 of 'svstnt1_scatter_offset', which expects a vector or pointer base address} } */
svstnt1_scatter_offset (pg, u32, void_ptr, s32); /* { dg-error "passing argument 3 of 'svstnt1_scatter_u32base_offset_s32' makes integer from pointer without a cast" } */
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
index 95be60591fb..5658a206fa3 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
@@ -135,41 +135,41 @@ g (int c)
diff = gs8 - gs8;
fs8 = ss8; // { dg-error {invalid conversion} "" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
fs8 = fs8;
fs8 = gs8; // { dg-error {invalid conversion} "" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
fs8 = su8; // { dg-error {cannot convert} "c++" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
fs8 = fu8; // { dg-error {cannot convert} "c++" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
fs8 = gu8; // { dg-error {cannot convert} "c++" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
fs8 = ss16; // { dg-error {cannot convert} "c++" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
fs8 = fs16; // { dg-error {cannot convert} "c++" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
fs8 = gs16; // { dg-error {cannot convert} "c++" { target c++ } }
- // { dg-warning {incompatible pointer type} "c" { target c } .-1 }
+ // { dg-error {incompatible pointer type} "c" { target c } .-1 }
select = c ? ss8 : ss8;
select = c ? ss8 : fs8; // { dg-error {distinct pointer types} "" { target c++ } }
- // { dg-warning {pointer type mismatch} "c" { target c } .-1 }
+ // { dg-error {pointer type mismatch} "c" { target c } .-1 }
select = c ? ss8 : gs8; // { dg-error {distinct pointer types} "" { target c++ } }
- // { dg-warning {pointer type mismatch} "c" { target c } .-1 }
+ // { dg-error {pointer type mismatch} "c" { target c } .-1 }
select = c ? fs8 : ss8; // { dg-error {distinct pointer types} "" { target c++ } }
- // { dg-warning {pointer type mismatch} "c" { target c } .-1 }
+ // { dg-error {pointer type mismatch} "c" { target c } .-1 }
select = c ? fs8 : fs8;
select = c ? fs8 : gs8; // { dg-error {distinct pointer types} "" { target c++ } }
- // { dg-warning {pointer type mismatch} "c" { target c } .-1 }
+ // { dg-error {pointer type mismatch} "c" { target c } .-1 }
select = c ? gs8 : ss8; // { dg-error {distinct pointer types} "" { target c++ } }
- // { dg-warning {pointer type mismatch} "c" { target c } .-1 }
+ // { dg-error {pointer type mismatch} "c" { target c } .-1 }
select = c ? gs8 : fs8; // { dg-error {distinct pointer types} "" { target c++ } }
- // { dg-warning {pointer type mismatch} "c" { target c } .-1 }
+ // { dg-error {pointer type mismatch} "c" { target c } .-1 }
select = c ? gs8 : gs8;
diff = sb - sb; // { dg-error {arithmetic on pointer to SVE type 'svbool_t'} }
diff --git a/gcc/testsuite/gcc.target/i386/sse2-bfloat16-scalar-typecheck.c b/gcc/testsuite/gcc.target/i386/sse2-bfloat16-scalar-typecheck.c
index d1a76db25e9..599b02632fd 100644
--- a/gcc/testsuite/gcc.target/i386/sse2-bfloat16-scalar-typecheck.c
+++ b/gcc/testsuite/gcc.target/i386/sse2-bfloat16-scalar-typecheck.c
@@ -181,8 +181,8 @@ __bf16 footest (__bf16 scalar0)
0 ? 0.1 : scalar0;
0 ? scalar0 : 0.1;
0 ? bfloat_ptr : bfloat_ptr2;
- 0 ? bfloat_ptr : float_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
- 0 ? float_ptr : bfloat_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
+ 0 ? bfloat_ptr : float_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
+ 0 ? float_ptr : bfloat_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
scalar0 ? scalar0 : scalar0;
scalar0 ? is_a_float : scalar0;
diff --git a/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_1.c b/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_1.c
index 8bc3f4a7b8f..f8bdf2e71fd 100644
--- a/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_1.c
+++ b/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_1.c
@@ -224,8 +224,8 @@ __m128bf16 footest (__m128bf16 vector0)
0 ? 0.1 : vector0; /* { dg-error {type mismatch in conditional expression} } */
0 ? vector0 : 0.1; /* { dg-error {type mismatch in conditional expression} } */
0 ? bfloat_ptr : bfloat_ptr2;
- 0 ? bfloat_ptr : float_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
- 0 ? float_ptr : bfloat_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
+ 0 ? bfloat_ptr : float_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
+ 0 ? float_ptr : bfloat_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
vector0 ? vector0 : vector0; /* { dg-error {used vector type where scalar is required} } */
vector0 ? is_a_float16_vec : vector0; /* { dg-error {used vector type where scalar is required} } */
diff --git a/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_2.c b/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_2.c
index 2a8a535daae..b6b7a430efa 100644
--- a/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_2.c
+++ b/gcc/testsuite/gcc.target/i386/vect-bfloat16-typecheck_2.c
@@ -214,8 +214,8 @@ __m256bf16 footest (__m256bf16 vector0)
0 ? 0.1 : vector0; /* { dg-error {type mismatch in conditional expression} } */
0 ? vector0 : 0.1; /* { dg-error {type mismatch in conditional expression} } */
0 ? bfloat_ptr : bfloat_ptr2;
- 0 ? bfloat_ptr : float_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
- 0 ? float_ptr : bfloat_ptr; /* { dg-warning {pointer type mismatch in conditional expression} } */
+ 0 ? bfloat_ptr : float_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
+ 0 ? float_ptr : bfloat_ptr; /* { dg-error {pointer type mismatch in conditional expression} } */
vector0 ? vector0 : vector0; /* { dg-error {used vector type where scalar is required} } */
vector0 ? is_a_float16_vec : vector0; /* { dg-error {used vector type where scalar is required} } */
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 1/6] c-family: Introduce pedpermerror
2023-11-13 13:09 ` [PATCH 1/6] c-family: Introduce pedpermerror Florian Weimer
@ 2023-11-13 19:22 ` Jeff Law
2023-11-14 7:39 ` Florian Weimer
1 sibling, 0 replies; 29+ messages in thread
From: Jeff Law @ 2023-11-13 19:22 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
On 11/13/23 06:09, Florian Weimer wrote:
> It turns out that permerror_opt is not directly usable for
> -fpermissive in the C front end. The front end uses pedwarn
> extensively, and pedwarns are not overridable by -Wno-* options,
> yet permerrors are. Add new pedpermerror helpers that turn into
> pedwarns if -pedantic-errors is active.
>
> Due to the dependency on flag_pedantic_errors, the new helpers
> are specific to the C-family front ends. For implementing the
> rich location variant, export emit_diagnostic_valist from
> gcc/diagnostic.cc in parallel to its location_t variant.
>
> gcc/
>
> * diagnostic-core.h (emit_diagnostic_valist): Declare function.
> * diagnostic.cc (emit_diagnostic_valist): Define it.
>
> gcc/c-family/
>
> * c-common.h (pedpermerror): Declare functions.
> * c-warn.cc (pedpermerror): Define them.
OK
jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
@ 2023-11-13 19:24 ` Jeff Law
2023-11-13 19:44 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416] Sam James
2023-12-01 11:29 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Thomas Schwinge
2 siblings, 0 replies; 29+ messages in thread
From: Jeff Law @ 2023-11-13 19:24 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
On 11/13/23 06:10, Florian Weimer wrote:
> gcc/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-typeck.cc (build_conditional_expr): Use pedpermerror for
> pointer/integer type mismatches, based on -Wint-conversion.
> (pedwarn_pedpermerror_init, permerror_init): New function.
> (pedwarn_init): Call pedwarn_pedpermerror_init.
> (convert_for_assignment): Use pedpermerror and
> pedpermerror_init for -Wint-conversion warnings.
>
> gcc/testsuite/
>
> * c-c++-common/pr77624-1.c (foo, bar): Expect
> error instead of warning.
> * gcc.dg/Wint-conversion-2.c: Compile with -fpermissive due
> to expected int-conversion warning.
> * gcc.dg/Wint-conversion-3.c: Likewise.
> * gcc.dg/Wint-conversion-4.c: New test. Based on
> gcc.dg/Wint-conversion-3.c. Expect int-conversion errors.
> * gcc.dg/assign-warn-1.c: Compile with -fpermissive.
> * gcc.dg/assign-warn-4.c: New file. Extracted from
> assign-warn1.c. Expect int-cnversion errors.
> * gcc.dg/diagnostic-types-1.c: compile with -fpermissive.
> * gcc.dg/diagnostic-types-2.c: New file. Extracted from
> gcc.dg/diagnostic-types-1.c. Expect some errors instead of
> warnings.
> * gcc.dg/gomp/pr35738.c: Compile with -fpermissive due to
> expected int-conversion error.
> * gcc.dg/gomp/pr35738-2.c: New test. Based on
> gcc.dg/gomp/pr35738.c. Expect int-converison errors.
> * gcc.dg/init-excess-3.c: Expect int-converison errors.
> * gcc.dg/overflow-warn-1.c: Likewise.
> * gcc.dg/overflow-warn-3.c: Likewise.
> * gcc.dg/param-type-mismatch.c: Compile with -fpermissive.
> * gcc.dg/param-type-mismatch-2.c: New test. Copied from
> gcc.dg/param-type-mismatch.c. Expect errors.
> * gcc.dg/pr61162-2.c: Compile with -fpermissive.
> * gcc.dg/pr61162-3.c: New test. Extracted from
> gcc.dg/pr61162-2.c. Expect int-conversion errors.
> * gcc.dg/spec-barrier-3.c: Use -fpermissive due to expected
> int-conversion error.
> * gcc.dg/spec-barrier-3a.c: New test. Based on
> gcc.dg/spec-barrier-3.c. Expect int-conversion errors.
> * gcc.target/aarch64/acle/memtag_2.c: Use -fpermissive due to expected
> int-conversion error.
> * gcc.target/aarch64/acle/memtag_2a.c: New test. Copied from
> gcc.target/aarch64/acle/memtag_2.c. Expect error.
> * gcc.target/aarch64/sve/acle/general-c/load_3.c (f1): Expect
> error.
> * gcc.target/aarch64/sve/acle/general-c/store_2.c (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
> (f1): Likewise.
OK
jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror
2023-11-13 13:10 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror Florian Weimer
@ 2023-11-13 19:25 ` Jeff Law
2023-11-13 19:42 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092] Sam James
1 sibling, 0 replies; 29+ messages in thread
From: Jeff Law @ 2023-11-13 19:25 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
On 11/13/23 06:10, Florian Weimer wrote:
> In the future, it may make sense to avoid cascading errors from
> the implicit declaration, especially its assumed int return type.
> This change here only changes the kind of the diagnostic, not
> its wording or consequences.
>
> gcc/c/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-decl.cc (implicit_decl_pedpermerror): Rename from
> implicit_decl_warning. Call pedpermerror instead of
> pedwarn and warning_at.
> (implicitly_declare): Adjust callers.
>
> gcc/testsuite/
>
> * c-c++-common/spellcheck-reserved.c (test, test_2): Expect
> error instead of warning.
> (f): Expect error instead of warning.
> * gcc.dg/Wimplicit-function-declaration-c99.c: Compile with
> -fpermissive due to expected warning.
> * gcc.dg/Wimplicit-function-declaration-c99-2.c: New test.
> Copied from gcc.dg/Wimplicit-function-declaration-c99.c.
> Expect error.
> * gcc.dg/missing-header-fixit-1.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-1a.c: New test. Copied from
> gcc.dg/missing-header-fixit-1.c, but expect error.
> * gcc.dg/missing-header-fixit-2.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-2a.c: New test. Copied from
> gcc.dg/missing-header-fixit-2.c, but expect error.
> * gcc.dg/missing-header-fixit-4.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-4a.c: New test. Copied from
> gcc.dg/missing-header-fixit-4.c, but expect error.
> * gcc.dg/missing-header-fixit-5.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-5a.c: New test. Copied from
> gcc.dg/missing-header-fixit-5.c, but expect error.
> * gcc.dg/pr61852.c: Expect implicit-function-declaration
> error instead of warning.
> * gcc.dg/spellcheck-identifiers-2.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-2a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
> * gcc.dg/spellcheck-identifiers-3.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-3a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
> * gcc.dg/spellcheck-identifiers-4.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-4a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect error.
> * gcc.dg/spellcheck-identifiers.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-1a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers.c. Expect errors.
> * gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c (f1):
> Expect error.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c:
> (f1): Likewise.
> ---
OK
jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror
2023-11-13 13:11 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror Florian Weimer
@ 2023-11-13 19:26 ` Jeff Law
2023-11-13 19:45 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror [PR91093] Sam James
1 sibling, 0 replies; 29+ messages in thread
From: Jeff Law @ 2023-11-13 19:26 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
On 11/13/23 06:11, Florian Weimer wrote:
> There is a missed opportunity here to issue spelling diagnostics
> in prototype declarations (e.g., for “extern int foo (int32t);”).
>
> gcc/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-decl.cc (warn_defaults_to): Call emit_diagnostic_valist
> instead of reimplementing it. Issue a pedpermerror for C99
> and later.
> (store_parm_decls_oldstyle): Call pedpermerror for
> OPT_Wimplicit_int.
>
> gcc/testsuite/
>
> * gcc.dg/Wimplicit-int-1.c: Compile with -fpermissive due to
> expected warning.
> * gcc.dg/Wimplicit-int-4.c: Likewise.
> * gcc.dg/Wimplicit-int-1a.c: New test. Copied from
> gcc.dg/Wimplicit-int-1.c, but expect errors.
> * gcc.dg/Wimplicit-int-4a.c: New test. Copied from
> gcc.dg/Wimplicit-int-4.c, but expect errors.
> * gcc.dg/gnu23-attr-syntax-2.c: Compile with -fpermissive
> due to expected implicit-int error.
> * gcc.dg/gnu23-attr-syntax-3.c: New test. Copied from
> gcc.dg/gnu23-attr-syntax-2.c, but expect an error.
> * gcc.dg/pr105635.c: Build with -fpermissive due to implicit
> int.
> * gcc.dg/pr105635-2.c: New test. Copied from
> gcc.dg/pr105635.c. Expect implicit int error.
> * gcc.dg/noncompile/pr79758.c: Build with -fpermissive due to
> implicit int.
> * gcc.dg/noncompile/pr79758-2.c: New test. Copied from
> gcc.dg/noncompile/pr79758.c. Expect implicit int error.
> ---
OK
jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 5/6] c: Turn -Wreturn-mismatch into a pedpermerror
2023-11-13 13:11 ` [PATCH 5/6] c: Turn -Wreturn-mismatch into a pedpermerror Florian Weimer
@ 2023-11-13 19:28 ` Jeff Law
0 siblings, 0 replies; 29+ messages in thread
From: Jeff Law @ 2023-11-13 19:28 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
On 11/13/23 06:11, Florian Weimer wrote:
> gcc/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-typeck.cc (c_finish_return): Issue a permerror
> for mismatching pointers to builtins. For mismatching
> other pointers, issue a pedpermerror.
>
> gcc/testsuite/
>
> * gcc.dg/20030906-1.c: Compile with -fpermissive due to
> expected -Wreturn-mismatch error.
> * gcc.dg/20030906-1a.c: New test. Copied from
> gcc.dg/20030906-1.c. Expect the error.
> * gcc.dg/20030906-2.c: Compile with -fpermissive due to
> expected -Wreturn-mismatch error.
> * gcc.dg/20030906-2a.c: New test. Copied from
> gcc.dg/20030906-2.c. Expect the error.
> * gcc.dg/Wreturn-mismatch-1.c: Compile with -fpermissive due to
> expected -Wreturn-mismatch error.
> * gcc.dg/Wreturn-mismatch-1a.c: New test. Copied from
> gcc.dg/Wreturn-mismatch-1.c. Expect the error.
> * gcc.dg/Wreturn-mismatch-2.c: Compile with -fpermissive due to
> expected -Wreturn-mismatch error.
> * gcc.dg/Wreturn-mismatch-2a.c: New test. Copied from
> gcc.dg/Wreturn-mismatch-2.c. Expect the error.
> * gcc.dg/diagnostic-range-bad-return.c: Compile with
> -fpermissive due to expected -Wreturn-mismatch error.
> * gcc.dg/diagnostic-range-bad-return-2.c: New test.
> Copied from gcc.dg/diagnostic-range-bad-return.c. Expect the
> error.
> * gcc.dg/pr105635-2.c: Expect -Wreturn-mismatch error.
> * gcc.dg/pr23075.c: Build with -fpermissive due to
> expected -Wreturn-mismatch error.
> * gcc.dg/pr23075-2.c: New test. Copied from gcc.dg/pr23075.c.
> Expect the error.
> * gcc.dg/pr29521.c: Compile with -fpermissive due to expected
> -Wreturn-mismatch error.
> * gcc.dg/pr29521-a.c: New test. Copied from gcc.dg/pr29521.c.
> Expect error.
> * gcc.dg/pr67730.c: Compile with -fpermissive due to expected
> -Wreturn-mismatch error.
> * gcc.dg/pr67730-a.c: New test. Copied from
> gcc.dg/pr67730-a.c. Expect error.
> * gcc.target/powerpc/conditional-return.c: Compile with
> -fpermissive due to expected -Wreturn-mismatch error.
> ---
OK
jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 6/6] c: Turn -Wincompatible-pointer-types into a pedpermerror
2023-11-13 13:11 ` [PATCH 6/6] c: Turn -Wincompatible-pointer-types " Florian Weimer
@ 2023-11-13 19:30 ` Jeff Law
0 siblings, 0 replies; 29+ messages in thread
From: Jeff Law @ 2023-11-13 19:30 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
On 11/13/23 06:11, Florian Weimer wrote:
> gcc/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-typeck.cc (build_conditional_expr): Use pedpermerror-
> equivalent for pointer type mismatches in conditional
> expression.
> (convert_for_assignment): Use pedpermerror and
> pedpermerror_init for OPT_Wincompatible_pointer_types
> warnings.
>
> gcc/testsuite/
>
> * gcc.dg/Wincompatible-pointer-types-2.c: Compile with
> -fpermissive due to expected errors.
> * gcc.dg/Wincompatible-pointer-types-4.c: Likewise.
> * gcc.dg/Wincompatible-pointer-types-5.c: New test. Copied
> from gcc.dg/Wincompatible-pointer-types-2.c. Expect errors.
> * gcc.dg/Wincompatible-pointer-types-6.c: New test. Copied
> from gcc.dg/Wincompatible-pointer-types-4.c. Expect errors.
> * gcc.dg/anon-struct-11.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/anon-struct-11a.c: New test. Copied from
> gcc.dg/anon-struct-11.c. Expect errors.
> * gcc.dg/anon-struct-13.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/anon-struct-13a.c: New test. Copied from
> gcc.dg/anon-struct-13.c. Expect errors.
> * gcc.dg/builtin-arith-overflow-4.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/builtin-arith-overflow-4a.c: New test. Copied from
> gcc.dg/builtin-arith-overflow-4.c. Expect errors.
> * gcc.dg/c23-qual-4.c: Expect -Wincompatible-pointer-types errors.
> * gcc.dg/dfp/composite-type.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/dfp/composite-type-2.c: New test. Copied from
> gcc.dg/dfp/composite-type.c. Expect errors.
> * gcc.dg/diag-aka-1.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/diag-aka-1a.c: New test. Copied from gcc.dg/diag-aka-1a.c.
> Expect errors.
> * gcc.dg/enum-compat-1.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/enum-compat-2.c: New test. Copied from
> gcc.dg/enum-compat-1.c. Expect errors.
> * gcc.dg/func-ptr-conv-1.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/func-ptr-conv-2.c: New test. Copied from
> gcc.dg/func-ptr-conv-1.c. Expect errors.
> * gcc.dg/init-bad-7.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/init-bad-7a.c: New test. Copied from gcc.dg/init-bad-7.c.
> Expect errors.
> * gcc.dg/noncompile/incomplete-3.c (foo): Expect
> -Wincompatible-pointer-types error.
> * gcc.dg/param-type-mismatch-2.c (test8): Likewise.
> * gcc.dg/pointer-array-atomic.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/pointer-array-atomic-2.c: New test. Copied from
> gcc.dg/pointer-array-atomic.c. Expect errors.
> * gcc.dg/pointer-array-quals-1.c (test): Expect
> -Wincompatible-pointer-types errors.
> * gcc.dg/transparent-union-1.c: Compile with -fpermissive
> due to expected errors.
> * gcc.dg/transparent-union-1a.c: New test. Copied from
> gcc.dg/transparent-union-1.c. Expect errors.
> * gcc.target/aarch64/acle/memtag_2a.c
> (test_memtag_warning_return_qualifier): Expect additional
> errors.
> * gcc.target/aarch64/sve/acle/general-c/load_2.c (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/sizeless-1.c (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/sizeless-2.c (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_1.c (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_2.c (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general/attributes_7.c
> (f1): Likewise.
> * gcc.target/i386/sse2-bfloat16-scalar-typecheck.c (footest):
> Expect -Wincompatible-pointer-types errors.
> * gcc.target/i386/vect-bfloat16-typecheck_1.c (footest): Likewise.
> * gcc.target/i386/vect-bfloat16-typecheck_2.c (footest): Likewise.
> ---
OK
jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092]
2023-11-13 13:10 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror Florian Weimer
2023-11-13 19:25 ` Jeff Law
@ 2023-11-13 19:42 ` Sam James
1 sibling, 0 replies; 29+ messages in thread
From: Sam James @ 2023-11-13 19:42 UTC (permalink / raw)
To: Florian Weimer; +Cc: gcc-patches
Florian Weimer <fweimer@redhat.com> writes:
> In the future, it may make sense to avoid cascading errors from
> the implicit declaration, especially its assumed int return type.
> This change here only changes the kind of the diagnostic, not
> its wording or consequences.
>
> gcc/c/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-decl.cc (implicit_decl_pedpermerror): Rename from
> implicit_decl_warning. Call pedpermerror instead of
> pedwarn and warning_at.
> (implicitly_declare): Adjust callers.
>
> gcc/testsuite/
>
> * c-c++-common/spellcheck-reserved.c (test, test_2): Expect
> error instead of warning.
> (f): Expect error instead of warning.
> * gcc.dg/Wimplicit-function-declaration-c99.c: Compile with
> -fpermissive due to expected warning.
> * gcc.dg/Wimplicit-function-declaration-c99-2.c: New test.
> Copied from gcc.dg/Wimplicit-function-declaration-c99.c.
> Expect error.
> * gcc.dg/missing-header-fixit-1.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-1a.c: New test. Copied from
> gcc.dg/missing-header-fixit-1.c, but expect error.
> * gcc.dg/missing-header-fixit-2.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-2a.c: New test. Copied from
> gcc.dg/missing-header-fixit-2.c, but expect error.
> * gcc.dg/missing-header-fixit-4.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-4a.c: New test. Copied from
> gcc.dg/missing-header-fixit-4.c, but expect error.
> * gcc.dg/missing-header-fixit-5.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-5a.c: New test. Copied from
> gcc.dg/missing-header-fixit-5.c, but expect error.
> * gcc.dg/pr61852.c: Expect implicit-function-declaration
> error instead of warning.
> * gcc.dg/spellcheck-identifiers-2.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-2a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
> * gcc.dg/spellcheck-identifiers-3.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-3a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
> * gcc.dg/spellcheck-identifiers-4.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-4a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect error.
> * gcc.dg/spellcheck-identifiers.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-1a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers.c. Expect errors.
> * gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c (f1):
> Expect error.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c:
> (f1): Likewise.
This is PR91092. In due course, we'll also have to update the porting to
GCC 14 page.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 0/6] Turn some C warnings into errors by default
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
` (5 preceding siblings ...)
2023-11-13 13:11 ` [PATCH 6/6] c: Turn -Wincompatible-pointer-types " Florian Weimer
@ 2023-11-13 19:44 ` Sam James
6 siblings, 0 replies; 29+ messages in thread
From: Sam James @ 2023-11-13 19:44 UTC (permalink / raw)
To: Florian Weimer; +Cc: gcc-patches
Florian Weimer <fweimer@redhat.com> writes:
> This patch series converts the following warnings into errors by
> default:
>
> -Wint-conversion
> -Wimplicit-function-declaration
> -Wimplicit-int
> -Wreturn-mismatch
> -Wincompatible-pointer-types
>
> As explained in the first commit, I decided not to use permerror_opt
> because it does not exhibit the existing behavior for -pedantic-errors.
>
> The impact on existing sources of the last commit is not really known to
> me at this point. I plan to start a Fedora build later this week with
> an instrumented compiler, to see how much of a compatible impact it will
> be. The first conversion pass through Fedora only covered
> -Wimplicit-function-declaration, -Wimplicit-int. I started looking at
> -Wint-conversion, and it did not seem to be too bad, so I think
> including it should be fine. I'm more worried about
> -Wincompatible-pointer-types.
>
> I have not yet added a new overview test for -fpermissive. Such a test
> should trigger all the dozen or so places where I introduced
> pedpermerror, and see what happens under multiple dialects, each with
> -fpermissive and without, and maybe also with and withoyt for
> -pedantic-errors in -std=gnu89 and default modes. I plan to do this
> once I get some initial feedback on the direction of these series
> because this test would likely be obsolete fairly quickly if changes to
> the diagnostics are required. I did copy some existing tests to test
> both the error and warning (-fpermissive) diagnostics, and adjusted
> others to expect errors, so there is already quite a bit coverage
> without that overview test.
>
> Right now, this series breaks the build on aarch64-linux-gnu due to an
> incompatible pointer assignment in libgcc:
>
> [PATCH] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder
> <https://inbox.sourceware.org/gcc-patches/874jht5tsq.fsf@oldenburg.str.redhat.com/>
>
> Other targets had the same issue previously, but I've already fixed most
> of them (I hope). There could of course be similar issues lurking in
> target-specific code, or even in system headers.
>
> With the recent testsuite fixes, the testsuite should be fairly clean
> despite these changes. I verified that on i686-linux-gnu,
> powerpc64-linux-gnu, and x86_64-linux-gnu. There is one
> aarch64-linux-gnu testsuite change I'd like the AArch64 maintainers to
> review:
I'll incrementally work on the other targets once stuff lands.
>
> [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c
> <https://inbox.sourceware.org/gcc-patches/87r0kx6eez.fsf@oldenburg.str.redhat.com/>
>
> Recently, I also found a problem in the gm2 testsuite:
>
> [PATCH] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test
> <https://inbox.sourceware.org/gcc-patches/874jhp3nwf.fsf@oldenburg.str.redhat.com/>
>
Also, please tag PR96284 for all of these.
> Thanks,
> Florian
>
>
> Florian Weimer (6):
> c-family: Introduce pedpermerror
> c: Turn int-conversion warnings into permerrors
> c: Turn -Wimplicit-function-declaration into a pedpermerror
> c: Turn -Wimplicit-int into a pedpermerror
> c: Turn -Wreturn-mismatch into a pedpermerror
> c: Turn -Wincompatible-pointer-types into a pedpermerror
>
> gcc/c-family/c-common.h | 4 +
> gcc/c-family/c-warn.cc | 34 ++++
> gcc/c/c-decl.cc | 40 ++--
> gcc/c/c-typeck.cc | 164 +++++++++------
> gcc/diagnostic-core.h | 3 +
> gcc/diagnostic.cc | 7 +
> gcc/doc/invoke.texi | 33 +++-
> gcc/testsuite/c-c++-common/pr77624-1.c | 4 +-
> .../c-c++-common/spellcheck-reserved.c | 4 +-
> gcc/testsuite/gcc.dg/20030906-1.c | 2 +-
> gcc/testsuite/gcc.dg/20030906-1a.c | 21 ++
> gcc/testsuite/gcc.dg/20030906-2.c | 2 +-
> gcc/testsuite/gcc.dg/20030906-2a.c | 21 ++
> .../Wimplicit-function-declaration-c99-2.c | 7 +
> .../Wimplicit-function-declaration-c99.c | 2 +-
> gcc/testsuite/gcc.dg/Wimplicit-int-1.c | 2 +-
> gcc/testsuite/gcc.dg/Wimplicit-int-1a.c | 11 ++
> gcc/testsuite/gcc.dg/Wimplicit-int-4.c | 2 +-
> gcc/testsuite/gcc.dg/Wimplicit-int-4a.c | 11 ++
> .../gcc.dg/Wincompatible-pointer-types-2.c | 2 +-
> .../gcc.dg/Wincompatible-pointer-types-4.c | 2 +-
> .../gcc.dg/Wincompatible-pointer-types-5.c | 10 +
> .../gcc.dg/Wincompatible-pointer-types-6.c | 10 +
> gcc/testsuite/gcc.dg/Wint-conversion-2.c | 2 +-
> gcc/testsuite/gcc.dg/Wint-conversion-3.c | 2 +-
> gcc/testsuite/gcc.dg/Wint-conversion-4.c | 14 ++
> gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c | 2 +-
> gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c | 40 ++++
> gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c | 2 +-
> gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c | 41 ++++
> gcc/testsuite/gcc.dg/anon-struct-11.c | 5 +-
> gcc/testsuite/gcc.dg/anon-struct-11a.c | 111 +++++++++++
> gcc/testsuite/gcc.dg/anon-struct-13.c | 2 +-
> gcc/testsuite/gcc.dg/anon-struct-13a.c | 76 +++++++
> gcc/testsuite/gcc.dg/assign-warn-1.c | 2 +-
> gcc/testsuite/gcc.dg/assign-warn-4.c | 21 ++
> .../gcc.dg/builtin-arith-overflow-4.c | 2 +-
> .../gcc.dg/builtin-arith-overflow-4a.c | 43 ++++
> gcc/testsuite/gcc.dg/c23-qual-4.c | 6 +-
> gcc/testsuite/gcc.dg/dfp/composite-type-2.c | 58 ++++++
> gcc/testsuite/gcc.dg/dfp/composite-type.c | 2 +-
> gcc/testsuite/gcc.dg/diag-aka-1.c | 2 +-
> gcc/testsuite/gcc.dg/diag-aka-1a.c | 29 +++
> .../gcc.dg/diagnostic-range-bad-return-2.c | 52 +++++
> .../gcc.dg/diagnostic-range-bad-return.c | 2 +-
> gcc/testsuite/gcc.dg/diagnostic-types-1.c | 2 +-
> gcc/testsuite/gcc.dg/diagnostic-types-2.c | 24 +++
> gcc/testsuite/gcc.dg/enum-compat-1.c | 2 +-
> gcc/testsuite/gcc.dg/enum-compat-2.c | 32 +++
> gcc/testsuite/gcc.dg/func-ptr-conv-1.c | 2 +-
> gcc/testsuite/gcc.dg/func-ptr-conv-2.c | 56 ++++++
> gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c | 2 +-
> gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c | 17 ++
> gcc/testsuite/gcc.dg/gomp/pr35738-2.c | 18 ++
> gcc/testsuite/gcc.dg/gomp/pr35738.c | 2 +-
> gcc/testsuite/gcc.dg/init-bad-7.c | 2 +-
> gcc/testsuite/gcc.dg/init-bad-7a.c | 12 ++
> gcc/testsuite/gcc.dg/init-excess-3.c | 4 +-
> gcc/testsuite/gcc.dg/missing-header-fixit-1.c | 2 +-
> .../gcc.dg/missing-header-fixit-1a.c | 37 ++++
> gcc/testsuite/gcc.dg/missing-header-fixit-2.c | 2 +-
> .../gcc.dg/missing-header-fixit-2a.c | 31 +++
> gcc/testsuite/gcc.dg/missing-header-fixit-4.c | 2 +-
> .../gcc.dg/missing-header-fixit-4a.c | 27 +++
> gcc/testsuite/gcc.dg/missing-header-fixit-5.c | 2 +-
> .../gcc.dg/missing-header-fixit-5a.c | 42 ++++
> .../gcc.dg/noncompile/incomplete-3.c | 2 +-
> gcc/testsuite/gcc.dg/noncompile/pr79758-2.c | 6 +
> gcc/testsuite/gcc.dg/noncompile/pr79758.c | 1 +
> gcc/testsuite/gcc.dg/overflow-warn-1.c | 4 +-
> gcc/testsuite/gcc.dg/overflow-warn-3.c | 4 +-
> gcc/testsuite/gcc.dg/param-type-mismatch-2.c | 187 ++++++++++++++++++
> gcc/testsuite/gcc.dg/param-type-mismatch.c | 2 +-
> gcc/testsuite/gcc.dg/pointer-array-atomic-2.c | 60 ++++++
> gcc/testsuite/gcc.dg/pointer-array-atomic.c | 2 +-
> gcc/testsuite/gcc.dg/pointer-array-quals-1.c | 6 +-
> gcc/testsuite/gcc.dg/pr105635-2.c | 11 ++
> gcc/testsuite/gcc.dg/pr105635.c | 2 +-
> gcc/testsuite/gcc.dg/pr23075-2.c | 14 ++
> gcc/testsuite/gcc.dg/pr23075.c | 2 +-
> gcc/testsuite/gcc.dg/pr29521-a.c | 15 ++
> gcc/testsuite/gcc.dg/pr29521.c | 2 +-
> gcc/testsuite/gcc.dg/pr61162-2.c | 2 +-
> gcc/testsuite/gcc.dg/pr61162-3.c | 13 ++
> gcc/testsuite/gcc.dg/pr61852.c | 4 +-
> gcc/testsuite/gcc.dg/pr67730-a.c | 11 ++
> gcc/testsuite/gcc.dg/pr67730.c | 2 +-
> gcc/testsuite/gcc.dg/spec-barrier-3.c | 2 +-
> gcc/testsuite/gcc.dg/spec-barrier-3a.c | 13 ++
> .../gcc.dg/spellcheck-identifiers-1a.c | 136 +++++++++++++
> .../gcc.dg/spellcheck-identifiers-2.c | 2 +-
> .../gcc.dg/spellcheck-identifiers-2a.c | 33 ++++
> .../gcc.dg/spellcheck-identifiers-3.c | 2 +-
> .../gcc.dg/spellcheck-identifiers-3a.c | 45 +++++
> .../gcc.dg/spellcheck-identifiers-4.c | 2 +-
> .../gcc.dg/spellcheck-identifiers-4a.c | 10 +
> gcc/testsuite/gcc.dg/spellcheck-identifiers.c | 2 +-
> gcc/testsuite/gcc.dg/transparent-union-1.c | 2 +-
> gcc/testsuite/gcc.dg/transparent-union-1a.c | 85 ++++++++
> .../gcc.target/aarch64/acle/memtag_2.c | 4 +-
> .../gcc.target/aarch64/acle/memtag_2a.c | 71 +++++++
> .../sve/acle/general-c/ld1sh_gather_1.c | 2 +-
> .../aarch64/sve/acle/general-c/load_2.c | 4 +-
> .../aarch64/sve/acle/general-c/load_3.c | 2 +-
> .../acle/general-c/load_ext_gather_index_1.c | 2 +-
> .../load_ext_gather_index_restricted_1.c | 2 +-
> .../acle/general-c/load_ext_gather_offset_1.c | 4 +-
> .../acle/general-c/load_ext_gather_offset_2.c | 4 +-
> .../acle/general-c/load_ext_gather_offset_3.c | 4 +-
> .../acle/general-c/load_ext_gather_offset_4.c | 4 +-
> .../acle/general-c/load_ext_gather_offset_5.c | 4 +-
> .../load_ext_gather_offset_restricted_1.c | 4 +-
> .../load_ext_gather_offset_restricted_2.c | 4 +-
> .../load_ext_gather_offset_restricted_3.c | 4 +-
> .../load_ext_gather_offset_restricted_4.c | 4 +-
> .../aarch64/sve/acle/general-c/sizeless-1.c | 8 +-
> .../aarch64/sve/acle/general-c/sizeless-2.c | 8 +-
> .../aarch64/sve/acle/general-c/store_1.c | 8 +-
> .../aarch64/sve/acle/general-c/store_2.c | 10 +-
> .../acle/general-c/store_scatter_index_1.c | 8 +-
> .../store_scatter_index_restricted_1.c | 8 +-
> .../acle/general-c/store_scatter_offset_2.c | 8 +-
> .../store_scatter_offset_restricted_1.c | 8 +-
> .../aarch64/sve/acle/general/attributes_7.c | 28 +--
> .../i386/sse2-bfloat16-scalar-typecheck.c | 4 +-
> .../i386/vect-bfloat16-typecheck_1.c | 4 +-
> .../i386/vect-bfloat16-typecheck_2.c | 4 +-
> .../gcc.target/powerpc/conditional-return.c | 2 +-
> 128 files changed, 1920 insertions(+), 231 deletions(-)
> create mode 100644 gcc/testsuite/gcc.dg/20030906-1a.c
> create mode 100644 gcc/testsuite/gcc.dg/20030906-2a.c
> create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c
> create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-1a.c
> create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-4a.c
> create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c
> create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-6.c
> create mode 100644 gcc/testsuite/gcc.dg/Wint-conversion-4.c
> create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c
> create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c
> create mode 100644 gcc/testsuite/gcc.dg/anon-struct-11a.c
> create mode 100644 gcc/testsuite/gcc.dg/anon-struct-13a.c
> create mode 100644 gcc/testsuite/gcc.dg/assign-warn-4.c
> create mode 100644 gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c
> create mode 100644 gcc/testsuite/gcc.dg/dfp/composite-type-2.c
> create mode 100644 gcc/testsuite/gcc.dg/diag-aka-1a.c
> create mode 100644 gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c
> create mode 100644 gcc/testsuite/gcc.dg/diagnostic-types-2.c
> create mode 100644 gcc/testsuite/gcc.dg/enum-compat-2.c
> create mode 100644 gcc/testsuite/gcc.dg/func-ptr-conv-2.c
> create mode 100644 gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c
> create mode 100644 gcc/testsuite/gcc.dg/gomp/pr35738-2.c
> create mode 100644 gcc/testsuite/gcc.dg/init-bad-7a.c
> create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-1a.c
> create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-2a.c
> create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-4a.c
> create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-5a.c
> create mode 100644 gcc/testsuite/gcc.dg/noncompile/pr79758-2.c
> create mode 100644 gcc/testsuite/gcc.dg/param-type-mismatch-2.c
> create mode 100644 gcc/testsuite/gcc.dg/pointer-array-atomic-2.c
> create mode 100644 gcc/testsuite/gcc.dg/pr105635-2.c
> create mode 100644 gcc/testsuite/gcc.dg/pr23075-2.c
> create mode 100644 gcc/testsuite/gcc.dg/pr29521-a.c
> create mode 100644 gcc/testsuite/gcc.dg/pr61162-3.c
> create mode 100644 gcc/testsuite/gcc.dg/pr67730-a.c
> create mode 100644 gcc/testsuite/gcc.dg/spec-barrier-3a.c
> create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c
> create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c
> create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c
> create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c
> create mode 100644 gcc/testsuite/gcc.dg/transparent-union-1a.c
> create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
>
>
> base-commit: b51bfee1beed03872ea0289cb47dd2336d9f528c
> prerequisite-patch-id: f46d6a56470ab459865ba2e45372d60e131b9ee2
> prerequisite-patch-id: 7e0b407ec2bbd5e3b9c7ed1342b08d3677a65283
> prerequisite-patch-id: 02e95117add6ada9d5cdb489399fb2e562db76e2
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416]
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
2023-11-13 19:24 ` Jeff Law
@ 2023-11-13 19:44 ` Sam James
2023-12-01 11:29 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Thomas Schwinge
2 siblings, 0 replies; 29+ messages in thread
From: Sam James @ 2023-11-13 19:44 UTC (permalink / raw)
To: Florian Weimer; +Cc: gcc-patches
Florian Weimer <fweimer@redhat.com> writes:
> gcc/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-typeck.cc (build_conditional_expr): Use pedpermerror for
> pointer/integer type mismatches, based on -Wint-conversion.
> (pedwarn_pedpermerror_init, permerror_init): New function.
> (pedwarn_init): Call pedwarn_pedpermerror_init.
> (convert_for_assignment): Use pedpermerror and
> pedpermerror_init for -Wint-conversion warnings.
>
> gcc/testsuite/
>
> * c-c++-common/pr77624-1.c (foo, bar): Expect
> error instead of warning.
> * gcc.dg/Wint-conversion-2.c: Compile with -fpermissive due
> to expected int-conversion warning.
> * gcc.dg/Wint-conversion-3.c: Likewise.
> * gcc.dg/Wint-conversion-4.c: New test. Based on
> gcc.dg/Wint-conversion-3.c. Expect int-conversion errors.
> * gcc.dg/assign-warn-1.c: Compile with -fpermissive.
> * gcc.dg/assign-warn-4.c: New file. Extracted from
> assign-warn1.c. Expect int-cnversion errors.
> * gcc.dg/diagnostic-types-1.c: compile with -fpermissive.
> * gcc.dg/diagnostic-types-2.c: New file. Extracted from
> gcc.dg/diagnostic-types-1.c. Expect some errors instead of
> warnings.
> * gcc.dg/gomp/pr35738.c: Compile with -fpermissive due to
> expected int-conversion error.
> * gcc.dg/gomp/pr35738-2.c: New test. Based on
> gcc.dg/gomp/pr35738.c. Expect int-converison errors.
> * gcc.dg/init-excess-3.c: Expect int-converison errors.
> * gcc.dg/overflow-warn-1.c: Likewise.
> * gcc.dg/overflow-warn-3.c: Likewise.
> * gcc.dg/param-type-mismatch.c: Compile with -fpermissive.
> * gcc.dg/param-type-mismatch-2.c: New test. Copied from
> gcc.dg/param-type-mismatch.c. Expect errors.
> * gcc.dg/pr61162-2.c: Compile with -fpermissive.
> * gcc.dg/pr61162-3.c: New test. Extracted from
> gcc.dg/pr61162-2.c. Expect int-conversion errors.
> * gcc.dg/spec-barrier-3.c: Use -fpermissive due to expected
> int-conversion error.
> * gcc.dg/spec-barrier-3a.c: New test. Based on
> gcc.dg/spec-barrier-3.c. Expect int-conversion errors.
> * gcc.target/aarch64/acle/memtag_2.c: Use -fpermissive due to expected
> int-conversion error.
> * gcc.target/aarch64/acle/memtag_2a.c: New test. Copied from
> gcc.target/aarch64/acle/memtag_2.c. Expect error.
> * gcc.target/aarch64/sve/acle/general-c/load_3.c (f1): Expect
> error.
> * gcc.target/aarch64/sve/acle/general-c/store_2.c (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_index_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_index_restricted_1.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_2.c
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/store_scatter_offset_restricted_1.c
> (f1): Likewise.
This is PR106416.
> ---
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror [PR91093]
2023-11-13 13:11 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror Florian Weimer
2023-11-13 19:26 ` Jeff Law
@ 2023-11-13 19:45 ` Sam James
1 sibling, 0 replies; 29+ messages in thread
From: Sam James @ 2023-11-13 19:45 UTC (permalink / raw)
To: Florian Weimer; +Cc: gcc-patches
Florian Weimer <fweimer@redhat.com> writes:
> There is a missed opportunity here to issue spelling diagnostics
> in prototype declarations (e.g., for “extern int foo (int32t);”).
>
> gcc/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-decl.cc (warn_defaults_to): Call emit_diagnostic_valist
> instead of reimplementing it. Issue a pedpermerror for C99
> and later.
> (store_parm_decls_oldstyle): Call pedpermerror for
> OPT_Wimplicit_int.
>
> gcc/testsuite/
>
> * gcc.dg/Wimplicit-int-1.c: Compile with -fpermissive due to
> expected warning.
> * gcc.dg/Wimplicit-int-4.c: Likewise.
> * gcc.dg/Wimplicit-int-1a.c: New test. Copied from
> gcc.dg/Wimplicit-int-1.c, but expect errors.
> * gcc.dg/Wimplicit-int-4a.c: New test. Copied from
> gcc.dg/Wimplicit-int-4.c, but expect errors.
> * gcc.dg/gnu23-attr-syntax-2.c: Compile with -fpermissive
> due to expected implicit-int error.
> * gcc.dg/gnu23-attr-syntax-3.c: New test. Copied from
> gcc.dg/gnu23-attr-syntax-2.c, but expect an error.
> * gcc.dg/pr105635.c: Build with -fpermissive due to implicit
> int.
> * gcc.dg/pr105635-2.c: New test. Copied from
> gcc.dg/pr105635.c. Expect implicit int error.
> * gcc.dg/noncompile/pr79758.c: Build with -fpermissive due to
> implicit int.
> * gcc.dg/noncompile/pr79758-2.c: New test. Copied from
> gcc.dg/noncompile/pr79758.c. Expect implicit int error.
This is PR91093.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 1/6] c-family: Introduce pedpermerror
2023-11-13 13:09 ` [PATCH 1/6] c-family: Introduce pedpermerror Florian Weimer
2023-11-13 19:22 ` Jeff Law
@ 2023-11-14 7:39 ` Florian Weimer
1 sibling, 0 replies; 29+ messages in thread
From: Florian Weimer @ 2023-11-14 7:39 UTC (permalink / raw)
To: gcc-patches; +Cc: Jason Merrill, Jeff Law, Joseph Myers
* Florian Weimer:
> It turns out that permerror_opt is not directly usable for
> -fpermissive in the C front end. The front end uses pedwarn
> extensively, and pedwarns are not overridable by -Wno-* options,
> yet permerrors are. Add new pedpermerror helpers that turn into
> pedwarns if -pedantic-errors is active.
>
> Due to the dependency on flag_pedantic_errors, the new helpers
> are specific to the C-family front ends. For implementing the
> rich location variant, export emit_diagnostic_valist from
> gcc/diagnostic.cc in parallel to its location_t variant.
>
> gcc/
>
> * diagnostic-core.h (emit_diagnostic_valist): Declare function.
> * diagnostic.cc (emit_diagnostic_valist): Define it.
>
> gcc/c-family/
>
> * c-common.h (pedpermerror): Declare functions.
> * c-warn.cc (pedpermerror): Define them.
Jason suggested off-list that this shouldn't be necessary, and the
description of -pedantic-errors is wrong (it is possible to undo
-pedantic-errors effects with -Wno-error=…). The permerror_opt
interface should already do what I need.
It turns out that I was very unlucky and picked -Wreturn-type for my
tests.
This:
long i = "abc";
volatile j;
int f (void) { return; }
Gives, with GCC 13:
$ gcc -pedantic-errors -Wno-error=implicit-int -Wno-error=int-conversion -Wno-error=return-type test.c
test.c:1:10: warning: initialization of ‘long int’ from ‘char *’ makes integer from pointer without a cast [-Wint-conversion]
1 | long i = "abc";
| ^~~~~
test.c:2:10: warning: type defaults to ‘int’ in declaration of ‘j’ [-Wimplicit-int]
2 | volatile j;
| ^
test.c: In function ‘f’:
test.c:3:16: error: ‘return’ with no value, in function returning non-void
3 | int f (void) { return; }
| ^~~~~~
test.c:3:5: note: declared here
3 | int f (void) { return; }
| ^
This happens because we drop the OPT_Wreturn_type in some cases:
if (flag_isoc99)
warned_here = pedwarn
(loc, warn_return_type >= 0 ? OPT_Wreturn_type : 0,
"%<return%> with no value, in function returning non-void");
else
warned_here = warning_at
(loc, OPT_Wreturn_type,
"%<return%> with no value, in function returning non-void");
And for the other direction:
if (TREE_CODE (TREE_TYPE (retval)) != VOID_TYPE)
warned_here = pedwarn
(xloc, warn_return_type >= 0 ? OPT_Wreturn_type : 0,
"%<return%> with a value, in function returning void");
I think with the -Wreturn-mismatch split, we can drop the
warn_return_type >= 0 condition, and then permerror_opt should indeed
do the right thing.
I'll write the kitchen sink test now, use that to verify this theory,
and repost as appropriate.
Thanks,
Florian
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
2023-11-13 19:24 ` Jeff Law
2023-11-13 19:44 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416] Sam James
@ 2023-12-01 11:29 ` Thomas Schwinge
2023-12-01 11:36 ` Florian Weimer
2 siblings, 1 reply; 29+ messages in thread
From: Thomas Schwinge @ 2023-12-01 11:29 UTC (permalink / raw)
To: Florian Weimer; +Cc: gcc-patches
Hi Florian!
On 2023-11-13T14:10:34+0100, Florian Weimer <fweimer@redhat.com> wrote:
> --- a/gcc/c/c-typeck.cc
> +++ b/gcc/c/c-typeck.cc
> @@ -7616,27 +7639,28 @@ convert_for_assignment (location_t location, location_t expr_loc, tree type,
> case ic_assign:
> - pedwarn (location, OPT_Wint_conversion,
> - "assignment to %qT from %qT makes pointer from integer "
> - "without a cast", type, rhstype);
> + pedpermerror (location, OPT_Wint_conversion,
> + "assignment to %qT from %qT makes pointer from "
> + "integer without a cast", type, rhstype);
> break;
In addition to the many ones that you've fixed, there's one more:
[-PASS:-]{+FAIL:+} gcc.dg/graphite/pr83126.c (test for excess errors)
[...]/testsuite/gcc.dg/graphite/pr83126.c: In function 'ew':
[...]/testsuite/gcc.dg/graphite/pr83126.c:15:10: error: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
Presumably your testing didn't have Graphite enabled due to missing
host libisl? However, you should be able to reproduce without that:
$ build-gcc/gcc/xgcc -Bbuild-gcc/gcc/ source-gcc/gcc/testsuite/gcc.dg/graphite/pr83126.c
source-gcc/gcc/testsuite/gcc.dg/graphite/pr83126.c: In function ‘ew’:
source-gcc/gcc/testsuite/gcc.dg/graphite/pr83126.c:15:10: error: assignment to ‘int *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
15 | fd = *fd;
| ^
I'm not proposing a patch as I don't know whether you'd like to just
silence the diagnostic, fix (?) the test case, and/or add another
'dg-error'-checking test case? (I've not yet looked at the history of
the test case.)
Grüße
Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-01 11:29 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Thomas Schwinge
@ 2023-12-01 11:36 ` Florian Weimer
0 siblings, 0 replies; 29+ messages in thread
From: Florian Weimer @ 2023-12-01 11:36 UTC (permalink / raw)
To: Thomas Schwinge; +Cc: gcc-patches
* Thomas Schwinge:
> I'm not proposing a patch as I don't know whether you'd like to just
> silence the diagnostic, fix (?) the test case, and/or add another
> 'dg-error'-checking test case? (I've not yet looked at the history of
> the test case.)
Jakub just posted a patch:
[PATCH] testsuite: Tweak some further tests for modern C changes
<https://inbox.sourceware.org/gcc-patches/ZWnDFz+FcrkpsHzE@tucnak/>
Thanks,
Florian
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-04 7:45 ` Kito Cheng
@ 2023-12-05 0:25 ` Kito Cheng
0 siblings, 0 replies; 29+ messages in thread
From: Kito Cheng @ 2023-12-05 0:25 UTC (permalink / raw)
To: Jeff Law
Cc: Sam James, 钟居哲, thomas, fweimer, gcc-patches
both patches are landed, newlib trunk should be able to build with gcc
trunk now.
On Mon, Dec 4, 2023 at 3:45 PM Kito Cheng <kito.cheng@gmail.com> wrote:
>
> RISC-V newlib patch send, one for libgloss and another one for libm,
> the libm issue is because we don't have right long double support,
> however newlib has supported that few months ago, and porting effort
> is minor, so I just port that to fix the issue :)
>
> https://sourceware.org/pipermail/newlib/2023/020725.html
> https://sourceware.org/pipermail/newlib/2023/020726.html
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-02 15:19 ` Jeff Law
@ 2023-12-04 7:45 ` Kito Cheng
2023-12-05 0:25 ` Kito Cheng
0 siblings, 1 reply; 29+ messages in thread
From: Kito Cheng @ 2023-12-04 7:45 UTC (permalink / raw)
To: Jeff Law
Cc: Sam James, 钟居哲, thomas, fweimer, gcc-patches
RISC-V newlib patch send, one for libgloss and another one for libm,
the libm issue is because we don't have right long double support,
however newlib has supported that few months ago, and porting effort
is minor, so I just port that to fix the issue :)
https://sourceware.org/pipermail/newlib/2023/020725.html
https://sourceware.org/pipermail/newlib/2023/020726.html
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-02 5:47 ` Sam James
@ 2023-12-02 15:19 ` Jeff Law
2023-12-04 7:45 ` Kito Cheng
0 siblings, 1 reply; 29+ messages in thread
From: Jeff Law @ 2023-12-02 15:19 UTC (permalink / raw)
To: Sam James; +Cc: 钟居哲, thomas, fweimer, gcc-patches
On 12/1/23 22:47, Sam James wrote:
>
> Jeff Law <jeffreyalaw@gmail.com> writes:
>
>> On 12/1/23 18:13, Sam James wrote:
>>> 钟居哲 <juzhe.zhong@rivai.ai> writes:
>>>
>>>> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:
>>>>
>>>> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40:
>>>> error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
>>>> 8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
>>>> | ^~~~
>>>> | |
>>>> | const char *
>>> This looks like an issue in newlib. We expect broken code to be
>>> broken
>>> by the recent changes. Can you investigate it on the newlib side?
>> A ton of stuff in newlib/libgloss is broken due to the compiler
>> changes. But that's not a big surprise -- much of the
>> newlib/libgloss code is c89 and clearly wrong for c99 and newer.
>
> Yeah, it's probably a reasonable candidate for -fpermissive to start
> with until it's cleaned up.
Perhaps. Particularly if it can be confined to libgloss as that's where
the bulk of the problems are. It'd be even better if we could
constrain it per-port, but I suspect putting all that in place would be
more work than just fixing this stuff.
>
> (Also, sorry, I didn't mean my comment to appear glib. I just meant to
> say "yes, this looks expected".)
No worries, I didn't take it that way at all. I fully agree this looks
expected and while annoying it's not a big deal IMHO. We fix and move on.
jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-02 3:40 ` Jeff Law
@ 2023-12-02 5:47 ` Sam James
2023-12-02 15:19 ` Jeff Law
0 siblings, 1 reply; 29+ messages in thread
From: Sam James @ 2023-12-02 5:47 UTC (permalink / raw)
To: Jeff Law
Cc: Sam James, 钟居哲, thomas, fweimer, gcc-patches
Jeff Law <jeffreyalaw@gmail.com> writes:
> On 12/1/23 18:13, Sam James wrote:
>> 钟居哲 <juzhe.zhong@rivai.ai> writes:
>>
>>> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:
>>>
>>> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40:
>>> error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
>>> 8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
>>> | ^~~~
>>> | |
>>> | const char *
>> This looks like an issue in newlib. We expect broken code to be
>> broken
>> by the recent changes. Can you investigate it on the newlib side?
> A ton of stuff in newlib/libgloss is broken due to the compiler
> changes. But that's not a big surprise -- much of the
> newlib/libgloss code is c89 and clearly wrong for c99 and newer.
Yeah, it's probably a reasonable candidate for -fpermissive to start
with until it's cleaned up.
(Also, sorry, I didn't mean my comment to appear glib. I just meant to
say "yes, this looks expected".)
>
> Jeff
thanks,
sam
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-02 1:13 ` Sam James
@ 2023-12-02 3:40 ` Jeff Law
2023-12-02 5:47 ` Sam James
0 siblings, 1 reply; 29+ messages in thread
From: Jeff Law @ 2023-12-02 3:40 UTC (permalink / raw)
To: Sam James, 钟居哲; +Cc: thomas, fweimer, gcc-patches
On 12/1/23 18:13, Sam James wrote:
>
> 钟居哲 <juzhe.zhong@rivai.ai> writes:
>
>> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:
>>
>> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40:
>> error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
>> 8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
>> | ^~~~
>> | |
>> | const char *
>
> This looks like an issue in newlib. We expect broken code to be broken
> by the recent changes. Can you investigate it on the newlib side?
A ton of stuff in newlib/libgloss is broken due to the compiler changes.
But that's not a big surprise -- much of the newlib/libgloss code is
c89 and clearly wrong for c99 and newer.
Jeff
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-02 1:53 ` 钟居哲
@ 2023-12-02 3:25 ` Patrick O'Neill
0 siblings, 0 replies; 29+ messages in thread
From: Patrick O'Neill @ 2023-12-02 3:25 UTC (permalink / raw)
To: 钟居哲, gcc-patches; +Cc: thomas, fweimer
[-- Attachment #1: Type: text/plain, Size: 24458 bytes --]
That failure is is due to newlib files:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../*newlib*/newlib/libm/complex/ccoshl.c:
In function 'ccoshl':
To build gcc w/ glibc with riscv-gnu-toolchain, run make linux.
A temporary fix for newlib is here:
https://github.com/patrick-rivos/riscv-gnu-toolchain/tree/35d8e8c486bd2f6e3e2e673db8d2b979309a6de4/fixups/newlib
On 12/1/23 17:53, 钟居哲 wrote:
> No. GLIBC 2.37 also failed:
>
> make[4]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib/riscv64-unknown-elf/newlib'
> CC libm/complex/libm_a-casinhl.o
> make[3]: *** [Makefile:5283: all] Error 2
> make[3]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib/riscv64-unknown-elf/newlib'
> make[2]: *** [Makefile:8492: all-target-newlib] Error 2
> make[2]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib'
> make[1]: *** [Makefile:879: all] Error 2
> make[1]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib'
> make: *** [Makefile:624: stamps/build-newlib] Error 2
> make: *** Waiting for unfinished jobs....
> CC libm/complex/libm_a-csinhl.o
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccoshl.c:
> In function 'ccoshl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccoshl.c:43:13:
> error: implicit declaration of function 'coshl'; did you mean 'coshf'?
> [-Wimplicit-function-declaration]
> 43 | w = coshl(x) * cosl(y) + (sinhl(x) * sinl(y)) * I;
> | ^~~~~
> | coshf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccoshl.c:43:24:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 43 | w = coshl(x) * cosl(y) + (sinhl(x) * sinl(y)) * I;
> | ^~~~
> | cosf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/clogl.c:
> In function 'clogl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccoshl.c:43:35:
> error: implicit declaration of function 'sinhl'; did you mean 'sinhf'?
> [-Wimplicit-function-declaration]
> 43 | w = coshl(x) * cosl(y) + (sinhl(x) * sinl(y)) * I;
> | ^~~~~
> | sinhf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/clogl.c:42:13:
> error: implicit declaration of function 'logl'; did you mean 'logf'?
> [-Wimplicit-function-declaration]
> 42 | p = logl(rr);
> | ^~~~
> | logf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccoshl.c:43:46:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 43 | w = coshl(x) * cosl(y) + (sinhl(x) * sinl(y)) * I;
> | ^~~~
> | sinf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/clogl.c:43:14:
> error: implicit declaration of function 'atan2l'; did you mean
> 'atan2f'? [-Wimplicit-function-declaration]
> 43 | rr = atan2l(cimagl(z), creall(z));
> | ^~~~~~
> | atan2f
> CC libm/complex/libm_a-csinl.o
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cexpl.c:
> In function 'cexpl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cexpl.c:43:13:
> error: implicit declaration of function 'expl'; did you mean 'expf'?
> [-Wimplicit-function-declaration]
> 43 | r = expl(x);
> | ^~~~
> | expf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cexpl.c:44:17:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 44 | w = r * cosl(y) + r * sinl(y) * I;
> | ^~~~
> | cosf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cexpl.c:44:31:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 44 | w = r * cosl(y) + r * sinl(y) * I;
> | ^~~~
> | sinf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cephes_subrl.c:
> In function '_cchshl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cephes_subrl.c:43:13:
> error: implicit declaration of function 'fabsl'; did you mean 'fabsf'?
> [-Wimplicit-function-declaration]
> 43 | if (fabsl(x) <= 0.5L) {
> | ^~~~~
> | fabsf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cargl.c:
> In function 'cargl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cargl.c:16:17:
> error: implicit declaration of function 'atan2l'; did you mean
> 'atan2f'? [-Wimplicit-function-declaration]
> 16 | return atan2l (cimagl (z), creall (z));
> | ^~~~~~
> | atan2f
> CC libm/complex/libm_a-catanl.o
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cephes_subrl.c:44:22:
> error: implicit declaration of function 'coshl'; did you mean 'coshf'?
> [-Wimplicit-function-declaration]
> 44 | *c = coshl(x);
> | ^~~~~
> | coshf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cephes_subrl.c:45:22:
> error: implicit declaration of function 'sinhl'; did you mean 'sinhf'?
> [-Wimplicit-function-declaration]
> 45 | *s = sinhl(x);
> | ^~~~~
> | sinhf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csqrtl.c:
> In function 'csqrtl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csqrtl.c:80:40:
> error: implicit declaration of function 'fabsl'; did you mean 'fabsf'?
> [-Wimplicit-function-declaration]
> 80 | return (cpackl(fabsl(b - b),
> copysignl(a, b)));
> | ^~~~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csqrtl.c:50:24:
> note: in definition of macro 'cpackl'
> 50 | #define cpackl(r, i) ((r) + (i) * I)
> | ^
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cephes_subrl.c:47:21:
> error: implicit declaration of function 'expl'; did you mean 'expf'?
> [-Wimplicit-function-declaration]
> 47 | e = expl(x);
> | ^~~~
> | expf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csqrtl.c:80:54:
> error: implicit declaration of function 'copysignl'; did you mean
> 'copysignf'? [-Wimplicit-function-declaration]
> 80 | return (cpackl(fabsl(b - b),
> copysignl(a, b)));
> | ^~~~~~~~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csqrtl.c:50:30:
> note: in definition of macro 'cpackl'
> 50 | #define cpackl(r, i) ((r) + (i) * I)
> | ^
> CC libm/fenv/libm_a-feclearexcept.o
> CC libm/fenv/libm_a-fe_dfl_env.o
> CC libm/fenv/libm_a-fegetenv.o
> CC libm/fenv/libm_a-fegetexceptflag.o
> make[4]: *** [Makefile:43116: libm/complex/libm_a-ccoshl.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[4]: *** [Makefile:43144: libm/complex/libm_a-clogl.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cprojl.c:
> In function 'cprojl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cprojl.c:60:32:
> error: implicit declaration of function 'copysignl'; did you mean
> 'copysignf'? [-Wimplicit-function-declaration]
> 60 | IMAG_PART(w) = copysignl(0.0L, cimagl(z));
> | ^~~~~~~~~
> | copysignf
> make[4]: *** [Makefile:43200: libm/complex/libm_a-cexpl.o] Error 1
> make[4]: *** [Makefile:43172: libm/complex/libm_a-cargl.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccosl.c:
> In function 'ccosl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccosl.c:43:13:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 43 | w = cosl(creall(z)) * ch - (sinl(creall(z)) * sh) * I;
> | ^~~~
> | cosf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ccosl.c:43:37:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 43 | w = cosl(creall(z)) * ch - (sinl(creall(z)) * sh) * I;
> | ^~~~
> | sinf
> make[4]: *** [Makefile:43214: libm/complex/libm_a-cephes_subrl.o] Error 1
> make[4]: *** [Makefile:43158: libm/complex/libm_a-csqrtl.o] Error 1
> make[4]: *** [Makefile:43186: libm/complex/libm_a-cprojl.o] Error 1
> make[4]: *** [Makefile:43242: libm/complex/libm_a-ccosl.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cpowl.c:
> In function 'cpowl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cpowl.c:48:13:
> error: implicit declaration of function 'powl'; did you mean 'powf'?
> [-Wimplicit-function-declaration]
> 48 | r = powl(absa, x);
> | ^~~~
> | powf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanhl.c:
> In function 'ctanhl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanhl.c:43:13:
> error: implicit declaration of function 'coshl'; did you mean 'coshf'?
> [-Wimplicit-function-declaration]
> 43 | d = coshl(2.0L * x) + cosl(2.0L * y);
> | ^~~~~
> | coshf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cpowl.c:51:25:
> error: implicit declaration of function 'expl'; did you mean 'expf'?
> [-Wimplicit-function-declaration]
> 51 | r = r * expl(-y * arga);
> | ^~~~
> | expf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanhl.c:43:31:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 43 | d = coshl(2.0L * x) + cosl(2.0L * y);
> | ^~~~
> | cosf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cpowl.c:52:37:
> error: implicit declaration of function 'logl'; did you mean 'logf'?
> [-Wimplicit-function-declaration]
> 52 | theta = theta + y * logl(absa);
> | ^~~~
> | logf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanhl.c:44:13:
> error: implicit declaration of function 'sinhl'; did you mean 'sinhf'?
> [-Wimplicit-function-declaration]
> 44 | w = sinhl(2.0L * x) / d + (sinl(2.0L * y) / d) * I;
> | ^~~~~
> | sinhf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cpowl.c:54:17:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 54 | w = r * cosl(theta) + (r * sinl(theta)) * I;
> | ^~~~
> | cosf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanhl.c:44:38:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 44 | w = sinhl(2.0L * x) / d + (sinl(2.0L * y) / d) * I;
> | ^~~~
> | sinf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/cpowl.c:54:36:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 54 | w = r * cosl(theta) + (r * sinl(theta)) * I;
> | ^~~~
> | sinf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanl.c:
> In function 'ctanl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanl.c:43:13:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 43 | d = cosl(2.0L * creall(z)) + coshl(2.0L * cimagl(z));
> | ^~~~
> | cosf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanl.c:43:38:
> error: implicit declaration of function 'coshl'; did you mean 'coshf'?
> [-Wimplicit-function-declaration]
> 43 | d = cosl(2.0L * creall(z)) + coshl(2.0L * cimagl(z));
> | ^~~~~
> | coshf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanl.c:45:13:
> error: implicit declaration of function 'fabsl'; did you mean 'fabsf'?
> [-Wimplicit-function-declaration]
> 45 | if (fabsl(d) < 0.25L)
> | ^~~~~
> | fabsf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanl.c:54:13:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 54 | w = sinl(2.0L * creall(z)) / d + (sinhl(2.0L *
> cimagl(z)) / d) * I;
> | ^~~~
> | sinf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/ctanl.c:54:43:
> error: implicit declaration of function 'sinhl'; did you mean 'sinhf'?
> [-Wimplicit-function-declaration]
> 54 | w = sinl(2.0L * creall(z)) / d + (sinhl(2.0L *
> cimagl(z)) / d) * I;
> | ^~~~~
> | sinhf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinhl.c:
> In function 'csinhl':
> make[4]: *** [Makefile:43312: libm/complex/libm_a-ctanhl.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinhl.c:43:13:
> error: implicit declaration of function 'sinhl'; did you mean 'sinhf'?
> [-Wimplicit-function-declaration]
> 43 | w = sinhl(x) * cosl(y) + (coshl(x) * sinl(y)) * I;
> | ^~~~~
> | sinhf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinhl.c:43:24:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 43 | w = sinhl(x) * cosl(y) + (coshl(x) * sinl(y)) * I;
> | ^~~~
> | cosf
> make[4]: *** [Makefile:43298: libm/complex/libm_a-cpowl.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinhl.c:43:35:
> error: implicit declaration of function 'coshl'; did you mean 'coshf'?
> [-Wimplicit-function-declaration]
> 43 | w = sinhl(x) * cosl(y) + (coshl(x) * sinl(y)) * I;
> | ^~~~~
> | coshf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinhl.c:43:46:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 43 | w = sinhl(x) * cosl(y) + (coshl(x) * sinl(y)) * I;
> | ^~~~
> | sinf
> make[4]: *** [Makefile:43326: libm/complex/libm_a-ctanl.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinl.c:
> In function 'csinl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinl.c:43:13:
> error: implicit declaration of function 'sinl'; did you mean 'sinf'?
> [-Wimplicit-function-declaration]
> 43 | w = sinl(creall(z)) * ch + (cosl(creall(z)) * sh) * I;
> | ^~~~
> | sinf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/csinl.c:43:37:
> error: implicit declaration of function 'cosl'; did you mean 'cosf'?
> [-Wimplicit-function-declaration]
> 43 | w = sinl(creall(z)) * ch + (cosl(creall(z)) * sh) * I;
> | ^~~~
> | cosf
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/catanl.c:
> In function 'catanl':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/catanl.c:55:20:
> error: implicit declaration of function 'atan2l'; did you mean
> 'atan2f'? [-Wimplicit-function-declaration]
> 55 | t = 0.5L * atan2l(2.0L * x, a);
> | ^~~~~~
> | atan2f
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../newlib/newlib/libm/complex/catanl.c:65:26:
> error: implicit declaration of function 'logl'; did you mean 'logf'?
> [-Wimplicit-function-declaration]
> 65 | w = w + (0.25L * logl(a)) * I;
> | ^~~~
> | logf
> make[4]: *** [Makefile:43354: libm/complex/libm_a-csinhl.o] Error 1
> make[4]: *** [Makefile:43368: libm/complex/libm_a-csinl.o] Error 1
> make[4]: *** [Makefile:43382: libm/complex/libm_a-catanl.o] Error 1
> make[4]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib-nano/riscv64-unknown-elf/newlib'
> make[3]: *** [Makefile:5283: all] Error 2
> make[3]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib-nano/riscv64-unknown-elf/newlib'
> make[2]: *** [Makefile:8492: all-target-newlib] Error 2
> make[2]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib-nano'
> make[1]: *** [Makefile:879: all] Error 2
> make[1]: Leaving directory
> '/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/build-newlib-nano'
> make: *** [Makefile:641: stamps/build-newlib-nano] Error 2
>
> Confirm newlib/glibc/musl definitely can not be compiled by trunk GCC.
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-02 0:33 [PATCH 2/6] c: Turn int-conversion warnings into permerrors 钟居哲
2023-12-02 1:10 ` Patrick O'Neill
@ 2023-12-02 1:13 ` Sam James
2023-12-02 3:40 ` Jeff Law
1 sibling, 1 reply; 29+ messages in thread
From: Sam James @ 2023-12-02 1:13 UTC (permalink / raw)
To: 钟居哲; +Cc: thomas, fweimer, gcc-patches
钟居哲 <juzhe.zhong@rivai.ai> writes:
> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:
>
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40:
> error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
> 8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
> | ^~~~
> | |
> | const char *
This looks like an issue in newlib. We expect broken code to be broken
by the recent changes. Can you investigate it on the newlib side?
Thanks.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
2023-12-02 0:33 [PATCH 2/6] c: Turn int-conversion warnings into permerrors 钟居哲
@ 2023-12-02 1:10 ` Patrick O'Neill
2023-12-02 1:53 ` 钟居哲
2023-12-02 1:13 ` Sam James
1 sibling, 1 reply; 29+ messages in thread
From: Patrick O'Neill @ 2023-12-02 1:10 UTC (permalink / raw)
To: 钟居哲, gcc-patches; +Cc: thomas, fweimer
[-- Attachment #1: Type: text/plain, Size: 24331 bytes --]
Hi Juzhe,
I can confirm the failure on Newlib.
I'm not seeing any issues on glibc 2.37.
I haven't tried to build musl.
Since this patch promotes warnings to errors breakages were probably
expected.
The fix may require changes to newlib to remove the errors.
I've hacked together a series of patches on top of newlib 4.3.0 that
resolves these issues (but I think they'd need more work to be
upstream-able):
https://github.com/patrick-rivos/riscv-gnu-toolchain/tree/35d8e8c486bd2f6e3e2e673db8d2b979309a6de4/fixups/newlib
@Thomas @Florian am I right in assuming that breakages were expected/the
fix should come from fixing the warnings?
Thanks,
Patrick
On 12/1/23 16:33, 钟居哲 wrote:
> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:
>
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_utime.c:5:39:
> warning: 'struct utimbuf' declared inside parameter list will not be
> visible outside of this definition or declaration
> 5 | _utime(const char *path, const struct utimbuf *times)
> | ^~~~~~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c:
> In function '_faccessat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c:7:50:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 7 | return syscall_errno (SYS_faccessat, 4, dirfd, file, mode,
> flags, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> make[5]: *** [Makefile:3315: riscv/riscv_libgloss_a-sys_access.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c:
> In function '_open':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c:8:38:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 8 | return syscall_errno (SYS_open, 3, name, flags, mode, 0, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c:
> In function '_openat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c:7:47:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 7 | return syscall_errno (SYS_openat, 4, dirfd, name, flags,
> mode, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> make[5]: *** [Makefile:3427: riscv/riscv_libgloss_a-sys_faccessat.o]
> Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:
> In function '_link':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:7:38:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 7 | return syscall_errno (SYS_link, 2, old_name, new_name, 0, 0,
> 0, 0);
> | ^~~~~~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:7:48:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 7 | return syscall_errno (SYS_link, 2, old_name, new_name, 0, 0,
> 0, 0);
> | ^~~~~~~~
> | |
> | const char *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c:
> In function '_fstat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c:12:47:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 12 | int rv = syscall_errno (SYS_fstat, 2, file, &kst, 0, 0, 0, 0);
> | ^~~~
> | |
> | struct kernel_stat *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:
> In function '_fstatat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:11:50:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 11 | int rv = syscall_errno (SYS_fstatat, 4, dirfd, file, &kst,
> flags, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:11:56:
> error: passing argument 5 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 11 | int rv = syscall_errno (SYS_fstatat, 4, dirfd, file, &kst,
> flags, 0, 0);
> | ^~~~
> | |
> | struct kernel_stat *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c:
> In function '_unlink':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:58:
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c:8:40:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 8 | return syscall_errno (SYS_unlink, 1, name, 0, 0, 0, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:
> In function '_access':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c:
> In function '_read':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c:8:44:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 8 | return syscall_errno (SYS_read, 3, file, ptr, len, 0, 0, 0);
> | ^~~
> | |
> | void *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'void *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> make[5]: *** [Makefile:3609: riscv/riscv_libgloss_a-sys_open.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:
> In function '_lstat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:10:41:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 10 | int rv = syscall_errno (SYS_lstat, 2, file, &kst, 0, 0, 0, 0);
> | ^~~~
> | |
> | const char *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:10:47:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 10 | int rv = syscall_errno (SYS_lstat, 2, file, &kst, 0, 0, 0, 0);
> | ^~~~
> | |
> | struct kernel_stat *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c:
> In function '_write':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c:9:45:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 9 | return syscall_errno (SYS_write, 3, file, ptr, len, 0, 0, 0);
> | ^~~
> | |
> | const void *
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'const void *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:
> In function '_stat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:11:40:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 11 | int rv = syscall_errno (SYS_stat, 2, file, &kst, 0, 0, 0, 0);
> | ^~~~
> | |
> | const char *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c:
> In function '_gettimeofday':
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'const char *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:11:46:
> error: passing argument 4 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 11 | int rv = syscall_errno (SYS_stat, 2, file, &kst, 0, 0, 0, 0);
> | ^~~~
> | |
> | struct kernel_stat *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c:29:46:
> error: passing argument 3 of 'syscall_errno' makes integer from
> pointer without a cast [-Wint-conversion]
> 29 | return syscall_errno (SYS_gettimeofday, 1, tp, 0, 0, 0, 0, 0);
> | ^~
> | |
> | struct timeval *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48:
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> In file included from
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c:4:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38:
> note: expected 'long int' but argument is of type 'struct timeval *'
> 66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2,
> long _a3, long _a4, long _a5)
> | ~~~~~^~~
> make[5]: *** [Makefile:3623: riscv/riscv_libgloss_a-sys_openat.o] Error 1
> make[5]: *** [Makefile:3567: riscv/riscv_libgloss_a-sys_link.o] Error 1
> make[5]: *** [Makefile:3455: riscv/riscv_libgloss_a-sys_fstat.o] Error 1
> make[5]: *** [Makefile:3469: riscv/riscv_libgloss_a-sys_fstatat.o] Error 1
> make[5]: *** [Makefile:3707: riscv/riscv_libgloss_a-sys_unlink.o] Error 1
> make[5]: *** [Makefile:4127: riscv/riscv_libsim_a-sys_access.o] Error 1
> make[5]: *** [Makefile:3637: riscv/riscv_libgloss_a-sys_read.o] Error 1
> make[5]: *** [Makefile:3595: riscv/riscv_libgloss_a-sys_lstat.o] Error 1
> make[5]: *** [Makefile:3749: riscv/riscv_libgloss_a-sys_write.o] Error 1
> make[5]: *** [Makefile:3665: riscv/riscv_libgloss_a-sys_stat.o] Error 1
> make[5]: *** [Makefile:3525:
> riscv/riscv_libgloss_a-sys_gettimeofday.o] Error 1
>
>
> ------------------------------------------------------------------------
> juzhe.zhong@rivai.ai
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 2/6] c: Turn int-conversion warnings into permerrors
@ 2023-12-02 0:33 钟居哲
2023-12-02 1:10 ` Patrick O'Neill
2023-12-02 1:13 ` Sam James
0 siblings, 2 replies; 29+ messages in thread
From: 钟居哲 @ 2023-12-02 0:33 UTC (permalink / raw)
To: gcc-patches; +Cc: thomas, fweimer
[-- Attachment #1: Type: text/plain, Size: 22009 bytes --]
Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:2:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_utime.c:5:39: warning: 'struct utimbuf' declared inside parameter list will not be visible outside of this definition or declaration
5 | _utime(const char *path, const struct utimbuf *times)
| ^~~~~~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c: In function '_faccessat':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c:7:50: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
7 | return syscall_errno (SYS_faccessat, 4, dirfd, file, mode, flags, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c:2:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
make[5]: *** [Makefile:3315: riscv/riscv_libgloss_a-sys_access.o] Error 1
make[5]: *** Waiting for unfinished jobs....
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c: In function '_open':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c:8:38: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
8 | return syscall_errno (SYS_open, 3, name, flags, mode, 0, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c:2:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c: In function '_openat':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c:7:47: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
7 | return syscall_errno (SYS_openat, 4, dirfd, name, flags, mode, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c:2:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
make[5]: *** [Makefile:3427: riscv/riscv_libgloss_a-sys_faccessat.o] Error 1
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c: In function '_link':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:7:38: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
7 | return syscall_errno (SYS_link, 2, old_name, new_name, 0, 0, 0, 0);
| ^~~~~~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:2:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:7:48: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
7 | return syscall_errno (SYS_link, 2, old_name, new_name, 0, 0, 0, 0);
| ^~~~~~~~
| |
| const char *
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c: In function '_fstat':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c:12:47: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
12 | int rv = syscall_errno (SYS_fstat, 2, file, &kst, 0, 0, 0, 0);
| ^~~~
| |
| struct kernel_stat *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c:3:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'struct kernel_stat *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c: In function '_fstatat':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:11:50: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
11 | int rv = syscall_errno (SYS_fstatat, 4, dirfd, file, &kst, flags, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:3:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:11:56: error: passing argument 5 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
11 | int rv = syscall_errno (SYS_fstatat, 4, dirfd, file, &kst, flags, 0, 0);
| ^~~~
| |
| struct kernel_stat *
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c: In function '_unlink':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:58: note: expected 'long int' but argument is of type 'struct kernel_stat *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c:8:40: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
8 | return syscall_errno (SYS_unlink, 1, name, 0, 0, 0, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c:2:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c: In function '_access':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
8 | return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:2:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c: In function '_read':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c:8:44: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
8 | return syscall_errno (SYS_read, 3, file, ptr, len, 0, 0, 0);
| ^~~
| |
| void *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c:3:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'void *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
make[5]: *** [Makefile:3609: riscv/riscv_libgloss_a-sys_open.o] Error 1
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c: In function '_lstat':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:10:41: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
10 | int rv = syscall_errno (SYS_lstat, 2, file, &kst, 0, 0, 0, 0);
| ^~~~
| |
| const char *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:3:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:10:47: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
10 | int rv = syscall_errno (SYS_lstat, 2, file, &kst, 0, 0, 0, 0);
| ^~~~
| |
| struct kernel_stat *
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'struct kernel_stat *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c: In function '_write':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c:9:45: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
9 | return syscall_errno (SYS_write, 3, file, ptr, len, 0, 0, 0);
| ^~~
| |
| const void *
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c:3:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'const void *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c: In function '_stat':
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:11:40: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
11 | int rv = syscall_errno (SYS_stat, 2, file, &kst, 0, 0, 0, 0);
| ^~~~
| |
| const char *
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c: In function '_gettimeofday':
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:3:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'const char *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:11:46: error: passing argument 4 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
11 | int rv = syscall_errno (SYS_stat, 2, file, &kst, 0, 0, 0, 0);
| ^~~~
| |
| struct kernel_stat *
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c:29:46: error: passing argument 3 of 'syscall_errno' makes integer from pointer without a cast [-Wint-conversion]
29 | return syscall_errno (SYS_gettimeofday, 1, tp, 0, 0, 0, 0, 0);
| ^~
| |
| struct timeval *
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: note: expected 'long int' but argument is of type 'struct kernel_stat *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
In file included from /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c:4:
/work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: note: expected 'long int' but argument is of type 'struct timeval *'
66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, long _a3, long _a4, long _a5)
| ~~~~~^~~
make[5]: *** [Makefile:3623: riscv/riscv_libgloss_a-sys_openat.o] Error 1
make[5]: *** [Makefile:3567: riscv/riscv_libgloss_a-sys_link.o] Error 1
make[5]: *** [Makefile:3455: riscv/riscv_libgloss_a-sys_fstat.o] Error 1
make[5]: *** [Makefile:3469: riscv/riscv_libgloss_a-sys_fstatat.o] Error 1
make[5]: *** [Makefile:3707: riscv/riscv_libgloss_a-sys_unlink.o] Error 1
make[5]: *** [Makefile:4127: riscv/riscv_libsim_a-sys_access.o] Error 1
make[5]: *** [Makefile:3637: riscv/riscv_libgloss_a-sys_read.o] Error 1
make[5]: *** [Makefile:3595: riscv/riscv_libgloss_a-sys_lstat.o] Error 1
make[5]: *** [Makefile:3749: riscv/riscv_libgloss_a-sys_write.o] Error 1
make[5]: *** [Makefile:3665: riscv/riscv_libgloss_a-sys_stat.o] Error 1
make[5]: *** [Makefile:3525: riscv/riscv_libgloss_a-sys_gettimeofday.o] Error 1
juzhe.zhong@rivai.ai
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2023-12-05 0:25 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
2023-11-13 13:09 ` [PATCH 1/6] c-family: Introduce pedpermerror Florian Weimer
2023-11-13 19:22 ` Jeff Law
2023-11-14 7:39 ` Florian Weimer
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
2023-11-13 19:24 ` Jeff Law
2023-11-13 19:44 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416] Sam James
2023-12-01 11:29 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Thomas Schwinge
2023-12-01 11:36 ` Florian Weimer
2023-11-13 13:10 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror Florian Weimer
2023-11-13 19:25 ` Jeff Law
2023-11-13 19:42 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092] Sam James
2023-11-13 13:11 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror Florian Weimer
2023-11-13 19:26 ` Jeff Law
2023-11-13 19:45 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror [PR91093] Sam James
2023-11-13 13:11 ` [PATCH 5/6] c: Turn -Wreturn-mismatch into a pedpermerror Florian Weimer
2023-11-13 19:28 ` Jeff Law
2023-11-13 13:11 ` [PATCH 6/6] c: Turn -Wincompatible-pointer-types " Florian Weimer
2023-11-13 19:30 ` Jeff Law
2023-11-13 19:44 ` [PATCH 0/6] Turn some C warnings into errors by default Sam James
2023-12-02 0:33 [PATCH 2/6] c: Turn int-conversion warnings into permerrors 钟居哲
2023-12-02 1:10 ` Patrick O'Neill
2023-12-02 1:53 ` 钟居哲
2023-12-02 3:25 ` Patrick O'Neill
2023-12-02 1:13 ` Sam James
2023-12-02 3:40 ` Jeff Law
2023-12-02 5:47 ` Sam James
2023-12-02 15:19 ` Jeff Law
2023-12-04 7:45 ` Kito Cheng
2023-12-05 0:25 ` Kito Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).