Re: gfortran.dg/dg.exp debug messages pollute test output

[Thomas Schwinge <thomas@codesourcery.com>]

Hi!

On 2023-11-15T11:29:20+0100, FX Coudert <fxcoudert@gmail.com> wrote:
>>> it's unclear if those messages can just be removed (they are pretty
>>> cryptic as is) or at least changed to use verbose instead of puts.
>>> Please fix.
>
> I don’t see value in this output, so I think it’s best to remove the puts calls entirely.

ACK, I'd noticed that, too.

> Attached patch does that.

> --- a/gcc/testsuite/gfortran.dg/coarray/caf.exp
> +++ b/gcc/testsuite/gfortran.dg/coarray/caf.exp
> @@ -81,7 +81,6 @@ if [check_effective_target_libatomic_available] {
>       }
>      }
>      set t [get_multilibs]
> -    puts "maybe al $maybe_atomic_lib ml $t"
>  }

I suppose 'set t [...]' can be let go, too?

> --- a/gcc/testsuite/gfortran.dg/dg.exp
> +++ b/gcc/testsuite/gfortran.dg/dg.exp
> @@ -68,7 +68,6 @@ if [check_effective_target_libatomic_available] {
>          set maybe_atomic_lib ""
>      }
>    set t [get_multilibs]
> -  puts "dg set al $maybe_atomic_lib ml $t"
>  }

Likewise.


Grüße
 Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955