From: Ian Lance Taylor <iant@golang.org>
To: FX Coudert <fxcoudert@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Iain Sandoe <iain@sandoe.co.uk>
Subject: Re: Darwin: Replace environment runpath with embedded [PR88590]
Date: Thu, 30 Nov 2023 11:43:47 -0800 [thread overview]
Message-ID: <CAKOQZ8wf60hJSW5Jem_1JGgOdRPOSLJ9P_cMo5a3mTTXEsPYSw@mail.gmail.com> (raw)
In-Reply-To: <11A36820-BC70-4A8C-8EAE-85E5CA6FD9F6@gmail.com>
On Sun, Oct 22, 2023 at 2:18 PM FX Coudert <fxcoudert@gmail.com> wrote:
>
> Thanks a lot Alexandre for the review!
This patch changed the files lingo/configure.ac and libgo/configure.
Those files live in an upstream repository and should be changed there
and then merged into the GCC repo, as described in libgo/README.gcc.
This is not a big deal, and I can take care of changing the upstream
repository. But I don't understand the changes in libgo. As far as I
can tell, all they do is add an automake conditional that is never
used. Is there any reason for that? Should I just revert the changes
to libgo?
To be clear, I am asking about this change in git revision
6a6d3817afa02bbcd2388c8e005da6faf88932f1 and the corresponding change
in the generated file libgo/configure.ac. Thanks.
diff --git a/libgo/configure.ac b/libgo/configure.ac
index 54c35c0903c..e8d66f8415d 100644
--- a/libgo/configure.ac
+++ b/libgo/configure.ac
@@ -53,6 +53,7 @@ AC_LIBTOOL_DLOPEN
AM_PROG_LIBTOOL
AC_SUBST(enable_shared)
AC_SUBST(enable_static)
+AM_CONDITIONAL([ENABLE_DARWIN_AT_RPATH], [test
x$enable_darwin_at_rpath = xyes])
CC_FOR_BUILD=${CC_FOR_BUILD:-gcc}
AC_SUBST(CC_FOR_BUILD)
next prev parent reply other threads:[~2023-11-30 19:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 16:58 FX Coudert
2023-08-18 20:17 ` Joseph Myers
2023-08-18 22:31 ` Iain Sandoe
2023-08-18 22:59 ` Joseph Myers
2023-08-18 23:05 ` Iain Sandoe
2023-08-25 7:50 ` FX Coudert
2023-08-25 16:28 ` Joseph Myers
2023-08-29 16:06 ` FX Coudert
2023-08-29 19:55 ` Joseph Myers
2023-08-29 20:17 ` FX Coudert
2023-09-12 17:52 ` FX Coudert
2023-09-20 13:52 ` FX Coudert
2023-10-08 13:07 ` Nathanael Nerode
2023-10-08 22:14 ` Iain Sandoe
2023-10-21 18:05 ` Jeff Law
2023-10-21 18:26 ` Iain Sandoe
2023-10-21 5:27 ` Alexandre Oliva
2023-10-22 21:18 ` FX Coudert
2023-11-30 19:43 ` Ian Lance Taylor [this message]
2023-11-30 19:56 ` Iain Sandoe
2023-11-30 19:58 ` Ian Lance Taylor
2023-11-30 21:25 ` Ian Lance Taylor
2023-10-30 16:17 ` Martin Jambor
[not found] ` <653fd72a.050a0220.a6a20.de86SMTPIN_ADDED_BROKEN@mx.google.com>
2023-10-30 16:19 ` Iain Sandoe
2023-10-30 16:31 ` FX Coudert
2023-10-30 19:08 ` Iain Sandoe
2023-11-15 20:11 ` Thomas Schwinge
2023-11-15 20:34 ` FX Coudert
2023-11-17 11:56 ` FX Coudert
2023-11-17 12:13 ` Thomas Schwinge
2023-11-17 14:20 ` FX Coudert
2023-11-22 10:52 ` Iain Sandoe
2023-11-22 10:55 ` FX Coudert
2023-11-13 15:27 ` gfortran.dg/dg.exp debug messages pollute test output Rainer Orth
2023-11-13 16:19 ` Iain Sandoe
2023-11-15 10:29 ` FX Coudert
2023-11-15 12:04 ` Rainer Orth
2023-11-17 12:36 ` Thomas Schwinge
2023-11-18 9:03 ` FX Coudert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOQZ8wf60hJSW5Jem_1JGgOdRPOSLJ9P_cMo5a3mTTXEsPYSw@mail.gmail.com \
--to=iant@golang.org \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).