Re: Darwin: Replace environment runpath with embedded [PR88590]

[Iain Sandoe <iain@sandoe.co.uk>]

Hi Ian

> On 30 Nov 2023, at 19:43, Ian Lance Taylor <iant@golang.org> wrote:
> 
> On Sun, Oct 22, 2023 at 2:18 PM FX Coudert <fxcoudert@gmail.com> wrote:
>> 
>> Thanks a lot Alexandre for the review!
> 
> This patch changed the files lingo/configure.ac and libgo/configure.
> Those files live in an upstream repository and should be changed there
> and then merged into the GCC repo, as described in libgo/README.gcc.
> This is not a big deal, and I can take care of changing the upstream
> repository.  But I don't understand the changes in libgo.  As far as I
> can tell, all they do is add an automake conditional that is never
> used.  Is there any reason for that?

It’s not used (yet) because we do not build libgo on Darwin, if/when we
do it would be used in the same way as for the other runtimes.

>  Should I just revert the changes to libgo?

That is also fine (because we do not yet build it on Darwin), it seems unlikely
we’d forget to re-add it.

Iain


> 
> To be clear, I am asking about this change in git revision
> 6a6d3817afa02bbcd2388c8e005da6faf88932f1 and the corresponding change
> in the generated file libgo/configure.ac.  Thanks.
> 
> diff --git a/libgo/configure.ac b/libgo/configure.ac
> index 54c35c0903c..e8d66f8415d 100644
> --- a/libgo/configure.ac
> +++ b/libgo/configure.ac
> @@ -53,6 +53,7 @@ AC_LIBTOOL_DLOPEN
> AM_PROG_LIBTOOL
> AC_SUBST(enable_shared)
> AC_SUBST(enable_static)
> +AM_CONDITIONAL([ENABLE_DARWIN_AT_RPATH], [test
> x$enable_darwin_at_rpath = xyes])
> 
> CC_FOR_BUILD=${CC_FOR_BUILD:-gcc}
> AC_SUBST(CC_FOR_BUILD)