Re: Darwin: Replace environment runpath with embedded [PR88590]

[Ian Lance Taylor <iant@golang.org>]

On Thu, Nov 30, 2023 at 11:58 AM Ian Lance Taylor <iant@golang.org> wrote:
>
> On Thu, Nov 30, 2023 at 11:56 AM Iain Sandoe <iain@sandoe.co.uk> wrote:
> >
> > > On 30 Nov 2023, at 19:43, Ian Lance Taylor <iant@golang.org> wrote:
> > >
> > > On Sun, Oct 22, 2023 at 2:18 PM FX Coudert <fxcoudert@gmail.com> wrote:
> > >>
> > >> Thanks a lot Alexandre for the review!
> > >
> > > This patch changed the files lingo/configure.ac and libgo/configure.
> > > Those files live in an upstream repository and should be changed there
> > > and then merged into the GCC repo, as described in libgo/README.gcc.
> > > This is not a big deal, and I can take care of changing the upstream
> > > repository.  But I don't understand the changes in libgo.  As far as I
> > > can tell, all they do is add an automake conditional that is never
> > > used.  Is there any reason for that?
> >
> > It’s not used (yet) because we do not build libgo on Darwin, if/when we
> > do it would be used in the same way as for the other runtimes.
> >
> > >  Should I just revert the changes to libgo?
> >
> > That is also fine (because we do not yet build it on Darwin), it seems unlikely
> > we’d forget to re-add it.
>
> Thanks, I'll make the change upstream.

Now done.

Ian