public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] configure: add --disable-fix-includes
Date: Mon, 09 May 2022 11:31:52 +0200	[thread overview]
Message-ID: <87v8ufkq5z.fsf@igel.home> (raw)
In-Reply-To: <d59fa9a4-262a-11c8-5290-4f6a138cdfee@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Mon, 9 May 2022 11:03:36 +0200")

On Mai 09 2022, Martin Liška wrote:

> +cat >>confdefs.h <<_ACEOF
> +#define FIX_INCLUDES $disable_fix_includes
> +_ACEOF

Where does this come from?  Also, nothing uses it.

> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index 1171c946e6e..6015e403aa9 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -842,6 +842,12 @@ gather_stats=`if test $enable_gather_detailed_mem_stats != no; then echo 1; else
>  AC_DEFINE_UNQUOTED(GATHER_STATISTICS, $gather_stats,
>  [Define to enable detailed memory allocation stats gathering.])
>  
> +AC_ARG_ENABLE(disable-fix-includes,
> +[AS_HELP_STRING([--disable-fix-includes],
> +		[skip fixing of includes])], [],
> +[disable_fix_includes=yes])

That creates the (non-working) options --enable-disable-fix-includes and
--disable-disable-fix-includes, but not --disable-fix-includes.  It also
disables fixincludes by default, which doesn't look intended.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2022-05-09  9:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  9:03 Martin Liška
2022-05-09  9:31 ` Andreas Schwab [this message]
2022-05-09 21:14 ` Joseph Myers
2022-05-11 10:55   ` Martin Liška
2022-05-11 11:00     ` Rainer Orth
2022-05-11 11:15       ` Martin Liška
2022-05-11 11:31         ` Rainer Orth
2022-05-11 11:58           ` Martin Liška
2022-05-11 12:48             ` Andreas Schwab
2022-05-11 14:50               ` Martin Liška
2022-05-20 12:42                 ` Alexandre Oliva
2022-05-24 12:05                   ` [PATCH v2] Support --disable-fixincludes Martin Liška
2022-05-25  5:37                     ` Alexandre Oliva
2022-07-08 11:14                       ` Martin Liška
2022-07-09 16:11                         ` Jeff Law
2022-08-31  4:30                           ` Xi Ruoyao
2022-08-31  4:30                             ` Xi Ruoyao
2022-08-31 15:25                             ` Alexandre Oliva
  -- strict thread matches above, loose matches on Subject: below --
2022-02-04 12:52 [PATCH] configure: add --disable-fix-includes Martin Liška
2022-02-04 13:07 ` Rainer Orth
2022-02-04 13:25   ` Richard Biener
2022-02-04 13:30     ` Jakub Jelinek
2022-02-04 15:01       ` Martin Liška
2022-02-04 15:22       ` Martin Liška
2022-02-05  2:26         ` Allan McRae
2022-02-28  8:36           ` Martin Liška
2022-02-04 15:02   ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8ufkq5z.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).