Re: [PATCH] configure: add --disable-fix-includes

["Martin Liška" <mliska@suse.cz>]

On 2/4/22 14:07, Rainer Orth wrote:
> Hi Martin,
> 
>> It seems to me that fixincludes is hardy unused feature for nowadays header
>> files and so I'm suggesting a developer option that can skip the fixing.
> 
> please remember that there's a world beyond current-day Linux.

Sure! That's why I'm suggesting an option and not removing the machinery.

> 
>> How is the feature used on other targets?
> 
> There are still quite a number of fixes on e.g. Solaris or macOS.  And
> people are still building gcc on older OS versions for one reason or
> another...
> 
>> diff --git a/gcc/configure.ac b/gcc/configure.ac
>> index 1171c946e6e..6015e403aa9 100644
>> --- a/gcc/configure.ac
>> +++ b/gcc/configure.ac
>> @@ -842,6 +842,12 @@ gather_stats=`if test $enable_gather_detailed_mem_stats != no; then echo 1; else
>>    AC_DEFINE_UNQUOTED(GATHER_STATISTICS, $gather_stats,
>>    [Define to enable detailed memory allocation stats gathering.])
>>    
>> +AC_ARG_ENABLE(disable-fix-includes,
>> +[AS_HELP_STRING([--disable-fix-includes],
> 
> The beast is called fixincludes, no '-' or '_'.
> 
>> +		[skip fixing of includes])], [],
> 
> Better say 'running fixincludes' for example rather than being
> vague/obtuse.

Note using --disable-fixinclude effectively disables building of everything in the folder.
That's not what I want, it breaks GCC build.

> 
> The new options requires documenting in install.texi.
> 
> That said, I'm not sure this is really worth yet adding another option.
> And how are developers supposed to know if they can safely use it or
> not.

Sure.

> 
> Besides, have you actually run a regtest with that option?  I'm asking
> because even on Ubuntu 20.04 fixincludes drops in it's own <limits.h>.
> You need to check that dropping that is actually safe.

Let me try that.

Martin

> 
> 	Rainer
>