public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@gnu.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	gcc-patches@gcc.gnu.org, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] configure: add --disable-fix-includes
Date: Fri, 20 May 2022 09:42:55 -0300	[thread overview]
Message-ID: <ora6bctlww.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <de68d89e-b998-def6-f92c-f734f2be33e1@suse.cz> ("Martin \=\?utf-8\?Q\?Li\=C5\=A1ka\=22's\?\= message of "Wed, 11 May 2022 16:50:54 +0200")

On May 11, 2022, Martin Liška <mliska@suse.cz> wrote:

> Ready to be installed?

Hmm...  I don't like that --disable-fixincludes would still configure,
build and even install fixincludes.  This would be surprising, given
that the semantics of disabling a component is to not even configure it.

How about leaving the top-level alone, and changing gcc/configure.ac to
clear STMP_FIXINC when --disable-fixincludes is given?

-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

  reply	other threads:[~2022-05-20 12:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  9:03 Martin Liška
2022-05-09  9:31 ` Andreas Schwab
2022-05-09 21:14 ` Joseph Myers
2022-05-11 10:55   ` Martin Liška
2022-05-11 11:00     ` Rainer Orth
2022-05-11 11:15       ` Martin Liška
2022-05-11 11:31         ` Rainer Orth
2022-05-11 11:58           ` Martin Liška
2022-05-11 12:48             ` Andreas Schwab
2022-05-11 14:50               ` Martin Liška
2022-05-20 12:42                 ` Alexandre Oliva [this message]
2022-05-24 12:05                   ` [PATCH v2] Support --disable-fixincludes Martin Liška
2022-05-25  5:37                     ` Alexandre Oliva
2022-07-08 11:14                       ` Martin Liška
2022-07-09 16:11                         ` Jeff Law
2022-08-31  4:30                           ` Xi Ruoyao
2022-08-31  4:30                             ` Xi Ruoyao
2022-08-31 15:25                             ` Alexandre Oliva
  -- strict thread matches above, loose matches on Subject: below --
2022-02-04 12:52 [PATCH] configure: add --disable-fix-includes Martin Liška
2022-02-04 13:07 ` Rainer Orth
2022-02-04 13:25   ` Richard Biener
2022-02-04 13:30     ` Jakub Jelinek
2022-02-04 15:01       ` Martin Liška
2022-02-04 15:22       ` Martin Liška
2022-02-05  2:26         ` Allan McRae
2022-02-28  8:36           ` Martin Liška
2022-02-04 15:02   ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ora6bctlww.fsf@lxoliva.fsfla.org \
    --to=oliva@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=mliska@suse.cz \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).