From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Martin Liška" <mliska@suse.cz>
Cc: Joseph Myers <joseph@codesourcery.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] configure: add --disable-fix-includes
Date: Wed, 11 May 2022 13:31:27 +0200 [thread overview]
Message-ID: <yddzgjo486o.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <a8f808d1-43ef-903a-f4fa-1faedfe9ab9f@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Wed, 11 May 2022 13:15:26 +0200")
Hi Martin,
>>> Subject: [PATCH] configure: add --disable-fix-includes
>>
>> As I've mentioned before, I believe, the command is called fixincludes
>> in current gcc docs, and the option should reflect that, not introduce a
>> name used nowhere else.
>
> No, I can't use it, because even with current master using --disable-fixincludes
> means the tool is not built at all. It results with:
>
> g++ -g -DIN_GCC -fPIC -fno-exceptions -fno-rtti
> -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
> -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic
> -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common
> -DHAVE_CONFIG_H -DGENERATOR_FILE -static-libstdc++ -static-libgcc -o
> build/genchecksum \
> build/genchecksum.o ../build-x86_64-pc-linux-gnu/libiberty/pic/libiberty.a
> make: *** No rule to make target
> '../build-x86_64-pc-linux-gnu/fixincludes/fixinc.sh', needed by
> 'stmp-fixinc'. Stop.
> make: *** Waiting for unfinished jobs....
and why not just fix that, rather than introducing yet another option?
This error suggests current --disable-fixincludes is useless on it's
own.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2022-05-11 11:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 9:03 Martin Liška
2022-05-09 9:31 ` Andreas Schwab
2022-05-09 21:14 ` Joseph Myers
2022-05-11 10:55 ` Martin Liška
2022-05-11 11:00 ` Rainer Orth
2022-05-11 11:15 ` Martin Liška
2022-05-11 11:31 ` Rainer Orth [this message]
2022-05-11 11:58 ` Martin Liška
2022-05-11 12:48 ` Andreas Schwab
2022-05-11 14:50 ` Martin Liška
2022-05-20 12:42 ` Alexandre Oliva
2022-05-24 12:05 ` [PATCH v2] Support --disable-fixincludes Martin Liška
2022-05-25 5:37 ` Alexandre Oliva
2022-07-08 11:14 ` Martin Liška
2022-07-09 16:11 ` Jeff Law
2022-08-31 4:30 ` Xi Ruoyao
2022-08-31 4:30 ` Xi Ruoyao
2022-08-31 15:25 ` Alexandre Oliva
-- strict thread matches above, loose matches on Subject: below --
2022-02-04 12:52 [PATCH] configure: add --disable-fix-includes Martin Liška
2022-02-04 13:07 ` Rainer Orth
2022-02-04 13:25 ` Richard Biener
2022-02-04 13:30 ` Jakub Jelinek
2022-02-04 15:01 ` Martin Liška
2022-02-04 15:22 ` Martin Liška
2022-02-05 2:26 ` Allan McRae
2022-02-28 8:36 ` Martin Liška
2022-02-04 15:02 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddzgjo486o.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).