From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Martin Liška" <mliska@suse.cz>
Cc: Joseph Myers <joseph@codesourcery.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] configure: add --disable-fix-includes
Date: Wed, 11 May 2022 13:00:33 +0200 [thread overview]
Message-ID: <ydd4k1w5o6m.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <2e2c7061-3f3f-fde4-6e8c-d2118820a5b6@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Wed, 11 May 2022 12:55:17 +0200")
Hi Martin,
> On 5/9/22 23:14, Joseph Myers wrote:
>> If you add a new configure option, it should be documented in
>> install.texi.
>>
>
> Both comments fixed in the v2.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> From 58d431568d6b6163dd9cdc920239f173689a769c Mon Sep 17 00:00:00 2001
> From: Martin Liska <mliska@suse.cz>
> Date: Fri, 4 Feb 2022 13:42:14 +0100
> Subject: [PATCH] configure: add --disable-fix-includes
As I've mentioned before, I believe, the command is called fixincludes
in current gcc docs, and the option should reflect that, not introduce a
name used nowhere else.
> Right now, fixinclude takes about 11 seconds on my machine, where
> it reads 130MB of header files.
>
> The number of fixed headers is negligible without any significant
> change.
Please speak for Linux, but not for other targets ;-)
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2022-05-11 11:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 9:03 Martin Liška
2022-05-09 9:31 ` Andreas Schwab
2022-05-09 21:14 ` Joseph Myers
2022-05-11 10:55 ` Martin Liška
2022-05-11 11:00 ` Rainer Orth [this message]
2022-05-11 11:15 ` Martin Liška
2022-05-11 11:31 ` Rainer Orth
2022-05-11 11:58 ` Martin Liška
2022-05-11 12:48 ` Andreas Schwab
2022-05-11 14:50 ` Martin Liška
2022-05-20 12:42 ` Alexandre Oliva
2022-05-24 12:05 ` [PATCH v2] Support --disable-fixincludes Martin Liška
2022-05-25 5:37 ` Alexandre Oliva
2022-07-08 11:14 ` Martin Liška
2022-07-09 16:11 ` Jeff Law
2022-08-31 4:30 ` Xi Ruoyao
2022-08-31 4:30 ` Xi Ruoyao
2022-08-31 15:25 ` Alexandre Oliva
-- strict thread matches above, loose matches on Subject: below --
2022-02-04 12:52 [PATCH] configure: add --disable-fix-includes Martin Liška
2022-02-04 13:07 ` Rainer Orth
2022-02-04 13:25 ` Richard Biener
2022-02-04 13:30 ` Jakub Jelinek
2022-02-04 15:01 ` Martin Liška
2022-02-04 15:22 ` Martin Liška
2022-02-05 2:26 ` Allan McRae
2022-02-28 8:36 ` Martin Liška
2022-02-04 15:02 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd4k1w5o6m.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).