[PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

[PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

[Lewis Hyatt]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

Hello-

The attached patch upgrades the cpp_wcwidth() function (needed for
computing display columns in diagnostics output) from Unicode 13 to
Unicode 14. I just mechanically followed the procedure in
contrib/unicode/README with nothing unexpected coming up. I attached it
compressed since it's a bit large, and not really human readable
anyway. Please let me know if it's OK to commit. I did bootstrap/regtest
all languages with no issues on x86-64 Linux. (Although I had to revert
locally one unrelated commit that seems to break bootstrap for Ada on the
master branch currently.)

BTW, is this something simple enough I should just commit it without bugging
the list for approval?

Thanks!

-Lewis

======

Subject: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

The procedure detailed in contrib/unicode/README was followed with nothing
notable coming up. The glibc scripts did not require any update, so the
only change was retrieving new versions of the Unicode data files and
rerunning gen_wcwidth.py.

contrib/ChangeLog:

	* unicode/EastAsianWidth.txt: Update to Unicode 14.0.0.
	* unicode/PropList.txt: Likewise.
	* unicode/README: Likewise.
	* unicode/UnicodeData.txt: Likewise.

libcpp/ChangeLog:

	* generated_cpp_wcwidth.h: Generated from updated Unicode data files.

[-- Attachment #2: unicode_14.txt.gz --]
[-- Type: application/x-gunzip, Size: 29802 bytes --]

Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

[David Malcolm]

On Mon, 2022-06-06 at 17:49 -0400, Lewis Hyatt via Gcc-patches wrote:
> Hello-
> 
> The attached patch upgrades the cpp_wcwidth() function (needed for
> computing display columns in diagnostics output) from Unicode 13 to
> Unicode 14. I just mechanically followed the procedure in
> contrib/unicode/README with nothing unexpected coming up. I attached it
> compressed since it's a bit large, and not really human readable
> anyway. Please let me know if it's OK to commit. I did
> bootstrap/regtest
> all languages with no issues on x86-64 Linux. (Although I had to revert
> locally one unrelated commit that seems to break bootstrap for Ada on
> the
> master branch currently.)
> 
> BTW, is this something simple enough I should just commit it without
> bugging
> the list for approval?

The patch seems reasonable to me, but Joseph seems to be the expert on
i18n-related matters.

Joseph, do we have a policy on this?

Thanks
Dave

> 
> Thanks!
> 
> -Lewis
> 
> ======
> 
> Subject: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0
> 
> The procedure detailed in contrib/unicode/README was followed with
> nothing
> notable coming up. The glibc scripts did not require any update, so the
> only change was retrieving new versions of the Unicode data files and
> rerunning gen_wcwidth.py.
> 
> contrib/ChangeLog:
> 
>         * unicode/EastAsianWidth.txt: Update to Unicode 14.0.0.
>         * unicode/PropList.txt: Likewise.
>         * unicode/README: Likewise.
>         * unicode/UnicodeData.txt: Likewise.
> 
> libcpp/ChangeLog:
> 
>         * generated_cpp_wcwidth.h: Generated from updated Unicode data
> files.

Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

[Joseph Myers]

On Fri, 24 Jun 2022, David Malcolm via Gcc-patches wrote:

> > BTW, is this something simple enough I should just commit it without
> > bugging
> > the list for approval?
> 
> The patch seems reasonable to me, but Joseph seems to be the expert on
> i18n-related matters.
> 
> Joseph, do we have a policy on this?

I don't think we have a policy on Unicode updates specifically, but the 
general principle for updating files maintained outside GCC and copied 
verbatim into the GCC sources doesn't require prior approval.

(Note that Unicode data is also used to generate ucnid.h - data for 
Unicode characters in identifiers - we should probably also include 
DerivedNormalizationProps.txt and DerivedCoreProperties.txt in the 
checked-in Unicode data for that purpose.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

[Lewis Hyatt]

On Fri, Jun 24, 2022 at 3:26 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Fri, 24 Jun 2022, David Malcolm via Gcc-patches wrote:
>
> > > BTW, is this something simple enough I should just commit it without
> > > bugging
> > > the list for approval?
> >
> > The patch seems reasonable to me, but Joseph seems to be the expert on
> > i18n-related matters.
> >
> > Joseph, do we have a policy on this?
>
> I don't think we have a policy on Unicode updates specifically, but the
> general principle for updating files maintained outside GCC and copied
> verbatim into the GCC sources doesn't require prior approval.
>
> (Note that Unicode data is also used to generate ucnid.h - data for
> Unicode characters in identifiers - we should probably also include
> DerivedNormalizationProps.txt and DerivedCoreProperties.txt in the
> checked-in Unicode data for that purpose.)

Thank you both for the feedback. I have pushed the change for wcwidth,
and then I will follow up with a patch that adds these other two
Unicode data files and updates contrib/unicode/README so that the
procedure there will update both wcwidth and ucnid.h... and the patch
will follow that procedure to update ucnid.h from Unicode 13 to
Unicode 14.

-Lewis