[PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.

[PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.

[Zopolis0]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0014-middle-end-Set-TREE_ADDRESSABLE-in-folding-debug-stm.patch --]
[-- Type: application/x-patch, Size: 1607 bytes --]

Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.

[Richard Biener]

On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>

That's wrong and the comment you remove explains why.

Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.

[Zopolis0]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

I was reverting a076632e274abe344ca7648b7c7f299273d4cbe0 as it removed code
for Java, but I may have misunderstood the change and made the incorrect
edits.

On Sat, 26 Nov 2022 at 07:16, Richard Biener <richard.guenther@gmail.com>
wrote:

> On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
>
> That's wrong and the comment you remove explains why.
>

Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.

[Richard Biener]

On Sat, Nov 26, 2022 at 1:19 AM Zopolis0 <creatorsmithmdt@gmail.com> wrote:
>
> I was reverting a076632e274abe344ca7648b7c7f299273d4cbe0 as it removed code for Java, but I may have misunderstood the change and made the incorrect edits.

The change is fixing a bug (setting TREE_ADDRESSABLE from a CTOR in
debug stmts) and fixes up the C++ frontend to
properly mark things addressable when needed.  I suspect the Java
frontend will need something similar - when
there's breakage without this reversion track down where what is
complained on is produced in the Java frontend
and properly mark things as TREE_ADDRESSABLE there.

Richard.

> On Sat, 26 Nov 2022 at 07:16, Richard Biener <richard.guenther@gmail.com> wrote:
>>
>> On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
>> <gcc-patches@gcc.gnu.org> wrote:
>> >
>>
>> That's wrong and the comment you remove explains why.

Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.

[Zopolis0]

New plan-- this patch is entirely pointless! I have reverted it in a
local build and had no regressions.

As such, simply do not review or consider this patch. I am not not
planning on re-sending the patchset even though it adjusts the patch
numbers because it is such an arduous process given that gmail no
longer supports git send-email.