* [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc
@ 2022-09-16 18:49 Sergei Trofimovich
2022-09-22 21:07 ` Sergei Trofimovich
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2022-09-16 18:49 UTC (permalink / raw)
To: gcc-patches; +Cc: Sergei Trofimovich
From: Sergei Trofimovich <siarheit@google.com>
i386-builtin-types.inc is included indirectly via i386-builtins.h
into 4 files: i386.cc i386-builtins.cc i386-expand.cc i386-features.cc
Only i386.cc dependency was present in gcc/config/t-i386 makefile.
As a result parallel builds occasionally fail as:
g++ ... -o i386-builtins.o ... ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc
In file included from ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc:92:
../../gcc-13-20220911/gcc/config/i386/i386-builtins.h:25:10:
fatal error: i386-builtin-types.inc: No such file or directory
25 | #include "i386-builtin-types.inc"
| ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [../../gcc-13-20220911/gcc/config/i386/t-i386:54: i386-builtins.o]
Error 1 shuffle=1663349189
gcc/
* config/i386/t-i386: Add build-time dependencies against
i386-builtin-types.inc to i386-builtins.o, i386-expand.o,
i386-features.o.
---
gcc/config/i386/t-i386 | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gcc/config/i386/t-i386 b/gcc/config/i386/t-i386
index 4e2a0efc615..ffdbbdfe8ce 100644
--- a/gcc/config/i386/t-i386
+++ b/gcc/config/i386/t-i386
@@ -62,7 +62,12 @@ i386-features.o: $(srcdir)/config/i386/i386-features.cc
$(COMPILE) $<
$(POSTCOMPILE)
+# i386-builtin-types.inc is included into i386-builtins.h.
+# Below are direct users of i386-builtins.h:
i386.o: i386-builtin-types.inc
+i386-builtins.o: i386-builtin-types.inc
+i386-expand.o: i386-builtin-types.inc
+i386-features.o: i386-builtin-types.inc
i386-builtin-types.inc: s-i386-bt ; @true
s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \
--
2.37.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc
2022-09-16 18:49 [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc Sergei Trofimovich
@ 2022-09-22 21:07 ` Sergei Trofimovich
2022-10-03 7:04 ` PING " Sergei Trofimovich
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2022-09-22 21:07 UTC (permalink / raw)
To: GCC Patches; +Cc: Sergei Trofimovich
On Fri, 16 Sept 2022 at 19:49, Sergei Trofimovich <slyich@gmail.com> wrote:
>
> From: Sergei Trofimovich <siarheit@google.com>
>
> i386-builtin-types.inc is included indirectly via i386-builtins.h
> into 4 files: i386.cc i386-builtins.cc i386-expand.cc i386-features.cc
>
> Only i386.cc dependency was present in gcc/config/t-i386 makefile.
>
> As a result parallel builds occasionally fail as:
>
> g++ ... -o i386-builtins.o ... ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc
> In file included from ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc:92:
> ../../gcc-13-20220911/gcc/config/i386/i386-builtins.h:25:10:
> fatal error: i386-builtin-types.inc: No such file or directory
> 25 | #include "i386-builtin-types.inc"
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[3]: *** [../../gcc-13-20220911/gcc/config/i386/t-i386:54: i386-builtins.o]
> Error 1 shuffle=1663349189
>
> gcc/
> * config/i386/t-i386: Add build-time dependencies against
> i386-builtin-types.inc to i386-builtins.o, i386-expand.o,
> i386-features.o.
> ---
> gcc/config/i386/t-i386 | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gcc/config/i386/t-i386 b/gcc/config/i386/t-i386
> index 4e2a0efc615..ffdbbdfe8ce 100644
> --- a/gcc/config/i386/t-i386
> +++ b/gcc/config/i386/t-i386
> @@ -62,7 +62,12 @@ i386-features.o: $(srcdir)/config/i386/i386-features.cc
> $(COMPILE) $<
> $(POSTCOMPILE)
>
> +# i386-builtin-types.inc is included into i386-builtins.h.
> +# Below are direct users of i386-builtins.h:
> i386.o: i386-builtin-types.inc
> +i386-builtins.o: i386-builtin-types.inc
> +i386-expand.o: i386-builtin-types.inc
> +i386-features.o: i386-builtin-types.inc
>
> i386-builtin-types.inc: s-i386-bt ; @true
> s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \
> --
> 2.37.2
>
Is it a reasonable approach? Maybe gcc has an equivalent of automake's
BUILT_SOURCES to avoid explicit tracking of such dependencies?
--
Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* PING [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc
2022-09-22 21:07 ` Sergei Trofimovich
@ 2022-10-03 7:04 ` Sergei Trofimovich
2022-10-03 20:41 ` Uros Bizjak
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2022-10-03 7:04 UTC (permalink / raw)
To: GCC Patches; +Cc: Sergei Trofimovich
On Thu, 22 Sep 2022 22:07:52 +0100
Sergei Trofimovich <slyich@gmail.com> wrote:
> On Fri, 16 Sept 2022 at 19:49, Sergei Trofimovich <slyich@gmail.com> wrote:
> >
> > From: Sergei Trofimovich <siarheit@google.com>
> >
> > i386-builtin-types.inc is included indirectly via i386-builtins.h
> > into 4 files: i386.cc i386-builtins.cc i386-expand.cc i386-features.cc
> >
> > Only i386.cc dependency was present in gcc/config/t-i386 makefile.
> >
> > As a result parallel builds occasionally fail as:
> >
> > g++ ... -o i386-builtins.o ... ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc
> > In file included from ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc:92:
> > ../../gcc-13-20220911/gcc/config/i386/i386-builtins.h:25:10:
> > fatal error: i386-builtin-types.inc: No such file or directory
> > 25 | #include "i386-builtin-types.inc"
> > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > make[3]: *** [../../gcc-13-20220911/gcc/config/i386/t-i386:54: i386-builtins.o]
> > Error 1 shuffle=1663349189
> >
> > gcc/
> > * config/i386/t-i386: Add build-time dependencies against
> > i386-builtin-types.inc to i386-builtins.o, i386-expand.o,
> > i386-features.o.
> > ---
> > gcc/config/i386/t-i386 | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/gcc/config/i386/t-i386 b/gcc/config/i386/t-i386
> > index 4e2a0efc615..ffdbbdfe8ce 100644
> > --- a/gcc/config/i386/t-i386
> > +++ b/gcc/config/i386/t-i386
> > @@ -62,7 +62,12 @@ i386-features.o: $(srcdir)/config/i386/i386-features.cc
> > $(COMPILE) $<
> > $(POSTCOMPILE)
> >
> > +# i386-builtin-types.inc is included into i386-builtins.h.
> > +# Below are direct users of i386-builtins.h:
> > i386.o: i386-builtin-types.inc
> > +i386-builtins.o: i386-builtin-types.inc
> > +i386-expand.o: i386-builtin-types.inc
> > +i386-features.o: i386-builtin-types.inc
> >
> > i386-builtin-types.inc: s-i386-bt ; @true
> > s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \
> > --
> > 2.37.2
> >
>
> Is it a reasonable approach? Maybe gcc has an equivalent of automake's
> BUILT_SOURCES to avoid explicit tracking of such dependencies?
>
> --
> Sergei
--
Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PING [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc
2022-10-03 7:04 ` PING " Sergei Trofimovich
@ 2022-10-03 20:41 ` Uros Bizjak
0 siblings, 0 replies; 4+ messages in thread
From: Uros Bizjak @ 2022-10-03 20:41 UTC (permalink / raw)
To: Sergei Trofimovich; +Cc: GCC Patches, Sergei Trofimovich
On Mon, Oct 3, 2022 at 9:05 AM Sergei Trofimovich via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Thu, 22 Sep 2022 22:07:52 +0100
> Sergei Trofimovich <slyich@gmail.com> wrote:
>
> > On Fri, 16 Sept 2022 at 19:49, Sergei Trofimovich <slyich@gmail.com> wrote:
> > >
> > > From: Sergei Trofimovich <siarheit@google.com>
> > >
> > > i386-builtin-types.inc is included indirectly via i386-builtins.h
> > > into 4 files: i386.cc i386-builtins.cc i386-expand.cc i386-features.cc
> > >
> > > Only i386.cc dependency was present in gcc/config/t-i386 makefile.
> > >
> > > As a result parallel builds occasionally fail as:
> > >
> > > g++ ... -o i386-builtins.o ... ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc
> > > In file included from ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc:92:
> > > ../../gcc-13-20220911/gcc/config/i386/i386-builtins.h:25:10:
> > > fatal error: i386-builtin-types.inc: No such file or directory
> > > 25 | #include "i386-builtin-types.inc"
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> > > make[3]: *** [../../gcc-13-20220911/gcc/config/i386/t-i386:54: i386-builtins.o]
> > > Error 1 shuffle=1663349189
> > >
> > > gcc/
> > > * config/i386/t-i386: Add build-time dependencies against
> > > i386-builtin-types.inc to i386-builtins.o, i386-expand.o,
> > > i386-features.o.
OK.
Thanks,
Uros.
> > > ---
> > > gcc/config/i386/t-i386 | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/gcc/config/i386/t-i386 b/gcc/config/i386/t-i386
> > > index 4e2a0efc615..ffdbbdfe8ce 100644
> > > --- a/gcc/config/i386/t-i386
> > > +++ b/gcc/config/i386/t-i386
> > > @@ -62,7 +62,12 @@ i386-features.o: $(srcdir)/config/i386/i386-features.cc
> > > $(COMPILE) $<
> > > $(POSTCOMPILE)
> > >
> > > +# i386-builtin-types.inc is included into i386-builtins.h.
> > > +# Below are direct users of i386-builtins.h:
> > > i386.o: i386-builtin-types.inc
> > > +i386-builtins.o: i386-builtin-types.inc
> > > +i386-expand.o: i386-builtin-types.inc
> > > +i386-features.o: i386-builtin-types.inc
> > >
> > > i386-builtin-types.inc: s-i386-bt ; @true
> > > s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \
> > > --
> > > 2.37.2
> > >
> >
> > Is it a reasonable approach? Maybe gcc has an equivalent of automake's
> > BUILT_SOURCES to avoid explicit tracking of such dependencies?
> >
> > --
> > Sergei
>
>
> --
>
> Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-03 20:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16 18:49 [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc Sergei Trofimovich
2022-09-22 21:07 ` Sergei Trofimovich
2022-10-03 7:04 ` PING " Sergei Trofimovich
2022-10-03 20:41 ` Uros Bizjak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).