* [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension}
@ 2024-04-04 10:00 Alex Coplan
2024-04-15 10:13 ` Alex Coplan
0 siblings, 1 reply; 8+ messages in thread
From: Alex Coplan @ 2024-04-04 10:00 UTC (permalink / raw)
To: gcc-patches; +Cc: Jason Merrill, Marek Polacek, Joseph Myers, Iain Sandoe
[-- Attachment #1: Type: text/plain, Size: 139 bytes --]
Hi,
This adds a note to the GCC 14 release notes mentioning support for
__has_{feature,extension} (PR60512).
OK to commit?
Thanks,
Alex
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 658 bytes --]
diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
index 9fd224c1..facead8d 100644
--- a/htdocs/gcc-14/changes.html
+++ b/htdocs/gcc-14/changes.html
@@ -242,6 +242,12 @@ a work-in-progress.</p>
<code>constinit</code> and optimized dynamic initialization</li>
</ul>
</li>
+ <li>The Clang language extensions <code>__has_feature</code> and
+ <code>__has_extension</code> have been implemented in GCC. These
+ are available from C, C++, and Objective-C(++).
+ This is primarily intended to aid the portability of code written
+ against Clang.
+ </li>
</ul>
<h4 id="libstdcxx">Runtime Library (libstdc++)</h4>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} 2024-04-04 10:00 [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} Alex Coplan @ 2024-04-15 10:13 ` Alex Coplan 2024-04-15 20:22 ` Eric Gallager 2024-04-17 15:41 ` Marek Polacek 0 siblings, 2 replies; 8+ messages in thread From: Alex Coplan @ 2024-04-15 10:13 UTC (permalink / raw) To: gcc-patches; +Cc: Jason Merrill, Marek Polacek, Joseph Myers, Iain Sandoe On 04/04/2024 11:00, Alex Coplan wrote: > Hi, > > This adds a note to the GCC 14 release notes mentioning support for > __has_{feature,extension} (PR60512). > > OK to commit? Ping. Is this changes.html patch OK? I guess it needs a review from C++ maintainers since it adds to the C++ section. > > Thanks, > Alex > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > index 9fd224c1..facead8d 100644 > --- a/htdocs/gcc-14/changes.html > +++ b/htdocs/gcc-14/changes.html > @@ -242,6 +242,12 @@ a work-in-progress.</p> > <code>constinit</code> and optimized dynamic initialization</li> > </ul> > </li> > + <li>The Clang language extensions <code>__has_feature</code> and > + <code>__has_extension</code> have been implemented in GCC. These > + are available from C, C++, and Objective-C(++). > + This is primarily intended to aid the portability of code written > + against Clang. > + </li> > </ul> > > <h4 id="libstdcxx">Runtime Library (libstdc++)</h4> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} 2024-04-15 10:13 ` Alex Coplan @ 2024-04-15 20:22 ` Eric Gallager 2024-04-17 15:41 ` Marek Polacek 1 sibling, 0 replies; 8+ messages in thread From: Eric Gallager @ 2024-04-15 20:22 UTC (permalink / raw) To: Alex Coplan Cc: gcc-patches, Jason Merrill, Marek Polacek, Joseph Myers, Iain Sandoe On Mon, Apr 15, 2024 at 6:14 AM Alex Coplan <alex.coplan@arm.com> wrote: > > On 04/04/2024 11:00, Alex Coplan wrote: > > Hi, > > > > This adds a note to the GCC 14 release notes mentioning support for > > __has_{feature,extension} (PR60512). > > > > OK to commit? > > Ping. Is this changes.html patch OK? I guess it needs a review from C++ > maintainers since it adds to the C++ section. > I think it's ok, but then again I can't approve; maybe try the docs maintainers (i.e. Gerald and/or Sandra) if you don't hear back from the C++ ones? > > > > Thanks, > > Alex > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > > index 9fd224c1..facead8d 100644 > > --- a/htdocs/gcc-14/changes.html > > +++ b/htdocs/gcc-14/changes.html > > @@ -242,6 +242,12 @@ a work-in-progress.</p> > > <code>constinit</code> and optimized dynamic initialization</li> > > </ul> > > </li> > > + <li>The Clang language extensions <code>__has_feature</code> and > > + <code>__has_extension</code> have been implemented in GCC. These > > + are available from C, C++, and Objective-C(++). > > + This is primarily intended to aid the portability of code written > > + against Clang. > > + </li> > > </ul> > > > > <h4 id="libstdcxx">Runtime Library (libstdc++)</h4> > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} 2024-04-15 10:13 ` Alex Coplan 2024-04-15 20:22 ` Eric Gallager @ 2024-04-17 15:41 ` Marek Polacek 2024-04-26 10:12 ` Alex Coplan 1 sibling, 1 reply; 8+ messages in thread From: Marek Polacek @ 2024-04-17 15:41 UTC (permalink / raw) To: Alex Coplan; +Cc: gcc-patches, Jason Merrill, Joseph Myers, Iain Sandoe On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote: > On 04/04/2024 11:00, Alex Coplan wrote: > > Hi, > > > > This adds a note to the GCC 14 release notes mentioning support for > > __has_{feature,extension} (PR60512). > > > > OK to commit? > > Ping. Is this changes.html patch OK? I guess it needs a review from C++ > maintainers since it adds to the C++ section. > > > > > Thanks, > > Alex > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > > index 9fd224c1..facead8d 100644 > > --- a/htdocs/gcc-14/changes.html > > +++ b/htdocs/gcc-14/changes.html > > @@ -242,6 +242,12 @@ a work-in-progress.</p> > > <code>constinit</code> and optimized dynamic initialization</li> > > </ul> > > </li> > > + <li>The Clang language extensions <code>__has_feature</code> and > > + <code>__has_extension</code> have been implemented in GCC. These > > + are available from C, C++, and Objective-C(++). Since the extension is for the whole c-family, not just C++, I think it belongs to a "C family" section. See e.g. <https://gcc.gnu.org/gcc-13/changes.html>. Marek ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} 2024-04-17 15:41 ` Marek Polacek @ 2024-04-26 10:12 ` Alex Coplan 2024-04-26 13:14 ` Marek Polacek 0 siblings, 1 reply; 8+ messages in thread From: Alex Coplan @ 2024-04-26 10:12 UTC (permalink / raw) To: Marek Polacek; +Cc: gcc-patches, Jason Merrill, Joseph Myers, Iain Sandoe On 17/04/2024 11:41, Marek Polacek wrote: > On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote: > > On 04/04/2024 11:00, Alex Coplan wrote: > > > Hi, > > > > > > This adds a note to the GCC 14 release notes mentioning support for > > > __has_{feature,extension} (PR60512). > > > > > > OK to commit? > > > > Ping. Is this changes.html patch OK? I guess it needs a review from C++ > > maintainers since it adds to the C++ section. > > > > > > > > Thanks, > > > Alex > > > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > > > index 9fd224c1..facead8d 100644 > > > --- a/htdocs/gcc-14/changes.html > > > +++ b/htdocs/gcc-14/changes.html > > > @@ -242,6 +242,12 @@ a work-in-progress.</p> > > > <code>constinit</code> and optimized dynamic initialization</li> > > > </ul> > > > </li> > > > + <li>The Clang language extensions <code>__has_feature</code> and > > > + <code>__has_extension</code> have been implemented in GCC. These > > > + are available from C, C++, and Objective-C(++). > > Since the extension is for the whole c-family, not just C++, I think it > belongs to a "C family" section. See e.g. <https://gcc.gnu.org/gcc-13/changes.html>. Thanks, I agree that makes more sense. How about this version instead then: diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index fce0fb44..42353955 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -303,7 +303,15 @@ a work-in-progress.</p> <li>Further clean up and improvements to the GNAT code.</li> </ul> -<!-- <h3 id="c-family">C family</h3> --> +<h3 id="c-family">C family</h3> +<ul> + <li>The Clang language extensions <code>__has_feature</code> and + <code>__has_extension</code> have been implemented in GCC. These + are available from C, C++, and Objective-C(++). + This is primarily intended to aid the portability of code written + against Clang. + </li> +</ul> <h4 id="c">C</h3> Alex > > Marek > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} 2024-04-26 10:12 ` Alex Coplan @ 2024-04-26 13:14 ` Marek Polacek 2024-04-26 13:31 ` Alex Coplan 2024-05-01 11:27 ` Gerald Pfeifer 0 siblings, 2 replies; 8+ messages in thread From: Marek Polacek @ 2024-04-26 13:14 UTC (permalink / raw) To: Alex Coplan; +Cc: gcc-patches, Jason Merrill, Joseph Myers, Iain Sandoe On Fri, Apr 26, 2024 at 11:12:54AM +0100, Alex Coplan wrote: > On 17/04/2024 11:41, Marek Polacek wrote: > > On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote: > > > On 04/04/2024 11:00, Alex Coplan wrote: > > > > Hi, > > > > > > > > This adds a note to the GCC 14 release notes mentioning support for > > > > __has_{feature,extension} (PR60512). > > > > > > > > OK to commit? > > > > > > Ping. Is this changes.html patch OK? I guess it needs a review from C++ > > > maintainers since it adds to the C++ section. > > > > > > > > > > > Thanks, > > > > Alex > > > > > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > > > > index 9fd224c1..facead8d 100644 > > > > --- a/htdocs/gcc-14/changes.html > > > > +++ b/htdocs/gcc-14/changes.html > > > > @@ -242,6 +242,12 @@ a work-in-progress.</p> > > > > <code>constinit</code> and optimized dynamic initialization</li> > > > > </ul> > > > > </li> > > > > + <li>The Clang language extensions <code>__has_feature</code> and > > > > + <code>__has_extension</code> have been implemented in GCC. These > > > > + are available from C, C++, and Objective-C(++). > > > > Since the extension is for the whole c-family, not just C++, I think it > > belongs to a "C family" section. See e.g. <https://gcc.gnu.org/gcc-13/changes.html>. > > Thanks, I agree that makes more sense. How about this version instead then: Thanks, I think you can go ahead with this. > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > index fce0fb44..42353955 100644 > --- a/htdocs/gcc-14/changes.html > +++ b/htdocs/gcc-14/changes.html > @@ -303,7 +303,15 @@ a work-in-progress.</p> > <li>Further clean up and improvements to the GNAT code.</li> > </ul> > > -<!-- <h3 id="c-family">C family</h3> --> > +<h3 id="c-family">C family</h3> > +<ul> > + <li>The Clang language extensions <code>__has_feature</code> and > + <code>__has_extension</code> have been implemented in GCC. These > + are available from C, C++, and Objective-C(++). > + This is primarily intended to aid the portability of code written > + against Clang. > + </li> > +</ul> > > <h4 id="c">C</h3> Marek ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} 2024-04-26 13:14 ` Marek Polacek @ 2024-04-26 13:31 ` Alex Coplan 2024-05-01 11:27 ` Gerald Pfeifer 1 sibling, 0 replies; 8+ messages in thread From: Alex Coplan @ 2024-04-26 13:31 UTC (permalink / raw) To: Marek Polacek; +Cc: gcc-patches, Jason Merrill, Joseph Myers, Iain Sandoe On 26/04/2024 09:14, Marek Polacek wrote: > On Fri, Apr 26, 2024 at 11:12:54AM +0100, Alex Coplan wrote: > > On 17/04/2024 11:41, Marek Polacek wrote: > > > On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote: > > > > On 04/04/2024 11:00, Alex Coplan wrote: > > > > > Hi, > > > > > > > > > > This adds a note to the GCC 14 release notes mentioning support for > > > > > __has_{feature,extension} (PR60512). > > > > > > > > > > OK to commit? > > > > > > > > Ping. Is this changes.html patch OK? I guess it needs a review from C++ > > > > maintainers since it adds to the C++ section. > > > > > > > > > > > > > > Thanks, > > > > > Alex > > > > > > > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > > > > > index 9fd224c1..facead8d 100644 > > > > > --- a/htdocs/gcc-14/changes.html > > > > > +++ b/htdocs/gcc-14/changes.html > > > > > @@ -242,6 +242,12 @@ a work-in-progress.</p> > > > > > <code>constinit</code> and optimized dynamic initialization</li> > > > > > </ul> > > > > > </li> > > > > > + <li>The Clang language extensions <code>__has_feature</code> and > > > > > + <code>__has_extension</code> have been implemented in GCC. These > > > > > + are available from C, C++, and Objective-C(++). > > > > > > Since the extension is for the whole c-family, not just C++, I think it > > > belongs to a "C family" section. See e.g. <https://gcc.gnu.org/gcc-13/changes.html>. > > > > Thanks, I agree that makes more sense. How about this version instead then: > > Thanks, I think you can go ahead with this. Great, I've pushed that to wwwdocs. > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > > index fce0fb44..42353955 100644 > > --- a/htdocs/gcc-14/changes.html > > +++ b/htdocs/gcc-14/changes.html > > @@ -303,7 +303,15 @@ a work-in-progress.</p> > > <li>Further clean up and improvements to the GNAT code.</li> > > </ul> > > > > -<!-- <h3 id="c-family">C family</h3> --> > > +<h3 id="c-family">C family</h3> > > +<ul> > > + <li>The Clang language extensions <code>__has_feature</code> and > > + <code>__has_extension</code> have been implemented in GCC. These > > + are available from C, C++, and Objective-C(++). > > + This is primarily intended to aid the portability of code written > > + against Clang. > > + </li> > > +</ul> > > > > <h4 id="c">C</h3> > > Marek > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} 2024-04-26 13:14 ` Marek Polacek 2024-04-26 13:31 ` Alex Coplan @ 2024-05-01 11:27 ` Gerald Pfeifer 1 sibling, 0 replies; 8+ messages in thread From: Gerald Pfeifer @ 2024-05-01 11:27 UTC (permalink / raw) To: Marek Polacek, Alex Coplan Cc: gcc-patches, Jason Merrill, Joseph Myers, Iain Sandoe On Fri, 26 Apr 2024, Marek Polacek wrote: > Thanks, I think you can go ahead with this. Agreed, thanks. Alex, if you agree, how about simplifying + This is primarily intended to aid the portability of code written + against Clang. to + This is aids the portability of code written against Clang. or similar? (Feel free to simply push such a change.) Gerald ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-05-01 11:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-04 10:00 [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension} Alex Coplan
2024-04-15 10:13 ` Alex Coplan
2024-04-15 20:22 ` Eric Gallager
2024-04-17 15:41 ` Marek Polacek
2024-04-26 10:12 ` Alex Coplan
2024-04-26 13:14 ` Marek Polacek
2024-04-26 13:31 ` Alex Coplan
2024-05-01 11:27 ` Gerald Pfeifer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).