public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* GCC Rust git branch
@ 2021-05-24 13:24 Philip Herron
  2021-05-24 16:24 ` Joseph Myers
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Philip Herron @ 2021-05-24 13:24 UTC (permalink / raw)
  To: gcc


[-- Attachment #1.1: Type: text/plain, Size: 2051 bytes --]

Hi everyone,

As some of you might know, I have been working on GCC Rust over on
GitHub https://github.com/Rust-GCC/gccrs. As the project is moving
forward and enforcing GCC copyright assignments for contributors, I
would like to create a branch on the GCC git repo to show the intention
to be upstream with GCC someday.

I tried to push the branch towards the start of the year, but I hit an
issue:

```
Enumerating objects: 4706, done.
Counting objects: 100% (4706/4706), done.
Delta compression using up to 8 threads
Compressing objects: 100% (1699/1699), done.
Writing objects: 100% (4412/4412), 3.33 MiB | 948.00 KiB/s, done.
Total 4412 (delta 3058), reused 3869 (delta 2683)
remote: Resolving deltas: 100% (3058/3058), completed with 271 local
objects.
remote: *** Invalid revision history for commit
c7c6f785c8e893ec7bcacd1a2319ce309d2450f2:
remote: *** The first line should be the subject of the commit,
remote: *** followed by an empty line.
remote: ***
remote: *** Below are the first few lines of the revision history:
remote: *** | Adding Rust target hook documentation
remote: *** | Added powerpc target hook and improved aarch64 feature
handling
remote: *** | Added DEC Alpha target hook
remote: *** | Added ARC target hook
remote: *** | Created ARM target hook (at least preliminary support)
remote: ***
remote: *** Please amend the commit's revision history and try again.
remote: error: hook declined to update refs/heads/gccrs
To ssh://gcc.gnu.org/git/gcc.git
 ! [remote rejected]         gcc-mirror -> gccrs (hook declined)
```

The commit message here is poorly formatted. To move forward, should I
rebase the tree to fix this commit and force push to rewrite the
history? Or is there a way to relax the rule for a new branch? Any
advice would be welcome.

Separately, some contributors have expressed interest in maintaining the
GCC style communications of using a mailing list and irc. Is it
reasonable for this project to get a rust@gcc.gnu.org?

Thanks,

--Phil



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-24 13:24 GCC Rust git branch Philip Herron
@ 2021-05-24 16:24 ` Joseph Myers
  2022-06-08 12:36   ` Thomas Schwinge
  2021-05-24 18:29 ` Mark Wielaard
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 13+ messages in thread
From: Joseph Myers @ 2021-05-24 16:24 UTC (permalink / raw)
  To: Philip Herron; +Cc: gcc

On Mon, 24 May 2021, Philip Herron wrote:

> remote: error: hook declined to update refs/heads/gccrs

refs/heads/gccrs doesn't match the branch naming conventions as documented 
at https://gcc.gnu.org/git.html (where you'd use refs/heads/devel/* for 
shared development branches), so if you hadn't had commit message 
formatting issues, the push would have been rejected for bad branch naming 
as well.

> The commit message here is poorly formatted. To move forward, should I
> rebase the tree to fix this commit and force push to rewrite the
> history? Or is there a way to relax the rule for a new branch? Any
> advice would be welcome.

If the community desires to relax the checks in a particular case, the way 
to do it would probably be to set hooks.no-precommit-check, naming the 
agreed branch name, temporarily in refs/meta/config:project.config, then 
revert that project.config change afterwards.  See 
https://github.com/AdaCore/git-hooks for the detailed documentation of 
hook configuration.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-24 13:24 GCC Rust git branch Philip Herron
  2021-05-24 16:24 ` Joseph Myers
@ 2021-05-24 18:29 ` Mark Wielaard
  2021-05-28 10:31   ` Philip Herron
  2021-05-28  3:05 ` Thomas Fitzsimmons
  2021-05-28  3:22 ` Jason Merrill
  3 siblings, 1 reply; 13+ messages in thread
From: Mark Wielaard @ 2021-05-24 18:29 UTC (permalink / raw)
  To: Philip Herron; +Cc: gcc

Hi Philip,

On Mon, May 24, 2021 at 02:24:13PM +0100, Philip Herron wrote:
> As some of you might know, I have been working on GCC Rust over on
> GitHub https://github.com/Rust-GCC/gccrs. As the project is moving
> forward and enforcing GCC copyright assignments for contributors, I
> would like to create a branch on the GCC git repo to show the intention
> to be upstream with GCC someday.
> [...] 
> The commit message here is poorly formatted. To move forward, should I
> rebase the tree to fix this commit and force push to rewrite the
> history? Or is there a way to relax the rule for a new branch? Any
> advice would be welcome.

As Joseph said you could create a developement branch for hacking on
the GCC Rust Frontend and relax the commit push rules for that one:
https://gcc.gnu.org/git.html#devbranches

Is the intention to eventually make this branch the main development
branch? Or will it just be a mirror of the main github repo/branch?

I assume it will be some months (years?) before this frontend will be
merge into the main gcc git repo. I wonder if it makes sense to create
a separate repo for the gcc rust frontend so you can use your own
rules for development. Currently you are using some github services,
like bors, that we might want to replicate. That might require some
special git branches for the automation. We can then experiment with
having a gccrs.git repo on gcc.gnu.org to see if such services can be
replicated on our own server. And the gcc rust community might show
other gcc developers whether and how that helps development.

It would also be great if we could somehow have "normal" gcc bugzilla
tickets instead of these github issue and pr numbers (which won't make
sense anymore once the frontend is merged).

> Separately, some contributors have expressed interest in maintaining the
> GCC style communications of using a mailing list and irc. Is it
> reasonable for this project to get a rust@gcc.gnu.org?

Personally I would love to have a normal mailinglist, but I am
personally somewhat (unrationally?) allergic to github and
web-chat-systems. If we are trying to make this new frontend a bit
more accessible to traditional gcc hackers, could we also have a
normal irc channel (there is #gcc on irc.oftc.net). It would be great
to also have a #gccrust channel on oftc.

Cheers,

Mark


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-24 13:24 GCC Rust git branch Philip Herron
  2021-05-24 16:24 ` Joseph Myers
  2021-05-24 18:29 ` Mark Wielaard
@ 2021-05-28  3:05 ` Thomas Fitzsimmons
  2021-05-28 10:18   ` Philip Herron
  2021-05-28  3:22 ` Jason Merrill
  3 siblings, 1 reply; 13+ messages in thread
From: Thomas Fitzsimmons @ 2021-05-28  3:05 UTC (permalink / raw)
  To: Philip Herron; +Cc: gcc

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

Hi Philip,

Philip Herron <philip.herron@embecosm.com> writes:

> As some of you might know, I have been working on GCC Rust over on
> GitHub https://github.com/Rust-GCC/gccrs. As the project is moving
> forward and enforcing GCC copyright assignments for contributors, I
> would like to create a branch on the GCC git repo to show the intention
> to be upstream with GCC someday.

I tried building GCC Rust on ppc64le.  With the attached patches,
"make check-rust" succeeds with:

		=== rust Summary ===

# of expected passes		2368
# of expected failures		26

Thomas


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-rs6000-Override-TARGET_RUST_OS_INFO-in-linux64.h.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]

From 42099a90a23c31d1af95ceac590938d50a362cf9 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Date: Thu, 27 May 2021 21:53:29 -0400
Subject: [PATCH 1/2] rs6000: Override TARGET_RUST_OS_INFO in linux64.h

Both config/rs6000/sysv4.h and config/rs6000/linux64.h define
TARGET_RUST_OS_INFO, and both are included in that order in tm.h.  This
change eliminates the error directive, permitting the more specific
definition in linux64.h to override the prior definition in sysv4.h.

gcc/ChangeLog:

2021-05-27  Thomas Fitzsimmons  <fitzsim@fitzsim.org>

	* config/rs6000/linux64.h: Undefine TARGET_RUST_OS_INFO before
	defining it.
---
 gcc/config/rs6000/linux64.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gcc/config/rs6000/linux64.h b/gcc/config/rs6000/linux64.h
index fbd8cf0a693..536007ca685 100644
--- a/gcc/config/rs6000/linux64.h
+++ b/gcc/config/rs6000/linux64.h
@@ -314,9 +314,8 @@ extern int dot_symbols;
     }							\
   while (0)
 
-#ifdef TARGET_RUST_OS_INFO
-# error "TARGET_RUST_OS_INFO already defined in linux64.h (rs6000) - c++ undefines it and redefines it."
-#endif
+/* Override less-specific rs6000/sysv4.h definition. */
+#undef TARGET_RUST_OS_INFO
 #define TARGET_RUST_OS_INFO()          \
   do {                                 \
     GNU_USER_TARGET_RUST_OS_INFO();		\
-- 
2.30.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-rs6000-Recognize-GNU-Rust-when-producing-epilogue.patch --]
[-- Type: text/x-diff, Size: 1690 bytes --]

From cd4d663c13d27a53ccabeef3d7d8cffa7a5a5365 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Date: Thu, 27 May 2021 21:55:46 -0400
Subject: [PATCH 2/2] rs6000: Recognize GNU Rust when producing epilogue

Handling the GNU Rust language when writing a function's epilogue is
necessary to avoid an internal compiler error.

gcc/ChangeLog:

2021-05-27  Thomas Fitzsimmons  <fitzsim@fitzsim.org>
            Mark Wielaard  <mark@klomp.org>

	* config/rs6000/rs6000-logue.c (rs6000_output_function_epilogue):
	Set language type field to 0 for GNU Rust.

Co-Authored-By: Mark Wielaard <mark@klomp.org>
---
 gcc/config/rs6000/rs6000-logue.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gcc/config/rs6000/rs6000-logue.c b/gcc/config/rs6000/rs6000-logue.c
index b0ac183ceff..7da8db6d232 100644
--- a/gcc/config/rs6000/rs6000-logue.c
+++ b/gcc/config/rs6000/rs6000-logue.c
@@ -5262,12 +5262,13 @@ rs6000_output_function_epilogue (FILE *file)
 	 use language_string.
 	 C is 0.  Fortran is 1.  Ada is 3.  Modula-2 is 8.  C++ is 9.
 	 Java is 13.  Objective-C is 14.  Objective-C++ isn't assigned
-	 a number, so for now use 9.  LTO, Go, D, and JIT aren't assigned
-	 numbers either, so for now use 0.  */
+	 a number, so for now use 9.  LTO, Go, D, Rust, and JIT aren't
+	 assigned numbers either, so for now use 0.  */
       if (lang_GNU_C ()
 	  || ! strcmp (language_string, "GNU GIMPLE")
 	  || ! strcmp (language_string, "GNU Go")
 	  || ! strcmp (language_string, "GNU D")
+	  || ! strcmp (language_string, "GNU Rust")
 	  || ! strcmp (language_string, "libgccjit"))
 	i = 0;
       else if (! strcmp (language_string, "GNU F77")
-- 
2.30.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-24 13:24 GCC Rust git branch Philip Herron
                   ` (2 preceding siblings ...)
  2021-05-28  3:05 ` Thomas Fitzsimmons
@ 2021-05-28  3:22 ` Jason Merrill
  2021-05-28 10:19   ` Philip Herron
  3 siblings, 1 reply; 13+ messages in thread
From: Jason Merrill @ 2021-05-28  3:22 UTC (permalink / raw)
  To: Philip Herron; +Cc: gcc Mailing List, Overseers mailing list

On Mon, May 24, 2021 at 9:25 AM Philip Herron <philip.herron@embecosm.com>
wrote:

> Hi everyone,
>
> As some of you might know, I have been working on GCC Rust over on
> GitHub https://github.com/Rust-GCC/gccrs. As the project is moving
> forward and enforcing GCC copyright assignments for contributors, I
> would like to create a branch on the GCC git repo to show the intention
> to be upstream with GCC someday.
>

 [snip]

Separately, some contributors have expressed interest in maintaining the
> GCC style communications of using a mailing list and irc. Is it
> reasonable for this project to get a rust@gcc.gnu.org?
>

That makes sense to me; I think overseers@ can help set up a new mailing
list.

Jason

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-28  3:05 ` Thomas Fitzsimmons
@ 2021-05-28 10:18   ` Philip Herron
  2021-05-28 11:48     ` Marc Poulhiès
  2021-05-30 22:49     ` Mark Wielaard
  0 siblings, 2 replies; 13+ messages in thread
From: Philip Herron @ 2021-05-28 10:18 UTC (permalink / raw)
  To: Thomas Fitzsimmons; +Cc: gcc


[-- Attachment #1.1: Type: text/plain, Size: 969 bytes --]

On 28/05/2021 04:05, Thomas Fitzsimmons wrote:
> Hi Philip,
>
> Philip Herron <philip.herron@embecosm.com> writes:
>
>> As some of you might know, I have been working on GCC Rust over on
>> GitHub https://github.com/Rust-GCC/gccrs. As the project is moving
>> forward and enforcing GCC copyright assignments for contributors, I
>> would like to create a branch on the GCC git repo to show the intention
>> to be upstream with GCC someday.
> I tried building GCC Rust on ppc64le.  With the attached patches,
> "make check-rust" succeeds with:
>
> 		=== rust Summary ===
>
> # of expected passes		2368
> # of expected failures		26
>
> Thomas
>
Hi Thomas,

Thank you so much for doing this, we will merge these later today. The
results look the same as the numbers were getting on x86 too.

If you are interested I maintain weekly and monthly status reports for
the project over on: https://github.com/Rust-GCC/Reporting

Thanks

--Phil



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-28  3:22 ` Jason Merrill
@ 2021-05-28 10:19   ` Philip Herron
  2022-06-08 10:58     ` Document <gcc-rust@gcc.gnu.org> mailing list (was: GCC Rust git branch) Thomas Schwinge
  0 siblings, 1 reply; 13+ messages in thread
From: Philip Herron @ 2021-05-28 10:19 UTC (permalink / raw)
  To: Jason Merrill; +Cc: gcc Mailing List, Overseers mailing list


[-- Attachment #1.1: Type: text/plain, Size: 1076 bytes --]

On 28/05/2021 04:22, Jason Merrill wrote:
> On Mon, May 24, 2021 at 9:25 AM Philip Herron
> <philip.herron@embecosm.com <mailto:philip.herron@embecosm.com>> wrote:
>
>     Hi everyone,
>
>     As some of you might know, I have been working on GCC Rust over on
>     GitHub https://github.com/Rust-GCC/gccrs
>     <https://github.com/Rust-GCC/gccrs>. As the project is moving
>     forward and enforcing GCC copyright assignments for contributors, I
>     would like to create a branch on the GCC git repo to show the
>     intention
>     to be upstream with GCC someday.
>
>
>  [snip]
>
>     Separately, some contributors have expressed interest in
>     maintaining the
>     GCC style communications of using a mailing list and irc. Is it
>     reasonable for this project to get a rust@gcc.gnu.org
>     <mailto:rust@gcc.gnu.org>?
>
>
> That makes sense to me; I think overseers@ can help set up a new
> mailing list.
>
> Jason

Thanks For the info everyone i will reach out to overseers about the
Mailing List idea.

Thanks

--Phil


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-24 18:29 ` Mark Wielaard
@ 2021-05-28 10:31   ` Philip Herron
  2021-05-30 22:33     ` Mark Wielaard
  0 siblings, 1 reply; 13+ messages in thread
From: Philip Herron @ 2021-05-28 10:31 UTC (permalink / raw)
  To: Mark Wielaard; +Cc: gcc


[-- Attachment #1.1: Type: text/plain, Size: 3232 bytes --]

On 24/05/2021 19:29, Mark Wielaard wrote:
> Hi Philip,
>
> On Mon, May 24, 2021 at 02:24:13PM +0100, Philip Herron wrote:
>> As some of you might know, I have been working on GCC Rust over on
>> GitHub https://github.com/Rust-GCC/gccrs. As the project is moving
>> forward and enforcing GCC copyright assignments for contributors, I
>> would like to create a branch on the GCC git repo to show the intention
>> to be upstream with GCC someday.
>> [...] 
>> The commit message here is poorly formatted. To move forward, should I
>> rebase the tree to fix this commit and force push to rewrite the
>> history? Or is there a way to relax the rule for a new branch? Any
>> advice would be welcome.
> As Joseph said you could create a developement branch for hacking on
> the GCC Rust Frontend and relax the commit push rules for that one:
> https://gcc.gnu.org/git.html#devbranches
>
> Is the intention to eventually make this branch the main development
> branch? Or will it just be a mirror of the main github repo/branch?
>
> I assume it will be some months (years?) before this frontend will be
> merge into the main gcc git repo. I wonder if it makes sense to create
> a separate repo for the gcc rust frontend so you can use your own
> rules for development. Currently you are using some github services,
> like bors, that we might want to replicate. That might require some
> special git branches for the automation. We can then experiment with
> having a gccrs.git repo on gcc.gnu.org to see if such services can be
> replicated on our own server. And the gcc rust community might show
> other gcc developers whether and how that helps development.
>
> It would also be great if we could somehow have "normal" gcc bugzilla
> tickets instead of these github issue and pr numbers (which won't make
> sense anymore once the frontend is merged).
>
>> Separately, some contributors have expressed interest in maintaining the
>> GCC style communications of using a mailing list and irc. Is it
>> reasonable for this project to get a rust@gcc.gnu.org?
> Personally I would love to have a normal mailinglist, but I am
> personally somewhat (unrationally?) allergic to github and
> web-chat-systems. If we are trying to make this new frontend a bit
> more accessible to traditional gcc hackers, could we also have a
> normal irc channel (there is #gcc on irc.oftc.net). It would be great
> to also have a #gccrust channel on oftc.
>
> Cheers,
>
> Mark
>
Hi Mark,

I think a branch on GCC's git repo will be a mirror of the github, but I
think its really important for the project to respect GCC traditions. By
that I mean that we respect patches sent to gcc-patches such that they
are treated with the same respect as PR's on Github.

If for instance a Mailing list on gcc.gnu.org became more active than
github i think at that point i would have to reconsider this, and weigh
up switching the main development over to gcc.gnu.org.

As for the git hooks, is it possible that I amend the hooks within the
gccrs repo .git/hooks folder? Or is this something i need to change in
the GCC repo? Sorry i should really read up more on git hooks in general.

Thanks.

--Phil



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-28 10:18   ` Philip Herron
@ 2021-05-28 11:48     ` Marc Poulhiès
  2021-05-30 22:49     ` Mark Wielaard
  1 sibling, 0 replies; 13+ messages in thread
From: Marc Poulhiès @ 2021-05-28 11:48 UTC (permalink / raw)
  To: Thomas Fitzsimmons; +Cc: Philip Herron, gcc

Philip Herron <philip.herron@embecosm.com> writes:

> On 28/05/2021 04:05, Thomas Fitzsimmons wrote:
>> Hi Philip,
>>
>> Philip Herron <philip.herron@embecosm.com> writes:
>>
>>> As some of you might know, I have been working on GCC Rust over on
>>> GitHub https://github.com/Rust-GCC/gccrs. As the project is moving
>>> forward and enforcing GCC copyright assignments for contributors, I
>>> would like to create a branch on the GCC git repo to show the intention
>>> to be upstream with GCC someday.
>> I tried building GCC Rust on ppc64le.  With the attached patches,
>> "make check-rust" succeeds with:
>>
>> 		=== rust Summary ===
>>
>> # of expected passes		2368
>> # of expected failures		26
>>
>> Thomas
>>
> Hi Thomas,
>
> Thank you so much for doing this, we will merge these later today. The
> results look the same as the numbers were getting on x86 too.

Hello,

FYI, your changes are being merged : https://github.com/Rust-GCC/gccrs/pull/454 

Thanks!
Marc

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-28 10:31   ` Philip Herron
@ 2021-05-30 22:33     ` Mark Wielaard
  0 siblings, 0 replies; 13+ messages in thread
From: Mark Wielaard @ 2021-05-30 22:33 UTC (permalink / raw)
  To: Philip Herron; +Cc: gcc

Hi Philip,

On Fri, May 28, 2021 at 11:31:02AM +0100, Philip Herron wrote:
> As for the git hooks, is it possible that I amend the hooks within the
> gccrs repo .git/hooks folder? Or is this something i need to change in
> the GCC repo? Sorry i should really read up more on git hooks in general.

See the email from Joseph Myers. The gcc repo already has hooks
installed and you can configure them through a magic ref/branch
project.config file setup.

Cheers,

Mark




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-28 10:18   ` Philip Herron
  2021-05-28 11:48     ` Marc Poulhiès
@ 2021-05-30 22:49     ` Mark Wielaard
  1 sibling, 0 replies; 13+ messages in thread
From: Mark Wielaard @ 2021-05-30 22:49 UTC (permalink / raw)
  To: Philip Herron; +Cc: Thomas Fitzsimmons, gcc

Hi,

On Fri, May 28, 2021 at 11:18:20AM +0100, Philip Herron wrote:
> On 28/05/2021 04:05, Thomas Fitzsimmons wrote:
> > I tried building GCC Rust on ppc64le.  With the attached patches,
> > "make check-rust" succeeds with:
> >
> > 		=== rust Summary ===
> >
> > # of expected passes		2368
> > # of expected failures		26
> >
> 
> Thank you so much for doing this, we will merge these later today. The
> results look the same as the numbers were getting on x86 too.

And I am getting the same results on arm64.  To make sure things keep
zero fail I added a fedora-x86_64 and debian_arm64 worker to my
buildbot setup:
https://builder.wildebeest.org/buildbot/#/builders?tags=gccrust
(The red builds were setup bugs, the last build is all green)

I'll try to also add the ppc64le builder. Are there any other arches
that are zero fail?

Once we have a mailinglist I can set it up so that any failures will
sent email to the rust@gcc mailinglist.

It is currently tracking the master branch. Maybe we can integrate it
with the bors setup you have running. But I didn't really understand
where it is running and how it is configured so that it can be
integrated with the buildbot workers.

Note that the workers aren't very fast. Especially the arm64 one. I
takes ~30 minutes for a fully make && make check. So please no more
than 48 patches a day please :)

Cheers,

Mark


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Document <gcc-rust@gcc.gnu.org> mailing list (was: GCC Rust git branch)
  2021-05-28 10:19   ` Philip Herron
@ 2022-06-08 10:58     ` Thomas Schwinge
  0 siblings, 0 replies; 13+ messages in thread
From: Thomas Schwinge @ 2022-06-08 10:58 UTC (permalink / raw)
  To: Philip Herron, gcc-rust, gcc-patches; +Cc: gcc, overseers, Jason Merrill

[-- Attachment #1: Type: text/plain, Size: 1684 bytes --]

Hi!

On 2021-05-28T11:19:16+0100, Philip Herron <philip.herron@embecosm.com> wrote:
> On 28/05/2021 04:22, Jason Merrill wrote:
>> On Mon, May 24, 2021 at 9:25 AM Philip Herron <philip.herron@embecosm.com <mailto:philip.herron@embecosm.com>> wrote:
>>>     As some of you might know, I have been working on GCC Rust over on
>>>     GitHub https://github.com/Rust-GCC/gccrs
>>>     <https://github.com/Rust-GCC/gccrs>. As the project is moving
>>>     forward and enforcing GCC copyright assignments for contributors, I
>>>     would like to create a branch on the GCC git repo to show the
>>>     intention
>>>     to be upstream with GCC someday.
>>>
>>>  [snip]
>>>
>>>     Separately, some contributors have expressed interest in
>>>     maintaining the
>>>     GCC style communications of using a mailing list and irc. Is it
>>>     reasonable for this project to get a rust@gcc.gnu.org
>>>     <mailto:rust@gcc.gnu.org>?
>>
>> That makes sense to me; I think overseers@ can help set up a new
>> mailing list.
>
> Thanks For the info everyone i will reach out to overseers about the
> Mailing List idea.

A <gcc-rust@gcc.gnu.org> mailing list has thus been set up a year ago;
now documented on <https://gcc.gnu.org/lists.html> per gcc-wwwdocs
commit 1c89cdccbebda5d4c2eeeb627b1461b8877bb27e
"Document <gcc-rust@gcc.gnu.org> mailing list", see attached.


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Document-gcc-rust-gcc.gnu.org-mailing-list.patch --]
[-- Type: text/x-diff, Size: 1070 bytes --]

From 1c89cdccbebda5d4c2eeeb627b1461b8877bb27e Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Wed, 8 Jun 2022 12:55:55 +0200
Subject: [PATCH] Document <gcc-rust@gcc.gnu.org> mailing list

---
 htdocs/lists.html | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/htdocs/lists.html b/htdocs/lists.html
index ad36a7e2..c32c505d 100644
--- a/htdocs/lists.html
+++ b/htdocs/lists.html
@@ -70,6 +70,11 @@ before <a href="#subscribe">subscribing</a> and posting to these lists.
   is a moderate volume list where regression results for the GCC compilers
   are posted.</li>
 
+  <li><b><a href="https://gcc.gnu.org/ml/gcc-rust/">gcc-rust</a></b>
+  is for discussing <a href="https://gcc.gnu.org/wiki/RustFrontEnd">Rust
+  support in GCC</a>.
+  Patches should be sent to both this list and <b>gcc-patches</b>.</li>
+
   <li><b><a href="https://gcc.gnu.org/ml/libstdc++/">libstdc++</a></b>
   is the main discussion and development list for the standard C++
   library (libstdc++-v3).  Patches to libstdc++-v3 should be sent to
-- 
2.35.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: GCC Rust git branch
  2021-05-24 16:24 ` Joseph Myers
@ 2022-06-08 12:36   ` Thomas Schwinge
  0 siblings, 0 replies; 13+ messages in thread
From: Thomas Schwinge @ 2022-06-08 12:36 UTC (permalink / raw)
  To: Joseph Myers, Philip Herron, gcc-rust, gcc, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 2268 bytes --]

Hi!

This is about GCC/Rust, <https://rust-gcc.github.io/>, now also having a
presence in GCC upstream Git sources; see also
<https://github.com/Rust-GCC/gccrs/issues/143> "GCC Git Branch".

On 2021-05-24T16:24:38+0000, Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 24 May 2021, Philip Herron wrote:
>
>> remote: error: hook declined to update refs/heads/gccrs
>
> refs/heads/gccrs doesn't match the branch naming conventions as documented
> at https://gcc.gnu.org/git.html (where you'd use refs/heads/devel/* for
> shared development branches), so if you hadn't had commit message
> formatting issues, the push would have been rejected for bad branch naming
> as well.
>
>> The commit message here is poorly formatted. To move forward, should I
>> rebase the tree to fix this commit and force push to rewrite the
>> history? Or is there a way to relax the rule for a new branch? Any
>> advice would be welcome.
>
> If the community desires to relax the checks in a particular case, the way
> to do it would probably be to set hooks.no-precommit-check, naming the
> agreed branch name, temporarily in refs/meta/config:project.config, then
> revert that project.config change afterwards.  See
> https://github.com/AdaCore/git-hooks for the detailed documentation of
> hook configuration.

Thanks.  I've thus pushed to refs/meta/config branch
commit 15e03be6fc6406e41c75ff95a9de449663fc9f0e "Enable
'no-precommit-check' for GCC/Rust development branches, 'devel/rust/*'",
see attached.


I've further pushed to gcc-wwwdocs
commit 325020ef06c714fbfd508d57e3f0bda272470464
"Document Git branch devel/rust/master", see attached.


I've also set up GCC Bugzilla:

  - Add new component *rust*:
    <https://gcc.gnu.org/bugzilla/editcomponents.cgi?action=edit&product=gcc&component=rust>.
  - Add new version *rust/master*:
    <https://gcc.gnu.org/bugzilla/editversions.cgi?action=edit&product=gcc&version=rust%2Fmaster>.


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Enable-no-precommit-check-for-GCC-Rust-development-b.patch --]
[-- Type: text/x-diff, Size: 931 bytes --]

From 15e03be6fc6406e41c75ff95a9de449663fc9f0e Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Wed, 8 Jun 2022 12:00:04 +0200
Subject: [PATCH] Enable 'no-precommit-check' for GCC/Rust development
 branches, 'devel/rust/*'

---
 project.config | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/project.config b/project.config
index b7bdaf30b9e..5905fe26272 100644
--- a/project.config
+++ b/project.config
@@ -87,3 +87,9 @@
 	# Custom email formatter.  This inserts GCC monotonically
 	# increasing commit ids in the commit emails.
 	commit-email-formatter = /git/gcc.git/hooks-bin/commit_email_formatter
+
+	# For GCC/Rust development that happens outside of GCC proper,
+	# <https://rust-gcc.github.io/>, the Git commit messages
+	# don't always adhere to standard GCC style; see
+	# <https://github.com/Rust-GCC/gccrs/issues/143>.
+	no-precommit-check = refs/heads/devel/rust/.*
-- 
2.35.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0001-Document-Git-branch-devel-rust-master.patch --]
[-- Type: text/x-diff, Size: 940 bytes --]

From 325020ef06c714fbfd508d57e3f0bda272470464 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Wed, 8 Jun 2022 14:21:06 +0200
Subject: [PATCH] Document Git branch devel/rust/master

---
 htdocs/git.html | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/htdocs/git.html b/htdocs/git.html
index 5fbd98bf..f9acea54 100644
--- a/htdocs/git.html
+++ b/htdocs/git.html
@@ -349,6 +349,12 @@ in Git.</p>
     implementation of Fortran coarrays.  It is maintained by
     <a href="mailto:koenigni@gcc.gnu.org">Nicolas K&ouml;nig</a>.</dd>
     
+  <dt><a href="https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=shortlog;h=refs/heads/devel/rust/master">devel/rust/master</a></dt>
+  <dd>
+    This branch is for development of
+    <a href="https://gcc.gnu.org/wiki/RustFrontEnd">Rust programming language
+      support in GCC</a>.
+  </dd>
 </dl>
 
 <h3 id="distrobranches">Distribution Branches</h3>
-- 
2.35.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-06-08 12:36 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 13:24 GCC Rust git branch Philip Herron
2021-05-24 16:24 ` Joseph Myers
2022-06-08 12:36   ` Thomas Schwinge
2021-05-24 18:29 ` Mark Wielaard
2021-05-28 10:31   ` Philip Herron
2021-05-30 22:33     ` Mark Wielaard
2021-05-28  3:05 ` Thomas Fitzsimmons
2021-05-28 10:18   ` Philip Herron
2021-05-28 11:48     ` Marc Poulhiès
2021-05-30 22:49     ` Mark Wielaard
2021-05-28  3:22 ` Jason Merrill
2021-05-28 10:19   ` Philip Herron
2022-06-08 10:58     ` Document <gcc-rust@gcc.gnu.org> mailing list (was: GCC Rust git branch) Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).