autogen version testing in fixincludes/genfixes

autogen version testing in fixincludes/genfixes

[Basile Starynkevitch]

Hello

With the autogen (GNU AutoGen) 5.11.9 on my Linux/Debian/Sid (or
perhaps /Experimental) the genfixes script fail, because of the version
test.

The following patch corrects that.

Index: fixincludes/genfixes
===================================================================
--- fixincludes/genfixes	(revision 174734)
+++ fixincludes/genfixes	(working copy)
@@ -62,7 +62,7 @@
 AG="autogen $AG"
 set -e
 
-if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ]
+if [ -z "`${AG} -v | fgrep ' 5.'`" ]
 then
   echo "AutoGen appears to be out of date or not correctly installed."
   echo "Please download and install:"

Should I submit the patch, or is there something I missed? 

Why do we test the Ver. string ???

Regards.
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

Re: autogen version testing in fixincludes/genfixes

[Andreas Schwab]

Basile Starynkevitch <basile@starynkevitch.net> writes:

> Hello
>
> With the autogen (GNU AutoGen) 5.11.9 on my Linux/Debian/Sid (or
> perhaps /Experimental) the genfixes script fail, because of the version
> test.
>
> The following patch corrects that.
>
> Index: fixincludes/genfixes
> ===================================================================
> --- fixincludes/genfixes	(revision 174734)
> +++ fixincludes/genfixes	(working copy)
> @@ -62,7 +62,7 @@
>  AG="autogen $AG"
>  set -e
>  
> -if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ]
> +if [ -z "`${AG} -v | fgrep ' 5.'`" ]

What happens when autogen 6 is released?

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

Re: autogen version testing in fixincludes/genfixes

[Basile Starynkevitch]

On Wed, 08 Jun 2011 10:07:20 +0200
Andreas Schwab <schwab@redhat.com> wrote:

> Basile Starynkevitch <basile@starynkevitch.net> writes:
> 
> > Hello
> >
> > With the autogen (GNU AutoGen) 5.11.9 on my Linux/Debian/Sid (or
> > perhaps /Experimental) the genfixes script fail, because of the version
> > test.
> >
> > The following patch corrects that.
> >
> > Index: fixincludes/genfixes
> > ===================================================================
> > --- fixincludes/genfixes	(revision 174734)
> > +++ fixincludes/genfixes	(working copy)
> > @@ -62,7 +62,7 @@
> >  AG="autogen $AG"
> >  set -e
> >  
> > -if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ]
> > +if [ -z "`${AG} -v | fgrep ' 5.'`" ]
> 
> What happens when autogen 6 is released?

I don't know, but I would imagine that autogen -v gave a different
string between 5.11.9 and some previous version, which probably was
also a 5.xx (not too far, since it worked on Debian/Sid a month ago)

What I find strange is to fgrep for the 'Ver.' string. The digit 5 is
ok for me. Here is what I get today:

% autogen --version
autogen (GNU AutoGen) 5.11.9
% autogen -v
autogen (GNU AutoGen) 5.11.9

You see, not Ver. string in it.

And current autogen behavior is not surprising; several other GNU
utilities have the same format : % ls --version
ls (GNU coreutils) 8.5
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>. This is free software: you are free
to change and redistribute it. There is NO WARRANTY, to the extent
permitted by law.

Written by Richard M. Stallman and David MacKenzie.

% gcc --version
gcc (Debian 4.6.0-10) 4.6.1 20110526 (prerelease)
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is
NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

% find --version
find (GNU findutils) 4.5.10
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>. This is free software: you are free
to change and redistribute it. There is NO WARRANTY, to the extent
permitted by law.

Written by Eric B. Decker, James Youngman, and Kevin Dalley.
Built using GNU gnulib version 25d7f3a59bfdc7aaca4a016f687826883a55bef3
Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION FTS
(FTS_CWDFD) CBO(level=2) 

% autoconf --version
autoconf (GNU Autoconf) 2.64
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later
<http://gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.
 % ld --version
GNU ld (GNU Binutils for Debian) 2.21.51.20110601
Copyright 2011 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms
of the GNU General Public License version 3 or (at your option) a later
version. This program has absolutely no warranty.


So most of the GNU tools I have have a quite similar format for telling
their version. The first line of the output of --version don't have a
Ver. string it it.

Of course, I have LANG=C in all cases.

Regards
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

Re: autogen version testing in fixincludes/genfixes

[Andreas Schwab]

Basile Starynkevitch <basile@starynkevitch.net> writes:

> You see, not Ver. string in it.

$ autogen -v
autogen (GNU AutoGen) - The Automated Program Generator - Ver. 5.11.1

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: autogen version testing in fixincludes/genfixes

[Basile Starynkevitch]

On Wed, 08 Jun 2011 20:52:51 +0200
Andreas Schwab <schwab@linux-m68k.org> wrote:

> Basile Starynkevitch <basile@starynkevitch.net> writes:
> 
> > You see, not Ver. string in it.
> 
> $ autogen -v
> autogen (GNU AutoGen) - The Automated Program Generator - Ver. 5.11.1

I might believe that could be more a issue in autogen than in GCC.

And I also believe that the minuscule patch I am proposing in
http://gcc.gnu.org/ml/gcc/2011-06/msg00081.html
should work on your system too. Could you try it please?

Regards.

-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

Re: autogen version testing in fixincludes/genfixes

[Andreas Schwab]

Basile Starynkevitch <basile@starynkevitch.net> writes:

> And I also believe that the minuscule patch I am proposing in
> http://gcc.gnu.org/ml/gcc/2011-06/msg00081.html
> should work on your system too. Could you try it please?

That's not the point.  The point is, if you patch, you should do it
right.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: autogen version testing in fixincludes/genfixes

[Basile Starynkevitch]

On Wed, 08 Jun 2011 21:54:56 +0200
Andreas Schwab <schwab@linux-m68k.org> wrote:

> Basile Starynkevitch <basile@starynkevitch.net> writes:
> 
> > And I also believe that the minuscule patch I am proposing in
> > http://gcc.gnu.org/ml/gcc/2011-06/msg00081.html
> > should work on your system too. Could you try it please?
> 
> That's not the point.  The point is, if you patch, you should do it
> right.

But what are your thinking of? I don't catch it (i.e. I don't guess
your thoughts).

And I would imagine that autogen version 6 is so far away in the future
that we can't guess its behavior.  I don't know why the script is
testing the version...

Regards.

Cheers.
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

Re: autogen version testing in fixincludes/genfixes

[Marc Glisse]

On Wed, 8 Jun 2011, Andreas Schwab wrote:

> Basile Starynkevitch <basile@starynkevitch.net> writes:
>
>> And I also believe that the minuscule patch I am proposing in
>> http://gcc.gnu.org/ml/gcc/2011-06/msg00081.html
>> should work on your system too. Could you try it please?
>
> That's not the point.  The point is, if you patch, you should do it
> right.

Hello,

so what's the right way to do it?
(the number of people using 5.12 is increasing, we have to fix it)

1) not test autogen at all. It will fail if it has to fail. Besides,
    nobody has autogen 4.* anymore.
2) instead of grepping Ver. 5., grep for " 5." or GNU, or grep -v for
    " [0-4]".
3) something else.

-- 
Marc Glisse