From: Lancelot SIX <Lancelot.Six@amd.com>
To: WANG Rui <r@hev.cc>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable
Date: Mon, 17 Apr 2023 22:12:52 +0100 [thread overview]
Message-ID: <1259de63-932e-ca42-632b-fe080067da12@amd.com> (raw)
In-Reply-To: <20230417162428.48426-1-r@hev.cc>
>
> diff --git a/gdb/symtab.c b/gdb/symtab.c
> index f2b1a14e006..a662d7d1869 100644
> --- a/gdb/symtab.c
> +++ b/gdb/symtab.c
> @@ -3735,7 +3735,7 @@ skip_prologue_using_linetable (CORE_ADDR func_addr)
> });
>
> for (;
> - it < linetable->item + linetable->nitems && it->pc <= end_pc;
> + it < linetable->item + linetable->nitems && it->pc < end_pc;
> it++)
> if (it->prologue_end)
> return {it->pc};
Hi Rui, thanks for spotting this.
I am not a maintainer, so I can only comment.
I do not think this patch applies cleanly to the master branch, but the
change should be trivial. That being said, it is true that
find_pc_partial_function returns the first address past the end of the
function, so the change looks good to me. Thanks for spotting this!
Best,
Lancelot.
next prev parent reply other threads:[~2023-04-17 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 16:24 WANG Rui
2023-04-17 17:38 ` Keith Seitz
2023-04-18 2:26 ` hev
2023-04-18 8:43 ` Tom de Vries
2023-04-18 9:59 ` hev
2023-04-17 21:12 ` Lancelot SIX [this message]
2023-04-18 2:26 ` hev
2023-04-22 8:36 ` Tom de Vries
2023-04-23 1:24 ` hev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259de63-932e-ca42-632b-fe080067da12@amd.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=r@hev.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).