From: WANG Rui <r@hev.cc>
To: gdb-patches@sourceware.org
Cc: Lancelot SIX <lancelot.six@amd.com>, WANG Rui <r@hev.cc>
Subject: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable
Date: Tue, 18 Apr 2023 00:24:28 +0800 [thread overview]
Message-ID: <20230417162428.48426-1-r@hev.cc> (raw)
We should exclude matches to the ending PC to prevent false matches with the
next function, as prologue_end is located at the end PC.
<fun1>:
0x00: ... <-- start_pc
0x04: ...
0x08: ... <-- breakpoint
0x0c: ret
<fun2>:
0x10: ret <-- end_pc | prologue_end of fun2
---
gdb/symtab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/symtab.c b/gdb/symtab.c
index f2b1a14e006..a662d7d1869 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -3735,7 +3735,7 @@ skip_prologue_using_linetable (CORE_ADDR func_addr)
});
for (;
- it < linetable->item + linetable->nitems && it->pc <= end_pc;
+ it < linetable->item + linetable->nitems && it->pc < end_pc;
it++)
if (it->prologue_end)
return {it->pc};
--
2.40.0
next reply other threads:[~2023-04-17 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 16:24 WANG Rui [this message]
2023-04-17 17:38 ` Keith Seitz
2023-04-18 2:26 ` hev
2023-04-18 8:43 ` Tom de Vries
2023-04-18 9:59 ` hev
2023-04-17 21:12 ` Lancelot SIX
2023-04-18 2:26 ` hev
2023-04-22 8:36 ` Tom de Vries
2023-04-23 1:24 ` hev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417162428.48426-1-r@hev.cc \
--to=r@hev.cc \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).