Re: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable

[hev <r@hev.cc>]

Hello Lancelot, Thanks for your comments.

On Tue, Apr 18, 2023 at 5:13 AM Lancelot SIX <Lancelot.Six@amd.com> wrote:
>
> >
> > diff --git a/gdb/symtab.c b/gdb/symtab.c
> > index f2b1a14e006..a662d7d1869 100644
> > --- a/gdb/symtab.c
> > +++ b/gdb/symtab.c
> > @@ -3735,7 +3735,7 @@ skip_prologue_using_linetable (CORE_ADDR func_addr)
> >           });
> >
> >         for (;
> > -          it < linetable->item + linetable->nitems && it->pc <= end_pc;
> > +          it < linetable->item + linetable->nitems && it->pc < end_pc;
> >             it++)
> >          if (it->prologue_end)
> >            return {it->pc};
>
> Hi Rui, thanks for spotting this.
>
> I am not a maintainer, so I can only comment.
>
> I do not think this patch applies cleanly to the master branch, but the
> change should be trivial.  That being said, it is true that
> find_pc_partial_function returns the first address past the end of the
> function, so the change looks good to me.  Thanks for spotting this!

I realized that I made a mistake. I have been focusing so much on
debugging Rust issues that I forgot to work on the 13 branch. I will
work on the v2 patch. Thank you!

--
Rui