From: hev <r@hev.cc>
To: Tom de Vries <tdevries@suse.de>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable
Date: Tue, 18 Apr 2023 17:59:11 +0800 [thread overview]
Message-ID: <CAHirt9hJBadOTrGbpP8n0vfQ-pkALOr97GNr6ck4sJfrrpJzvQ@mail.gmail.com> (raw)
In-Reply-To: <cefcf83d-90bf-be91-6eae-fe6a6a712778@suse.de>
On Tue, Apr 18, 2023 at 4:43 PM Tom de Vries <tdevries@suse.de> wrote:
>
> On 4/18/23 04:26, hev wrote:
> >> I have to ask, though, is there a way to write a test case for this? Maybe
> >> by using dw2-prologue-end.exp as an example?
>
> > I attempted to write a test case, but it did not work. I discovered this
> > issue while running the Rust debuginfo test[1] on LoongArch. As the
> > function entry alignment is 4-byte, which is the size of an instruction,
> > there is no padding between the two functions. This creates a possibility
> > of matching the start address of the next function. This is unlike x86,
> > which is why this problem does not occur on x86. I sincerely hope that this
> > information proves to be beneficial to you.
>
> Using this information I managed to write a regression test for this,
> I've attached it to a PR I opened for this issue (
> https://sourceware.org/bugzilla/show_bug.cgi?id=30369 ).
Awesome! Thank you.
--
Rui
next prev parent reply other threads:[~2023-04-18 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 16:24 WANG Rui
2023-04-17 17:38 ` Keith Seitz
2023-04-18 2:26 ` hev
2023-04-18 8:43 ` Tom de Vries
2023-04-18 9:59 ` hev [this message]
2023-04-17 21:12 ` Lancelot SIX
2023-04-18 2:26 ` hev
2023-04-22 8:36 ` Tom de Vries
2023-04-23 1:24 ` hev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHirt9hJBadOTrGbpP8n0vfQ-pkALOr97GNr6ck4sJfrrpJzvQ@mail.gmail.com \
--to=r@hev.cc \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).