public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: hev <r@hev.cc>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Lancelot SIX <lancelot.six@amd.com>
Subject: Re: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable
Date: Sun, 23 Apr 2023 09:24:55 +0800	[thread overview]
Message-ID: <CAHirt9iWfA17OH9WFaTTm-sz_21ZemJ8DVdGvkbyhtC3txN_kA@mail.gmail.com> (raw)
In-Reply-To: <3dee100c-1837-f95b-711a-c6f02bb9887a@suse.de>

Hi Tom,

On Sat, Apr 22, 2023 at 4:36 PM Tom de Vries <tdevries@suse.de> wrote:
>
> On 4/17/23 18:24, WANG Rui wrote:
> > We should exclude matches to the ending PC to prevent false matches with the
> > next function, as prologue_end is located at the end PC.
>
> Hi Rui,
>
> thanks for the bug-report-and-fix, much appreciated.
>
> If you might make more or larger contributions in the future, please
> consider filing a copyright assignment (
> https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assignment
> ).

Thank you for suggesting that I consider filing a copyright assignment
with the FSF if I plan on making more contributions in the future. I
appreciate your guidance and will definitely keep it in mind. :)

Thanks
Rui

      reply	other threads:[~2023-04-23  1:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 16:24 WANG Rui
2023-04-17 17:38 ` Keith Seitz
2023-04-18  2:26   ` hev
2023-04-18  8:43     ` Tom de Vries
2023-04-18  9:59       ` hev
2023-04-17 21:12 ` Lancelot SIX
2023-04-18  2:26   ` hev
2023-04-22  8:36 ` Tom de Vries
2023-04-23  1:24   ` hev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHirt9iWfA17OH9WFaTTm-sz_21ZemJ8DVdGvkbyhtC3txN_kA@mail.gmail.com \
    --to=r@hev.cc \
    --cc=gdb-patches@sourceware.org \
    --cc=lancelot.six@amd.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).