* [PATCH] Fixed top frame assumption in watchpoint-hw-attach
@ 2018-06-27 10:18 Richard Bunt
2018-06-27 13:31 ` Simon Marchi
2018-06-29 14:51 ` Pedro Alves
0 siblings, 2 replies; 6+ messages in thread
From: Richard Bunt @ 2018-06-27 10:18 UTC (permalink / raw)
To: gdb-patches; +Cc: nd
Fixed top frame assumption in watchpoint-hw-attach
watchpoint-hw-attach.exp was noticed to fail on some machines.
Thanks to the input from sergiodj and palves on the IRC channel,
it was concluded that the test case incorrectly assumed that on
attach it was landed in the top-most frame of the inferior. This
was fixed by running to a break point in main by explicitly
defining the source file name before continuing with the test.
Tested on the following architectures x86_64, aarch64 and ppc64le.
gdb/testsuite/ChangeLog:
2018-06-25 Richard Bunt <richard.bunt@arm.com>
* gdb.base/watchpoint-hw-attach.c (main): Remove unneeded
code.
* gdb.base/watchpoint-hw-attach.exp: Break in outermost frame.
---
gdb/testsuite/gdb.base/watchpoint-hw-attach.c | 1 -
gdb/testsuite/gdb.base/watchpoint-hw-attach.exp | 8 ++++----
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.base/watchpoint-hw-attach.c
b/gdb/testsuite/gdb.base/watchpoint-hw-attach.c
index 9d55b28..5bfea50 100644
--- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.c
+++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.c
@@ -36,7 +36,6 @@ main (void)
for (counter = 0; !should_continue && counter < 100; counter++)
sleep (1); /* pidacquired */
- watched_variable = 0; /* prewatchtrigger */
/* Trigger a watchpoint. */
watched_variable = 4;
printf ("My variable is %d\n", watched_variable);
diff --git a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
index 0c5037c..ba7205d 100644
--- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
+++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
@@ -57,12 +57,12 @@ clean_restart $binfile
gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*"
-gdb_test_no_output "set should_continue = 1"
-
# Ensure the test program is in the top frame so the required
# variables are in scope.
-gdb_breakpoint [gdb_get_line_number "prewatchtrigger"]
-gdb_continue_to_breakpoint "prewatchtrigger"
+gdb_breakpoint $srcfile:[gdb_get_line_number "pidacquired"]
+gdb_continue_to_breakpoint "$srcfile:pidacquired"
+
+gdb_test_no_output "set should_continue = 1"
gdb_test "watch watched_variable" \
"Hardware watchpoint $decimal: watched_variable"
--
1.8.5.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach
2018-06-27 10:18 [PATCH] Fixed top frame assumption in watchpoint-hw-attach Richard Bunt
@ 2018-06-27 13:31 ` Simon Marchi
2018-06-29 14:51 ` Pedro Alves
1 sibling, 0 replies; 6+ messages in thread
From: Simon Marchi @ 2018-06-27 13:31 UTC (permalink / raw)
To: Richard Bunt, gdb-patches; +Cc: nd
On 2018-06-27 06:17 AM, Richard Bunt wrote:
> Fixed top frame assumption in watchpoint-hw-attach
>
> watchpoint-hw-attach.exp was noticed to fail on some machines.
> Thanks to the input from sergiodj and palves on the IRC channel,
> it was concluded that the test case incorrectly assumed that on
> attach it was landed in the top-most frame of the inferior. This
> was fixed by running to a break point in main by explicitly
> defining the source file name before continuing with the test.
>
> Tested on the following architectures x86_64, aarch64 and ppc64le.
LGTM, thanks!
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach
2018-06-27 10:18 [PATCH] Fixed top frame assumption in watchpoint-hw-attach Richard Bunt
2018-06-27 13:31 ` Simon Marchi
@ 2018-06-29 14:51 ` Pedro Alves
2018-06-29 15:23 ` Richard Bunt
2018-06-29 16:39 ` Richard Bunt
1 sibling, 2 replies; 6+ messages in thread
From: Pedro Alves @ 2018-06-29 14:51 UTC (permalink / raw)
To: Richard Bunt, gdb-patches; +Cc: nd
Hi,
On 06/27/2018 11:17 AM, Richard Bunt wrote:
> --- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
> +++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
> @@ -57,12 +57,12 @@ clean_restart $binfile
>
> gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*"
Diffing test results, I noticed:
PASS: gdb.base/watchpoint-hw-attach.exp: continue to breakpoint: pidacquired
PASS: gdb.base/watchpoint-hw-attach.exp: get integer valueof "mypid"
PASS: gdb.base/watchpoint-hw-attach.exp: detach
PASS: gdb.base/watchpoint-hw-attach.exp: attach 25501
^^^^^
It's better to avoid using unstable numbers in test names. Can you
fix this in the obvious way (make it print "attach" only)? Thanks.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach
2018-06-29 14:51 ` Pedro Alves
@ 2018-06-29 15:23 ` Richard Bunt
2018-06-29 16:39 ` Richard Bunt
1 sibling, 0 replies; 6+ messages in thread
From: Richard Bunt @ 2018-06-29 15:23 UTC (permalink / raw)
To: Pedro Alves, gdb-patches; +Cc: nd
On 06/29/2018 03:51 PM, Pedro Alves wrote:
> Hi,
>
> On 06/27/2018 11:17 AM, Richard Bunt wrote:
>
>> --- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> +++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> @@ -57,12 +57,12 @@ clean_restart $binfile
>>
>> gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*"
>
> Diffing test results, I noticed:
>
> PASS: gdb.base/watchpoint-hw-attach.exp: continue to breakpoint: pidacquired
> PASS: gdb.base/watchpoint-hw-attach.exp: get integer valueof "mypid"
> PASS: gdb.base/watchpoint-hw-attach.exp: detach
> PASS: gdb.base/watchpoint-hw-attach.exp: attach 25501
> ^^^^^
>
> It's better to avoid using unstable numbers in test names. Can you
> fix this in the obvious way (make it print "attach" only)? Thanks.
>
Understood, I'll prepare a fix.
> Thanks,
> Pedro Alves
>
Many thanks,
Rich
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach
2018-06-29 14:51 ` Pedro Alves
2018-06-29 15:23 ` Richard Bunt
@ 2018-06-29 16:39 ` Richard Bunt
2018-06-29 16:40 ` Pedro Alves
1 sibling, 1 reply; 6+ messages in thread
From: Richard Bunt @ 2018-06-29 16:39 UTC (permalink / raw)
To: Pedro Alves, gdb-patches; +Cc: nd
On 06/29/2018 03:51 PM, Pedro Alves wrote:
> Hi,
>
> On 06/27/2018 11:17 AM, Richard Bunt wrote:
>
>> --- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> +++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> @@ -57,12 +57,12 @@ clean_restart $binfile
>>
>> gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*"
>
> Diffing test results, I noticed:
>
> PASS: gdb.base/watchpoint-hw-attach.exp: continue to breakpoint: pidacquired
> PASS: gdb.base/watchpoint-hw-attach.exp: get integer valueof "mypid"
> PASS: gdb.base/watchpoint-hw-attach.exp: detach
> PASS: gdb.base/watchpoint-hw-attach.exp: attach 25501
> ^^^^^
>
> It's better to avoid using unstable numbers in test names. Can you
> fix this in the obvious way (make it print "attach" only)? Thanks.
>
> Thanks,
> Pedro Alves
>
Fix pushed. Sorry about this.
Many thanks,
Rich
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach
2018-06-29 16:39 ` Richard Bunt
@ 2018-06-29 16:40 ` Pedro Alves
0 siblings, 0 replies; 6+ messages in thread
From: Pedro Alves @ 2018-06-29 16:40 UTC (permalink / raw)
To: Richard Bunt, gdb-patches; +Cc: nd
On 06/29/2018 05:39 PM, Richard Bunt wrote:
> Fix pushed. Sorry about this.
Thanks! And no worries. :-)
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-29 16:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 10:18 [PATCH] Fixed top frame assumption in watchpoint-hw-attach Richard Bunt
2018-06-27 13:31 ` Simon Marchi
2018-06-29 14:51 ` Pedro Alves
2018-06-29 15:23 ` Richard Bunt
2018-06-29 16:39 ` Richard Bunt
2018-06-29 16:40 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).