[revert] [PATCH v7 00/10] Validate binary before use

[Jan Kratochvil <jan.kratochvil@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

On Wed, 15 Jul 2015 17:49:59 +0200, Jan Kratochvil wrote:
> therefore this patchset is checked in:
> 
> ddc98fbf2fd9e244a215a4d09e559180dc573a14 Create empty nat/linux-maps.[ch] and common/target-utils.[ch]
> 6e5b4429db0d66e2d0b27e1bcfe4709f3dae73ed Move gdb_regex* to common/
> f7af1fcd759fa126612018a5916cf808df7bb8bc Prepare linux_find_memory_regions_full & co. for move
> 9904185cfde13d6c6849f1f042c8e3b74974cf08 Move linux_find_memory_regions_full & co.
> 700ca40f6fc1addd7238f4ab57f76c095ad3c99f gdbserver build-id attribute generator
> ca5268b6be265580b91ef75c1a1a9815f581ae42 Validate symbol file using build-id
> 0a94970d663a053c523f23ac0d71deb25a77f709 Tests for validate symbol file using build-id

It has been reverted as it broke non-x86* builds such as s390*-linux:

linux-tdep.o: In function `linux_info_proc':
linux-tdep.c:(.text+0x110e): undefined reference to `read_mapping'
linux-tdep.o: In function `linux_find_memory_regions_gdb':
linux-tdep.c:(.text+0x2a2a): undefined reference to `linux_find_memory_regions_full'
collect2: error: ld returned 1 exit status

It is now obvious from:
        Create empty nat/linux-maps.[ch] and common/target-utils.[ch].
        * Makefile.in (HFILES_NO_SRCDIR); Add nat/linux-maps.h,
        common/target-utils.h.
        (COMMON_OBS): Add target-utils.o.
        (linux-maps.o, target-utils.o): New.
        * target/target-utils.c: New file.
        * target/target-utils.h: New file.
        * config/i386/linux.mh (NATDEPFILES): Add linux-maps.o.
        * config/i386/linux64.mh (NATDEPFILES): Ditto.
        * nat/linux-maps.c: New file.
        * nat/linux-maps.h: New file.

I updated that config/i386/* only as a proof of concept and later forgot about
it.  As nat/linux-maps.c is used by linux-tdep.c it seems to me it should not
be in nat/ .

Anyway the fix is not obvious to me so I have just reverted it so far.


Jan

[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 1898 bytes --]

commit db1ff28b60f8886b8d7c634f1db2f939ba47a13c
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Wed Jul 15 20:27:32 2015 +0200

    Revert the previous 7 commits of: Validate binary before use
    
    ddc98fbf2fd9e244a215a4d09e559180dc573a14 Create empty nat/linux-maps.[ch] and common/target-utils.[ch]
    6e5b4429db0d66e2d0b27e1bcfe4709f3dae73ed Move gdb_regex* to common/
    f7af1fcd759fa126612018a5916cf808df7bb8bc Prepare linux_find_memory_regions_full & co. for move
    9904185cfde13d6c6849f1f042c8e3b74974cf08 Move linux_find_memory_regions_full & co.
    700ca40f6fc1addd7238f4ab57f76c095ad3c99f gdbserver build-id attribute generator
    ca5268b6be265580b91ef75c1a1a9815f581ae42 Validate symbol file using build-id
    0a94970d663a053c523f23ac0d71deb25a77f709 Tests for validate symbol file using build-id
    
    gdb/ChangeLog
    2015-07-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
    
    	Revert the previous 6 commits:
    	Create empty nat/linux-maps.[ch] and common/target-utils.[ch].
    	Move gdb_regex* to common/
    	Prepare linux_find_memory_regions_full & co. for move
    	Move linux_find_memory_regions_full & co.
    	gdbserver build-id attribute generator
    	Validate symbol file using build-id
    
    gdb/gdbserver/ChangeLog
    2015-07-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
    
    	Revert the previous 3 commits:
    	Move gdb_regex* to common/
    	Move linux_find_memory_regions_full & co.
    	gdbserver build-id attribute generator
    
    gdb/doc/ChangeLog
    2015-07-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
    
    	Revert the previous 2 commits:
    	gdbserver build-id attribute generator
    	Validate symbol file using build-id
    
    gdb/testsuite/ChangeLog
    2015-07-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
    
    	Revert the previous commit:
    	Tests for validate symbol file using build-id.