From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
gdb-patches <gdb-patches@sourceware.org>,
Aleksandar Ristovski <ARistovski@qnx.com>
Subject: Re: [PATCH v9 09/10] Validate symbol file using build-id
Date: Tue, 14 Jul 2015 16:14:00 -0000 [thread overview]
Message-ID: <CADPb22TLu1FW=DXaECJv2fwR5er4ZLPQwm4o1kaCWDgC4HdtVQ@mail.gmail.com> (raw)
In-Reply-To: <20150713123835.GA2529@host1.jankratochvil.net>
On Mon, Jul 13, 2015 at 5:38 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Mon, 13 Jul 2015 12:34:33 +0200, Pedro Alves wrote:
>> As the plan is for the feature to apply to the main executable too,
>> it's better that "solib" isn't part of the setting name. I agree
>> that "validate-build-id" sounds better than "build-id-validation".
>
> OK, so validate-build-id or solib-validate-build-id.
>
> Just this series being approved is still only for shlib and I do not yet have
> completely finished the second series for all binaries; although 7.10 is
> branched so till 7.11 there is now really enough time to have it all.
>
> So I do not know if I should call it in this shlib-only first series as
> validate-build-id or as solib-validate-build-id.
One of the important bits for me is to not add an option knowing
we're going to rename it later.
We've just branched 7.10 and I'm guessing all of this will be
present for 7.11.
So I'd be ok with just adding a simple note somewhere saying
the option only applies to solibs at the moment and will
eventually also apply to exes.
next prev parent reply other threads:[~2015-07-14 16:14 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 19:25 [PATCH v7 00/10] Validate binary before use Jan Kratochvil
2015-06-14 19:25 ` [PATCH v7 01/10] Move utility functions to common/ Jan Kratochvil
2015-06-15 13:22 ` Joel Brobecker
2015-06-15 15:07 ` [commit] " Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 07/10] Move linux_find_memory_regions_full & co Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 03/10] Code cleanup: Rename enum -> enum filterflags Jan Kratochvil
2015-06-15 13:34 ` Joel Brobecker
2015-06-15 15:12 ` [commit] " Jan Kratochvil
2015-07-08 14:38 ` Pedro Alves
2015-06-14 19:26 ` [PATCH v7 06/10] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 02/10] Merge multiple hex conversions Jan Kratochvil
2015-06-15 13:33 ` Joel Brobecker
2015-06-15 15:09 ` [commit] " Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 04/10] Create empty nat/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 05/10] Move gdb_regex* to common/ Jan Kratochvil
2015-07-08 14:39 ` Pedro Alves
2015-07-14 20:13 ` Jan Kratochvil
2015-06-14 19:27 ` [PATCH v7 10/10] Tests for validate symbol file using build-id Jan Kratochvil
2015-07-08 14:44 ` Pedro Alves
2015-06-14 19:27 ` [PATCH v7 08/10] gdbserver build-id attribute generator Jan Kratochvil
2015-07-08 14:41 ` Pedro Alves
2015-06-14 19:27 ` [PATCH v7 09/10] Validate symbol file using build-id Jan Kratochvil
2015-06-21 10:16 ` [PATCH v8 " Jan Kratochvil
2015-06-22 12:55 ` Aleksandar Ristovski
2015-06-22 20:37 ` Jan Kratochvil
2015-06-22 20:41 ` Aleksandar Ristovski
2015-06-22 22:25 ` Doug Evans
2015-06-23 20:47 ` Jan Kratochvil
2015-07-08 14:44 ` Pedro Alves
2015-07-12 19:09 ` Jan Kratochvil
2015-07-12 19:29 ` [PATCH v9 " Jan Kratochvil
2015-07-12 19:54 ` Eli Zaretskii
2015-07-12 20:01 ` Jan Kratochvil
2015-07-13 2:30 ` Eli Zaretskii
2015-07-13 10:34 ` Pedro Alves
2015-07-13 12:38 ` Jan Kratochvil
2015-07-14 16:14 ` Doug Evans [this message]
2015-07-15 8:21 ` Jan Kratochvil
2015-07-15 14:59 ` Doug Evans
2015-06-27 21:05 ` [PATCH v8 " Jan Kratochvil
2015-07-08 15:40 ` Doug Evans
2015-07-12 19:27 ` Jan Kratochvil
2015-07-15 16:36 ` [commit] [PATCH v7 00/10] Validate binary before use Jan Kratochvil
2015-07-15 18:33 ` [revert] " Jan Kratochvil
2015-07-13 12:48 [PATCH v9 09/10] Validate symbol file using build-id Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22TLu1FW=DXaECJv2fwR5er4ZLPQwm4o1kaCWDgC4HdtVQ@mail.gmail.com' \
--to=dje@google.com \
--cc=ARistovski@qnx.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).