Re: [PATCH v8 09/10] Validate symbol file using build-id

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 08 Jul 2015 17:39:14 +0200, Doug Evans wrote:
> On Sat, Jun 27, 2015 at 4:05 PM, Jan Kratochvil
> <jan.kratochvil@redhat.com> wrote:
> >> > ... This is actual
> >> > +       BUILD_ID which comes either from the remote target via qXfer
> >> > +       packet or via reading target memory.  Therefore, it may differ
> >> > +       from the build-id of the associated bfd.  In a normal
> >> > +       scenario, this so would soon lose its abfd due to failed
> >> > +       validation.
> >>
> >> I can't read this last sentence.
> >> What are you trying to say here?
> >
> > It was written by Aleksandar Ristovski and I find it OK myself.
> > So as an explanation the process is:
> >
> > 1. GDB reads/receives so->build_id from GDB server.
> > 2. GDB opens local BFD so->abfd.
> > 3. GDB compares so->build_id with so->abfd->build_id (by ops->validate)
> > 4. If they differ so->abfd is freed/cleared (in solib_map_sections).
> >
> > Therefore could you suggest a different comment?
> 
> I'd be ok with just deleting the last two sentences:
> 
> This is actual
> BUILD_ID which comes either from the remote target via qXfer
> packet or via reading target memory.
> 
> But if you want more I'm ok with:
> 
> This is actual
> BUILD_ID which comes either from the remote target via qXfer
> packet or via reading target memory. Note that if there's a
> mismatch with the associated bfd then so->abfd will be cleared.

Used the latter one.


Thanks,
Jan