From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Doug Evans <dje@google.com>,
gdb-patches <gdb-patches@sourceware.org>,
Aleksandar Ristovski <ARistovski@qnx.com>
Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
Date: Sun, 12 Jul 2015 19:09:00 -0000 [thread overview]
Message-ID: <20150712190921.GA8682@host1.jankratochvil.net> (raw)
In-Reply-To: <559D3749.9010200@redhat.com>
On Wed, 08 Jul 2015 16:44:25 +0200, Pedro Alves wrote:
> Jan Kratochvil wrote:
>
> > +static char *
> > +svr4_validate (const struct so_list *const so)
> > +{
>
> ...
>
> > + return xstrprintf (_("remote build ID is %s "
> > + "but local file does not have build ID"),
> > + remote_hex);
>
> Seems odd to say "remote" here. Can't these errors trigger with native
> debugging as well?
For this patchset not yet. The message is changed in a later patchset being
prepared where it applies also for local files.
> Doug Evans wrote:
> >
> >> > If so, having solib in the option name is confusing.
> >> >
> >> > set build-id-force
> >> > or
> >> > set require-build-id-match
> >> > or some such would be clearer.
>
> "build-id-force" sound odd to me. The latter sounds OK,
> as would "set build-id-validation on/off/...".
OK, I will change it to "set build-id-validation on/off/...".
> With that, and once the previous issues raised are
> addressed, I think this is good to go.
There patches are left without reply:
[PATCH v7 04/10] Create empty nat/linux-maps.[ch] and common/target-utils.[ch]
[PATCH v7 06/10] Prepare linux_find_memory_regions_full & co. for move
[PATCH v7 07/10] Move linux_find_memory_regions_full & co.
There particularly the [PATCH v7 06/10] contains non-mechanical (a bit)
changes.
Thanks,
Jan
next prev parent reply other threads:[~2015-07-12 19:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 19:25 [PATCH v7 00/10] Validate binary before use Jan Kratochvil
2015-06-14 19:25 ` [PATCH v7 01/10] Move utility functions to common/ Jan Kratochvil
2015-06-15 13:22 ` Joel Brobecker
2015-06-15 15:07 ` [commit] " Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 05/10] Move gdb_regex* " Jan Kratochvil
2015-07-08 14:39 ` Pedro Alves
2015-07-14 20:13 ` Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 04/10] Create empty nat/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 06/10] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 02/10] Merge multiple hex conversions Jan Kratochvil
2015-06-15 13:33 ` Joel Brobecker
2015-06-15 15:09 ` [commit] " Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 07/10] Move linux_find_memory_regions_full & co Jan Kratochvil
2015-06-14 19:26 ` [PATCH v7 03/10] Code cleanup: Rename enum -> enum filterflags Jan Kratochvil
2015-06-15 13:34 ` Joel Brobecker
2015-06-15 15:12 ` [commit] " Jan Kratochvil
2015-07-08 14:38 ` Pedro Alves
2015-06-14 19:27 ` [PATCH v7 09/10] Validate symbol file using build-id Jan Kratochvil
2015-06-21 10:16 ` [PATCH v8 " Jan Kratochvil
2015-06-22 12:55 ` Aleksandar Ristovski
2015-06-22 20:37 ` Jan Kratochvil
2015-06-22 20:41 ` Aleksandar Ristovski
2015-06-22 22:25 ` Doug Evans
2015-06-23 20:47 ` Jan Kratochvil
2015-07-08 14:44 ` Pedro Alves
2015-07-12 19:09 ` Jan Kratochvil [this message]
2015-07-12 19:29 ` [PATCH v9 " Jan Kratochvil
2015-07-12 19:54 ` Eli Zaretskii
2015-07-12 20:01 ` Jan Kratochvil
2015-07-13 2:30 ` Eli Zaretskii
2015-07-13 10:34 ` Pedro Alves
2015-07-13 12:38 ` Jan Kratochvil
2015-07-14 16:14 ` Doug Evans
2015-07-15 8:21 ` Jan Kratochvil
2015-07-15 14:59 ` Doug Evans
2015-06-27 21:05 ` [PATCH v8 " Jan Kratochvil
2015-07-08 15:40 ` Doug Evans
2015-07-12 19:27 ` Jan Kratochvil
2015-06-14 19:27 ` [PATCH v7 08/10] gdbserver build-id attribute generator Jan Kratochvil
2015-07-08 14:41 ` Pedro Alves
2015-06-14 19:27 ` [PATCH v7 10/10] Tests for validate symbol file using build-id Jan Kratochvil
2015-07-08 14:44 ` Pedro Alves
2015-07-15 16:36 ` [commit] [PATCH v7 00/10] Validate binary before use Jan Kratochvil
2015-07-15 18:33 ` [revert] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150712190921.GA8682@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=ARistovski@qnx.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).