From: Natalia Saiapova <natalia.saiapova@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 5/6] gdb/infrun: in condition evaluation do not stop all threads.
Date: Fri, 9 Oct 2020 13:27:17 +0200 [thread overview]
Message-ID: <20201009112719.629-6-natalia.saiapova@intel.com> (raw)
In-Reply-To: <20201009112719.629-1-natalia.saiapova@intel.com>
If a thread is evaluating a BP condition, do not stop other threads.
Some of them might be already resumed due to the condition being
evaluated as false.
gdb/ChangeLog:
2020-08-26 Natalia Saiapova <natalia.saiapova@intel.com>
Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* infrun.c (stop_waiting): In condition evaluation do not stop
all threads.
Co-authored-by: Natalia Saiapova <natalia.saiapova@intel.com>
Co-authored-by: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Signed-off-by: Natalia Saiapova <natalia.saiapova@intel.com>
---
gdb/infrun.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index d260eb6e3a7..286af5abbe1 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -7764,9 +7764,15 @@ stop_waiting (struct execution_control_state *ecs)
/* Let callers know we don't want to wait for the inferior anymore. */
ecs->wait_some_more = 0;
+ bool in_cond_eval = ecs->event_thread != nullptr
+ && ecs->event_thread->control.in_cond_eval;
+
/* If all-stop, but there exists a non-stop target, stop all
- threads now that we're presenting the stop to the user. */
- if (!non_stop && exists_non_stop_target ())
+ threads now that we're presenting the stop to the user.
+ Do not stop, if the event thread is evaluating a BP condition.
+ This will be handled elsewhere depending on the result of
+ the condition. */
+ if (!non_stop && exists_non_stop_target () && !in_cond_eval)
stop_all_threads ();
}
--
2.17.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2020-10-09 11:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200831123519.16232-1-natalia.saiapova () intel ! com>
2020-10-09 11:27 ` [PATCH v2 0/6] Fix inferior calls from breakpoint condition Natalia Saiapova
2020-10-09 11:27 ` [PATCH v2 1/6] gdb: add in_cond_eval field to thread_control_state struct Natalia Saiapova
2021-03-02 10:43 ` Andrew Burgess
2020-10-09 11:27 ` [PATCH v2 2/6] gdb/infrun: in condition evaluation resume only current thread Natalia Saiapova
2021-03-02 11:15 ` Andrew Burgess
2020-10-09 11:27 ` [PATCH v2 3/6] gdb/infcall: in condition evaluation register target back after infcall Natalia Saiapova
2020-10-19 0:53 ` Kevin Buettner
2021-03-02 11:26 ` Andrew Burgess
2020-10-09 11:27 ` [PATCH v2 4/6] gdb/infrun: in condition evaluation wait only for the current inferior Natalia Saiapova
2020-10-19 1:44 ` Kevin Buettner
2020-10-26 12:11 ` Saiapova, Natalia
2021-03-02 12:17 ` Andrew Burgess
2020-10-09 11:27 ` Natalia Saiapova [this message]
2020-10-09 11:27 ` [PATCH v2 6/6] gdb/testsuite: add tests for inferior calls in breakpoint conditions Natalia Saiapova
2020-10-12 0:49 ` [PATCH v2 0/6] Fix inferior calls from breakpoint condition Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009112719.629-6-natalia.saiapova@intel.com \
--to=natalia.saiapova@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).