From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/6] Fix inferior calls from breakpoint condition
Date: Sun, 11 Oct 2020 17:49:11 -0700 [thread overview]
Message-ID: <20201011174911.76984cec@f32-m1.lan> (raw)
In-Reply-To: <20201009112719.629-1-natalia.saiapova@intel.com>
Hi Natalia,
Thank you for rebasing and reposting your work.
I've successfully applied your v2 patches to recent GDB sources. I've
built GDB with your patches applied and have done some a bit of testing.
All looks good so far.
I'll do a more thorough review in the coming week.
Thanks again,
Kevin
On Fri, 9 Oct 2020 13:27:12 +0200
Natalia Saiapova via Gdb-patches <gdb-patches@sourceware.org> wrote:
> Hi,
>
> This is the rebased on top of
>
> 51a948fdf0e gdb: Have allocate_target_description return a unique_ptr
>
> version of
> https://sourceware.org/pipermail/gdb-patches/2020-August/171592.html.
>
> The patch set is tested on x86_64-pc-linux-gnu configuration, the default
> and gdbserver-native boards.
>
> Regards,
> --Natalia
>
> Natalia Saiapova:
> Tankut Baris Aktemur:
>
> gdb: add in_cond_eval field to thread_control_state struct.
> gdb/infrun: in condition evaluation resume only current thread.
> gdb/infcall: in condition evaluation register target back after infcall.
> gdb/infrun: in condition evaluation wait only for the current inferior.
> gdb/infrun: in condition evaluation do not stop all threads.
> gdb/testsuite: add tests for inferior calls in breakpoint conditions.
>
> gdb/breakpoint.c | 3 +
> gdb/gdbthread.h | 3 +
> gdb/infcall.c | 3 +
> gdb/infrun.c | 35 +++++++--
> gdb/testsuite/gdb.threads/infcall-bp-cond.c | 58 +++++++++++++++
> gdb/testsuite/gdb.threads/infcall-bp-cond.exp | 73 +++++++++++++++++++
> 6 files changed, 169 insertions(+), 6 deletions(-)
> create mode 100644 gdb/testsuite/gdb.threads/infcall-bp-cond.c
> create mode 100644 gdb/testsuite/gdb.threads/infcall-bp-cond.exp
>
> --
> 2.17.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Gary Kershaw
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>
prev parent reply other threads:[~2020-10-12 0:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200831123519.16232-1-natalia.saiapova () intel ! com>
2020-10-09 11:27 ` Natalia Saiapova
2020-10-09 11:27 ` [PATCH v2 1/6] gdb: add in_cond_eval field to thread_control_state struct Natalia Saiapova
2021-03-02 10:43 ` Andrew Burgess
2020-10-09 11:27 ` [PATCH v2 2/6] gdb/infrun: in condition evaluation resume only current thread Natalia Saiapova
2021-03-02 11:15 ` Andrew Burgess
2020-10-09 11:27 ` [PATCH v2 3/6] gdb/infcall: in condition evaluation register target back after infcall Natalia Saiapova
2020-10-19 0:53 ` Kevin Buettner
2021-03-02 11:26 ` Andrew Burgess
2020-10-09 11:27 ` [PATCH v2 4/6] gdb/infrun: in condition evaluation wait only for the current inferior Natalia Saiapova
2020-10-19 1:44 ` Kevin Buettner
2020-10-26 12:11 ` Saiapova, Natalia
2021-03-02 12:17 ` Andrew Burgess
2020-10-09 11:27 ` [PATCH v2 5/6] gdb/infrun: in condition evaluation do not stop all threads Natalia Saiapova
2020-10-09 11:27 ` [PATCH v2 6/6] gdb/testsuite: add tests for inferior calls in breakpoint conditions Natalia Saiapova
2020-10-12 0:49 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201011174911.76984cec@f32-m1.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).