Re: [PATCH v2 3/6] gdb/infcall: in condition evaluation register target back after infcall.

[Kevin Buettner <kevinb@redhat.com>]

Hi Natalia,

Could you add your commit log comment (or something similar)
to your change to infcall.c?

Thanks,

Kevin

On Fri,  9 Oct 2020 13:27:15 +0200
Natalia Saiapova via Gdb-patches <gdb-patches@sourceware.org> wrote:

> After an inferior call is finished, the target is unregistered from
> the event loop.  However, if the inferior call has happened during
> the condition evaluation, we still want to get `stop` events from
> other threads in `wait_one`.  So, register the target back.
> 
> gdb/ChangeLog:
> 2020-08-26  Natalia Saiapova  <natalia.saiapova@intel.com>
> 	    Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> 
> 	* infcall.c (run_inferior_call): In condition evaluation,
> 	register the target back after the infcall.
> 
> Co-authored-by: Natalia Saiapova <natalia.saiapova@intel.com>
> Co-authored-by: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> 
> Signed-off-by: Natalia Saiapova <natalia.saiapova@intel.com>
> ---
>  gdb/infcall.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gdb/infcall.c b/gdb/infcall.c
> index 399b1724ea2..0b0226f8e82 100644
> --- a/gdb/infcall.c
> +++ b/gdb/infcall.c
> @@ -667,6 +667,9 @@ run_inferior_call (struct call_thread_fsm *sm,
>  
>    call_thread->control.in_infcall = saved_in_infcall;
>  
> +  if (call_thread->control.in_cond_eval && target_can_async_p ())
> +    target_async (true);
> +
>    return caught_error;
>  }
>  
> -- 
> 2.17.1
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Gary Kershaw
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>