[PATCH v2 6/6] gdb/testsuite: add tests for inferior calls in breakpoint conditions.

[Natalia Saiapova <natalia.saiapova@intel.com>]

Test three scenarios for breakpoints whose condition includes a function
call:
* only one thread matches the condition;
* both threads match the condition;
* no thread matches the condition.

gdb/testsuite/ChangeLog:
2020-08-26  Natalia Saiapova  <natalia.saiapova@intel.com>

	* gdb.threads/infcall-bp-cond.c: New test.
	* gdb.threads/infcall-bp-cond.exp: New file.

Signed-off-by: Natalia Saiapova <natalia.saiapova@intel.com>
---
 gdb/testsuite/gdb.threads/infcall-bp-cond.c   | 58 +++++++++++++++
 gdb/testsuite/gdb.threads/infcall-bp-cond.exp | 73 +++++++++++++++++++
 2 files changed, 131 insertions(+)
 create mode 100644 gdb/testsuite/gdb.threads/infcall-bp-cond.c
 create mode 100644 gdb/testsuite/gdb.threads/infcall-bp-cond.exp

diff --git a/gdb/testsuite/gdb.threads/infcall-bp-cond.c b/gdb/testsuite/gdb.threads/infcall-bp-cond.c
new file mode 100644
index 00000000000..dda2d3bb0e0
--- /dev/null
+++ b/gdb/testsuite/gdb.threads/infcall-bp-cond.c
@@ -0,0 +1,58 @@
+/* Copyright 2020 Free Software Foundation, Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <pthread.h>
+
+#define NUM_THREADS 2
+
+int
+is_one (int tid)
+{
+  return tid == 1;
+}
+
+int
+return_true ()
+{
+  return 1;
+}
+
+int
+return_false ()
+{
+  return 0;
+}
+
+void *
+doSmt (void *arg)
+{
+  int a = 42; /* breakpoint-here  */
+}
+
+int main(int argc, char *argv[])
+{
+  pthread_t threads[NUM_THREADS];
+  int args[NUM_THREADS];
+
+  for (int i = 0; i < NUM_THREADS; i++)
+    {
+      args[i] = i;
+      pthread_create (&threads[i], NULL, doSmt, &args[i]);
+    }
+
+  pthread_exit(NULL);
+}
diff --git a/gdb/testsuite/gdb.threads/infcall-bp-cond.exp b/gdb/testsuite/gdb.threads/infcall-bp-cond.exp
new file mode 100644
index 00000000000..c5abe2646f0
--- /dev/null
+++ b/gdb/testsuite/gdb.threads/infcall-bp-cond.exp
@@ -0,0 +1,73 @@
+# Copyright 2020 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Tests inferior calls executed from a breakpoint condition in
+# a multi-threaded program.
+
+standard_testfile
+
+if { [prepare_for_testing "failed to prepare" ${binfile} "${srcfile}" \
+	  {debug pthreads}] } {
+    return
+}
+
+set bp_line [gdb_get_line_number "breakpoint-here"]
+
+proc run_condition_test {message n_expected_hits condition} {
+    with_test_prefix $message {
+	global binfile gdb_prompt srcfile bp_line
+
+	clean_restart ${binfile}
+
+	if {![runto_main]} {
+	    fail "run to main"
+	    return
+	}
+
+	gdb_test "set \$n_cond_eval = 0"
+	gdb_breakpoint "$srcfile:$bp_line if (++\$n_cond_eval) $condition"
+
+	set n_hit_condition 0
+	set should_continue true
+	set iteration 0
+
+	while {$should_continue} {
+	    incr iteration
+	    with_test_prefix "continue iteration $iteration" {
+		gdb_test_multiple "continue" "continue" {
+		    -re "$srcfile:$bp_line.*$gdb_prompt" {
+			incr n_hit_condition
+		    }
+		    -re "$gdb_prompt" {
+			set should_continue false
+		    }
+		}
+	    }
+	}
+
+	set test_condition "expected number of hits"
+	if {$n_hit_condition == $n_expected_hits} {
+	    pass $test_condition
+	} else {
+	    fail $test_condition
+	}
+
+	gdb_test "print \$n_cond_eval" "= 2" "condition was evaluated twice"
+    }
+}
+
+run_condition_test "exactly one thread is hit" 1 "&& is_one (*(int*)arg)"
+run_condition_test "exactly two threads are hit" 2 "|| return_true ()"
+run_condition_test "no thread is hit" 0 "&& return_false ()"
-- 
2.17.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928