From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Pedro Alves <pedro@palves.net>
Subject: [PATCH v2 2/8] Switch to -Wimplicit-fallthrough=5
Date: Tue, 21 Nov 2023 08:27:29 -0700 [thread overview]
Message-ID: <20231121152817.31859-3-tom@tromey.com> (raw)
In-Reply-To: <20231121152817.31859-1-tom@tromey.com>
This changes the various gdb-related directories to use
-Wimplicit-fallthrough=5, meaning that only the fallthrough attribute
can be used in switches -- special 'fallthrough' comments will no
longer be usable.
Approved-By: Pedro Alves <pedro@palves.net>
---
gdb/configure | 2 +-
gdbserver/configure | 2 +-
gdbsupport/configure | 2 +-
gdbsupport/warning.m4 | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/configure b/gdb/configure
index 7e411cd7668..3dd73b0a2c8 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -31161,7 +31161,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wno-mismatched-tags \
-Wno-error=deprecated-register \
-Wsuggest-override \
--Wimplicit-fallthrough=3 \
+-Wimplicit-fallthrough=5 \
-Wduplicated-cond \
-Wshadow=local \
-Wdeprecated-copy \
diff --git a/gdbserver/configure b/gdbserver/configure
index dc2ecd884a8..f1292f9b707 100755
--- a/gdbserver/configure
+++ b/gdbserver/configure
@@ -13697,7 +13697,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wno-mismatched-tags \
-Wno-error=deprecated-register \
-Wsuggest-override \
--Wimplicit-fallthrough=3 \
+-Wimplicit-fallthrough=5 \
-Wduplicated-cond \
-Wshadow=local \
-Wdeprecated-copy \
diff --git a/gdbsupport/configure b/gdbsupport/configure
index 3f262a5da78..b501b36373f 100755
--- a/gdbsupport/configure
+++ b/gdbsupport/configure
@@ -14162,7 +14162,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wno-mismatched-tags \
-Wno-error=deprecated-register \
-Wsuggest-override \
--Wimplicit-fallthrough=3 \
+-Wimplicit-fallthrough=5 \
-Wduplicated-cond \
-Wshadow=local \
-Wdeprecated-copy \
diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4
index ea573c63c4a..774f0208e9b 100644
--- a/gdbsupport/warning.m4
+++ b/gdbsupport/warning.m4
@@ -44,7 +44,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wno-mismatched-tags \
-Wno-error=deprecated-register \
-Wsuggest-override \
--Wimplicit-fallthrough=3 \
+-Wimplicit-fallthrough=5 \
-Wduplicated-cond \
-Wshadow=local \
-Wdeprecated-copy \
--
2.41.0
next prev parent reply other threads:[~2023-11-21 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:27 Tom Tromey
2023-11-21 15:27 ` [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute Tom Tromey
2023-11-30 18:03 ` Simon Marchi
2023-11-30 19:13 ` Tom Tromey
2023-11-30 21:08 ` Simon Marchi
2023-12-01 3:55 ` Tom Tromey
2023-12-01 4:17 ` Simon Marchi
2023-11-21 15:27 ` Tom Tromey [this message]
2023-11-21 15:27 ` [PATCH v2 3/8] Enable some C++14 code in array-view.h Tom Tromey
2023-11-21 15:27 ` [PATCH v2 4/8] Use try_emplace in index-write.c Tom Tromey
2023-11-21 15:27 ` [PATCH v2 5/8] Rely on C++17 <new> in new-op.cc Tom Tromey
2023-11-21 15:27 ` [PATCH v2 6/8] Rely on copy elision in scope-exit.h Tom Tromey
2023-11-21 15:27 ` [PATCH v2 7/8] Use C++17 void_t Tom Tromey
2023-11-21 15:27 ` [PATCH v2 8/8] Remove gdb_static_assert Tom Tromey
2023-11-29 23:28 ` (unknown) Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121152817.31859-3-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).