From: Simon Marchi <simark@simark.ca>
To: PATCH@sourceware.org, More@sourceware.org, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, John Baldwin <jhb@FreeBSD.org>,
Luis Machado <luis.machado@arm.com>,
Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute
Date: Thu, 30 Nov 2023 13:03:35 -0500 [thread overview]
Message-ID: <23d042a3-7f2a-4af3-ab8b-0f43dc0f275e@simark.ca> (raw)
In-Reply-To: <20231121152817.31859-2-tom@tromey.com>
On 11/21/23 10:27, Tom Tromey wrote:
> This changes gdb to use the C++17 [[fallthrough]] attribute rather
> than special comments.
>
> This was mostly done by script, but I neglected a few spellings and so
> also fixed it up by hand.
>
> I suspect this fixes the bug mentioned below, by switching to a
> standard approach that, presumably, clang supports.
Are you able to test building on macos? I see this on my macos builder:
/Users/jenkins/build/workspace/binutils-gdb_master_macosbuild/platform/macos-amd64/target_board/unix/src/binutils-gdb/gdb/dbxread.c:2809:7: error: fallthrough annotation does not directly precede switch label
[[fallthrough]];
^
Simon
next prev parent reply other threads:[~2023-11-30 18:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:27 Tom Tromey
2023-11-21 15:27 ` [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute Tom Tromey
2023-11-30 18:03 ` Simon Marchi [this message]
2023-11-30 19:13 ` Tom Tromey
2023-11-30 21:08 ` Simon Marchi
2023-12-01 3:55 ` Tom Tromey
2023-12-01 4:17 ` Simon Marchi
2023-11-21 15:27 ` [PATCH v2 2/8] Switch to -Wimplicit-fallthrough=5 Tom Tromey
2023-11-21 15:27 ` [PATCH v2 3/8] Enable some C++14 code in array-view.h Tom Tromey
2023-11-21 15:27 ` [PATCH v2 4/8] Use try_emplace in index-write.c Tom Tromey
2023-11-21 15:27 ` [PATCH v2 5/8] Rely on C++17 <new> in new-op.cc Tom Tromey
2023-11-21 15:27 ` [PATCH v2 6/8] Rely on copy elision in scope-exit.h Tom Tromey
2023-11-21 15:27 ` [PATCH v2 7/8] Use C++17 void_t Tom Tromey
2023-11-21 15:27 ` [PATCH v2 8/8] Remove gdb_static_assert Tom Tromey
2023-11-29 23:28 ` (unknown) Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d042a3-7f2a-4af3-ab8b-0f43dc0f275e@simark.ca \
--to=simark@simark.ca \
--cc=More@sourceware.org \
--cc=PATCH@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=luis.machado@arm.com \
--cc=pedro@palves.net \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).