From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Pedro Alves <pedro@palves.net>
Subject: [PATCH v2 3/8] Enable some C++14 code in array-view.h
Date: Tue, 21 Nov 2023 08:27:30 -0700 [thread overview]
Message-ID: <20231121152817.31859-4-tom@tromey.com> (raw)
In-Reply-To: <20231121152817.31859-1-tom@tromey.com>
This changes gdbsupport/array-view.h to enable some code that is
C++14-specific.
Approved-By: Pedro Alves <pedro@palves.net>
---
gdbsupport/array-view.h | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/gdbsupport/array-view.h b/gdbsupport/array-view.h
index 4b519112e78..0417f9e80a0 100644
--- a/gdbsupport/array-view.h
+++ b/gdbsupport/array-view.h
@@ -153,18 +153,17 @@ class array_view
: m_array (c.data ()), m_size (c.size ())
{}
- /* Observer methods. Some of these can't be constexpr until we
- require C++14. */
- /*constexpr14*/ T *data () noexcept { return m_array; }
+ /* Observer methods. */
+ constexpr T *data () noexcept { return m_array; }
constexpr const T *data () const noexcept { return m_array; }
- /*constexpr14*/ T *begin () noexcept { return m_array; }
+ constexpr T *begin () noexcept { return m_array; }
constexpr const T *begin () const noexcept { return m_array; }
- /*constexpr14*/ T *end () noexcept { return m_array + m_size; }
+ constexpr T *end () noexcept { return m_array + m_size; }
constexpr const T *end () const noexcept { return m_array + m_size; }
- /*constexpr14*/ reference operator[] (size_t index) noexcept
+ constexpr reference operator[] (size_t index) noexcept
{
#if defined(_GLIBCXX_DEBUG)
gdb_assert (index < m_size);
@@ -173,7 +172,7 @@ class array_view
}
constexpr const_reference operator[] (size_t index) const noexcept
{
-#if defined(_GLIBCXX_DEBUG) && __cplusplus >= 201402L
+#if defined(_GLIBCXX_DEBUG)
gdb_assert (index < m_size);
#endif
return m_array[index];
@@ -188,7 +187,7 @@ class array_view
[[nodiscard]]
constexpr array_view<T> slice (size_type start, size_type size) const noexcept
{
-#if defined(_GLIBCXX_DEBUG) && __cplusplus >= 201402L
+#if defined(_GLIBCXX_DEBUG)
gdb_assert (start + size <= m_size);
#endif
return {m_array + start, size};
@@ -199,7 +198,7 @@ class array_view
[[nodiscard]]
constexpr array_view<T> slice (size_type start) const noexcept
{
-#if defined(_GLIBCXX_DEBUG) && __cplusplus >= 201402L
+#if defined(_GLIBCXX_DEBUG)
gdb_assert (start <= m_size);
#endif
return {m_array + start, size () - start};
--
2.41.0
next prev parent reply other threads:[~2023-11-21 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:27 Tom Tromey
2023-11-21 15:27 ` [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute Tom Tromey
2023-11-30 18:03 ` Simon Marchi
2023-11-30 19:13 ` Tom Tromey
2023-11-30 21:08 ` Simon Marchi
2023-12-01 3:55 ` Tom Tromey
2023-12-01 4:17 ` Simon Marchi
2023-11-21 15:27 ` [PATCH v2 2/8] Switch to -Wimplicit-fallthrough=5 Tom Tromey
2023-11-21 15:27 ` Tom Tromey [this message]
2023-11-21 15:27 ` [PATCH v2 4/8] Use try_emplace in index-write.c Tom Tromey
2023-11-21 15:27 ` [PATCH v2 5/8] Rely on C++17 <new> in new-op.cc Tom Tromey
2023-11-21 15:27 ` [PATCH v2 6/8] Rely on copy elision in scope-exit.h Tom Tromey
2023-11-21 15:27 ` [PATCH v2 7/8] Use C++17 void_t Tom Tromey
2023-11-21 15:27 ` [PATCH v2 8/8] Remove gdb_static_assert Tom Tromey
2023-11-29 23:28 ` (unknown) Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121152817.31859-4-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).