Re: [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Are you able to test building on macos?

No.

Simon>  /Users/jenkins/build/workspace/binutils-gdb_master_macosbuild/platform/macos-amd64/target_board/unix/src/binutils-gdb/gdb/dbxread.c:2809:7: error: fallthrough annotation does not directly precede switch label
Simon>        [[fallthrough]];
Simon>        ^

Can you try the appended?

thanks,
Tom

diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 99d9fba96ea..4947a8e8193 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -2808,7 +2808,6 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, const char *name,
       unknown_symtype_complaint (hex_string (type));
       [[fallthrough]];
 
-    define_a_symbol:
       /* These symbol types don't need the address field relocated,
 	 since it is either unused, or is absolute.  */
     case N_GSYM:		/* Global variable.  */
@@ -2820,6 +2819,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, const char *name,
     case N_LSYM:		/* Local symbol in stack.  */
     case N_PSYM:		/* Parameter variable.  */
     case N_LENG:		/* Length of preceding symbol type.  */
+    define_a_symbol:
       if (name)
 	{
 	  int deftype;