From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Pedro Alves <pedro@palves.net>
Subject: [PATCH v2 6/8] Rely on copy elision in scope-exit.h
Date: Tue, 21 Nov 2023 08:27:33 -0700 [thread overview]
Message-ID: <20231121152817.31859-7-tom@tromey.com> (raw)
In-Reply-To: <20231121152817.31859-1-tom@tromey.com>
gdbsupport/scope-exit.h has a couple of comments about being able to
rely on copy elision in C++17. This patch makes the change.
Approved-By: Pedro Alves <pedro@palves.net>
---
gdbsupport/scope-exit.h | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/gdbsupport/scope-exit.h b/gdbsupport/scope-exit.h
index cb8d9255869..8fa40b1ca8a 100644
--- a/gdbsupport/scope-exit.h
+++ b/gdbsupport/scope-exit.h
@@ -69,16 +69,7 @@ class scope_exit_base
}
}
- /* This is needed for make_scope_exit because copy elision isn't
- guaranteed until C++17. An optimizing compiler will usually skip
- calling this, but it must exist. */
- scope_exit_base (const scope_exit_base &other)
- : m_released (other.m_released)
- {
- other.m_released = true;
- }
-
- void operator= (const scope_exit_base &) = delete;
+ DISABLE_COPY_AND_ASSIGN (scope_exit_base);
/* If this is called, then the wrapped function will not be called
on destruction. */
@@ -132,16 +123,7 @@ class scope_exit : public scope_exit_base<scope_exit<EF>>
rhs.release ();
}
- /* This is needed for make_scope_exit because copy elision isn't
- guaranteed until C++17. An optimizing compiler will usually skip
- calling this, but it must exist. */
- scope_exit (const scope_exit &other)
- : scope_exit_base<scope_exit<EF>> (other),
- m_exit_function (other.m_exit_function)
- {
- }
-
- void operator= (const scope_exit &) = delete;
+ DISABLE_COPY_AND_ASSIGN (scope_exit);
void operator= (scope_exit &&) = delete;
private:
--
2.41.0
next prev parent reply other threads:[~2023-11-21 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:27 Tom Tromey
2023-11-21 15:27 ` [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute Tom Tromey
2023-11-30 18:03 ` Simon Marchi
2023-11-30 19:13 ` Tom Tromey
2023-11-30 21:08 ` Simon Marchi
2023-12-01 3:55 ` Tom Tromey
2023-12-01 4:17 ` Simon Marchi
2023-11-21 15:27 ` [PATCH v2 2/8] Switch to -Wimplicit-fallthrough=5 Tom Tromey
2023-11-21 15:27 ` [PATCH v2 3/8] Enable some C++14 code in array-view.h Tom Tromey
2023-11-21 15:27 ` [PATCH v2 4/8] Use try_emplace in index-write.c Tom Tromey
2023-11-21 15:27 ` [PATCH v2 5/8] Rely on C++17 <new> in new-op.cc Tom Tromey
2023-11-21 15:27 ` Tom Tromey [this message]
2023-11-21 15:27 ` [PATCH v2 7/8] Use C++17 void_t Tom Tromey
2023-11-21 15:27 ` [PATCH v2 8/8] Remove gdb_static_assert Tom Tromey
2023-11-29 23:28 ` (unknown) Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121152817.31859-7-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).