Re: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp

[Tom de Vries <tdevries@suse.de>]

On 4/24/23 18:48, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> Fix this by using "expr" instead:
> Tom> ...
> Tom> set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }]
> 
> expr seems very weird here, since it's normally used for evaluating an
> expression.

I got the idea from here ( 
https://stackoverflow.com/questions/30489106/using-lmap-to-filter-list-of-strings 
).

> Maybe subst would be a more idiomatic choice, if it works.

It does, indeed:
...
-set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }]
+set sources [lmap i $sources { subst $srcdir/$subdir/$i }]
...

My working set of tcl is a bit random, so I don't know what idiomatic is 
and what not.

I agree that subst is neater since it needs less quoting.

Thanks,
- Tom