From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp
Date: Tue, 2 May 2023 17:40:56 +0200 [thread overview]
Message-ID: <5f4f5d69-311c-e97b-5d40-4a8ffbd57b7d@suse.de> (raw)
In-Reply-To: <87354lxx4p.fsf@tromey.com>
On 4/27/23 15:39, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> Then with subst we have the same:
> Tom> ...
> Tom> set res [lmap v $l { subst {$v/c} }]
> Tom> ...
> Tom> unless we forget the quoting:
>
> This is true for everything in Tcl though.
> The quoting matters a lot.
>
True.
> Tom> Hmm, in that case I think subst is the worse choice. With expr,
> Tom> things either parse or not, and if it parses you get the right result.
>
> expr has corner cases where weird things will happen as well.
> It's really just intended for use with the expression sub-language.
Ack.
I've just pushed a patch that uses set instead of expr, so this is no
longer an issue.
Thanks for reporting this.
- Tom
prev parent reply other threads:[~2023-05-02 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:48 Tom de Vries
2023-04-24 12:48 ` [pushed 2/4] [gdb/testsuite] Add basic lmap for tcl < 8.6 Tom de Vries
2023-04-24 12:48 ` [pushed 3/4] [gdb/testsuite] Fix gdb.multi/multi-arch.exp on powerpc64le Tom de Vries
2023-04-24 12:48 ` [pushed 4/4] [gdb/testsuite] Require GCC >= 5.x.x in gdb.base/utf8-identifiers.exp Tom de Vries
2023-04-24 16:48 ` [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp Tom Tromey
2023-04-24 20:22 ` Tom de Vries
2023-04-25 18:38 ` Tom Tromey
2023-04-26 6:34 ` Tom de Vries
2023-04-26 7:08 ` Andreas Schwab
2023-05-02 15:38 ` Tom de Vries
2023-04-27 13:39 ` Tom Tromey
2023-05-02 15:40 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f4f5d69-311c-e97b-5d40-4a8ffbd57b7d@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).