From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp
Date: Mon, 24 Apr 2023 14:48:43 +0200 [thread overview]
Message-ID: <20230424124846.29580-1-tdevries@suse.de> (raw)
Test-case gdb.dwarf2/dw2-abs-hi-pc.exp uses string cat:
...
set sources [lmap i $sources { string cat "${srcdir}/${subdir}/" $i }]
...
but that's only supported starting tcl 8.6.
Fix this by using "expr" instead:
...
set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }]
...
Tested on x86_64-linux.
---
gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
index 0868b69f15e..2ea6a5cea00 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
@@ -24,7 +24,8 @@ set sources \
${testfile}.c \
${testfile}-hello.c \
${testfile}-world.c]
-set sources [lmap i $sources { string cat "${srcdir}/${subdir}/" $i }]
+set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }]
+
lassign [function_range hello $sources] \
hello_start hello_len
lassign [function_range world $sources] \
base-commit: ea5c591c023544e40bb4967314a47d8e6a1e806d
--
2.35.3
next reply other threads:[~2023-04-24 12:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:48 Tom de Vries [this message]
2023-04-24 12:48 ` [pushed 2/4] [gdb/testsuite] Add basic lmap for tcl < 8.6 Tom de Vries
2023-04-24 12:48 ` [pushed 3/4] [gdb/testsuite] Fix gdb.multi/multi-arch.exp on powerpc64le Tom de Vries
2023-04-24 12:48 ` [pushed 4/4] [gdb/testsuite] Require GCC >= 5.x.x in gdb.base/utf8-identifiers.exp Tom de Vries
2023-04-24 16:48 ` [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp Tom Tromey
2023-04-24 20:22 ` Tom de Vries
2023-04-25 18:38 ` Tom Tromey
2023-04-26 6:34 ` Tom de Vries
2023-04-26 7:08 ` Andreas Schwab
2023-05-02 15:38 ` Tom de Vries
2023-04-27 13:39 ` Tom Tromey
2023-05-02 15:40 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424124846.29580-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).